Commit Graph

1753 Commits

Author SHA1 Message Date
Bernardo Rufino
897a0e0470 Ignore "package:<package>" in MANAGE_OVERLAY_PERMISSION intent
Before this change, intents with action = MANAGE_OVERLAY_PERMISSION and data =
URI "package:<package>" would redirect the user to the specific app screen with
the toggle to grant SYSTEM_ALERT_WINDOW (SAW) permission.

This makes it too easy for malicious apps to fool the user into enabling
it and we know that exist malware attempts to do so.

This CL redirects that intent to the screen that list all the apps
requesting SAW permission, introducing some friction for the user, which
hopefully will allow more time for consideration.

This is consistent with how other access permission intents work.

Test: Working on CTS
Test: adb shell am start -a
      android.settings.action.MANAGE_OVERLAY_PERMISSION -d package:<package>
      goes to list of apps screen
Test: adb shell am start -a android.settings.action.MANAGE_OVERLAY_PERMISSION
      also goes there
Bug: 135920175

Change-Id: I02fb842106602dab7fc285d0741edb58432ac7ad
2019-11-08 16:55:19 +00:00
Jason Chiu
bbaf0a0014 Leverage the bahavior of Back key to the Up button of action bar
Fixes: 138765370
Fixes: 134395822
Fixes: 132049537
Test: manual, robotest
Change-Id: I2099a232049bb9f0fffc18755fca8d5c7d7b7ef0
2019-11-05 12:46:53 +08:00
Alex Johnston
c0c75a3e96 Added a warning dialog when installing a CA certificate
This is part of the changes to improve the UX and language for installing certificates.
Previously, the different types of certificate used the same installation flow.
Due to concerns around users installing CA certificates without understanding the conseqences,
this CL introduces a new warning dialog when a CA certificate is installed from settings.

Bug: 139173976
Test: Atest com.android.settings.security
      manual testing from Settings by selecting the certificate type
	preference and ensuring the installation flow still worked as expected.

Screenshot of the screen: https://hsv.googleplex.com/5046848484016128

Change-Id: If95bffd1e68f14734fb20e8cc4b60eeb1c372358
2019-10-24 15:25:52 +01:00
TreeHugger Robot
a0e9852083 Merge "Use a regular drawable as ConnectedDeviceDashboardActivity icon" 2019-10-24 06:41:17 +00:00
hughchen
02b116edcc Use a regular drawable as ConnectedDeviceDashboardActivity icon
Bug: 142629154
Test: rebuild
Change-Id: Idbce03dac48892003e10e3ecda497c33855c6c48
2019-10-23 11:55:49 +08:00
Bonian Chen
3b8d0faeed [Settings] Remove unused SimPreferenceDialog
Remove unused SimPreferenceDialog

Bug: 143018062
Test: build pass
Change-Id: Ia1b9d64a7956c8fe326d7df7635c7910cfd09951
2019-10-20 22:56:32 +08:00
Fabian Kozynski
42d9a70916 Merge "Add BooleanState metadata to DevelopmentTiles" 2019-10-16 13:07:50 +00:00
hughchen
b78ecc4d8b Adds cross-profile intents for Bluetooth detail Settings
Bug: 142349493
Test: manually
Change-Id: If8c0f9d52c81226c6aa567520c3848189b489a31
2019-10-16 15:27:17 +08:00
Bonian Chen
b7633cc59d [RadioInfo] Remove from Settings (into Telephony)
Moving RadioInfo and BandMode to Telephony app.

Bug: 123598192
Test: Manual test
Change-Id: Id62a2bf4b2c44efcd48319734d1cab6ed969ee06
2019-10-08 06:49:18 +00:00
Raff Tsai
6db277ebb7 Remove summary provider
- use SummaryProvider to provide the summary of UserSettings
- use WifiDisplayPreferenceController to replace the summary loader
in WifiDisplaySettings
- use ConfigureNotificationPreferernceController to replace the
sumary load in ConfigureNotificationSettings

Fixes: 141653158
Test: robolectric
Change-Id: Id5f5ed645707caa0b25ecae5252174cbf017651c
2019-10-03 15:04:36 +08:00
Raff Tsai
9e3a9fd255 Add fragment in xml instead of using injected way
- It can improve performance because we use less injected item
- Also remove summary provider from those fragments

Bug: 141653158
Test: robolectric
Change-Id: I6255f71b3b8300aea064a4fefd6711c1ff59e08a
2019-10-02 11:49:51 +08:00
Raff Tsai
129c98bba1 Remove summary loader in some fragments
- Summary Loader only works in injected items, but those fragments
are not injected to Settings UI. The SummaryLoader class them are
useless.

Bug: 141653158
Test: robolectric
Change-Id: I1ca0bf5a1f417b7fe86b28e96aff7d4aee2cf2d3
2019-10-01 10:02:26 +08:00
joshmccloskey
be7d733886 Added different flow for re-enrollment am: bba7632f28
am: 3511ad89ca

Change-Id: I2b06407f4df37f8d16f95c6068de0ac3523df293
2019-09-27 18:38:20 -07:00
Yanting Yang
85713d0841 Fix upper back button behavior of MobileDataUsageListActivity
Fixes: 141622125
Test: visual
Change-Id: I5a8fac02428fe811e2d0f340b1469ff948637623
2019-09-27 18:34:04 +08:00
joshmccloskey
bba7632f28 Added different flow for re-enrollment
In order to enable this new flow, a user must currently have an enrolled
face and the security setting face_unlock_re_enroll must be non-zero.

Ex.
1. Enroll Face.
2. adb shell settings put
(secure face_unlock_re_enroll|secure_face_unlock_must_re_enroll) 1
3. If settings is opened, close it.
4. Open settings
5. Verify the new flow appears.

Bug: 141380252
Bug: 141254937
Test: Verified that the user's face is deleted after clicking delete.
Test: Verified that the user can re-enroll after removing their face.
Change-Id: I2b36a0bda5cb10fb33dfb2a5627d8fa40f14fb7e
2019-09-26 23:54:59 +00:00
Yanting Yang
5edcc30ada Fix upper back button behavior of LocationSettingsActivity
In acrossing different apps, it should go back to previous app if user
click the upper back button on LocationSettingsActivity. So remove the
android:parentActivityName attribute of LocationSettingsActivity from
AndroidManifest.

Fixes: 140370314
Test: visual
Change-Id: I1efa750f1371a313c83844a67862d903cfe65bf6
2019-09-05 16:25:17 +08:00
joshmccloskey
d30db87bc8 Removed deprecated permission
Fixes: 135968171
Test: Can still use fingerprint
Change-Id: I767919a2bf14ebd7e44003460536e0f67b9f1f4f
2019-08-27 12:07:08 -07:00
govenliu
14a74125e6 [Wi-Fi NetworkRequest] Set theme for the NetworkRequest dialog
We should set the same theme which applied in Settings APP to the NetworkRequestDialog

Bug: 139294487
Test: check if the right theme is applied when launching this activity.
Change-Id: Iefdfd5b810f5cf22c220830e1ee965113a439a3e
Merged-In: Iefdfd5b810f5cf22c220830e1ee965113a439a3e
2019-08-21 12:23:32 +08:00
govenliu
dbf920cfff [Wi-Fi NetworkRequest] Set theme for the NetworkRequest dialog
We should set the same theme which applied in Settings APP to the NetworkRequestDialog

Bug: 139294487
Test: check if the right theme is applied when launching this activity.
Change-Id: Iefdfd5b810f5cf22c220830e1ee965113a439a3e
2019-08-20 10:26:14 +08:00
Roshan Pius
5c3a161cc3 Merge "Settings(wifi): Allow mainline wifi stack to use network request dialog" 2019-08-14 19:33:12 +00:00
govenliu
8d6e5d14cb [Wi-Fi] Add a new fragment for configuring a new AccessPoint network.
When configuring a new access point in Wi-Fi settings page, it's hard to figure out there are some other option items after you tapping the "Advanced options" button.

To improve it, use full screen fragment to present the configuration items, so user can see as many items as possible.

Bug: 31052996
Test: Mock this fragment and check each button status run as expected.
Change-Id: I1c8e552fcabb1414bb500d918ed61287bf4aece2
2019-08-10 21:01:01 +08:00
Roshan Pius
6faf8649c7 Settings(wifi): Allow mainline wifi stack to use network request dialog
The wifi stack may not be running in system_server, so cannot get
NETWORK_SETTINGS permisison (platform signature). Guard it using the new
wifi mainline permission. If the wifi stack is running in system_server
(until it becomes a mainline module), it's uid (SYTEM_UID) should bypass all
permission checks.

Bug: 113174748
Test: Verified with CtsVerifier tests.
Change-Id: I87be97bb6e42c055d3aaa317a096256fd66f9e14
2019-08-08 12:27:15 -07:00
Fabian Kozynski
e94d09fc34 Add BooleanState metadata to DevelopmentTiles
Test: manual, tiles now have correct TB
Bug: 138579147
Change-Id: If4d7c1685058cb63935e57d90af4d0d4c42a3251
2019-08-07 15:42:03 -04:00
Julia Reynolds
c400ce3c80 Move channel listing into a pref controller
And a hidden preference category. This makes
hiding/showing the list a lot cleaner and also allows more
of the code to be tested.

Also delete some unused code that no longer complied after
this refactor.

Fixes: 133443871
Test: atest
Change-Id: I4a5fe0e075019bae2df44a0a9dcec26a40ee6d12
(cherry picked from commit a295d71c94)
2019-07-26 19:24:43 +00:00
Quang Luong
b470e725c9 Added WifiSettings -> WifiSettings2 redirection behind feature flag
Use WifiSettings2 if settings_wifitracker2 feature flag is enabled.
WifiSettings2 will be used for changes to WifiSettings to incorporate
the WifiTracker2 refactor.

Bug: 70983952
Test: make, set feature flag, open Wifi settings to verify new page
opens.

Change-Id: I08edc227bf38ab4b3b785180bf123815bf95da81
2019-07-22 14:41:11 -07:00
Sunny Shao
600ba96eea Fix nevigation up to wrong place
Remove the parentActivityName attribute of the Settings$ManageDomainUrlsActivity
in the manifest.xml.

Fixes: 136686496
Test: manual
Change-Id: I99587dc99eea7fd2a22f11b839033e841eadb411
2019-07-04 11:52:59 +08:00
Julia Reynolds
a295d71c94 Move channel listing into a pref controller
And a hidden preference category. This makes
hiding/showing the list a lot cleaner and also allows more
of the code to be tested.

Also delete some unused code that no longer complied after
this refactor.

Fixes: 133443871
Test: atest
Change-Id: I4a5fe0e075019bae2df44a0a9dcec26a40ee6d12
2019-07-02 11:24:50 -04:00
Andrew Sapperstein
82ce229d4a Merge "Add UI for mainline modules licenses." into qt-dev am: 72aded338a am: 0c1f7da25a
am: 722f8c0ac1

Change-Id: Ib41961f01cfc6530a43e65e593a1248714f6143c
2019-06-28 11:07:18 -07:00
Andrew Sapperstein
72aded338a Merge "Add UI for mainline modules licenses." into qt-dev 2019-06-28 16:56:04 +00:00
Winson Chung
7c896fa1c0 Merge "Adding unique task affinity for FallbackHome activity" into qt-dev am: 9591c3f963 am: 8bf207bab6
am: 27424848e8

Change-Id: Ifce634aa74f79829ba618b0d8b20c75e04a38532
2019-06-27 17:10:57 -07:00
Louis Chang
397cdd6ead Adding unique task affinity for FallbackHome activity
Settings activities were launched and resided on home task
which was originally started by FallbackHome. Adding a
unique task affinity for FallbackHome activity in order to
prevent the task being reused by other Settings activities.

Bug: 135696366
Test: starting Settings activity before FallbackHome finishes
Change-Id: I3fe41dd3b77e37236b11006dbf08727783b6a2ec
2019-06-27 09:57:54 +08:00
Andrew Sapperstein
56a8c33c1b Add UI for mainline modules licenses.
Added a module licenses option that lives in Legal information settings.
Clicking that option opens module licenses page, which displays every
module by name, filtered to exclude modules without license files.
Clicking a module in the list opens HTMLViewer.

Created ModuleLicensesProvider, a new ContentProvider that serves as a
redirect for the Uris sent to HTMLViewer so that they open asset files.
In order to provide the redirect, the provider will write the license file
to a file in Settings' cache directory when the license does not exist
in the cache or is outdated. The provider then opens that cached file.

Fixes: 135183006
Test: robotests
Change-Id: I7d69da34780c8c4efb150d0c0411078c12bc80d8
2019-06-25 16:01:38 -07:00
Sunny Shao
0b0e6fc3a0 Fix settings back button return to previous launched page
QuickSetting use FLAG_ACTIVITY_NEW_TASK flag to launch setting page. It shares the same
taskid with Settings. That's why user press BACK key will return the previous settings
page. Now add the new taskAffinity in Settings homepage to fix this problem.

Fixes: 135018024
Test: manual & robotest
Change-Id: Ic73645e9afe5415691f0696c5ae33a9eacda6d50
2019-06-18 06:00:46 +00:00
Kevin Chang
219349cb2b Merge "Add tutorial dialog for gesture navigation" into qt-dev-plus-aosp am: 52482edb2b
am: abee9d52e4

Change-Id: I91e8fb09ae80638f678408a7a19da58830473667
2019-06-06 02:22:26 -07:00
Kevin Chang
9ff00646d0 Add tutorial dialog for gesture navigation
Add new tutorial dialog for gesture navigation in order to teach
users how to use the gesture

Fixes: 133650388
Test: Manual
Change-Id: I7cc6a950af49044b27cf7ca41e3bcf67ef40b5fd
Merged-In: I7cc6a950af49044b27cf7ca41e3bcf67ef40b5fd
2019-06-06 06:20:49 +00:00
Kevin Chang
0e1f39fad8 Add tutorial dialog for gesture navigation
Add new tutorial dialog for gesture navigation in order to teach
users how to use the gesture

Fixes: 133650388
Test: Manual
Change-Id: I7cc6a950af49044b27cf7ca41e3bcf67ef40b5fd
2019-06-06 13:56:54 +08:00
Julia Reynolds
dd806ce357 Merge "Reorder notification settings" into qt-dev am: 1abcbaa093 am: 760f617502
am: ef7ba1918a

Change-Id: I0478f3cbc6129a8674711bc2d717e7198557be52
2019-05-31 06:42:31 -07:00
Julia Reynolds
a87f740d90 Reorder notification settings
Test: manual
Fixes: 132271798
Change-Id: I57e726a332513620bea25b97345b1a8564c6d5ef
2019-05-30 16:52:08 -04:00
Antony Sargent
47742e5e5b Merge "Switch to using an intent for eSIM erasing" into qt-dev am: f010cb4034 am: 55ac2d75fc
am: 694de4f5aa

Change-Id: If06e0c1bd794b7f056f17da42f8e1b1904066c8f
2019-05-29 13:37:43 -07:00
Antony Sargent
c6e07c61d0 Switch to using an intent for eSIM erasing
We initially landed support for erasing an eSIM subscription in
ag/7208624 for b/124254555 using our own confirmation/progress UI, and
calling the EuiccManager.deleteSubscription method to do the
deletion. It turns out this is a low-level API which doesn't handle some
important cases such as subscription grouping or the eSIM slot not being
active.

This CL changes Settings to just launch an intent to begin an eSIM
Manager flow to delete a subscription that provides its own
confirmation/progress UI, and should properly handle subscription
grouping and making the eSIM slot active as needed.

Bug: 132114333
Test: make RunSettingsRoboTests
Change-Id: Ie59fea37fa73c5e6573e1181e271ffb5d453bd08
2019-05-28 15:31:51 -07:00
Steve Elliott
edf253fef6 Merge "Add entry point to global actions panel settings" into qt-dev am: 4b5d31fe67 am: d5c5c8ab9f
am: b136e0a5ce

Change-Id: I2ffbf354700bd1f638226dd2c7713e8f27210fd5
2019-05-24 16:50:16 -07:00
lindatseng
421c6e9f7b Merge "Always create new task when launching WifiDialogActivity" into qt-dev am: 49776845e5 am: 0146947e25
am: 775f9c577a

Change-Id: I0e0a54c37cbdb314f71cb32d85e06cf2554f873d
2019-05-24 06:37:23 -07:00
Steve Elliott
e772123a26 Add entry point to global actions panel settings
Bug: 133241418
Test: manual
Change-Id: Id4268cacce30b08ad5c7c8afe3e1b44d4d1ac1e3
2019-05-22 20:51:40 +00:00
TreeHugger Robot
49776845e5 Merge "Always create new task when launching WifiDialogActivity" into qt-dev 2019-05-22 17:12:30 +00:00
Hai Zhang
30a04be5be Merge "Remove SmsDefaultDialog which has been replaced by role." into qt-dev am: 98ba2a6b8b am: c46403a34e
am: e99117aa25

Change-Id: I6ab872fe7f7580555eb228f61f38154f5aab33f3
2019-05-21 21:22:31 -07:00
lindatseng
8d7d01360d Always create new task when launching WifiDialogActivity
Set doucmentLaunchMode to always for WifiDialogActivity.  Always
create new task when launching wifi dialog activity so it won't
try to open the existing one.

Test: Manual
Fixes: 133206261
Change-Id: If35f0ea8f6d2f6b94ff58b4508f73f265ca4b5dd
2019-05-21 15:53:25 -07:00
Hai Zhang
4feab60a30 Remove SmsDefaultDialog which has been replaced by role.
Bug: 131204827
Test: presubmit
Change-Id: If436d4f0777838dc490fa45901005008bb57315b
2019-05-20 15:23:05 -07:00
Pavel Grafov
4b6571849e Merge "Merge "Make credential confirmation activity resizeable." into qt-dev am: e455680bd2 am: 52f1e826e9" into qt-r1-dev-plus-aosp
am: 79ecab0822

Change-Id: Ia0ea30825321a4f9262f2ee5a7692c62f7d7ee5b
2019-05-16 21:58:23 -07:00
Pavel Grafov
973c5e5bf3 Make credential confirmation activity resizeable.
This prevents it from breaking split-screen mode.

Test: manual
Bug: 129045018
Change-Id: I380a9a51dbfb0e44f8d9800ae521584b13d0cc3f
2019-05-15 11:16:31 +01:00
Fan Zhang
ff8a733f63 Merge "Revert "Revert "Make subsettings display edge-to-edge""" into qt-dev am: 17521d0ac7
am: d32e9b5229

Change-Id: Icf5c8c48bb2ea7375cc03d3cec9d9879b6db7249
2019-05-14 18:15:28 -07:00