Commit Graph

599 Commits

Author SHA1 Message Date
Angela Wang
e92627e26d Merge "Rename CachedBluetoothDevice.getConnectableProfiles()" into main 2024-08-07 09:52:32 +00:00
Yiyi Shen
81539522d4 Merge "[Audiosharing] Handle device volume when volume bar is changed without touch" into main 2024-08-07 08:56:45 +00:00
Yiyi Shen
adbdc16113 [Audiosharing] Handle device volume when volume bar is changed without touch
Fix volume control when user use talk back swipe up/down or use Switch
Access to change the volume bar progress

Fix: 357028436
Fix: 357028435
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Iab7d48ab8713a3a809cc8f7b28381a2b86b9be5f
2024-08-07 15:17:18 +08:00
chelseahao
e7a1762ef3 [Audiosharing] When landscape mode, collapse app bar to make more space. Also refined fragments and make them scrollable.
Bug: b/356302527, b/356300387, b/356297148
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Test: atest
Change-Id: I5d94f0d05afc78c13cab5b75ad662af72ffa0350
2024-08-06 09:09:11 +00:00
Angela Wang
711d0b269c Rename CachedBluetoothDevice.getConnectableProfiles()
The original method name implied that the returned profiles were guaranteed to be connectable. However, it actually filters profiles based on user can access the profile in the UI and initiate the connection. Change the method name to getUiAccessibleProfiles() aligns the name with the actual behavior.

Flag: EXEMPT simple renaming
Bug: 356530795
Test: m
Change-Id: Ib7d29a4bf9c213ddcecc567864583165ab97a099
2024-08-05 07:14:15 +00:00
Yiyi Shen
7edad1c84a [Audiosharing] Returns BluetoothDevice when fetchConnectedDevicesByGroupId
CachedBluetoothDevice can change its member variable mDevice, so we can
not rely on the CachedBluetoothDevice#getDevice when we add source to
it. This change will return BluetoothDevice instead of
CachedBluetoothDevice when fetchConnectedDevicesByGroupId, so that we
won't add source to unintended BluetoothDevice via
CachedBluetoothDevice#getDevice.

Fix: 350877510
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: I4ee41b8f1449e7176f0a05a7dd4e59034c161824
2024-08-02 05:20:31 +00:00
chelseahao
e85e1c823a [Audiosharing] When user enters a bad code, apply error color on summary.
Bug: 356071392
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Test: atest
Change-Id: I427e08a3cce8d0e85f29f821d9b779acc95217b1
2024-08-01 04:25:21 +00:00
Yiyi Shen
124a9e1ebd [Audiosharing] Not announce enable/disable when toggle main switch
Fix: 356318679
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: I3331f9ded48352f442712287a6b536da883fe73d
2024-07-31 18:56:33 +08:00
Yiyi Shen
7b2435a01c [Audiosharing] Clean up dup codes
Bug: 305620450
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Test: atest
Change-Id: Ife2bf26d78e522dc51891be633d6635883923de3
2024-07-30 15:34:09 +08:00
Oleg Blinnikov
2c2b7a5064 Merge "External display page is not searchable" into main 2024-07-24 22:23:44 +00:00
Oleg Blinnikov
efc891fca7 Merge "External display mode limit flag in settings" into main 2024-07-24 20:50:46 +00:00
Yuanru Qian
e8f15fd1f5 Merge "Remove ex-team members from OWNERS" into main am: 8303a38d10 am: 97f922d60c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3191891

Change-Id: I6cb2cd56da335ee064fc4c4ee89c1e56f797cfca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-24 10:43:15 +00:00
Yuanru Qian
97f922d60c Merge "Remove ex-team members from OWNERS" into main am: 8303a38d10
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3191891

Change-Id: I39c450800b0a3fc08d7cab8e74ff7318f753cbf9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-24 10:27:41 +00:00
Yuanru Qian
3fac9ad21b Remove ex-team members from OWNERS
Change-Id: I025d4963e5b63a28fb0fe36df8a4e1fdd76a9b3d
2024-07-24 09:41:31 +00:00
Oleg Blinnikov
1821d25d39 External display mode limit flag in settings
Use external display mode limit flag and override
for the flag in the settings to allow selection
of any resolutions with the refresh rate around 60

Change-Id: I180ba97eb9dfa14a386a7517f29504d369268563
Bug: 351831642
Flag: com.android.settings.flags.resolution_and_enable_connected_display_setting
Test: atest ResolutionPreferenceFragmentTest
2024-07-23 16:47:46 +00:00
Oleg Blinnikov
df9b9abd4d External display page is not searchable
Page was moved to connnected devices
from connected devices->connection pref.
This makes the page non-searchable,
therefore must be dropped from
the search index.

Change-Id: I437b1310bedc5943041eb0baa73b2e3152eb9ebd
Bug: 294015706
Test: manual
Flag: EXEMPT bugfix
2024-07-22 15:35:47 +00:00
chelseahao
7299e0f6bd Add accessibility label for "QR code" image.
Also added landscape mode.

Test: atest
Bug: 354116021
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ide20e07f38660ef7f444fbe3b20d3364b9951e02
2024-07-22 10:27:08 +00:00
chelseahao
8dd7d1cc80 Add accessibility label for "QR code" button in Audio sharing page.
Test: atest
Bug: 354112158
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: I5d2e2c70ca76e3598ca3d9550ebcc140d3400e34
2024-07-22 14:19:06 +08:00
Yiyi Shen
9eaf954e19 Merge "Fix dup preference key on Connected devices page" into main 2024-07-16 02:45:44 +00:00
Jayant Chowdhary
8569d2ade0 Merge "Exclude webcam and MIDI USB preferences from requiring auth challenge" into main 2024-07-03 04:55:58 +00:00
Jayant Chowdhary
cf9eee0bb5 Exclude webcam and MIDI USB preferences from requiring auth challenge
Webcam / MIDI don't transfer any persistent data to the host device,
so it is okay to not guard it by an auth challenge. Auth challenge for
webcam use increases friction and reduces usability.

Bug: 349370229

Flag: com.android.settings.flags.exclude_webcam_auth_challenge

Test: Check when the flag is enabled, webcam / MIDI doesn't require auth
Test: Settings robolectric tests

Change-Id: Id4c97a635a4c0a9ed14f88fbdda2743e2371dd10
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2024-07-02 18:36:51 +00:00
Yiyi Shen
07a346fcf5 Fix dup preference key on Connected devices page
Use different key (prefix + CacheBluetooothDevice hash) for
each BluetoothDevicePreference to avoid Java crash due to "Two different
ViewHolders have the same change ID".

Test: atest
Fix: 325831741
Flag: EXEMPT safe fix only change preference key string
Change-Id: Ic993f3cab206b794045c2f46e6b4b376bfa3adea
2024-07-01 15:32:34 +08:00
Chelsea Hao
94cfea7ed1 Merge "[Audiosharing] onDestroy() is not guaranteed to be called after stopSelf(). In this case callbacks are not unregistered timely and the notification kept being brought up again if any callback is received." into main 2024-06-27 11:13:13 +00:00
Yiyi Shen
9c5ac400a0 Merge "[Audiosharing] Fix IllegalStateException at getChildFragmentManager" into main 2024-06-27 10:53:15 +00:00
chelseahao
c49658d154 [Audiosharing] onDestroy() is not guaranteed to be called after stopSelf(). In this case callbacks are not unregistered timely and the notification kept being brought up again if any callback is received.
This CL also moved some binder calls to bg thread.

Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostream
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Bug: 347605485
Change-Id: I1a3a3db88178a43f27cac74cf743bdb75cdfb60e
2024-06-27 09:57:37 +00:00
Chelsea Hao
f647356d62 Merge "[Audiosharing] Increase test coverage." into main 2024-06-27 08:36:02 +00:00
chelseahao
7529e1bea7 [Audiosharing] Increase test coverage.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostream
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Bug: 345686602
Change-Id: I668df463ec1c6e994d2dcaa363a20aa06f69f199
2024-06-27 07:11:37 +00:00
Yiyi Shen
6e6df5d6e2 [Audiosharing] Fix IllegalStateException at getChildFragmentManager
Fix: 349300412
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: I33a22ce12ae4c602be9aafdbd9cf9fdcee82bdde
2024-06-26 18:17:46 +08:00
Yiyi Shen
832c751e29 Merge "[Audiosharing] Avoid start sharing dialog for single device." into main 2024-06-26 06:29:07 +00:00
Oleg Blinnikov
b3926bdf35 Merge "Added External Display settings page" into main 2024-06-25 15:01:01 +00:00
Oleg Blinnikov
a6016e6552 Added External Display settings page
Settings page to show rotation, resolution,
enable/disable display settings for
external and overlay displays. In case
persist.demo.userrotation.package_name
sysprop is set, then the virtual
display with this will also be shown.

In case there is only one allowed display
available, then this display will be
shown right away. When there are more
than 1 displays available, then the list
of displays will be shown.

Change-Id: I186667aaba94ed6befec3a98f4a87f2b2d1f1859
Test: atest ExternalDisplayUpdaterTest
Test: atest ExternalDisplayPreferenceFragmentTest
Test: atest ResolutionPreferenceFragmentTest
Test: atest ConnectedDeviceGroupControllerTest
Bug: 340218151
Bug: 294015706
Bug: 253296253
Flag: com.android.settings.flags.rotation_connected_display_setting
Flag: com.android.settings.flags.resolution_and_enable_connected_display_setting
2024-06-25 13:41:10 +00:00
Yiyi Shen
f9424c6231 [Audiosharing] Avoid start sharing dialog for single device.
Issue - for LEA device with two BT addresses, when the second bud connected with
incorrect group id, we wrongly show up the start audio sharing dialog.

Fix - check there are two connected LEA valid groups before show up
start audio sharing dialog.

Bug: 347655885
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Icd86ce2cfa4312c10c14906f46df324357c56990
2024-06-25 18:11:02 +08:00
chelseahao
4afef7eed1 [Audiosharing] Created test for the name and password preferences.
Test: atest -c com.android.settings.connecteddevice.audiosharing
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Bug: 345686602
Change-Id: I9036e560e29aba9555c207dce1b2018be010bca8
2024-06-24 14:36:08 +08:00
chelseahao
e0abdc5c7a [Audiosharing] Created test for the main controller.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostreams
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Bug: 345686602
Change-Id: Ieb735d392607c131c213be90cd72c4b7a9ed958d
2024-06-21 14:34:39 +08:00
chelseahao
44a0b59ad2 [Audiosharing] Listen to onProfileConnectionStateChanged of LE_AUDIO_BROADCAST_ASSISTANT to be more precise on device connection status upon bluetooth on/off. Also increase test coverage.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostreams
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Bug: 345686602
Change-Id: Ia78b1fe19bff3cb179794db1dc09374db13818d8
2024-06-21 14:14:45 +08:00
chelseahao
4b85389124 [Audiosharing] Increase test coverage for audio stream states.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostreams
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Bug: 345686602
Change-Id: I91d9a45abd4c9659c9d0ddeca5f5aaefed36f820
2024-06-21 11:00:54 +08:00
Chelsea Hao
e626a77a81 Merge "[Audiosharing] Add log for debugging." into main 2024-06-19 02:42:55 +00:00
chelseahao
89df32b48c [Audiosharing] Add log for debugging.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostreams
Bug: 347605485
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Change-Id: I319747652837c08ffcbbd5980609a0f8f35e3c24
2024-06-19 02:42:37 +00:00
Yiyi Shen
52cbe21569 [Audiosharing] Add audio sharing loggings (P4)
Bug: 331515891
Test: atest
Change-Id: I05e1c138f9cc32c4e873852f93bac65d3d0dc3ca
2024-06-17 18:46:11 +08:00
Yiyi Shen
9bd19f4604 Merge "[Audiosharing] Reset shadows after tests." into main 2024-06-16 13:24:13 +00:00
Yiyi Shen
440d061648 Merge "[Audiosharing] Increase audio sharing test coverage" into main 2024-06-16 13:21:38 +00:00
chelseahao
16f9205fb6 [Audiosharing] Add tests for qrcode related classes.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostreams
Bug: 308368124
Change-Id: I74caacf43a23bbd0a6da44af24a1be4dd9544a5d
2024-06-14 11:38:51 +00:00
Yiyi Shen
f570ee0018 [Audiosharing] Reset shadows after tests.
Test: atest
Bug: 345686602
Change-Id: I311ba5c8d234240e61dffd17b4357452c12f4fb1
2024-06-14 17:44:33 +08:00
chelseahao
f6b235746d [Audiosharing] Add tests.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostreams
Bug: 308368124
Change-Id: I6322ccbb5deffe2bc169a898ef0208e135caa819
2024-06-14 08:48:17 +00:00
chelseahao
8a8c89a49c [Audiosharing] Add logging 3.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostreams
Bug: 308368124
Change-Id: Idc96c23d20041a00d4fb1e20a7457baaa0f55527
2024-06-14 08:47:55 +00:00
Yiyi Shen
2c6b9bb364 [Audiosharing] Increase audio sharing test coverage
Bug: 345686602
Test: atest
Change-Id: Iec196fc884c3b7ddd580eb8dd13b445d59e3b1b7
2024-06-14 14:30:14 +08:00
chelseahao
a3b1638c4b [Audiosharing] Add logging 2.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostreams
Bug: 308368124
Change-Id: I50fc57427aa135a13566c4627ba193aed9d73e0d
2024-06-12 08:04:17 +00:00
chelseahao
f017332c91 [Audiosharing] Add logging 1.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostreams
Bug: 308368124
Change-Id: I2513824826b9d7dd6240728179ea004f33b4fbe3
2024-06-12 08:04:17 +00:00
Ze Li
44de7e98d3 Merge "[ConnectedDevicePage] Make bonded bluetooth devices can be found by Settings search" into main 2024-06-11 10:50:04 +00:00
Yiyi Shen
996e12b34d Merge "[Audiosharing] Increase test coverage for audio sharing" into main 2024-06-11 09:32:10 +00:00