Commit Graph

42 Commits

Author SHA1 Message Date
Daniel Nishi
84aba27da4 Merge "Add user icon to the other user preferences." into oc-dev am: b1c336de5f
am: f4af2774ee

Change-Id: I1ff26ce55a3b1ade531745e091e5c6e2de243593
2017-04-10 17:37:54 +00:00
Daniel Nishi
fe33c58a18 Add user icon to the other user preferences.
This icon is loaded in the background to avoid doing IO on
the main thread. Once we know there are more users and also
have the icon loaded, we add the category to the view.

Fixes: 36252572
Test: Robotest

Change-Id: Ib50287bb7ed323f22fbe407b56be1bf2fe98f121
2017-04-07 14:57:07 -07:00
Daniel Nishi
c2157ab443 Add a movies & tv apps category to storage settings.
Change-Id: Idfabe83739272b19cbef4b13a82339170f8f97b3
Fixes: 36223441
Test: Settings Robotest
2017-03-28 17:18:15 -07:00
Daniel Nishi
16e9247d21 Merge "Badge the icons for profile storage screen." 2017-03-27 22:20:09 +00:00
Daniel Nishi
aaebe26678 Merge "Add icons to the main static storage setting prefs." 2017-03-23 22:16:19 +00:00
Daniel Nishi
3414a6904b Badge the icons for profile storage screen.
Fixes: 36224168
Test: Settings Robotest
Change-Id: I27f0540aaa639b1248347ad41c8f1b711fe65fe7
2017-03-23 13:36:20 -07:00
Daniel Nishi
49118e7e01 Add icons to the main static storage setting prefs.
The dynamic user icons require more than just XML changes to
successfully fetch the badged user icons and are coming in a future
patch.

Bug: 35801039
Test: Manual -- this is purely XML and comment changes.
Change-Id: Id493c0335037a5c6e4f8b4734700611bfc0da7f1
2017-03-23 10:34:06 -07:00
Daniel Nishi
fda5d5a6a8 Update the system info dialog.
The string is updated as well as where the dialog shows up.

Change-Id: If1a3b17dca04fe81f52dbdc2353db34ce7adc49a
Fixes: 34857117
Test: Robotest
2017-03-22 16:12:55 -07:00
Daniel Nishi
cf0e659a6c Re-add the progress bar for storage preferences.
This re-adds the progress bar and unifies the
StorageItemPreference and its alternate.

Change-Id: Iefc12b4b554306c706c83be232175dd2b84227b7
Fixes: 36223433
Test: Settings robotest
2017-03-20 11:42:46 -07:00
Daniel Nishi
47b07cc9c1 Merge changes from topic 'storage-o-strings'
* changes:
  Use total size and not free in Storage summary.
  Add new strings.
2017-03-17 22:03:48 +00:00
Daniel Nishi
f1050cb7c7 Use total size and not free in Storage summary.
Fixes: 36223330
Test: Settings Robotest
Change-Id: I4406dc673961db0f91ae37da3abd0e1541517c7d
2017-03-15 16:51:21 -07:00
Daniel Nishi
02b269be4b Merge "Category breakdown size should match total size." 2017-03-15 20:30:10 +00:00
Daniel Nishi
8325e80fdb Merge "Count legacy games as games in Storage view." 2017-03-14 00:11:59 +00:00
Daniel Nishi
fd82752694 Count legacy games as games in Storage view.
The old Games flag was being ignored for categorization.
This caused the very few games which used the flag to be
miscategorized as "Other apps."

Change-Id: Ib8650d1c43579bc1698576c09c884e5a7bc4626d
Fixes: 36109122
Test: Settings robotest
2017-03-13 13:20:30 -07:00
Daniel Nishi
092e3c0b3c Don't show owner as a secondary user.
Change-Id: I0a67eb176528a0f95595107b12c6ecc679a1041f
Fixes: 36138657
Test: Robotest
2017-03-13 12:27:22 -07:00
Daniel Nishi
325d38043f Category breakdown size should match total size.
The system apps' base size was not being properly attributed
to the system. This was causing the storage to go totally
unattributed (and causing roughly a 1GB gap in sizes.) On my
test device, the sizes now sum properly.

Change-Id: Ibc13015e40f854090a7a3ec09eef4c5c52918e0f
Fixes: 35144717
Test: Settings robo
2017-03-10 15:15:42 -08:00
Daniel Nishi
abd92e0519 Update the Manage Storage preference.
Now, it is a master switch preference which can toggle the
automatic management on/off. This also removes the old
UI in the storage summary at the top.

Bug: 33199077
Test: SettingsRoboTests

Change-Id: I709fd2ca0687f760a5d97ad6bebe477b427b0464
2017-03-08 10:18:43 -08:00
Daniel Nishi
41f36cdae8 Merge "Use the screen context when adding preferences." 2017-03-07 22:55:06 +00:00
Daniel Nishi
522e05f169 Align the profile calculation with other screens.
The profile fragment was accidentally adding all of the app's
code data to the profile, even if it was already attributed to the
primary user.

Change-Id: I47000bbe1fcf98d5e9f252eb74b22fee05b7034d
Fixes: 35919232
Test: Settings Robotest
2017-03-06 13:56:57 -08:00
Daniel Nishi
dbc54a1736 Use the screen context when adding preferences.
When the context from the controller itself is used, it is
not the correct context and causes the created preferences to
be styled incorrectly. By using the screen's context directly,
we can ensure that the preferences inherit the correct style.

Change-Id: I02503e5f4fab8f8110e5d29bd3a479f0ce1d6aca
Fixes: 35891968
Test: Robotest
2017-03-02 15:08:29 -08:00
Daniel Nishi
01a9935528 Merge "Use the new package stats query." 2017-03-01 20:55:01 +00:00
Daniel Nishi
73a1c2afb3 Use the new package stats query.
This allows us to remove the logic w.r.t. uid merging.

Bug: 35754646
Test: StorageAsyncLoaderTest
Change-Id: I93aff1d55e0e761269c135f0e821ed2067eeda06
2017-02-28 13:30:13 -08:00
Daniel Nishi
b6059a9e98 Use "Music & audio" as the title for the music view.
Change-Id: I33bc5ccf55ee09842368b2fd4a83b9fd492eded0
Fixes: 35713002
Test: Manual
2017-02-28 01:36:22 +00:00
Daniel Nishi
63558780a5 Merge "Add support for user profiles to the Storage Settings." 2017-02-23 18:39:35 +00:00
Daniel Nishi
e3ac0cd6db Use the upstreamed StorageStatsSource wrapper.
This was upstreamed into SettingsLib when similar wrappers
started showing up in other projects. Settings, however, was
using the non-upstreamed version.

Change-Id: Iffadb75655165d3b64a25fd7b21e5b9765cb40be
Fixes: 35680800
Test: Settings Robotests still pass despite the data swap out.
2017-02-22 17:49:41 -08:00
Daniel Nishi
9f60f42a94 Add support for user profiles to the Storage Settings.
This adds new preferences for each profile (such as the work
profile) and defines a new view for viewing the storage
breakdown for the individual profile. The functionality closely
mimics the presentation on the main view, but without the system-wide
breakdown and without any additional users/profiles.

Bug: 34715777
Test: Settings Robotests

Change-Id: I19d449b648c6566331fd02e45c2e45f8c74ea7e7
2017-02-22 17:33:24 -08:00
Daniel Nishi
b826edb2af Add logging to help debug loader issue.
Sometimes, it looks like the loader is not returning the result
to populate the storage settings view. The current bug reports
have no smoking guns. By adding this debug logging to the build,
the bug reports should hopefully help lead us to where the bug
is originating.

Bug: 35389719
Test: None
Change-Id: Ifa3f69f1fb4669aa72e6ef9c7ccc9d74b9e0fa71
2017-02-21 16:26:10 -08:00
Daniel Nishi
422e7c354d Update the loading of info for the secondary users.
Bug: 34715777, 34225103
Test: Settings Robotest
Change-Id: I32bb15ad8bc866c1fd41728e56faa8b09ae11eb6
2017-02-21 12:08:28 -08:00
Daniel Nishi
dfed8a2acb Add support for visualizing secondary users.
This functionality adds the secondary users to the screen, but
currently does not populate the information for them. Once the
external stats query works, I will add a loader which will
populate this information.

This also does not cover work profiles. Support for that is
forthcoming.

Bug: 34715777, 34225103
Test: Settings Robotest
Change-Id: Ib9b692b214f5ce5d303dfd64516381443d4acebd
2017-02-21 12:07:23 -08:00
Daniel Nishi
e0eb1a2e27 Add metric events triggers for new storage actions.
Bug: 35063738
Test: Settings Robotests
Change-Id: I435cb16c492d3777e735266c2d3a2b1930443acb
2017-02-16 13:43:03 -08:00
Fan Zhang
c6ca314c0b Log source with visibility change
- Add a method in VisibilityLoggerMixin to log visible event using
  LogMaker, which allows logging additional FIELD_CONTEXT field.
- In Utils.startFragment, add current page's metricsCategory as an extra
  to next page.
- In next page's onResume(), extract the previous page's metricsCategory
  and send it to VisibilityLoggerMixin.visible()
- Update all caller with additional paramters

Change-Id: I8e1f2597fa465b7d3aa16fa1d21c052a3219694a
Fix: 35359289
Test: RunSettingsRoboTests
2017-02-15 17:17:19 -08:00
Daniel Nishi
7cec1bc53c Use the "fast track" storage calculation for all categories.
Bug: 34204877
Test: Settings Robo
Change-Id: I4a3e26e6e96e9b697c1019160c053b079076d3a2
2017-02-02 13:02:32 -08:00
Daniel Nishi
0905600b7a Use the fast track calculation for apps.
This replaces the calculation of the apps category
and add in a calculation for the games category using
the faster GID calculation. This should result in app
sizes loading roughly 10 times after.

Bug: 34204877
Test: Settings unit & robo tests
Change-Id: I78044a8d50f695f8c0a7e04183030232a9719260
2017-02-01 14:02:03 -08:00
Daniel Nishi
31027dae93 Add a music apps view to the Storage Settings.
When you tap the Music & Audio preference, it takes you a
hybridized applications view. In this view, there also is
a line item which defines the amount of storage used by
audio files on the device. Using the new storage query, we
can add this information very quickly to the view.

Bug: 33199077
Test: Settings robo tests
Change-Id: If51cba0b3de20805543a39049367eb13613081e7
2017-01-25 11:56:02 -08:00
Daniel Nishi
c208eff2f8 Hook up the Games storage category preference to a games view.
This patch adds functionality for the soon-to-be-deprecated games
and the new app categorization.

Bug: 33199077
Test: settings robo
Change-Id: Iae055c6f1b4d1af3f51aba9897c140ae7aac41c9
2017-01-24 09:43:58 -08:00
Daniel Nishi
f7fc304724 Launch the Gallery app to manage photos from the Storage screen.
This replaces the old behavior of opening the Files app and
matches the latest mocks.

Bug: 33199077
Test: settings robo
Change-Id: Id6451300063fcb3f10c6272c2a2fa49fe1384ac5
2017-01-13 10:44:12 -08:00
Daniel Nishi
a3494347e4 Add ASM enabled/disabled text to the Storage settings.
Bug: 33199077
Test: Settings Robo Tests
Change-Id: I86897c63b584d3c8be171723367a6b4e060684f3
2017-01-12 02:37:12 +00:00
Daniel Nishi
b465005c29 Update the storage summary header.
This changes it to now have a donut graph and reflects the new UI.
Finalized redlines are still pending, so there will be a follow
up patch to get everything aligned as per the mocks.

Bug: 33199077
Test: Settings Robo Tests
Change-Id: Ic12a77bd9be335af14f80886d1ecc24c82940e9b
2017-01-11 12:37:33 -08:00
Daniel Nishi
884809199f Hook up the storage item preferences to actual data.
This uses the same storage query implementation as the previous
iteration of the Storage Settings. In b/32206268, a new API for
querying this information will be added for querying this info.

Once the new API has landed, a future patch will swap out the
impl, but this should work for today.

Bug: 33199077
Test: Settings Robo Tests
Change-Id: I58763e8ee38aabbea533bc614268288e854ff8d4
2017-01-10 17:52:52 -08:00
Daniel Nishi
8cc6f9f718 Add click behavior to the storage item preferences.
This currently imitates the previous implementation behavior.
The new mocks have a new intermediate view for some of these
behaviors, but this view isn't ready yet.
This patch should bring parity for the click functionality
for the storage line item preferences.

Bug: 33199077
Test: Settings Robo Tests

Change-Id: I4f654d30add92e4eec721c36b2801f9af9824e78
2017-01-10 16:46:44 -08:00
Daniel Nishi
7f6d117c28 Remove debug log statement.
It accidentally was left in from a previous patch.

Test: None
Change-Id: I5f1638be7154b0870c19a8624be18e6aa433b4d8
2017-01-09 17:04:25 -08:00
Daniel Nishi
ec89a3f57f Add first pass at a new Storage screen.
This patch begins setting up the structure for the screen.
The functionality for populating the data in the preferences
is coming in a later patch.

Bug: 33199077
Test: Settings Robo Tests
Change-Id: I9ebad9d3896501e31ac715704ca986eceb36877d
2017-01-05 11:54:56 -08:00