Commit Graph

3011 Commits

Author SHA1 Message Date
Julie Pan
7eac19fc3f Merge "Remove beccahughes@google.com from src/com/android/settings/applications/credentials/OWNERS" into main am: ce2a5e07e2 am: 33e2eb32fa
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3118591

Change-Id: I44916de88f8c594814f46d5ccd36ec910981926c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-06 20:15:33 +00:00
Julie Pan
33e2eb32fa Merge "Remove beccahughes@google.com from src/com/android/settings/applications/credentials/OWNERS" into main am: ce2a5e07e2
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3118591

Change-Id: I46352b557bef347fd55d89c0fbdd29d87d52c1bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-06 19:54:52 +00:00
Owner Cleanup Bot
88ab066a66 Remove beccahughes@google.com from src/com/android/settings/applications/credentials/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote CR -1 and the bot
will abandon it. Vote CR +1/2 to approve this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/beccahughes@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I8563f73848a4e32ff3da4b1eaf34253374d9012c
2024-06-06 17:47:53 +00:00
Lifu Tang
c233ecca5c Change the relative time format to LONG
The `SHORT` format, which abbreviates relative time as 'x min.
ago,' presents an accessibility issue for screen readers like
TalkBack. TalkBack announces this as 'x minimum. Ago', and the
dot after "min" is treated as period and causes a full-stop.

Attempts to directly modify TalkBack's pronunciation of this
text have proven difficult. Given the ample space available in
the user interface, using abbreviations isn't necessary.
Switching to the `LONG` format ('x minutes ago') would resolve
this accessibility problem while also making the interface
clearer for all users.

Bug: 318323722
Change-Id: I42ba960bd8d5d8fc8a9cb895ecf24c56dab6d2c4
2024-05-29 20:52:18 +00:00
Amith Yamasani
5953a3386c Merge "Add a source parameter for resrictions logging" into main 2024-05-23 18:54:49 +00:00
Amith Yamasani
8b37c093b7 Add a source parameter for resrictions logging
Modify existing callers to use the new parameter

Bug: 341112680
Test: statsd_testdrive 866
      Manually change battery restriction level for an app
Flag: android.app.app_restrictions_api
Change-Id: I66f23341b90f96eb3091b94ab6db512570988643
2024-05-22 16:15:29 +00:00
Treehugger Robot
4bbb31db66 Merge "Add additional right padding for the button view" into main 2024-05-22 08:22:02 +00:00
Jerry Shi
96b5e6af05 Add additional right padding for the button view
Test: locally built and tested for both LRT and RTL locales
Bug: 332495504
Change-Id: I4db57a7cb038863dc7db3bb69bf94b95886f0cf3
2024-05-21 20:31:44 -07:00
Oli Thompson
383b7960f1 Backup connected apps settings
Save the preference for connected apps for backup and restore

Flag: android.app.admin.backup_connected_apps_settings
Bug: 175067666
Test: manual

Change-Id: Ic46fbd1ab82f551ecf89caf800e41d6afe48fc68
2024-05-17 13:18:29 +00:00
Jerry Shi
07b7679319 Properly handle the autofill provider names, making sure place holder
name is properly filtered out.

Bug: 337040395
Test: locally built and tested
Change-Id: I081064c6103f79fe966a36d0eea854ee9893bce3
2024-05-15 10:11:29 -07:00
Jerry Shi
9884f1ccf4 Fix the issue the if primary provider is disabled by work admin, it
should be removed from the settings' storage.

Test: locally built and tested
Bug: 337040395
Change-Id: Ic572cd87f571d93ee0e7fa29157172444c7c36ce
2024-05-13 23:45:54 -07:00
Daniel Kim
f000f82ac2 Merge "Replace credential provider placeholder" into main 2024-05-07 17:53:14 +00:00
Daniel
385f5a0c7b Replace credential provider placeholder
Replace credential provider placeholder with the actual credential
autofill provider.

Bug: 330177328
Test: cts
Change-Id: Ib6c9688b3f728706b1f5ac0faa3f042bb6dc447c
2024-04-30 19:45:55 +00:00
Manish Singh
54461d2679 Merge "Apply personal filter when private tab not shown" into main 2024-04-30 09:55:34 +00:00
Manish Singh
4875662f48 Apply personal filter when private tab not shown
Bug: 336327005
Fix: 337744275
Test: manual
Change-Id: I1c8cbc35f90cd39bb332f9a6b787473779249166
2024-04-29 15:48:24 +00:00
Ivan Chiang
6afb9ece62 Add the different summary for the app store details
When the initiating package is different from the installing package,
show the different summary. E.g WebApk

Test: atest AppInstallerInfoPreferenceTest
Bug: 329140383
Change-Id: Icd5559bce06c059844269d70926b3c0b39589edb
2024-04-25 02:41:33 +00:00
Becca Hughes
862e71b73d Merge "Fix bug where empty section is sometimes shown" into main 2024-04-18 22:08:29 +00:00
Becca Hughes
1c3fb49913 Fix bug where empty section is sometimes shown
There is a bug where the empty section is
sometimes shown for additional providers. This
is because the logic for calculating the
visibility gets the providers and then the
logic for displaying the list gets the providers
and can result in getting out of sync. This aligns
both sets of logic to use the same data.

Test: ondevice & unit
Bug: 330163369
Change-Id: Icf71c78d67d55c929476f8e699d5893e60a49776
2024-04-18 19:52:15 +00:00
Jason Chiu
8d3d975795 Merge "Remove the package name restriction of ACTION_UNINSTALL_PACKAGE" into main 2024-04-18 01:49:09 +00:00
Jason Chiu
5d82f6a648 Remove the package name restriction of ACTION_UNINSTALL_PACKAGE
PackageInstaller has protected the intent action by setting
"android:priority=1".

Test: manual
Fix: 332228634
Change-Id: If0794e5957366d8b26acd0362b59c6c9076a0c4f
2024-04-17 16:26:52 +08:00
Amith Yamasani
7676217e4d Call noteAppRestrictionChanged when toggling restrictions/exemptions
This is to log the reasons for restriction level change and force stop

Bug: 333882527
Test: statsd_testdrive 863
      Toggle battery restrictions manually for an app and verify logging
      of reason
      atest BatteryOptimizeUtilsTest
Change-Id: Ifcc99efc1b6acc5a992f7d952967210b07319f2e
2024-04-16 21:58:40 -07:00
Becca Hughes
2fc40e8be7 Make sure policy transparency is applied in all cases
There are some cases where policy transparency is not
correctly showing up (e.g. on the main setting screen
for the primary provider). This makes sure policy
transparency is fully applied to the end user.

Test: manual on device
Bug: 333597574
Change-Id: I8d6a4c60e40bd2e639127777efdb04f1035c24bc
2024-04-11 16:18:54 +00:00
Song Chun Fan
523fd97cb4 Merge "[Settings/Archive] remove all checks for the archiving system property" into main 2024-04-08 22:36:39 +00:00
Becca Hughes
fba70edef5 Merge "Add provider name to on/off switch talkback" into main 2024-04-08 21:59:37 +00:00
Song Chun Fan
6ae958abd2 [Settings/Archive] remove all checks for the archiving system property
No longer needed

Change-Id: I24bc9a3d7503da1606d29eb3dfa963b0e6bf9d3e
BUG: 331165939
Test: builds
2024-04-08 18:16:11 +00:00
Becca Hughes
0c14078504 Disable primary provider clickable state
Since this view isn't clickable this was
resulting in incorrect talkback
descriptions.

Bug: 322252309
Test: on device manual
Change-Id: I6b00707dbab9081a5ed09cc2383d06baf0397600
2024-04-08 10:05:06 -07:00
Becca Hughes
cf2d635601 Add provider name to on/off switch talkback
Test: ondevice manual
Bug: 322274544

Change-Id: If067b3bea941ae997d9aefe03286d3b223956326
2024-04-08 16:53:58 +00:00
Becca Hughes
13c6b07868 Pass the package name from the intent to the picker fragment
When an app uses the legacy autofill intent to launch the
settings activity we should pass the package name of the
launching app to the picker. If the app is then picked by
the user we will return result_ok to the app and if it
is not picked we will return result_cancel.

Change-Id: I99dbfad2c69ed57ff891c189f726ecc408d9d188
Test: ondevice manual
Bug: 324197609
2024-04-02 17:53:30 +00:00
Becca Hughes
92485a7308 Merge "Implement policy transparency for CredMan" into main 2024-03-29 22:20:11 +00:00
Becca Hughes
9931d03f6f Implement policy transparency for CredMan
This CL implements policy transparency for
Credential Manager settings.

Screenshots:
https://hsv.googleplex.com/5502938857340928
https://hsv.googleplex.com/4999933426925568

Test: on device w/ test dpc
Bug: 318552220
Change-Id: I78e1fa47541c81e6e2d2bf2c13159be01928e77c
2024-03-29 09:56:47 -07:00
Jason Chiu
6ca5c992d7 Merge "[Safer intents] Permission controller" into main 2024-03-29 09:20:28 +00:00
Jason Chiu
cf13dfd4c6 [Safer intents] Permission controller
To avoid implicit intents, make intents launch explicitly.

Test: build, manual
Bug: 323061508
Change-Id: Ib95b417fc8682f690890fc55f321b4fece2c0369
2024-03-28 17:09:37 +08:00
Jason Chiu
071dfe8691 [Safer intents] Applications
To avoid implicit intents, make intents launch explicitly.

Test: build, robotest
Bug: 323061508
Change-Id: I9bf4eb102550f4afd8d14a6799940d37fc0ab9a7
2024-03-28 04:13:47 +00:00
Edgar Wang
1a683a1007 Merge "Listen Developer option enable state" into main 2024-03-22 01:13:17 +00:00
Edgar Wang
26a5c73dc7 Listen Developer option enable state
- When developer option disabled, any page in Developer option
  should be closed.

Bug: 293894425
Test: manual

Change-Id: I392b122e885118770be1af2b51c0c7ef92279e1b
2024-03-21 04:08:08 +00:00
Manish Singh
3b4e29e68d Merge "Return my user id" into main 2024-03-15 16:55:36 +00:00
Manish Singh
20b7cdcda8 Return my user id
Since the current context is the correct one, we can simply return
myUserId - just like for the managed profile.

Bug: 329784721
Test: manual
Change-Id: Ifbc13b0d87ba7b06c6d04c3442bbac0580c4cf3e
2024-03-15 12:25:51 +00:00
Olivier Nshimiye
a4babe7463 Merge "Add enable_private_space_features flag check for Private Space implementation" into main 2024-03-14 09:48:27 +00:00
Oli Thompson
77f8e503c3 add a check if the app store link intent can be opened in the profile.
Bug: 245269933
Test: manually tested
Change-Id: I5240c2a5e2444444738fe1d226c11e9d56ab8c87
2024-03-08 18:55:52 +00:00
Olivier Nshimiye
baa7a8c2c8 Add enable_private_space_features flag check for Private Space implementation
Bug: 326060689
Test: Manual
Change-Id: I82105714e74789394a3d46b852aaa3e7b93e5877
2024-03-08 15:36:29 +00:00
Graciela Wissen Putri
aed31bb8bd Follow config overlay's order of aspect ratio options am: a0f573a35e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26456385

Change-Id: I30ff221caba3be36834acb44958cf2aed30c17d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-07 12:11:14 +00:00
Olivier Nshimiye
b816437d39 Merge changes from topic "add-ps-features-flag" into main
* changes:
  Add Private Space features flag check to Settings tests
  Add an additional flag guard for Private Space implementation
2024-03-07 10:48:58 +00:00
Graciela Wissen Putri
a0f573a35e Follow config overlay's order of aspect ratio options
Fix flaky UserAspectRatioAppsPageProviderTest by using advanceUntilIdle
to make sure all coroutines are finished before asserting.

Bug: 325911424
Test: atest UserAspectRatioDetailsTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:32815ad699448c5c5b1f38df6d2d2a881d4251c1)
Merged-In: I83e9a7f31536c1a006789722b0310f3364d14337
Change-Id: I83e9a7f31536c1a006789722b0310f3364d14337
2024-03-05 17:11:59 +00:00
Manish Singh
55e9f41bda Return true only if the userManager belongs to private profile
The existing code asks the main user's userManager if there's a
private profile belonging to it. If a private profile exists then the
answer to that question will always be true. So, we always end up
showing the apps from the private profile for the personal case.

We should instead ask the userManager if it belongs to the private
profile or not.

Bug: 327598131
Test: manual
Change-Id: I7bc9d58c371341235579d3456b54ea85f598892b
2024-03-04 18:26:58 +00:00
Olivier Nshimiye
0f3799cbad Add an additional flag guard for Private Space implementation
This a layer of flag guarding only for the implementation of Private Space features excluding the APIs. The MVP flag allow_private_profile still guards all the features including the APIs.

Bug: 326060689
Test: Manual - a few verifications that some feeatures are unavailable when this flag is disabled
Test: Run presubmits and verify that nothing breaks
Change-Id: I05f7e2f20c6132b33484bb133ce03a933ece485f
2024-03-04 15:43:24 +00:00
Hani Kazmi
05427e6903 Merge changes from topics "ecm-manager", "ecm-tests" into main
* changes:
  Replace ECM AppOps call with service
  Wired remaining SpecialAppAccess for ECM.
2024-02-21 19:29:04 +00:00
Hani Kazmi
206300962f Replace ECM AppOps call with service
A new ECM service was introcuded in changeId
I831391e4437b51b3312b5273a2360bd029a3d8ee.

We begin calling it, and update/cleanup method signatures to match.

Note: There are two feature flags:

1. enhancedConfirmationModeApisEnabled - read only, protects the
   mainline API.

2. extendEcmToAllSettings - runtime - gates calls to the above APIs.

We use both so we can ramp up in teamfood as needed.

Bug: 297372999
Test: Tested on device
Test: atest SpaPrivilegedLibTests
Test: atest com.android.settings.applications.specialaccess.notificationaccess
Test: atest com.android.settings.datausage
Test: atest PremiumSmsAccessTest
Test: atest RestrictedPreferenceHelperTest
Change-Id: I945ec51df5cd63de548a8ffdd1acc4f09f2301e5
2024-02-21 14:43:02 +00:00
josephpv
62df3efdd7 Handle listing of PS apps in Apps > Special App Access > Device Admin Apps
Currently Device Admin Apps page shows apps from Private space even
when PS is locked.  This change takes care to hide PS apps from the list
when private profile is in quiet mode and on disabling quiet mode PS
apps are shown in the list.
Also takes care to update the active apps summary count to not include
PS apps when private profile is in quiet mode.

Recording link : b/324311892#comment2

Bug: 324311892
Test: Manual
Change-Id: If4199ecad0a228c8e491778fb62c09c8b3f20604
2024-02-19 23:00:19 +00:00
Becca Hughes
62fa76f719 Merge "Hide "additional services" if there is only a single primary services" into main 2024-02-15 23:54:59 +00:00
Hani Kazmi
96ab2b9e25 Wired remaining SpecialAppAccess for ECM.
This change enables the remaining settings for ECM, and adds tests for
both this and previous ECM changes.

Bug: 297372999
Test: Tested on device
Test: atest SpaPrivilegedLibTests
Test: atest com.android.settings.applications.specialaccess.notificationaccess
Test: atest com.android.settings.datausage
Test: atest PremiumSmsAccessTest
Test: atest RestrictedPreferenceHelperTest
Change-Id: I73d39d765dba0c1a75111c37b29ccf1c85d2cdd8
2024-02-15 15:15:23 +00:00