Commit Graph

101 Commits

Author SHA1 Message Date
josephpv
83f73732de Set SKIP_FIRST_USE_HINTS setting for private space
With this change the value of Secure settings SKIP_FIRST_USE_HINTS is
set for private profile after creation of profile in PS setup flow.

The value is set for the profile user so that first launch of an app in
private space will not display introductory hints.

Bug: 325596557
Test: PrivateSpaceMaintainerTest
Change-Id: I63a967bba052a3dcb4742c95b89c6da19aba74d5
2024-04-15 10:47:42 +00:00
Joseph Vincent
1759f174fb Merge "Update string and button choice in PS lock setup screen" into main 2024-04-12 16:33:05 +00:00
josephpv
d562080b75 Update string and button choice in PS lock setup screen
Screenshot : go/ss/93jhuNKsPPzDvzy.png
Recording link : b/334013507#comment5

Bug: 334013507
Test: Manual
Change-Id: I03e1e5297c69f1d5154a45481f54d4207f454bd4
2024-04-12 14:33:26 +00:00
josephpv
a7603d2b43 Handle startProfile failure during creation of private space
This includes to verify return value of startProfile to check if profile
is started successfully. If startProfile failed for any reason then
delete the created profile and return false for createPrivateProfile().

Bug: 313926659
Test: atest PrivateSpaceMaintainerTest
Change-Id: I493cb3a41cef8bdc1be42fe328c4f7bd04944b94
2024-04-11 15:59:43 +00:00
josephpv
3978c30817 Handle private space account login skip result
Bug: 320460786
Test: Manual
Change-Id: I59ad178a7925ef1680e67deb5321ec6d0c702e73
2024-04-10 14:39:10 +00:00
Joseph Vincent
db315e642b Merge changes I6387c999,I470e5c6e into main
* changes:
  Update illustrations in Private Space setup & settings
  Replace autoadvance screens with waiting screen in PS setup
2024-04-10 09:51:35 +00:00
Joseph Vincent
782ec3d5aa Merge "Remove settings activity from recents at end of PS setup" into main 2024-04-09 22:37:24 +00:00
josephpv
f145d0e9a0 Update illustrations in Private Space setup & settings
This inlcudes the changes to use latest private space icon and update
the illustrations in private space setup and settings.
Change made to update illustrations dynamically between light and dark
theme.

Recordings link:
b/332867167#comment3

Bug: 332867167
Test: Manual
Change-Id: I6387c9991ec9bb419f446431926f99843f92c859
2024-04-09 22:35:04 +00:00
josephpv
af800e55f4 Replace autoadvance screens with waiting screen in PS setup
This change replaces the auto advancing screens shown during private
space setup flow with a single loading screen.

Recording: b/332652637#comment3

Bug: 332652637
Test: Manual
Change-Id: I470e5c6ece16cfefd0734d3daadf1d8efe963f63
2024-04-09 21:13:37 +00:00
Himanshu Gupta
52c8655e30 Merge "Fix Logs" into main 2024-04-09 19:43:37 +00:00
josephpv
d82e3961f4 Remove settings activity from recents at end of PS setup
Recording link:
b/310192654#comment2

Bug: 310192654
Test: Manual
Change-Id: Id71480ddce94aee8d9d5f1aa83bfff4e06df6377
2024-04-09 15:06:20 +00:00
Manish Singh
f2869fd64e Merge "Remove all Settings tasks from Recents when PS is locked" into main 2024-04-05 15:06:41 +00:00
Olivier Nshimiye
f195e8bfec Merge "Remove 'Hide Sensitive Notifications' item from PS settings page" into main 2024-04-04 17:08:04 +00:00
Joseph Vincent
2f8efa0633 Merge "Support face unlock for PS if class2 biometric and above" into main 2024-04-04 13:03:31 +00:00
Olivier Nshimiye
7851c33bbd Remove 'Hide Sensitive Notifications' item from PS settings page
Remove the hide sensitive notifications toggle, but keep private space sensitive notifications always hidden on lockscreen

Bug: 329657118
Test: atest PrivateSpaceMaintainerTest
Test: Manual - verified that PS sensitive notifications are always hidden on lockscreen.

Change-Id: Id4229c11a2c5a3a4d3fedaf710c51f25af64bf86
2024-04-04 09:40:36 +00:00
josephpv
4e32375f3d Use canAddPrivateProfile() to enable PS delete from Reset
This change adds canAddPrivateProfile() check to enable/disable
Private space delete controller in Reset options.

Matches the availability to delete private space from reset
options with the conditions used to show the private space entry point.

In Settings Reset options preference to delete private space will be
shown only when private space creation is allowed on the device or if
private space already exists on the device.

Bug: 330396315
Test: ResetOptionsDeletePrivateSpaceControllerTest
Change-Id: I63232556f7927aeb07b73e8732bbb8b1d2423456
2024-04-03 20:39:12 +00:00
josephpv
1791ce216b Support face unlock for PS if class2 biometric and above
With this change it is checked if face unlock is supported as a class2
or class3 biometrics on the device.
If face is convenience biometrics then face unlock for
private space controller is not added.

Bug: 329044103
Test: atest UtilsTest and verified Face unlock is not added if face is convenience
Change-Id: I6e1a6557774be1173ad3ee7ff7b14d51f9fe1716
2024-04-03 19:09:40 +00:00
Joseph Vincent
0fee5fa0b0 Revert^2 "Add waiting screen before PS setup completion"
This reverts commit d2c91b587e.

Reason for revert: Landing the original cl as the test passes locally with changes and failed test looks to be flaky and not related to the change.

Failure is not seen in the ABTD test run results with this CL  b/331935387#comment10

Change-Id: I744e11a04b70e265c5dcfe5aa8db7237561f3a08
2024-04-03 16:36:21 +00:00
Manish Singh
f42207e1d9 Remove all Settings tasks from Recents when PS is locked
Bug: 330865434
Test: manual
Test: atest PrivateSpaceMaintainerTest
Change-Id: I56b12a6ea5bfedd243fd138ef898f8496301199e
2024-04-03 12:29:44 +00:00
Priyanka Advani
27d7b192f7 Merge "Revert "Add waiting screen before PS setup completion"" into main 2024-03-29 21:43:30 +00:00
Priyanka Advani
d2c91b587e Revert "Add waiting screen before PS setup completion"
This reverts commit 7b0b26ec92.

Reason for revert: b/331935387. ACA has already verified the revert.

Change-Id: Idf28854f25c4bad3563408dbb7b5c84f0cdbe2f2
2024-03-29 21:30:27 +00:00
Joseph Vincent
ea6500455a Merge "Add waiting screen before PS setup completion" into main 2024-03-29 14:30:07 +00:00
Himanshu Gupta
438dfde6c3 Fix Logs
Bug: 328578044
Test: Manual Build and Test
Change-Id: I33d8b97bfa609e1f65c8fcb2c7badc4610bc8bc4
2024-03-29 14:02:47 +00:00
josephpv
7b0b26ec92 Add waiting screen before PS setup completion
At the end of PS setup just before showing the final sucess screen this
change adds a new screen with loading layout which enables profile quiet
mode.
After enabling quiet mode checks if user is stopped before removing the
loading layout screen. Until user is stopped loading screen will be
shown.

Bug: 329042236
Bug: 328393532
Test: Manual verify new delay screen is shown
Change-Id: Iac3fd2f0f5c75a64719fbce32ff4dbfb533322d5
2024-03-28 22:53:46 +00:00
Joseph Vincent
7e3d30c95f Merge "Change Never Option to lock private space after device restart" into main 2024-03-28 22:39:13 +00:00
josephpv
d4f5641c55 Change Never Option to lock private space after device restart
Bug: 324208974
Test: atest AutoLockPreferenceControllerTest
Change-Id: Ia45f7f02f407808eaa9a061ae32480c354bdfb74
2024-03-28 11:16:23 +00:00
Joseph Vincent
e8ba1b5711 Merge "Enable talkback in Header Text View in private space setup autoadvance screen" into main 2024-03-27 20:41:47 +00:00
josephpv
12054c7f1f Enable talkback in Header Text View in private space setup
autoadvance screen

Bug: 330455551
Test: Manual
Change-Id: I320c919964312eb8847bc76ef4e6de07c7d2db75
2024-03-27 11:21:51 +00:00
Manish Singh
1236e94cf4 Merge "Rename the name of private profile creation from Settings" into main 2024-03-27 09:43:47 +00:00
josephpv
4cc915ad64 Change icon for Private Space unlocked and setup success toast
Change is made to show customised icon in Toast message shown by using
Toast.makeCustomToastWithIcon()

Screenshots :
go/ss/AcaRQUJQfh79wDw.png
go/ss/5j4oD8xydwX7HTX.png

Bug: 329391204
Bug: 309575523
Test: Manual
Change-Id: I336d7d0419b1de60024e584e943a725662b446a9
2024-03-25 16:53:46 +00:00
Himanshu Gupta
8735770fa8 Merge "Disable PS entry point and Activity when PS is not allowed." into main 2024-03-24 14:45:32 +00:00
Himanshu Gupta
5e451db395 Disable PS entry point and Activity when PS is not allowed.
In this change we disable:
1. Security Center Entry point
2. PrivateSpaceAuthenticationActivity

when private profile is not present and cannot be added.

Additionally, the intent exposing PrivateSpaceAuthenticationActivity
is also non-exported and changed to a better name.

Bug: 328578044
Test: Manual build and flash
Change-Id: I13d298316c6d719d0b06e4969989ea1da83dd4c6
2024-03-22 13:44:23 +00:00
Joseph Vincent
4230ad4b07 Merge "Add a preference in reset options to delete private space" into main 2024-03-22 10:01:19 +00:00
josephpv
43c8d3a3f8 Add a preference in reset options to delete private space
This takses care to add an entry point in Settings->System->Reset
options->Delete private space when private space feature is supported on
the device. Entry point appears both when private space exists and also
when private is not created.
On selecting asks for user authentication and on successful
authentication using device lock shows a dialog asking for
confirmation and calls for deletion private space.

Based on this entrypoint it would not be possible to guess if private
space exists on the device.

Recording link : b/329041740#comment3

Bug: 329041740
Test: atest ResetOptionsDeletePrivateSpaceControllerTest and verified
this doesn't give away existence of private space

Change-Id: I9a5b908e7a3f9edaf609cf7e6a87f9842d689ce6
2024-03-21 21:54:52 +00:00
josephpv
6a3bd88078 Add message in dialog shown on choosing separate private space lock
Change to add message in the dialog shown on selecting to choose a new
profile lock for private space.

screenshot : go/ss/ASkBCFJuCzp7dkf.png

Bug: 330218365
Test: Manual. Diaog shown as per UX mock
Change-Id: I17f4d7ebf515dc7c95fcae7a5ec5edeb9918ded3
2024-03-20 17:28:45 +00:00
Joseph Vincent
e6a759303c Merge "Update strings in private space hide when locked settings page" into main 2024-03-20 17:28:21 +00:00
josephpv
4cebe66d71 Update strings in private space hide when locked settings page
Recording link:
b/330221666#comment2
screenshot :
go/ss/Ja2xyxVm4wjDF6P.png
go/ss/56Kujyq6WfBLtHG.png
go/ss/9wvcJTXnarizyU5.png

Bug: 330221666
Bug: 330327338

Test: Manual. Verified strings are updated as per UX mocks
Change-Id: I053bd2558503eb58fcf196eb0988bfa007583704
2024-03-19 17:05:28 +00:00
Manish Singh
e157ba8f39 Rename the name of private profile creation from Settings
Bug: 324844478
Test: manual
Change-Id: I9d2a2e3a2aa73e3eeea4fd08c45c9f9d654ea5d4
2024-03-19 15:52:27 +00:00
josephpv
f9bc323633 To skip face enrollment for PS unlock setup based on intent extra
For private space lock setup as part of both PS setup and separate lock
form private space settings we need to show only traditional unlock
factors and Fingerprint but not show Face enrolment even on devices
where Face unlock is supported by hardware.
Once LSKF is enrolled it should be followed by Fingerprint enrollment
flow and after that Face enrollment should not be shown and exit lock
setup flow.

Currently for separate profile lock setup ACTION_SET_NEW_PASSWORD intent
is used in private space setup.
With this intent the options of LSKF+fingerprint+Face is shown in
devices supporting both fingerprint and face hardware. After the LSKF
ennrollment BiometricEnrollActivity is started which continues with
fingerprint and Face enrollment.

With this change we are passing an extra along with the intent to enroll
fingerprint only. Based on the intent extra value if set even if hardware
support exists the lock enrollment for the profile will support only
LSKF and fingerprint enrollment but not start Face enrollment.

User will still have the option to enroll Face from the dedicated settings
entrypoint in private space settings.

Recording link : b/323839067#comment4

Bug: 323839067
Test: Manual, verified option for face enrollment is shown or not shown
based on the intent extra. When extra is not passed the behaviour will be
default.

Change-Id: Idf92084052e02df9ca89f288c618796750e563e6
2024-03-19 11:58:08 +00:00
Joseph Vincent
f2f44f50de Merge "Add entrypoint for Learn More in PS settings & Setup intro" into main 2024-03-15 07:39:16 +00:00
Olivier Nshimiye
a4babe7463 Merge "Add enable_private_space_features flag check for Private Space implementation" into main 2024-03-14 09:48:27 +00:00
josephpv
1af33733c6 Add entrypoint for Learn More in PS settings & Setup intro
Screenshots:
go/ss/RXhN57DSuSj7aQf.png
go/ss/5xcbx3mWeo2sZ37.png

Bug: 326059389
Test: atest PrivateSpaceFooterPreferenceControllerTest
Change-Id: I72beb1a04ea11909643dd6b455575478cfb5d87c
2024-03-12 16:15:53 +00:00
josephpv
3c97c63d62 Show Alert dialog on Hide when locked is enabled
Bug: 325398789
Test: atest HidePrivateSpaceControllerTest
Change-Id: I6bfa3546b3ba56905918f8fd44c5351bf2d284b8
2024-03-12 10:35:56 +00:00
Olivier Nshimiye
baa7a8c2c8 Add enable_private_space_features flag check for Private Space implementation
Bug: 326060689
Test: Manual
Change-Id: I82105714e74789394a3d46b852aaa3e7b93e5877
2024-03-08 15:36:29 +00:00
Olivier Nshimiye
b816437d39 Merge changes from topic "add-ps-features-flag" into main
* changes:
  Add Private Space features flag check to Settings tests
  Add an additional flag guard for Private Space implementation
2024-03-07 10:48:58 +00:00
Anna Zhuravleva
a05ba46acd Merge "Log change in autolock settings" into main 2024-03-05 10:18:58 +00:00
Anna Zhuravleva
cbc0ec7111 Log change in autolock settings
Bug: 327181532
Test: statsd_testdrive https://paste.googleplex.com/4866138112000000
Change-Id: I4133e35ff343e32261cb0fc190af4a32474b69e3
2024-03-04 18:24:05 +00:00
Olivier Nshimiye
0f3799cbad Add an additional flag guard for Private Space implementation
This a layer of flag guarding only for the implementation of Private Space features excluding the APIs. The MVP flag allow_private_profile still guards all the features including the APIs.

Bug: 326060689
Test: Manual - a few verifications that some feeatures are unavailable when this flag is disabled
Test: Run presubmits and verify that nothing breaks
Change-Id: I05f7e2f20c6132b33484bb133ce03a933ece485f
2024-03-04 15:43:24 +00:00
josephpv
d61b4a418c Fix for PS setup crash in AOSP build
Recording link : b/312454851#comment2

Bug: 312454851
Test: Manual
Change-Id: I2c8f812f0bb75b1d4b41565e8545e83c0a01af09
2024-02-28 11:03:06 +00:00
josephpv
0809d4dee7 Update illustrations in private space setup and settings
Recording link : b/326391912#comment3
https://drive.google.com/file/d/1Rykqy8iugvVNiE8uW2tgAlFhAypGxhdN/view?usp=drive_link

Bug: 326391912
Test: Manual
Change-Id: Ic53c42ec87fde4f1b8c38634e1e2927b235ff2a3
2024-02-28 06:47:49 +00:00