Commit Graph

54912 Commits

Author SHA1 Message Date
Haijie Hong
79f17d1188 make device setting be able to use both Intent and PendingIntent
BUG: 343317785
Test: local tested
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I0c370d64bda1479778b55dc97e136ff73223f5d3
2024-09-29 20:06:49 +08:00
SongFerng Wang
4e05cd99a9 Merge "Hide the enabling mobile data" into main 2024-09-28 00:55:48 +00:00
Tomasz Wasilczyk
c25a0b8f9d Merge "Add support for ApnSetting.TYPE_OEM_PAID and OEM_PRIVATE" into main 2024-09-27 21:35:52 +00:00
Treehugger Robot
c769fc586c Merge "Add a check to ensure that intent data is available before proceeding." into main am: 9a0ba22e79 am: 2c3fbda054
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3278732

Change-Id: If1ee7c3dce581d8276d19ba61564a077d10ecf7c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-27 10:23:47 +00:00
Treehugger Robot
9a0ba22e79 Merge "Add a check to ensure that intent data is available before proceeding." into main 2024-09-27 09:54:21 +00:00
songferngwang
ed5e803c87 Hide the enabling mobile data
Since the framework behavior was changed after the enabling mobile data dialog was implemented.
Bug: 368450590
Test: manully test the dialog.

Change-Id: I08e0e1b9643781e52f6a9d4fa2c0eccf0feb7901
2024-09-27 08:47:52 +00:00
Quang Luong
5f1b6be477 Merge "Do not auto-downgrade WPA3->Transition mode if password too short" into main 2024-09-27 07:52:45 +00:00
Yining Liu
ccaa62ec8a Merge changes from topic "notif_minimalism_settings" into main
* changes:
  Notification Minimalism Settings Main Switch
  Show the Tangor Unseen Notification Toggle when notification_minimalism is Enabled
2024-09-27 05:38:22 +00:00
Yining Liu
41cd514fb3 Notification Minimalism Settings Main Switch
Add a main preference switch for the lockscreen
notification minimalism feature

Bug: 330387368
Bug: 354047572
Flag: com.android.server.notification.notification_minimalism
Test: atest
LockscreenNotificationMinimalismPreferenceControllerTest

Change-Id: I9aa4c51f9e316dd0dd1529d712b5e9486e43453b
2024-09-26 20:58:18 +00:00
Yining Liu
8b6431878a Show the Tangor Unseen Notification Toggle when notification_minimalism is Enabled
Show the Tangor unseen notification toggle in the Notification settings when
notification_minimalism flag is enabled on both phones and large screen devices.

Bug: 330387368
Bug: 354047572
Flag: com.android.server.notification.notification_minimalism
Test: atest ShowOnlyUnseenNotificationsOnLockscreenPreferenceControllerTest
Change-Id: Ic126b7885eb29897b55c4acdc1a2f73b4bc7841e
2024-09-26 20:50:23 +00:00
Joshua Mccloskey
b5aa5265ee Merge "Spit up FingerprintManagerInteractor 2/N" into main 2024-09-26 18:29:36 +00:00
Treehugger Robot
0634f99251 Merge "Protect the Settings application from potential null pointer exceptions." into main am: 6a4fb45e38 am: 840f5a573d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3282054

Change-Id: Ic3001502499250f66af57c0e49ae8ba2a80515f6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-26 11:13:30 +00:00
Quang Anh Luong
5aa95553cd Do not auto-downgrade WPA3->Transition mode if password too short
Hotspot security is auto-downgraded from WPA3->Transition mode if the
band is changed from 6Ghz -> 2.4/5GHz. However, Transition mode requires
a password of 8 chars or more, but WPA3 SAE does not. Avoid changing the
security type if the current password is less than 8 chars.

Flag: EXEMPT minor bugfix

Bug: 366452667
Test: atest WifiHotspotRepositoryTest
Change-Id: I1abadd59966e170b51899782746b9f14e33e6186
2024-09-26 07:09:47 +00:00
Chaohui Wang
9969334647 Fix Can't Able to Click Sims
The root cause is SubscriptionManager.OnSubscriptionsChangedListener
.onSubscriptionsChanged() not invoked in some cases.

Even the SubscriptionManager.addOnSubscriptionsChangedListener's doc
says the onSubscriptionsChanged() method will also be invoked once
initially when calling it, there still case that the
onSubscriptionsChanged() method is not invoked initially.
For example, when the onSubscriptionsChanged event never happens before,
on a device never ever has any subscriptions.

Adding a .onStart { emit(Unit) } to fix.

Also make the subscriptionsChangedFlow() a shared flow to mitigate the
extra emit cost.

Bug: 369276595
Flag: EXEMPT bug fix
Test: manual - factory reset & no any sim
Test: atest SubscriptionRepositoryTest
Change-Id: Ic32a5666f14373926b5dfedb5dedadb4369acfc7
2024-09-26 13:29:47 +08:00
Tomasz Wasilczyk
322f3cf496 Add support for ApnSetting.TYPE_OEM_PAID and OEM_PRIVATE
Bug: 366194627
Test: m
Test: manually add oem_paid APN to telephony.db and verify if shows up
      in APN editor
Flag: com.android.internal.telephony.flags.oem_paid_private
Change-Id: Ida8f6f5712f49caa3172119c547b7ee17e41c12e
2024-09-25 20:05:22 -07:00
Yiyi Shen
d2e97b455e Merge "[Audiosharing] Show dialogs when lifecycle isAtLeast STARTED" into main 2024-09-26 02:49:43 +00:00
Yiyi Shen
d375984779 Merge "[Audiosharing] Use DialogFragment instead of raw AlertDialog" into main 2024-09-26 02:49:38 +00:00
Abdelrahman Daim
996afd17a1 Protect the Settings application from potential null pointer exceptions.
Summary: The app bar is not available, causing a null pointer exception.

Test: Successful Build on master branch

Change-Id: I36849606f6587d6e7f004ae21e1a6e6a5206735a
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-25 17:02:37 -07:00
Treehugger Robot
e3bc83b7b0 Merge "Fixed elapsed_time_millis in SettingsUIChanged event" into main 2024-09-25 23:55:49 +00:00
Yi-an Chen
781cbcdbf0 Merge "Correct behavior on Google Location History preference click" into main 2024-09-25 20:27:33 +00:00
David Liu
2f39a808fc Fixed elapsed_time_millis in SettingsUIChanged event
This change stores timestamp when received com.google.android.setupwizard.SETUP_WIZARD_FINISHED. This timestamp will be used to calculate elapsed_time_millis for SettingsUIChanged event after SUW complete. This enables to analyze how the user uses Settings in a specific time span after setup.

Bug: 344466251
Test: metrics related change only
Flag: EXEMPT metrics change only

Change-Id: I85b15f1eb5e5a4502a27d8588bb01e59b7ad83b5
2024-09-25 18:44:26 +00:00
Treehugger Robot
d6f73f35b6 Merge "Update titles and summaries of the Date and time settings page" into main 2024-09-25 16:54:05 +00:00
Geoffrey Boullanger
8b7399a8d9 Update titles and summaries of the Date and time settings page
Design doc: go/dd-android-settings-time-2024

This change covers Part 1, which consists of adding user-friendly summary under each toggle and rewording titles.

Bug: 296835792
Test: on-device and atest
Flag: EXEMPT resource only update
Change-Id: I0b685743599880fc1c4ad680eca9c36e4e64d0ff
2024-09-25 15:19:10 +00:00
Haijie Hong
9b36ed51a2 Merge "Add icon for more settings preference" into main 2024-09-25 10:37:04 +00:00
Haijie Hong
684ec23cad Merge "Add metrics category for more settings fragment" into main 2024-09-25 10:36:29 +00:00
Yiyi Shen
54b0d18a04 [Audiosharing] Use DialogFragment instead of raw AlertDialog
FragmentManager can help manage the state of the dialog and automatically restore the dialog when a configuration change occurs

Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858921
Change-Id: If63c7891cfb92e06c457e37eb5556f3eaf3f6121
2024-09-25 17:31:14 +08:00
Yiyi Shen
57355a0743 [Audiosharing] Show dialogs when lifecycle isAtLeast STARTED
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 305620450
Change-Id: I34f4f46b9377f1e3ec1a4cd27687c14d674f6da4
2024-09-25 17:13:19 +08:00
Haijie Hong
63ecd2781f Add icon for more settings preference
BUG: 343317785
Test: atest DeviceSettingRepositoryTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: Id7c272edce5ff8166f03b7162ac9ba5ff1f15097
2024-09-25 09:02:07 +00:00
Haijie Hong
fc27dcccde Add metrics category for more settings fragment
BUG: 343317785
Test: local tested
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I21a3ca0deea516765f1af2f5d7117b6c3c1763a7
2024-09-25 16:17:48 +08:00
Haijie Hong
7e7530bfd1 Merge "Fix two-panel issue in tablet" into main 2024-09-25 07:36:43 +00:00
Jacky Wang
09289058d1 Merge "Avoid potential ActivityNotFoundException" into main 2024-09-25 06:27:26 +00:00
Haijie Hong
1020e7132d Fix two-panel issue in tablet
Keep the logic same as BlockingPrefWithSliceController.

BUG: 343317785
Test: atest BluetoothDeviceDetailsViewModelTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I77e62479def433869ae5e93987ec7069cc61173a
2024-09-25 13:48:33 +08:00
Yiyi Shen
28d1551870 Merge "[Audiosharing] Apply new string resid" into main 2024-09-25 05:19:49 +00:00
Jacky Wang
1c486036ef Avoid potential ActivityNotFoundException
Bug: 332202168
Flag: com.android.settings.flags.catalyst
Test: Manual
Change-Id: I74d7bbc9eb34e0f8d04cfb663b04393a3432e784
2024-09-25 11:58:10 +08:00
Treehugger Robot
00c90b0e6f Merge "Migrate Android version preference" into main 2024-09-25 03:30:59 +00:00
Menghan Li
26392847f0 Merge "refactor(brightness suw): decouple auto brightness initialization logic for setup flow" into main 2024-09-25 01:23:55 +00:00
Yi-an Chen
73ab82f52f Correct behavior on Google Location History preference click
Fixes: 366060896
Bug: 360240563
Flag: EXEMPT bugfix
Test: Manually and RecentLocationAccessPreferenceControllerTest
Change-Id: Ibe3c49c3060bcc0967f93a3a88aa45b04ab8a41d
2024-09-25 01:23:52 +00:00
Treehugger Robot
adb3d1f1d4 Merge "Migrate the Legal Info page to Catalyst" into main 2024-09-25 00:39:10 +00:00
Dongzhuo Zhang
c51a76014a Merge "Add contacts storage setting entry in app settings page." into main 2024-09-25 00:20:32 +00:00
Jacky Wang
4329d8371e Migrate Android version preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: I0a15cd460543a7dd84edc5c3a5a2ff900aeba13f
2024-09-25 07:28:52 +08:00
Dongzhuo Zhang
6231453e91 Add contacts storage setting entry in app settings page.
Test: atest SettingsRoboTests:com.android.settings.applications.contacts.ContactsStoragePreferenceControllerTest

Bug: 368641291
Flag: com.android.settings.flags.enable_contacts_default_account_in_settings

Change-Id: I8da16f24b17e44dc0ea417cffabd85c36d7edc5f
2024-09-24 22:28:22 +00:00
Julia Reynolds
2fe4cb6393 Merge "Make legacy DND pages not searchable" into main 2024-09-24 20:19:17 +00:00
Abdelrahman Daim
3be2314fac Add a check to ensure that intent data is available before proceeding.
Summary: There are instances where intent data is absent, leading to a crash while trying to retrieve the schema. This change adds a null check to prevent attempted access when there's no data.

Test: Successful Build on master branch

Change-Id: Ie83bd3243f2c79102061d3fa43d809b3ef3c6c78
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-24 12:21:22 -07:00
Julia Reynolds
0c5eb711a9 Make legacy DND pages not searchable
Flag: EXEMPT unflaggable
Fixes: 341726633
Test: manual, searching in settings
Change-Id: I592a1775a890711086db1099fb333c1dc1a11e0b
2024-09-24 15:18:16 +00:00
Sunny Shao
e060aeb1e1 Migrate the Legal Info page to Catalyst
Test: atest LegalPreferenceTest
Test: atest LegalSettingsScreenTest
Test: atest WallpaperAttributionsPreferenceTest
Bug: 360061554
Flag: com.android.settings.flags.catalyst_legal_information
Change-Id: Ic15384e853584b72a847e1a10713a0c3c29273a7
2024-09-24 23:15:27 +08:00
Jacky Wang
84d31c2ad9 Migrate Android security update preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: I745358d8dfc17b68535336653a149c334b266c91
2024-09-24 17:49:30 +08:00
Jacky Wang
b8d2bc12b1 Migrate mainline module version preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: I1f3f69b08fe22c66d1b1c6786f9cd7e7ff413529
2024-09-24 16:52:13 +08:00
Menghan Li
e0f734526d refactor(brightness suw): decouple auto brightness initialization logic for setup flow
The AccessibilitySettingsForSetupWizard class should not be responsible for managing the initial
logic of controllers, such as determining which controllers need to be dynamically added or updated
using setInSetupWizard APIs. This logic should be handled directly by the controllers themselves.

Bug: 311093618
Flag: EXEMPT bugfix
Test: atest AccessibilitySettingsForSetupWizardTest
            AutoBrightnessPreferenceControllerForSetupWizardTest
            AutoBrightnessPreferenceControllerTest
            BrightnessLevelPreferenceControllerForSetupWizardTest
            BrightnessLevelPreferenceControllerTest

Change-Id: I6065a10e72d002981c0f514543e6933d79c2aa1b
2024-09-24 05:41:23 +00:00
Maryam Dehaini
6a6a3efe57 Merge "Change "Open by default" setting page selection to radio buttons" into main 2024-09-23 22:45:07 +00:00
Maryam Dehaini
11825b0bc7 Change "Open by default" setting page selection to radio buttons
Selection to open page in app or browser needs to be displayed via radio
buttons as discussed here: http://b/346622495#comment14

Bug: 359262490
Test: Open links in app and browser
Flag: EXEMPT small UI change
Change-Id: Ib23084bcc7f899b97b59019775584807e5b70d7e
2024-09-23 14:32:08 -07:00