Commit Graph

27792 Commits

Author SHA1 Message Date
Arc Wang
781a61930c Merge "[Wi-Fi DPP] Wi-Fi QR code scanner is not working after a connection fail" into qt-dev am: d64b6c8846 am: 9b971efd6b
am: 6d435d69b3

Change-Id: I7aeb116d93e608204541d626b48274ffd8254bb6
2019-06-19 21:34:36 -07:00
Antony Sargent
2ee1249b01 Add a listener for subscription changes to SimDialogFragment am: 6a1d7e60ac
am: d985cb848f

Change-Id: Ifb25c4c11e394452b475442dbe452272f52b229e
2019-06-19 20:56:36 -07:00
Arc Wang
6d435d69b3 Merge "[Wi-Fi DPP] Wi-Fi QR code scanner is not working after a connection fail" into qt-dev am: d64b6c8846
am: 9b971efd6b

Change-Id: I12af9c0f4aef532f114dc5d2f28ba82cc38c1a21
2019-06-19 20:27:51 -07:00
Arc Wang
9b971efd6b Merge "[Wi-Fi DPP] Wi-Fi QR code scanner is not working after a connection fail" into qt-dev
am: d64b6c8846

Change-Id: Icfa3b21e383182a127a1e633a671013c371ab105
2019-06-19 19:38:57 -07:00
Antony Sargent
d985cb848f Add a listener for subscription changes to SimDialogFragment
am: 6a1d7e60ac

Change-Id: I7fe944662d3a37223a997ed55d3197764df42a90
2019-06-19 19:07:32 -07:00
Arc Wang
d64b6c8846 Merge "[Wi-Fi DPP] Wi-Fi QR code scanner is not working after a connection fail" into qt-dev 2019-06-20 01:34:09 +00:00
Antony Sargent
6a1d7e60ac Add a listener for subscription changes to SimDialogFragment
For some kinds of telephony changes that might happen while we're
already showing one of these dialogs, we already get sent a new intent
for the dialog which we internally convert into a refresh of the dialog
contents instead of stacking a new copy on top of the old one.

But it turns out there are some other cases where the telephony stack
doesn't send a new intent for the dialog but *does* send a change event
through the SubscriptionManager, and we want to respond to those as
well. This CL adds a listener for those events.

Fixes: 135276696
Test: make RunSettingsRoboTests
Change-Id: Ifb93ae95f45fda5831e112306dd9361ccaa5119c
2019-06-19 12:20:59 -07:00
Arc Wang
0a628e227a Merge "[Wi-Fi DPP] Support WPA2/WPA3 transition mode" into qt-dev am: d8916ef151 am: c58b3aaf0f
am: 8c123c6a59

Change-Id: Id6caccbcd9790e0f9393b8b0ddea6ebb529706b6
2019-06-19 10:36:46 -07:00
Arc Wang
8c123c6a59 Merge "[Wi-Fi DPP] Support WPA2/WPA3 transition mode" into qt-dev am: d8916ef151
am: c58b3aaf0f

Change-Id: I44c813e93d563fff6956d3b15bc08da143023437
2019-06-19 10:26:08 -07:00
Arc Wang
3454468111 Merge "[Wi-Fi DPP] Support WPA2/WPA3 transition mode" into qt-dev
am: d8916ef151

Change-Id: I37b2fd97fbe952d9cdc214b364ff766231158d4d
2019-06-19 10:15:44 -07:00
Arc Wang
c58b3aaf0f Merge "[Wi-Fi DPP] Support WPA2/WPA3 transition mode" into qt-dev
am: d8916ef151

Change-Id: I360ff827ae8544d76c4411410172ace81bbcef56
2019-06-19 10:14:55 -07:00
TreeHugger Robot
d8916ef151 Merge "[Wi-Fi DPP] Support WPA2/WPA3 transition mode" into qt-dev 2019-06-19 16:54:35 +00:00
TreeHugger Robot
21da32d9b1 Merge "Pull out PreferenceControllers from AccessibilitySettings" 2019-06-19 16:50:22 +00:00
Mill Chen
d37618c8ed Pull out PreferenceControllers from AccessibilitySettings
- clean up the format of accessibility_settings
- To leverage the existing TtsPreferenceController and
FontSizePreferenceController
- pull out the logic of magnification from AccessibilitySettings

Bug: 135056871
Test: manual, robotest
Change-Id: I414fa7a04fd558d3a3a8b5e157469c198a772732
2019-06-19 15:05:39 +00:00
TreeHugger Robot
174c9b7f82 Merge "Pull out a PreferenceController of lock screen from accessibility" 2019-06-19 10:15:25 +00:00
TreeHugger Robot
8d51b1b4e8 Merge "[Wi-Fi DPP] Improve Wi-Fi QR code error messages" 2019-06-19 10:05:45 +00:00
Mill Chen
dce601db84 Pull out a PreferenceController of lock screen from accessibility
To reduce the complexity of AccessibilitySettings, we are planning to
create a bunch of preference controllers. First of all, we are converting
lock screen preference to a preference controller. The rest part will be
uploaded soon.

Bug: 135056871
Test: robotest, manual
Change-Id: I6079136f3d08934c9a5363eb4d0e0ade29f8ba99
2019-06-19 16:44:42 +08:00
TreeHugger Robot
11e1d45c9c Merge "[Wi-Fi DPP] Fix UI defects" 2019-06-19 06:17:22 +00:00
Android Build Merger (Role)
00fe5ebc8d Merge "Merge "Replace isSubscriptionEnabled with isActiveSubId." into qt-dev am: 0304f4d1ce am: b3b52ce088 am: 47ea5ad9dc" 2019-06-19 05:16:18 +00:00
Malcolm Chen
af7b0ebb9c Merge "Replace isSubscriptionEnabled with isActiveSubId." into qt-dev am: 0304f4d1ce am: b3b52ce088
am: 47ea5ad9dc

Change-Id: Ida614addc7b6cc58178f91e7e6b2645100762723
2019-06-18 22:14:39 -07:00
Android Build Merger (Role)
b34a3ec1d9 Merge "Merge "MobileData slice should be null if not-actionable" into qt-dev am: e2ab7540a3 am: 1601d41f8a am: ae7ca4133a" 2019-06-19 05:12:25 +00:00
Matthew Fritze
a891dd8743 Merge "MobileData slice should be null if not-actionable" into qt-dev am: e2ab7540a3 am: 1601d41f8a
am: ae7ca4133a

Change-Id: I1e3012e83243b9dd6be04f1ecc5d885836b8e022
2019-06-18 22:11:48 -07:00
TreeHugger Robot
ce7b012f9c Merge "[Wi-Fi DPP] Remove scanner button of unsaved WiFi network dialogs" 2019-06-19 04:55:24 +00:00
Malcolm Chen
47ea5ad9dc Merge "Replace isSubscriptionEnabled with isActiveSubId." into qt-dev am: 0304f4d1ce
am: b3b52ce088

Change-Id: I672ddbb1a853d16e7a17a2c95fa4754e17d7055c
2019-06-18 20:48:05 -07:00
Matthew Fritze
ae7ca4133a Merge "MobileData slice should be null if not-actionable" into qt-dev am: e2ab7540a3
am: 1601d41f8a

Change-Id: Ic1bce363e5b6d6a5e52fcf3da6547d1976333f2e
2019-06-18 20:39:39 -07:00
Malcolm Chen
b3b52ce088 Merge "Replace isSubscriptionEnabled with isActiveSubId." into qt-dev
am: 0304f4d1ce

Change-Id: I3a78fe154d3861c779365d1e611ac8c559861a10
2019-06-18 20:29:39 -07:00
Malcolm Chen
cdae15bcc4 Merge "Replace isSubscriptionEnabled with isActiveSubId." into qt-dev
am: 0304f4d1ce

Change-Id: I9f91b0292b464e76db849163573031dba8bef5a1
2019-06-18 20:28:40 -07:00
Matthew Fritze
1601d41f8a Merge "MobileData slice should be null if not-actionable" into qt-dev
am: e2ab7540a3

Change-Id: If562aec8635ab4d56ff5016eea5d19d2a96e2383
2019-06-18 20:23:30 -07:00
Matthew Fritze
60a1dc1609 Merge "MobileData slice should be null if not-actionable" into qt-dev
am: e2ab7540a3

Change-Id: Ie4630b5927b93083e6b970cb67da04cbc19a2c50
2019-06-18 20:23:29 -07:00
TreeHugger Robot
0304f4d1ce Merge "Replace isSubscriptionEnabled with isActiveSubId." into qt-dev 2019-06-19 03:11:25 +00:00
TreeHugger Robot
e2ab7540a3 Merge "MobileData slice should be null if not-actionable" into qt-dev 2019-06-19 02:26:20 +00:00
Arc Wang
00c8b534cd [Wi-Fi DPP] Wi-Fi QR code scanner is not working after a connection fail
After a user uses Wi-Fi QR code scanner to scan a QR code of an unreachable
Wi-Fi network, the scanner does not recognize any QR code until the scanner is
restarted or back from a screen off state.

To restart QrCamera after a Wi-Fi QR code recognition, we should stop it before
start, otherwise the DecodeTask will not work.

Bug: 135225856
Test: Scan a Wi-Fi QR code of unreachable Wi-Fi network and
      scan a Wi-Fi QR code of reachable Wi-Fi network, check
      if the scanner recognizes QR code.

Change-Id: I0063c867d8e4046f184d02134bda842887c003a1
2019-06-19 10:01:17 +08:00
TreeHugger Robot
8933b8bde9 Merge "Check the missing useHomeWfMode case" 2019-06-19 01:30:50 +00:00
Antony Sargent
290279ea59 Merge "Use displayName instead of operator name in MMS data notification" into qt-dev am: 40e9ffc2f0 am: fa274596f0
am: e02811b578

Change-Id: I49836c71b909fd84fb123396a79ad47b68de2fb0
2019-06-18 17:40:53 -07:00
Malcolm Chen
dd0b2fc380 Replace isSubscriptionEnabled with isActiveSubId.
As we don't allow pSIM modem disablment, we should simply use isActiveSubId
to decide whether a subscription's preferences is changable. This will
avoid potential modem bugs that reports wrong modem status that result
in Setting's UX error.

Bug: 135222940
Test: manual and robo
Change-Id: I7cccf2fdab7c89d26dac4daad51cd5d6f3a90eba
2019-06-18 23:55:35 +00:00
Antony Sargent
e02811b578 Merge "Use displayName instead of operator name in MMS data notification" into qt-dev am: 40e9ffc2f0
am: fa274596f0

Change-Id: Ied104a2ae9936e6dfdf54e116c625eee32d8d32b
2019-06-18 16:27:28 -07:00
Kevin Chyn
733fc82c9d Merge "Retrieve help URL" into qt-r1-dev am: 509d6bcf73
am: 60e6426012

Change-Id: I998a7449143cc346aca4c2380fd0f92c4c878955
2019-06-18 16:06:12 -07:00
Antony Sargent
ff1c4940c8 Merge "Use displayName instead of operator name in MMS data notification" into qt-dev
am: 40e9ffc2f0

Change-Id: Ie50c5041ef4b9df9ef015cd5f147b1c45956893f
2019-06-18 16:02:39 -07:00
Antony Sargent
fa274596f0 Merge "Use displayName instead of operator name in MMS data notification" into qt-dev
am: 40e9ffc2f0

Change-Id: I0e2e20de501b2a5b3ee8905e69dd3a6eca97d0b1
2019-06-18 15:42:04 -07:00
Kevin Chyn
60e6426012 Merge "Retrieve help URL" into qt-r1-dev
am: 509d6bcf73

Change-Id: I233f80a04f5db4947ffea0581e527c8314f10d9b
2019-06-18 15:22:49 -07:00
Antony Sargent
40e9ffc2f0 Merge "Use displayName instead of operator name in MMS data notification" into qt-dev 2019-06-18 21:54:33 +00:00
Antony Sargent
37008824e6 Use displayName instead of operator name in MMS data notification
When the phone is in DSDS mode and the user tries to send an MMS message
from the SIM that isn't the default for data, we need to pop up a
notification letting them know that the action can't succeed unless they
turn on the advanced option to allow data use for MMS messages. This
notification was using the operator name instead of the subscription
display name, so it didn't reflect any renaming the user might have done
to keep track of their SIMs, which is obviously confusing especially if
they have two different SIMs for the same carrier. This CL switches to
using the subscription display name in this notification.

Fixes: 134771858
Test: make RunSettingsRoboTests
Change-Id: I6995bf9dd6d5e9544e26f0d8e30e97c4e73ab783
2019-06-18 21:54:22 +00:00
Matthew Fritze
63bc6a1090 MobileData slice should be null if not-actionable
In cases where MobileData should not be changed:
- Airplane mode
- No data subscriptions

we will return a null slice, rather than a slice with a no-op intent
attached as a primary action. The problem with the no-op intent is that
Slices assumes all actions are by definition, actionable, and the the
TalkBack description announces that the item is clickable, which it
really isn't.

We will in the future investigate disabled actions on Slices, but this
is the short-term fix.

Fixes: 132924748
Test: Robolectric
Test: Panel tester app
Change-Id: I1d62af32fe2dd985f0b52ea4188651e76f9c90ec
2019-06-18 14:53:21 -07:00
TreeHugger Robot
509d6bcf73 Merge "Retrieve help URL" into qt-r1-dev 2019-06-18 21:03:54 +00:00
Youming Ye
31608ace73 Check the missing useHomeWfMode case
Bug: 133812904
Test: Build
Change-Id: If89c67c0595808a1339517c6084f1d1e23f5974b
2019-06-18 13:24:38 -07:00
Kevin Chyn
bd6e80e56d Retrieve help URL
Fixes: 118644802

Test: Help page is seen
Change-Id: Ib89d21ce5027f9ca9c3b6709a9a1301f988a0675
2019-06-18 11:13:31 -07:00
TreeHugger Robot
5cb9f7801c Merge "Fix double divider in Privacy page" 2019-06-18 06:50:24 +00:00
Jason Chiu
f3e3d7a46b Fix double divider in Privacy page
The second divider is shown after we set a background to the pinned
header.

- Simply hide the pinned header instead of its inner views.
- Move setActionBarShadowAnimation to controller and just call it when
  the bar chart is available.

Fixes: 134652710
Test: robotest, visual
Change-Id: I4381e5ca1a042583d3e5874f5600719267b19786
2019-06-18 11:50:45 +08:00
Kevin Chyn
93ea1f8440 Merge "Do not allow toggle to be clickable/focusable" into qt-r1-dev am: 5ac3690908
am: 0a519b9cbb

Change-Id: I5e956efb3c15e72180a78887c1709cacc8db61d5
2019-06-17 19:31:24 -07:00
Kevin Chyn
0a519b9cbb Merge "Do not allow toggle to be clickable/focusable" into qt-r1-dev
am: 5ac3690908

Change-Id: I19725e4ddc93a162ee3570b81cc6810b9be57cff
2019-06-17 19:07:53 -07:00