Commit Graph

3307 Commits

Author SHA1 Message Date
Weng Su
75a070f3f0 Restrict MobileDataSlice
- Hide MobileDataSlice if the user is not allowed to configure mobile networks.

Bug: 310630794
Flag: EXEMPT bugfix
Test: manual test
atest -c MobileDataSliceTest

Change-Id: I35814733a915f011e284b082ce7a94898ce8a6fb
2024-08-06 04:14:12 +08:00
Chaohui Wang
09fb13fd1c Merge "Settings search for Vo5G" into main 2024-08-01 07:19:08 +00:00
Tom Hsu
d26c804af1 Merge "[Settings]Check the Satellite modem state instead of enabled state only." into main 2024-08-01 05:27:06 +00:00
tomhsu
90553d91f1 [Settings]Check the Satellite modem state instead of enabled state only.
Flag: EXEMPT bugfix
Fix: 354806125
Test: Manual test pass
Change-Id: Iaa8d1c9d3df36e40fafda0117234036d9451a4fa
2024-08-01 03:38:48 +00:00
Chaohui Wang
874c818b31 Settings search for Vo5G
Also adding keywords support to MobileNetworkSettingsSearchItem.

Fix: 262684662
Flag: EXEMPT bug fix
Test: manual - search vo5g
Change-Id: Ic73b76a2a7b2ef238b167fe3673835298d8939fd
2024-07-31 17:47:21 +08:00
Chaohui Wang
b7f68b4a60 Merge changes from topic "MobileNetworkSettingsSearchIndex" into main
* changes:
  Fix search for MMS Message
  Show category when search "Mobile data"
2024-07-31 09:07:20 +00:00
Priyanka Advani (xWF)
9bf8ce78b2 Merge "Revert "Change API requestIsEnabled to requestIsSessionStarted"" into main 2024-07-30 18:12:18 +00:00
Chaitanya Cheemala (xWF)
413e85fa7a Revert "Change API requestIsEnabled to requestIsSessionStarted"
Revert submission 28533501-NTN_check_modem_state

Reason for revert: Likely culprit for b/356320274  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:28533501-NTN_check_modem_state

Change-Id: I4cdb936eb6a27eeee0aba6a5adfcf9cbdfacd5eb
2024-07-30 09:31:35 +00:00
Tom Hsu
d5225c236d Merge "Change API requestIsEnabled to requestIsSessionStarted" into main 2024-07-30 06:51:17 +00:00
Chaohui Wang
30b9c3c1ae Merge "Create SubscriptionRepository.phoneNumberFlow" into main 2024-07-30 04:41:02 +00:00
Hakjun Choi
ad6c9cf31a Merge "[Internal cleanup] remove warning message for resource ID" into main 2024-07-30 04:38:09 +00:00
Chaohui Wang
7009c008f9 Fix search for MMS Message
Also display multiple results when there are multiple MMS Message on
different SIMs.

When doing indexing, we not also log sub id as part of the key.
When user clicks the result, using SpaSearchLandingActivity to do the
redirection, set arguments to the fragment.

Fix: 352245817
Flag: EXEMPT bug fix
Test: manual - search mms
Test: unit test
Change-Id: Id47a1151cb418c18f68f97e3be33dcd21c5f5102
2024-07-30 11:34:24 +08:00
tomhsu
b091995671 Change API requestIsEnabled to requestIsSessionStarted
- Avoid using APM/WIFI/BT in settings app from any transitioning from TN to NTN.

Flag: EXEMPT bugfix
fix: 354806125
Test: Manual test
Change-Id: Id65567971b3d1ea3e177a0cc1e1304446d8fa0e8
2024-07-30 01:27:58 +00:00
Hakjun Choi
a0ba9182ad [Internal cleanup] remove warning message for resource ID
Currently we are seeing Drawable com.android.settings:drawable/ic_check_circle_24px has unresolved theme attributes! error
To address this, use Context.getDrawable(int) to provide theme info when using the icon

Bug: 356149221
Flag: EXEMPT bugfix
Test: manually run Satellite setting menu and check the log whether the waring is shown or not
Change-Id: I55fd1bd4cbaf07e7433cdd286e71f88dacc3e1b5
2024-07-29 16:46:38 +00:00
SongFerng Wang
b1ce525751 Merge "Can not reset the sim name in the onboarding sim flow" into main 2024-07-26 16:12:48 +00:00
songferngwang
9fb316de8b Can not reset the sim name in the onboarding sim flow
After the sim name has been changed, the user changed back to original one.
The map did not remove the sim item, so the onboarding flow change the
sim name.

Bug: 355138239
Flag: EXEMPT bugfix
Test: atest SimOnboardingServiceTest
Change-Id: If4276320c939604b48cf2ce8c1b6b553da699c28
2024-07-26 07:06:53 +00:00
Chaohui Wang
cf13fe7776 Create SubscriptionRepository.phoneNumberFlow
And use it in the MobileNetworkSettings.

Fix: 341318273
Flag: EXEMPT bug fix
Test: manual - on MobileNetworkSettings
Test: unit test
Change-Id: I886373c1ed5129ebd8bcceedd513e9d1776106c8
2024-07-25 16:06:02 +08:00
Chaohui Wang
c181d60bac Fix race condition when requestNetworkScan
requestNetworkScan() could call callbacks concurrently, so we use a
single thread to avoid racing conditions.

Fix: 345494692
Flag: EXEMPT bug fix
Test: manual - do network scan
Change-Id: Ibf38442bbd9cfbbd0762b31347645810aca1113b
2024-07-25 10:23:21 +08:00
Yuchen
48f304a23f Clean up preference_summary_default_combination in Settings.
Test: Existing tests passed
Flag: EXEMPT clean up
Bug: 328519240
Change-Id: I86996c43243b7a8e2d4b1a83180c189986b3a6ca
2024-07-24 02:36:09 +00:00
Chaohui Wang
9503f42efb Merge "Clean up UiccInfoEntity unused fields" into main 2024-07-18 08:44:19 +00:00
Chaohui Wang
fe712d3ea3 Merge "Always set cross sim calling" into main 2024-07-17 07:48:59 +00:00
Chaohui Wang
0ffd546f2f Clean up UiccInfoEntity unused fields
It's safe since MobileNetworkDatabase is in memory only.

Bug: 348118234
Flag: EXEMPT clean up
Test: manual - check Mobile Settings
Change-Id: Icea406a3c2e633ee51160e51b1af553b4f3034dc
2024-07-17 14:54:49 +08:00
Chaohui Wang
fb0583404f Always set cross sim calling
By CrossSimCallingViewModel, in SIMs and per SIM settings page.
To ensure the status is always right, including the case after the
onboarding set up finished.

Fix: 347882381
Fix: 348529996
Flag: EXEMPT bug fix
Test: manual - turn on / off "Automatic data switching" on SIMs
Test: manual - turn off "Automatic data switching" during onboarding
Change-Id: Icc2eacb67850fa7b3aa0fe310cd09a0e0147912b
2024-07-16 17:46:23 +08:00
yomna
62004763e1 Remove searchability of CellularSecuritySettingsFragment
Test: m & manual
Bug: b/335554085
Flag: EXEMPT bug fix
Change-Id: Ia226b0848d70a307b80060049ec24b9714ee476a
2024-07-16 01:17:25 +00:00
Chaohui Wang
cd4cf67422 Clean up SubscriptionInfoEntity unused fields
It's safe since MobileNetworkDatabase is in memory only.

Bug: 348118234
Flag: EXEMPT clean up
Test: manual - check Mobile Settings
Change-Id: If170c65f4d0dfdc42c1cec9a56e25c516db4f75e
2024-07-11 04:15:37 +00:00
SongFerng Wang
6213cb9aa9 Merge "Fix UI flashing after changing network mode" into main 2024-07-03 08:10:12 +00:00
hoffc
e55e9dc90b Fix UI flashing after changing network mode
DashboardFragment will dynamically control every preference's visibility according to preference's availability status, but EID and IMEI preference controllers have incorrect visibility control logic when these two preferences are inavailable, which leads to confliction with DashboardFragment's visibility control logic.

Remove EID and IMEI preferences's visibility settings from their controllers.

Bug: 335369817
Test: the author has tested.
Flag: EXEMPT bugfix
Change-Id: I572f9de07ff3fb8b39294d4b54b04a40a26a78ab
2024-07-02 09:45:16 +00:00
Chaohui Wang
d101f2d154 Merge "Clean up MobileNetworkInfoEntity unused fields" into main 2024-06-28 05:18:07 +00:00
Chaohui Wang
6afb2f3006 Merge "Not use SubscriptionInfoEntity in DataUsageList" into main 2024-06-28 05:14:06 +00:00
Chaohui Wang
b8ad25f8bd Clean up MobileNetworkInfoEntity unused fields
It's safe since MobileNetworkDatabase is in memory only.

Bug: 348118234
Flag: EXEMPT clean up
Test: manual - check Mobile Settings
Change-Id: I25141a87b9afb42b85d73cbcd7307b899b3f0a3b
2024-06-27 17:30:19 +08:00
Chaohui Wang
af56a3ea21 Not use SubscriptionInfoEntity in DataUsageList
Carrier id will be get in DataUsageListAppsController async.

Bug: 348118234
Flag: EXEMPT clean up
Test: manual - on DataUsageList
Change-Id: I06b361f38d04c5020431cd8c6e359aa3a69942e5
2024-06-26 11:58:07 +08:00
Chaohui Wang
b70c805717 Fix unable to erase eSIM
Before this change,
- eSIM will be erased twice, one with result callback and one without
  result callback.
- During reset, ResetNetworkConfirm could interrupted by subscription
  invalid event, which happens during reset.

After this change,
- eSIM will be erased only once, result callback is registered
  separately.
- Explicit exit the page when reset finish, and ignore the subscription
  invalid event after reset started.

Bug: 328293508
Flag: EXEMPT bug fix
Test: manual - dry run the reset
Test: ResetNetworkConfirmTest
Change-Id: I51395a556b1c8775192d5897a87f13046c042578
2024-06-26 11:02:56 +08:00
Chaohui Wang
edc72a9b0f SubscriptionRepository.activeSubscriptionIdListFlow
Bug: 328293508
Flag: EXEMPT refactor
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I63a86569f4fa3a27bd38d9853f6141890d26b881
2024-06-26 10:55:59 +08:00
Chaohui Wang
67d977b72e Merge "Clean up MobileNetworkRepository.DataRoamingObserver" into main 2024-06-25 09:37:01 +00:00
Chaohui Wang
3e393d0a46 Merge "Fix Talkback can focus on blank area" into main 2024-06-25 06:51:12 +00:00
Chaohui Wang
a23c53c9a9 Fix Talkback can focus on blank area
By hiding radio button frame instead of just radio button.

Fix: 347185801
Flag: EXEMPT bug fix
Test: manual - on ApnSettings
Change-Id: I7a2ba536f037a6cd014989bba1374d034169d90b
2024-06-25 13:26:12 +08:00
Chaohui Wang
b132ed91b1 Clean up MobileNetworkRepository.DataRoamingObserver
Bug: 348118234
Flag: EXEMPT clean up
Test: manual - on Mobile Settings
Change-Id: If9e7ed7cde0d7864ff00d135339a7725de179f1b
2024-06-25 12:12:41 +08:00
tomhsu
f60b42acad When received Carrier Config Change, refresh UI.
Flag: EXEMPT bug fix
Fix: 340890663
Test: Manual test
Change-Id: Ia78c2dfb7e567161bcbb8d1d622cdccb178778e0
2024-06-24 13:04:18 +00:00
Chaohui Wang
0bd8a5d232 Merge "Use wifiCallingReadyFlow in WifiCallingSettingsForSub" into main 2024-06-24 02:09:16 +00:00
Chaohui Wang
4d8c8faa9e Merge "Clean up unused fields from MobileNetworkRepository" into main 2024-06-21 13:25:46 +00:00
Chaohui Wang
562f56bb7a Use wifiCallingReadyFlow in WifiCallingSettingsForSub
Simply and unify the logic, and fixed a crash.

Fix: 348372605
Flag: EXEMPT bug fix
Test: manual on Wi-Fi calling
Change-Id: Idc7dff934323fbebb09137bbd0585575e65a7867
2024-06-21 16:53:38 +08:00
Chaohui Wang
cfd401b04e Fix crash in RoamingPreferenceController
With new MobileDataRepository.isDataRoamingEnabledFlow() to provide
the data instead of MobileNetworkRepository.

Fix: 347224962
Flag: EXEMPT bug fix
Test: manual on Mobile Settings
Test: unit test
Change-Id: I2a994cb11c93296fb46558f566d6d4467ba4c846
2024-06-21 04:39:44 +00:00
Chaohui Wang
ef12f1ddb5 New CarrierConfigRepository
Benefices,
- Gets the configuration values of the specified keys, for better
  performance
- Check key suffix for correctness
- Support cache
- If CarrierConfigManager throw exception, use default value

Bug: 337417520
Flag: EXEMPT refactor
Test: manual on Sim Status
Test: unit
Change-Id: I68f41ef66d495080f628794ade63cf807efba619
2024-06-21 04:39:24 +00:00
Chaohui Wang
ec59cd0c8b Move mobile data logic into MobileDataRepository
Bug: 347224962
Flag: EXEMPT refactor
Test: manual on Mobile Settings
Test: unit
Change-Id: I2b54f9e6c4addafd31d7d96f2a44870cd54fe185
2024-06-20 11:49:06 +08:00
Rambo Wang
700fff1eb7 Merge "Fix Settings restart during Reset mobile nework settings flow" into main 2024-06-19 14:41:46 +00:00
Rambo Wang
5ac9d9c8fa Fix Settings restart during Reset mobile nework settings flow
This CL avoids restarting Settings in the reset mobile flow when phone
process is restarted, by switching the usage of the stable content
provider connection to the unstable client.

The CL also arranges restarting phone process as the last reset
operation in the flow (later than RILD reset) to avoid any reset
operation get impacted by phone process restarting.

Since the permission to protect the TelephonyContentProvider has been
renamed, the CL also renames the requsted permision.

Bug: 347047105
Test: atest ResetNetworkOperationBuilderTest
Test: Reset mobile network feature test
Flag: EXEMPT resource update with minor refactoring
Change-Id: I7bfa79bc9d7451a4a03269704b0009a3730e287f
2024-06-19 14:41:19 +00:00
Chaohui Wang
e36a2d863e Clean up unused fields from MobileNetworkRepository
Bug: 348118234
Flag: EXEMPT refactor
Test: manual on Mobile Settings
Change-Id: I45520aac3bd3f2e31c396056f4f38b52e4e6fa55
2024-06-19 15:40:54 +08:00
Chaohui Wang
03ccaf8b9d Merge "Refactor ApnEditCarrierEnabled" into main 2024-06-19 05:21:24 +00:00
Chaohui Wang
71331802ef Refactor ApnEditCarrierEnabled
Also fix tests.

Bug: 342374681
Flag: EXEMPT refactor
Test: manual - on Apn Edit
Test: unit test
Change-Id: I6db7f27a26341084940be4f8039f5097faa07ec8
2024-06-19 02:19:29 +00:00
Chaohui Wang
c956160fe7 Lazy create InternetPreferenceRepository
In InternetPreferenceControllerV2, to not created in search indexing for
better performance.

Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - on Internet
Change-Id: I9e0e36ba6296d48d3761714db52074c90f635233
2024-06-18 17:26:21 +08:00