Commit Graph

62 Commits

Author SHA1 Message Date
Joseph Vincent
f2f44f50de Merge "Add entrypoint for Learn More in PS settings & Setup intro" into main 2024-03-15 07:39:16 +00:00
Olivier Nshimiye
a4babe7463 Merge "Add enable_private_space_features flag check for Private Space implementation" into main 2024-03-14 09:48:27 +00:00
josephpv
1af33733c6 Add entrypoint for Learn More in PS settings & Setup intro
Screenshots:
go/ss/RXhN57DSuSj7aQf.png
go/ss/5xcbx3mWeo2sZ37.png

Bug: 326059389
Test: atest PrivateSpaceFooterPreferenceControllerTest
Change-Id: I72beb1a04ea11909643dd6b455575478cfb5d87c
2024-03-12 16:15:53 +00:00
josephpv
3c97c63d62 Show Alert dialog on Hide when locked is enabled
Bug: 325398789
Test: atest HidePrivateSpaceControllerTest
Change-Id: I6bfa3546b3ba56905918f8fd44c5351bf2d284b8
2024-03-12 10:35:56 +00:00
Olivier Nshimiye
baa7a8c2c8 Add enable_private_space_features flag check for Private Space implementation
Bug: 326060689
Test: Manual
Change-Id: I82105714e74789394a3d46b852aaa3e7b93e5877
2024-03-08 15:36:29 +00:00
Olivier Nshimiye
b816437d39 Merge changes from topic "add-ps-features-flag" into main
* changes:
  Add Private Space features flag check to Settings tests
  Add an additional flag guard for Private Space implementation
2024-03-07 10:48:58 +00:00
Anna Zhuravleva
a05ba46acd Merge "Log change in autolock settings" into main 2024-03-05 10:18:58 +00:00
Anna Zhuravleva
cbc0ec7111 Log change in autolock settings
Bug: 327181532
Test: statsd_testdrive https://paste.googleplex.com/4866138112000000
Change-Id: I4133e35ff343e32261cb0fc190af4a32474b69e3
2024-03-04 18:24:05 +00:00
Olivier Nshimiye
0f3799cbad Add an additional flag guard for Private Space implementation
This a layer of flag guarding only for the implementation of Private Space features excluding the APIs. The MVP flag allow_private_profile still guards all the features including the APIs.

Bug: 326060689
Test: Manual - a few verifications that some feeatures are unavailable when this flag is disabled
Test: Run presubmits and verify that nothing breaks
Change-Id: I05f7e2f20c6132b33484bb133ce03a933ece485f
2024-03-04 15:43:24 +00:00
josephpv
d61b4a418c Fix for PS setup crash in AOSP build
Recording link : b/312454851#comment2

Bug: 312454851
Test: Manual
Change-Id: I2c8f812f0bb75b1d4b41565e8545e83c0a01af09
2024-02-28 11:03:06 +00:00
josephpv
0809d4dee7 Update illustrations in private space setup and settings
Recording link : b/326391912#comment3
https://drive.google.com/file/d/1Rykqy8iugvVNiE8uW2tgAlFhAypGxhdN/view?usp=drive_link

Bug: 326391912
Test: Manual
Change-Id: Ic53c42ec87fde4f1b8c38634e1e2927b235ff2a3
2024-02-28 06:47:49 +00:00
josephpv
c1fd5ad1ec Change to add temp GAIA education screen and swap account and lock flow
The change does below things:
- Interchange account and lock setup in PS setup
- After profile creation checks if network is present and starts new
  GAIA education screen
  If network is not present on device skips account login and shows lock setup screen.
- Adds a temp GAIA education screen before starting of account login which can skip to
  lock setup or start account login

Recording link : b/326389818#comment5
Screenshot : go/ss/7qWLUF4WDHFBQzi.png
go/ss/A8EvoCFJwihaTQP.png

Bug: 326389818
Test: Manual
Change-Id: I91e3591c60aae22fc10058fb94dcb624573d2e37
2024-02-28 06:46:49 +00:00
josephpv
2a431fe8d9 Change for private space intro screen string changes
This includes below changes based on latest UX mocks
- Changes the strings and icon in the intro screen
- Updates the title in Auto advance screens

Recording link : b/326391690#comment4
Screenshots:
go/ss/9xbZP5Lp8j9yh6m.png
go/ss/pvKMNdgu6yt2Xtr.png

Bug: 326391690
Test: Manual, verify the strings are updated as in Mocks
Change-Id: I714919ac1f3d45fa0007395bd17cfb340874ed5a
2024-02-26 14:26:33 +00:00
Olivier Nshimiye
75ada354ed Merge "Add a toggle for enabling/disabling sensitive lockscreen notifications for Private Space" into main 2024-02-22 14:22:33 +00:00
Olivier Nshimiye
baecaee2a5 Add a toggle for enabling/disabling sensitive lockscreen notifications for Private Space
This adds a toggle in the Private Space Settings page to control the
lockscreen sensitive notifications for the private profile.
Sensitive notifications for private profile will still be disabled if
sensitive notifications are disabled for the main user.

Demo link:https://drive.google.com/file/d/1--LNXziTRTMvfdsJZAh90SiNiPxWNcI8/view?usp=sharing

Bug: 317067050
Test: atest SettingsUnitTests:HidePrivateSpaceSensitiveNotificationsControllerTest

Change-Id: Ie7f18c1a940e5ffd64112a01c48ac9dee58cb1ab
2024-02-22 11:10:54 +00:00
Jigar Thakkar
5bbc1166f3 Use SetScreenLockDialogActivity to power screen lock setup prompt
With this change, we move to using SetScreenLockDialogActivity to enable
the prompt to set up the screen lock. This prompt is shown whenever
someone taps the private space settings page option to either
setup/unlock the space. We will also be using the same dialog prompt in
other places in the framework
(UserManagerService.requestQuietModeEnabled) as well.

Test: atest PrivateSpaceAuthenticationActivityTest
Bug: 316129700
Flag: android.multiuser.show_set_screen_lock_dialog
Change-Id: Ib9fe009d3b36e0eea242fbf894e616b1efcb9d6b
2024-02-20 19:46:54 +00:00
josephpv
e9f3a0925b Add illustration to final screen in PS setup and update existing illustrations.
Screenshots:
- go/ss/9KhqUSezFKHnyys.png

Recording link:
- b/321694009#comment2

Bug: 323156268
Bug: 321694009
Test: Verified manually
Change-Id: Ib8abc080f31cad0a9be3b73a1694be744c108a06
2024-02-13 18:27:17 +00:00
josephpv
1e6e14c2c5 Add check to not show PS unlock message when activity is recreated
The condition added with this change makes sure the toast message is
shown only once and to not show duplicate toast  evertime the activity
is recreated on screen rotation.

Recording link : b/324442522#comment2

Bug: 324442522
Test: Manual
Change-Id: I4e17384c1d02deacdd911195f014b0c8f1eb8833
2024-02-09 19:30:07 +00:00
josephpv
e1a2c82db3 Add Private space Delete settings page inside PS settings page
Contains implementation of settings page for Delete private space
controller inside private space settings page.
- On selecting to delete private space displays list of account signed in
to private profile and deletes the private space after authentication.
- Shows a toast message after private space is deleted

- Adds dependency for setupdesgin loading layout to show a loading
  screen while deletion of private space is in progress.

Recording Link : b/318383729
go/ss/4Aq3rmbSGHMHesK.png

Bug: 318383729
Test: atest DeletePrivateSpaceControllerTest

Change-Id: Ia1730915e2469b47823c507f9ef6cd8f63c99baf
2024-01-31 19:29:13 +00:00
Joseph Vincent
cd5bf1da51 Merge "Remove private space biometrics on switching to device lock" into main 2024-01-23 23:08:05 +00:00
josephpv
ec273aca12 Remove private space biometrics on switching to device lock
Bug: 320685466
Test: Verified manually
Change-Id: I5fe850ada9ae53bb1a00ed171beb6f8e099fbc0d
2024-01-23 15:24:55 +00:00
josephpv
f27e9e6553 Add skip button in PS account login error screen
Recording link : b/320460786#comment5

Bug: 320460786
Test: Verified skip button in shown in error screen.
Change-Id: I0b3b9258ad55069c9920d7fc9fb7f17d422297f1
2024-01-23 13:20:34 +00:00
josephpv
a05b33b661 Add check to verify if separate lock is setup for private space.
With this change on selecting new lock option for private space it is
taken care to handle back/swipe left action to show the lock setup
screen again if a separate lock is not setup for private profile.

Bug: 307281644
Bug: 313142822
Test: Manual
Change-Id: I8f31b7f69307c0c6947cb0f6c52cb3560e69a156
2024-01-22 10:25:09 +00:00
josephpv
6f4dc73c53 Add logging to private space settings
Bug: 317625931
Test: Manual
Change-Id: I01200b54c436d2a60ac07c9facbb5cf35a44d920
2024-01-19 23:11:42 +00:00
josephpv
4d6e11ce4b Show private space unlocked toast when PS is unlocked from Settings
This contains the change to show private space unlocked toast message
when PS is unlocked from private space settings entry point.
Also has change in the pending intent passed to requestQuietModeEnabled
API to allow BAL of PS settings page as suggested in go/debug-bal

Recording is uploaded to the issue b/317313482

Bug: 317313482
Test: Manually verified Toast is shown on PS unlock from settings

Change-Id: I2f03b7decdad2bb9e1018012ff5986e48305a4e7
2024-01-17 10:26:33 +00:00
Joseph Vincent
bd3e3a174f Merge "In Private space settings when no face support show only fingerprint unlock" into main 2024-01-17 10:02:05 +00:00
josephpv
099ae32943 Add auto lock preference inside private space settings
This includes below changes
- Adds perference for Auto Lock settings inside private space settings page.
- Feaure is behind flag
android.multiuser.support_autolock_for_private_space

Screenshots:
go/ss/ZCaYGWMDdH8bQNz.png
go/ss/AxnD8DviiT5hhkW.png
go/ss/9TMYmacyiVhyexB.png
go/ss/6SzhkGfTbDYVUVE.png

Bug: 312893140
Test: atest AutoLockPreferenceControllerTest, atest AutoLockPreferenceControllerTest

Change-Id: I95beb9d71c709002e17307e612c60b2f5087290b
2024-01-12 19:12:30 +00:00
josephpv
1741f5355a In Private space settings when no face support show only fingerprint unlock
This contains fix for PS biometrics issue in Pixel devices without
face hardware support.

In private space separate lock settings page
- without face support only fingerprint unlock controller is shown
- with face support controller for both face and fingerprint is shown.

Screenshot:
-Without Face support
go/ss/qhDqdyqYLCTYaJq.png
go/ss/4Jw54XKJPNYm4R6.png
go/ss/5LPjRQ76cVPZy7j.png

-if without Fingerprint
go/ss/ACGqKU7j24G3Q9Q.png

-With Face support
go/ss/7jV385WCFsXajZM.png
go/ss/ZrGTdiYUN5MFY3r.png
go/ss/6QNKqaFuZvuMJZ9.png
go/ss/9ZcSvXULHuPK2ps.png
go/ss/7GfABcYE4h8BkCo.png

Bug: 319794904
Test: Manual
Change-Id: I053e8584d036ca0d6e3d8157d0fdef6d465492aa
2024-01-12 19:10:46 +00:00
josephpv
0b7d46746c Add Biometrics settings inside private space One Lock settings
This includes below changes:
- Add Biometrics preferernce in Private Space One Lock settings page
- Face and Fingerprint enrolment for Private profile
- Feature is behind flag android.multiuser.enable_biometrics_to_unlock_private_space

Screenshots:
go/ss/9cWZRAuvGGW7gMm.png
go/ss/B3NoFbL3KbpSzeN.png
go/ss/7xH3DLi9d6Lu2mR.png
go/ss/8WBEgKychWpduXg.png
go/ss/8pmPGshd9aiPvVC.png
go/ss/AFPBPbiaBBvTj3p.png
go/ss/3fE4XKLLUdP8LmF.png

Bug: 308862923
Test: atest CombinedBiometricStatusUtilsTest, atest FaceFingerprintUnlockControllerTest
Change-Id: I1853107a4df4fc97db53c97524c6d44a4f554e37
2023-12-19 18:57:10 +00:00
Joseph Vincent
a123021e1d Merge "Finish PS sub-settings page if PS is locked" into main 2023-12-19 18:14:53 +00:00
josephpv
4c055dd097 Finish PS sub-settings page if PS is locked
Bug: 317026141
Test: Manual
Change-Id: If3a3045c40dd61779b272589231d395ce7ae9fa9
2023-12-19 11:32:11 +00:00
josephpv
223737e0b5 Show customized message for private space while choosing lock
The change adds private profile checks in addition to the exisiting
managed profile check to show customized message while choosing lock for
private profile in Pattern, PIN and Password screens.

Bug: 311343571
Test: Verify lock screen message for private space
Change-Id: Ic8173ff8c1af23fc593390acaff4c67390f99b9c
2023-12-18 19:34:29 +00:00
Treehugger Robot
bb49d847a2 Merge "Log start of sign in flow" into main 2023-12-18 19:12:27 +00:00
josephpv
16c32a5e2c Calling requestQuietMode with peindingIntent to match PS settings with
PS state

Bug: 314910049, 312399293
Test: Manually verified

Change-Id: Iebdd09d4c6f319d50b8c0f118de0ddb2eaeb95d6
2023-12-18 14:16:11 +00:00
Joseph Vincent
0bdf8e9c1a Merge "Add intent to start Private Space setup/settings" into main 2023-12-15 16:38:18 +00:00
Manish Singh
132252da27 Merge "Don't show setting if private profile is locked" into main 2023-12-15 13:04:09 +00:00
josephpv
92f28a17c8 Add intent to start Private Space setup/settings
Bug: 310027945
Test: Manual
Change-Id: I9df2b239ba24ac44c65a4cb3c18214bbc27bbcec
2023-12-13 18:27:19 +00:00
Anna Zhuravleva
9ad57d4cc0 Log start of sign in flow
Test: statsd_testdrive
https://paste.googleplex.com/4692799132270592
Bug: 315947418
Change-Id: I94a1a44596206c15a5497fd8aec1d8a2628f03e3
2023-12-13 16:35:32 +00:00
josephpv
d2d3453f81 Update USER_SETUP_COMPLETE setting after starting private space
On setting USER_SETUP_COMPLETE for private profile device is reapplied
to the profile

Bug: 311348071
Test: Verified device theme color is applied to profile
Change-Id: I25f3013aaf6cfc6925d858b461c1f2c6beb534f6
2023-12-13 14:31:47 +00:00
Manish Singh
c1cd428e43 Don't show setting if private profile is locked
Bug: 311343261
Test: manual
Change-Id: I16e1f08c7cace0964e666a71e785fee1c18cc577
2023-12-12 08:51:19 +00:00
josephpv
242ae4fbcc Lock Private space at the end of PS setup.
This change is to call UserManager requestQuietModeEnabled() API at the
end of PS setup to enable quitemode for private space.

Bug: 313652502
Test: atest PrivateSpaceMaintainerTest
Verify Private space is locked state after private space setup completion.

Change-Id: I1d863f6d51ffa4bb58318696603905d35c3109b6
2023-12-11 20:43:59 +00:00
josephpv
992f6b97dd Update private space setup string and loading screen title
This includes below changes based on the updated UX mocks:
- Add one more loading screen in setup flow
- Update feature intro text on Setup page
- To swap order of bullets on the setup intro screen
- Update "Private Space" to "private space" in setup flow screens

go/ss/7pVGBSPqezDek47.png
go/ss/ADLX8aXAAGgYQHD.png
go/ss/tYtrGypBgRuXM9V.png
go/ss/3zZfij6JDpudwYR.png
go/ss/BFtWegFZyTueQoT.png
Recording link - b/313654776#comment5

Bug: 313654776, 313882412, 313655290
Test: Verify title and text is same as UX flow
Change-Id: I6a985c4fd6ecbe8ddd11e36bf76a2a9cc8427ef5
2023-12-07 12:39:56 +00:00
josephpv
2d7985fbf3 Show customized message for private space lock setup screen
go/ss/3kmkEkasv6vmDDo.png
go/ss/7CzzSXZthbJVcEr.png

Bug: 308862923
Test: atest ChooseLockGenericTest and Verified manually customized
message is shown when passed with intent.

Change-Id: I784d42c4702801ec45bc8d4c5e911a404f549d46
2023-12-06 20:39:51 +00:00
josephpv
fa6ee75c0e Swap orders of GAIA signin and lock setup during Private space setup
Bug: 312892127
Test: Verified manually Lock setup is before GAIA login
Change-Id: I05b7c61306e4988a59511988f88e26cdefbed194
2023-12-04 17:37:09 +00:00
Anna Zhuravleva
b1fdd55707 Log events during PS setup flow.
Log pages and user clicks during private
space setup flow.

Bug: 313170618
Test: statd_testdrive 97, output: https://paste.googleplex.com/4874404496932864
Change-Id: I1f59e9720ee4bdd21670b86a4f1f0f98a91fa0db
2023-11-29 15:39:10 +00:00
Manish Singh
51f1321b1e Put stricter flag checks
Also removed a log which gives away flag.

Bug: 312976400
Test: manual
Change-Id: I4a989de8b6b920666aabf0cc9311e28becc4d862
2023-11-24 18:51:27 +00:00
Joseph Vincent
4a88ae4957 Merge "Add fade out/fade in animation in PS setup auto advancing screen" into main 2023-11-17 09:54:58 +00:00
josephpv
5dea00c4e7 Add fade out/fade in animation in PS setup auto advancing screen
As per the UX requirement below changes are made in the screen:

- Position of "Setting up Pirvate Space" text is left aligned to layout
- Lading progress bar next to text removed
- Add fade out and fade in animation for header and image in auto
   advance screen

Bug: 310218201
Test: Manual
Change-Id: Iaf9c27761ce7f25368aac8f9a7d43eba20d66353
2023-11-16 19:11:12 +00:00
Manish Singh
aa91f1db3a Merge "Reset Private Space settings on new space creation" into main 2023-11-15 13:55:12 +00:00
Manish Singh
7a556b851c Reset Private Space settings on new space creation
Also added PrivateSpaceMaintainerTest

Bug: 310217645
Test: atest PrivateSpaceMaintainerTest
Test: atest HidePrivateSpaceControllerTest
Test: manual
Change-Id: Ic1096fd652d23ae6aa9da1421017c08f6bc480aa
2023-11-15 12:54:20 +00:00