Android/packages_apps_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
46,377 Commits 1 Branch 0 Tags
6d48242da70804ddc29bd45c7dfa31754a58ce81
Commit Graph

7 Commits

Author SHA1 Message Date
jyhshiangwang
4d015b17b3 Use ListFormatter to join strings 
Currently in Settings we are using R.string.join_many_items_first, R.string.join_many_items_middle and R.string.join_many_items_last to manually join strings. The join code is messy and the joined string is incorrect in some languages, so we migrate all string join to just use ListFormatter.getInstance().format().

Bug: b/78248791
Test: robotests
Change-Id: I898339978e6e2027587e28994b0280fa46821fd6
 2018-05-02 11:15:32 +08:00
Fan Zhang
04f1423bfa Remove custom updateState() if it's just setting summary 
Change-Id: I6311d67d6ba11961a6814b91dcd8e37a2e17df40
Fixes: 73950519
Test: rerun robotests
 2018-02-28 15:22:09 -08:00
Fan Zhang
906572b127 Change PreferenceController#getSummary return type. 
Return CharSequence instead of String.

All user visible string should be modeled as CharSequence.

Bug: 73950519
Test: robotest
Change-Id: I30befef0c33f94351d4a2774e283bd1ed804aa8b
 2018-02-27 22:30:12 -08:00
Matthew Fritze
c69f73f4d1 Support getDynamicSummary in BasePreferenceController 
Adds dynamic summary getter in relevant BasePreferenceControllers.
Preferece controllers that don't have dynamic summaries or which
are not yet BasePreferenceControllers are not changed right now.

Change-Id: I435ccab7758d90515583fd8ca10a9b1ef0c858b9
Fixes: 71514936
Test: robotests
 2018-01-04 13:58:01 -08:00
Doris Ling
a9693524bf Change the permission labels to lowercase. 
In the summary for Apps permissions, change the list of permissions
lable to lowercase instead.

Change-Id: I5b3133c33de7110dbec6ab179c6f1308c4ed481e
Fixes: 65049565
Test: make RunSettingsRoboTests
 2017-09-13 15:23:06 -07:00
Tony Mantler
1d583e125f Make PreferenceController a mixin 
Bug: 62912136
Test: Existing tests in BaseSearchIndexProviderTest
Change-Id: Ieda359806c09a019840b2005446c7ec8b61fdb00
 2017-06-26 10:58:36 -07:00
Doris Ling
ffda9c23c4 Add summary text to App permissions settings. 
Check the granted permissions for the installed app and compose the
summary text to use the first 3 permissions granted from the list:
Location, Microphone, Camera, Sms, Contacts, and Phone.

Change-Id: I61d21f279af2fe86132de22b94e1a49da0225fcd
Fix: 36376411
Test: make RunSettingsRoboTests
 2017-05-01 17:36:20 -07:00