Commit Graph

2994 Commits

Author SHA1 Message Date
Chaohui Wang
6664870eb8 Fix cannot update APN settings in new edit page
Fix: 326164397
Test: manual - edit existing APN
Test: unit test - existing tests still pass
Change-Id: I92a2e375b990f0e478dbb30c389371a8e0596608
2024-02-21 18:14:20 +08:00
SongFerng Wang
f4d0eff41e Merge "[SimUiEnhancement] Fix Automatic Data switch UI at SimOnboarding" into main 2024-02-20 02:02:22 +00:00
songferngwang
6d0b41af5a [SimUiEnhancement] Fix Automatic Data switch UI at SimOnboarding
- Automatic Data switch can't set value to framework, since
the nonDds is -1
- update the ProgressDialog as compose UI

Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: Build pass
Change-Id: Ifeca38b42b3a51e8a967c0e744eeae06338f6ddc
2024-02-19 03:12:50 +00:00
Chaohui Wang
e9917e2f48 Fallback to NUMERIC when CARRIER_ID is unknown
For some subscription, the carrier id is unknown (-1), which cause the
inserted APN not be displayed.

Fallback to NUMERIC when CARRIER_ID is unknown to fix this issue.

Fix: 324394199
Test: manual with esim test profile - carrier id -1
Test: unit tests
Change-Id: Ic63a3e0c9ab37c8bdf86a2c7155b08778f05deff
2024-02-18 16:26:15 +08:00
Hyunho Shin
0516e24d34 Merge "Click the 'convert to eSIM' menu to finish the pSIM setting" into main 2024-02-08 17:27:49 +00:00
Hyunho
2e53658089 Click the 'convert to eSIM' menu to finish the pSIM setting
Bug: b/319527964
Test: manual done

Change-Id: I07facccf53c5ee258f0148f64643eb6e1c3d9118
2024-02-08 13:49:20 +00:00
songferngwang
f1ea484425 SIM Onboarding flow completed
- Add the setup flow for switching sim and rename and setup primary sim
  items
- Add the bottom sheet and progress dialog.
Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: build pass. Will upload another cl for testing

Change-Id: Ie9680f0a67afe453c1449c0f2b59e98fd627e215
2024-02-06 10:56:59 +00:00
SongFerngWang
8535539582 [Sim UI enhancement] MobileNetworkSettings UI enhancement
- Add the phone number
- Add the mobile network(SPN)
- Add the IMEI
- Add the EID
- Remove the mobile data
- Remove the Auto data switch
- Remove the calls and SMS default subscription

Bug: 318310357
Bug: 298898436
Bug: 298891941

Test: atest MobileNetworkEidPreferenceControllerTest
atest MobileNetworkImeiPreferenceControllerTest
atest MobileNetworkPhoneNumberPreferenceControllerTest
atest MobileNetworkSpnPreferenceControllerTest
atest MobileDataPreferenceControllerTest
atest MobileNetworkSettingsTest

Change-Id: Ie2767056dd04d1131390e3a03d6d82d56fe5b2dc
2024-01-31 07:45:28 +00:00
Hakjun Choi
833714434a Remove unnecessary term 'all' from the API name
getAllSatellitePlmnsForCarrier > getSatellitePlmnsForCarrier
The word 'all' is unnecessary here, it's already implied by PLMN being a plural.

Bug: 320462244
Test: atest SatelliteManagerTet, NetworkSelectSettingsTest
Change-Id: Idb6439176be55a787f27f298c211deef6900c7f9
2024-01-27 20:56:41 +00:00
Hakjun Choi
7f2f0612d1 Reflect satellite api refactoring to Settings
Removed the word Satellite from all the method names might improve brevity and readability excluding cases that cause confusion.

Bug: 297933128
Test: manual test using testSatelliteApp

Change-Id: Ia817b8bf531031c28264750c03a6f7004ed81aa5
2024-01-26 13:26:25 +00:00
SongFerngWang
685befa86a SIMs page enhancement
This is for the Sim onboarding UI enhancement
- create new SIMs spa UI
- hide the Call & SMS when flag is on

Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: munally test

Change-Id: Iaecb8fe435b26f2952263024c93c8719feda96a4
2024-01-26 04:20:01 +00:00
SongFerng Wang
7b8848a60c Merge "[Sim UI enhancement] hide Calls & SMS when using new ui" into main 2024-01-24 07:57:44 +00:00
SongFerng Wang
3a6f8d2809 Merge "Using new API setDataEnabledForReason for setDataEnabled" into main 2024-01-24 06:46:07 +00:00
SongFerngWang
0e4018f469 [Sim UI enhancement] hide Calls & SMS when using new ui
Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: manually test
Change-Id: Ic6e1b77a300f3e9d86225f9cd4812b0f9b426269
2024-01-24 06:42:32 +00:00
Charlotte Lu
9bdb3b58e5 Merge "Modify the format of the wep warning dialog" into main 2024-01-24 05:06:12 +00:00
SongFerngWang
533e045598 Using new API setDataEnabledForReason for setDataEnabled
Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: atest MobileNetworkUtilsTest
Change-Id: I30b56247370ebaa5896bec3205ddce3e5c92c7d0
2024-01-24 04:46:53 +00:00
Hakjun Choi
4b80409474 Merge "Add Satellite Messaging activity" into main 2024-01-24 01:31:30 +00:00
Ling Ma
b6e28eeda5 Merge "Wrap subManager creation with createForAllProfiles" into main 2024-01-23 18:03:11 +00:00
Hakjun Choi
2f57f53831 Add Satellite Messaging activity
Add satellite messaging activity into Settings for carrier satellite
service

Bug: 319035517
Test: manual
1. Set CarrierConfig Key KEY_SATELLITE_ATTACH_SUPPORTED_BOOL as false then verify satellite messaging menu is not shwon from
   Settings > Network & internet > SIMs > test sim
2. Set CarrierConfig key KEY_SATELLITE_ATTACH_SUPPORTED_BOOL as true
3. Insert test SIM
3. Get into to Settings > Network & internet > SIMs > test sim > verify Satellite messaging is shown
4. Verify whether descriptions are as directed. icons are as directed.
5. Add satellite messaging does not work when click
6. Invoke web browser with test website when click 'More about satellite messaging'
7. Replace SIM of which MCC/MNC is not test sim
8. verify no action happen when click 'More about satellite messaging'

Change-Id: Iee8fad58b41cbca34f373d2a9df1d074c447cfb1
2024-01-23 07:49:00 +00:00
Charlotte Lu
ccac2b9a94 Merge "apn insert exception for duplicate apn entry" into main 2024-01-23 07:20:07 +00:00
Charlotte Lu
27a8deeb4a Modify the format of the wep warning dialog
Test: Visual Test
Fix: 321855606
Change-Id: I1156f3305685f2253752a7a1d99b16d3eede55f9
2024-01-23 12:59:23 +08:00
SongFerng Wang
4601261f81 Merge "Add the UI of dual sim onboarding" into main 2024-01-22 08:40:49 +00:00
Charlotte Lu
e5aff32142 Merge "Change apn type into ExposedDropdownMenuCheckBox" into main 2024-01-22 08:39:59 +00:00
SongFerngWang
4713fd6baa Add the UI of dual sim onboarding
This is the first version.

Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: Build pass
atest SimOnboardingLabelSimTest
atest SimOnboardingPageProviderTest
atest SimOnboardingPrimarySimTest
atest SimOnboardingSelectSimTest

Change-Id: I195bd6b03ab0e881fdd67272c2476ef2b1fcd3ed
2024-01-22 07:47:51 +00:00
Charlotte Lu
1c9921a264 apn insert exception for duplicate apn entry
Test: Visual Test
Fix: 321619947
Change-Id: I362cd0c5dec7b8fab9af081f67717c4633064cdd
2024-01-22 06:38:57 +00:00
Ling Ma
9c3ad34d6e Wrap subManager creation with createForAllProfiles
Since U, a sub can be associated with a particular profile, and thus in V we enforce filtering on the caller and only show the subs that are associated with the caller.
However, in some cases the caller indeed needs to see all subs regardless of its association, e.g. sysUI. Therefore, a param isForAllProfile is added to indicate whether the caller intends to see all subs.

Bug: 296076674
Test: voice call + data browsing
Flag: ACONFIG com.android.internal.telephony.flags.enforce_subscription_user_filter
 DEVELOPMENT
Change-Id: Ib5ccc841029a32ae9cf25d7a65b156e363d6b139
2024-01-20 05:28:14 +00:00
SongFerng Wang
1229c54470 Using the phone number without formate for the unique DisplayName
If the phone number has formate, the getUniqueSubscriptionDisplayNames may have the white space.

Bug: 318022908
Change-Id: I459fb244ec690eff03d565b494b007849ef44c8b
Test: atest SubscriptionUtilTest
2024-01-19 17:52:55 +00:00
Charlotte Lu
0f577f7ddd Change apn type into ExposedDropdownMenuCheckBox
Test: Visual Test
Fix: 320891903,320621937
Change-Id: Ia6e4dbbcb568afae04776658a025e30c69e1ddd8
2024-01-19 07:15:13 +00:00
Charlotte Lu
495ab9d09e Merge "Add [ssid] is blocked for wep network" into main 2024-01-18 09:42:13 +00:00
Charlotte Lu
a38b151118 Add [ssid] is blocked for wep network
Test: Visual Test
Fix: 320829123
Change-Id: Ia742e8b3e622c4c44a69daca20ca64edc6f9f826
2024-01-18 16:44:52 +08:00
Charlotte Lu
77615e83d2 Merge "Adjusting the apn action items" into main 2024-01-18 07:38:22 +00:00
Charlotte Lu
e0f6540fd1 Adjusting the apn action items
Test: Visual Test
Fix: 320617647
Change-Id: If3fddab5b45140b2c66a3487c08b421a1bd3b78a
2024-01-18 13:04:06 +08:00
Charlotte Lu
1eb4bc0c5f Merge "Duplicate apn entry" into main 2024-01-18 04:00:58 +00:00
SongFerng Wang
7e2fc39678 Merge "Remove the phone number at Rename page" into main 2024-01-17 09:08:49 +00:00
Charlotte Lu
031aa3417d Duplicate apn entry
Test: Visual Test
Fix: 319194851
Change-Id: I491655bb80a17cc9fc99d47f1e1ac5824eb11921
2024-01-17 15:58:24 +08:00
SongFerngWang
4366ceea15 Remove the phone number at Rename page
Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: Build pass
Change-Id: I6e77f2a8858e17e3e56c01769e6eb5b4fd478a04
2024-01-17 15:11:55 +08:00
Chaohui Wang
8a5bf167c1 Merge "Catch IllegalStateException when get carrier config" into main 2024-01-16 03:37:13 +00:00
Charlotte Lu
89b966fff5 Merge "When apn is read only, hide the save button." into main 2024-01-15 08:54:51 +00:00
Chaohui Wang
9a6a0865de Catch IllegalStateException when get carrier config
Fix: 319149441
Test: manual - on System Update page
Test: unit test
Change-Id: I484a036b2ce086531b20e1a5ca7e541934bc4c07
2024-01-15 16:52:06 +08:00
Charlotte Lu
f8bc0841bc When apn is read only, hide the save button.
Test: Visual Test
Fix: 320200491
Change-Id: I8280fdaa3643a982137936473d827b8502a6e023
2024-01-15 15:39:49 +08:00
Hyunho Shin
4130a95c5d Merge "Add the condtions to show the pSIM conversion menu" into main 2024-01-15 05:12:40 +00:00
Hyunho
3d2c417236 Add the condtions to show the pSIM conversion menu
if the value of carrier config and current SIM's carrier is matched, then the pSIM conversion menu will show

Bug: b/319527964
Test: manual test (b/319527964#comment3)
Change-Id: I82025447f43c0151ba58edd77c6f8b7e8aff660d
2024-01-13 03:48:07 +00:00
Hakjun Choi
197a10a0a9 Filter out satellite plmn when in SAT mode
[SAT-070] : PLMNs associated with SAT MODE, as specified in SAT-008, should not be displayed or selectable in Manual Selection/Network Operator Menu

Bug: 316264277
Test: Manual test with pixel in live network
Test: atest NetworkSelectSettingsTest

Change-Id: Ic100772c97fa1ab18d7e63b654e397d8a80eda8a
2024-01-11 07:14:30 +00:00
Sunny Shao
bee65b4109 Merge "Revert^2 "Nullability Annotations replacement"" into main 2024-01-10 08:35:06 +00:00
Sunny Shao
076ed573eb Revert^2 "Nullability Annotations replacement"
This reverts commit 19d1d3d15d.

Reason for revert: revert it because this is not the root cause.

bug: 316867690
Change-Id: I0f168dbb64044aa720202af7b1040afd4f028c9c
2024-01-10 07:34:01 +00:00
Hyunho
b6a6b1e91a Add the config to show the pSIM conversion menu and set it to false
Bug: b/314881248
Test: manual done
Change-Id: I258471182cb9092fade50881f52f7299c10c8da2
2024-01-10 06:00:12 +00:00
Charlotte Lu
d442ac8db1 mmsc can be ""
Test: Visual Test
Fix: 319063785
Change-Id: I8909412b1debee06fa461de9e9230a991bc046e1
2024-01-08 09:43:34 +00:00
Chaohui Wang
601fe12ea9 Merge "Show "0 B used" when no data usage this cycle" into main 2024-01-08 05:39:47 +00:00
Joonhun Shin
43d6a231e0 Merge "Data only device(without FEATURE_TELEPHON_CALLING) : Add try/catch to handle UnsupportedOperationException" into main 2024-01-08 02:06:46 +00:00
Chaohui Wang
f28d119560 Show "0 B used" when no data usage this cycle
When the latest cycle has no data usage, currently it shows all time
usage without cycle info, which could confuse user.

Change to "0 B used used xxx - xxx" to fix this issue.

Fix: 292346951
Test: manual - on Mobile Settings
Test: unit tests
Change-Id: Ic06fd63a3bc049d70538d0a3cd1fa3d62dbd71d7
2024-01-06 19:05:47 +08:00