Commit Graph

53415 Commits

Author SHA1 Message Date
Roshan Pius
f04ee0dfab settings: Remove @hide NFC API usage
These @hide usages in other parts of platform need to be cleaned
up to unbundle NFC mainline module.

Flag: None (The NFC flag - `enableNfcMainline` has been promoted to trunkfood. Note these APIs are available as @hide even if not available in formal SDK until V)
Bug: 307352220
Test: Compiles

Change-Id: I6f87ad7ae03c67aaa2ddb0ac2529debc53278ba8
2023-11-29 21:24:28 +00:00
Anna Zhuravleva
b1fdd55707 Log events during PS setup flow.
Log pages and user clicks during private
space setup flow.

Bug: 313170618
Test: statd_testdrive 97, output: https://paste.googleplex.com/4874404496932864
Change-Id: I1f59e9720ee4bdd21670b86a4f1f0f98a91fa0db
2023-11-29 15:39:10 +00:00
Edgar Wang
07b2af4120 Merge "Refactor Date & Time Settings" into main 2023-11-29 13:19:40 +00:00
YK Hung
0b6a023f80 Merge "Protect failed setUidPolicy() and avoid storing invalid UIDs" into main 2023-11-29 10:56:45 +00:00
Edgar Wang
fdab44f9e7 Refactor Date & Time Settings
- Rid off AbstractPreferenceController

Test: robotest
Bug: 235445309
Change-Id: I61118a0ff580231973509c06e84e7088dba897f5
2023-11-29 18:35:43 +08:00
Yiyi Shen
bc3a1fa31f [Audiosharing] Add feature gates as utils.
Flagged with enable_le_audio_sharing

Bug: 305620450
Test: manual
Change-Id: I022174b5b40300b46b7b8dd78c7cddf541ed2aec
2023-11-29 17:55:28 +08:00
shaoweishen
365f55efc5 [PK Setting] update searchable if page is not visible
if PK setting is not available, also make it not searchable.

Test: verified on device
Bug: 301881819
Change-Id: I6e71634ce5ddc6d5db3d31f5614fef7ccabc6d3d
2023-11-29 09:02:08 +00:00
ykhung
6891900af5 Protect failed setUidPolicy() and avoid storing invalid UIDs
Add protection for the setUidPolicy() failed case to avoid invalid UIDs
to crash the caller process, and avoid storing the invalid UIDs to
SharedPreferences if it is failed to setUidPolicy()

Bug: 306329984
Test: make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.fuelgauge"
Change-Id: I5c14434708b82ba3c238c2338d47085c2ce244e0
2023-11-29 16:59:17 +08:00
Chaohui Wang
01ce50de90 Merge "Avoid ANR of TetherPreferenceController" into main 2023-11-29 07:04:30 +00:00
Eric Biggers
32154db445 Merge "Use isCeStorageUnlocked() in storage wizards" into main am: 7ec6e27c64 am: 51a0475c44 am: e4f1aa8098
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2807094

Change-Id: I5d8aa16768a2145fcc0e06155be53d6a306e3e74
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-29 04:42:21 +00:00
Eric Biggers
e4f1aa8098 Merge "Use isCeStorageUnlocked() in storage wizards" into main am: 7ec6e27c64 am: 51a0475c44
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2807094

Change-Id: I3dc5181c72a6e99964b5681ec275c35eece2e6ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-29 04:09:41 +00:00
Chaohui Wang
880068d23a Avoid ANR of TetherPreferenceController
Off load the following work from main thread,
- Calculate title
- Calculate summery

This also helps improve the latency.

Also migrate to registerTetheringEventCallback() since
TetheringManager.ACTION_TETHER_STATE_CHANGED is deprecated.

Fix: 311848767
Test: manual - on Network & internet page and turn on / off tethering
Test: unit tests
Change-Id: I6ee182b41ef51f691ea31938142be1a41faf5573
2023-11-29 12:06:37 +08:00
Eric Biggers
51a0475c44 Merge "Use isCeStorageUnlocked() in storage wizards" into main am: 7ec6e27c64
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2807094

Change-Id: I038600e5177845571e80d65c24eb90278320e295
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-29 03:38:30 +00:00
Yiyi Shen
6a3a3e2ac7 Merge "[Audiosharing] Show/hide audio sharing settings based on BT state." into main 2023-11-29 02:32:42 +00:00
Eric Biggers
7ec6e27c64 Merge "Use isCeStorageUnlocked() in storage wizards" into main 2023-11-29 02:27:02 +00:00
Derek Jedral
2c4f5454f1 Update strings for Watch Unlock
Test: Built locally
Bug: 294281617
Change-Id: I01493060d5ea1b1941b1fb381d0c90cd4ce2ee78
2023-11-29 01:21:09 +00:00
Treehugger Robot
95235f8b3f Merge "Ensure udfps icon doesnt disappear in enroll" into main 2023-11-28 23:07:04 +00:00
Joshua McCloskey
a16a36c911 Ensure udfps icon doesnt disappear in enroll
Test: Manual
Fixes: 306280706
Change-Id: I7fd41d53b891fcfd2140ad1e2b1376ee4c017591
2023-11-28 22:06:16 +00:00
Becca Hughes
d4e09de3e1 Merge "Swap cog and left hand side of row" into main 2023-11-28 21:19:40 +00:00
Chris Antol
82a3db7b7a MainlineModuleVersionPreferenceControllerTest to access intent directly
Bug: 313567396
Test: Test updated accordingly
Change-Id: I4a21d618059c7c7f2e0b3bdb0c53c4fc3938d24c
2023-11-28 19:32:14 +00:00
Becca Hughes
e70dad42f4 Swap cog and left hand side of row
See bug for more context.

Test: flash device
Bug: 280951040
Change-Id: I21ba2a2177f88dbabea42915727f8c33aa0e23f8
2023-11-28 10:05:38 -08:00
Manish Singh
d503f25692 Check purely for the presence of a managed profile
including the parent user, as here we care only about the existence of
the managed profile.

This maintains the behaviour prior to private space changes.

Bug: 313128792
Test: manual
Test: atest ProfileSelectFragmentTest
Change-Id: I1d253f95ca534b48acfdb4c1c8b84368d731dded
2023-11-28 16:09:11 +00:00
Yiyi Shen
bdc870a4c1 [Audiosharing] Show/hide audio sharing settings based on BT state.
Flagged with enable_le_audio_sharing

Bug: 305620450
Test: atest
Change-Id: I1af8ae268194cfca8e03cc49151b68a25717e89a
2023-11-28 19:17:40 +08:00
Yiyi Shen
011b606740 Merge "[Audiosharing] Enable/disable the main switch base on BT state." into main 2023-11-28 07:36:23 +00:00
Charlotte Lu
4ac2d9c8db Merge "Automatically save on return" into main 2023-11-28 06:21:03 +00:00
Edgar Wang
d640a51d09 Merge "Refactor AppPicker to adopt the latest UX" into main 2023-11-28 05:50:29 +00:00
Chaohui Wang
34d9392dfd Merge "Clean ProxyPreferenceController" into main 2023-11-28 05:33:12 +00:00
Weng Su
f20baa2bc7 Merge "Fine-tune launch time in Network & Internet settings" into main 2023-11-28 04:02:02 +00:00
Chaohui Wang
b5da10e797 Clean ProxyPreferenceController
This is a controller without UI.

Bug: 311604902
Test: manual - on Network & internet page
Change-Id: Id88709b5c3f64ef7f6b441260b4b88ce7a9a5847
2023-11-28 11:07:44 +08:00
Chaohui Wang
c3e97122c1 Clean up BackupSettingsHelper.getSummary()
Backup item in System page no longer has summary.

Bug: 310513318
Test: m RunSettingsRoboTests
Change-Id: I0bb3b9114287546c279a5f30b65fb7081af54e44
2023-11-28 02:30:09 +00:00
Daniel Norman
126de9691a Use A11yManagerService to check if the A11yService warning is required.
Bug: 303511250
Test: m RunSettingsRoboTests ROBOTEST_FILTER=ToggleAccessibilityServicePreferenceFragmentTest
Change-Id: Ibef748bd82ba166e377be0611df113ac09d052bc
2023-11-28 01:54:21 +00:00
Daniel Norman
9f6e77a094 Minor refactoring to replace duplicated logic with existing methods.
Bug: 303511250
Test: tested in child change in the topic
Change-Id: I0995ce5fc685257ba69f7e4aa733de74aeb1fde3
2023-11-28 00:07:17 +00:00
Omer Ozer
b347d32b31 Merge "Change the existing permission to a system level perm for factory reset prep." into main 2023-11-27 22:57:32 +00:00
Weng Su
129ff9b8fe Fine-tune launch time in Network & Internet settings
- Avoid creating WifiPickerTracker if Hotspot network feature is not enabled

Fix: 312905628
Test: unit test
atest -c InternetPreferenceControllerTest

Change-Id: I5818698ce06244aa7660e90a5f2fd372a3a221bf
2023-11-28 06:51:39 +08:00
Treehugger Robot
958a6ab7aa Merge "Remove unnecessary flag check" into main 2023-11-27 19:05:22 +00:00
Manish Singh
62692bf6eb Merge "Put stricter flag checks" into main 2023-11-27 18:53:53 +00:00
Manish Singh
eaafcbcb28 Remove unnecessary flag check
This code is to remove the user which shouldn't be shown when in quiet
mode - if anything, it's better to keep this not behind the flag.

Also, the user property is not behind the flag.

Bug: 312976400
Test: manual
Change-Id: Ic66a53bf7608848df223914b0fe78ed00b86db70
2023-11-27 17:39:16 +00:00
Chaohui Wang
b848685b8d Merge "Clean up Contextual Wifi card" into main 2023-11-27 06:55:55 +00:00
Chaohui Wang
357076d03d Merge "Remove injecting developer options into Settings itself" into main 2023-11-27 06:49:55 +00:00
Chaohui Wang
30c8254cfd Merge "Clean up unused SummaryProvider" into main 2023-11-27 06:49:47 +00:00
Charlotte Lu
c776835da5 Automatically save on return
Test: Visual Test
Fix: 313008844
Change-Id: I795807d1984bbd170db3fdc9e54de700ff85ec69
2023-11-27 14:48:15 +08:00
Chaohui Wang
34c4deb6c9 Clean up Contextual Wifi card
Bug: 245854887
Test: m RunSettingsRoboTests
Change-Id: I3b4ccc076a68eadc11e9fb3d2967a34fe0396cf9
2023-11-27 13:59:33 +08:00
Chaohui Wang
ee7139a889 Remove injecting developer options into Settings itself
- It can improve performance because we use less injected item
- Also use RestrictedPreference instead just checking restrictions,
  so we follow policy transparency.

Note: Renamed DevelopmentSettingsDashboardActivity to
DevelopmentSettingsActivity,
because DevelopmentSettingsDashboardActivity could in disabled state
even after Settings upgrades, use a new name to prevent this issue.

Bug: 311604902
Test: manual - turn on / off Developer Options
Test: unit test
Change-Id: I17be117ae59e59410687e6d08fd5edd034d0508f
2023-11-27 05:12:13 +00:00
Chaohui Wang
c9ccf861c6 Merge "Clean up unused MobilePlanPreferenceController" into main 2023-11-27 05:11:53 +00:00
Chaohui Wang
7c4b3a3477 Clean up unused SummaryProvider
Remove unused content provider to improve latency.

Bug: 311604902
Test: manual - on System page
Change-Id: I3208a2fe341337c2648733b5e11159b96f5e6908
2023-11-27 12:26:48 +08:00
Manish Singh
51f1321b1e Put stricter flag checks
Also removed a log which gives away flag.

Bug: 312976400
Test: manual
Change-Id: I4a989de8b6b920666aabf0cc9311e28becc4d862
2023-11-24 18:51:27 +00:00
Treehugger Robot
b76f32ef3e Merge "Hide search results when Battery info page is disabled." into main 2023-11-24 16:50:20 +00:00
Yi-Ling Chuang
43260f6f28 Hide search results when Battery info page is disabled.
Fixes: 312639417
Test: robotest
Change-Id: I04279c4068ebb0e06b575ae2df44836d193f9bac
2023-11-24 23:56:08 +08:00
Chaohui Wang
a39905eabd Clean up unused MobilePlanPreferenceController
Which can improve the latency of "Network & internet" page.

Bug: 311604902
Test: manual - on "Network & internet" page
Change-Id: If306e93491402278ede4f20591296765b30bde37
2023-11-24 23:55:14 +08:00
Treehugger Robot
f122a93efc Merge "Add power consumption footer in screen timeout page." into main 2023-11-24 09:59:58 +00:00