Commit Graph

53415 Commits

Author SHA1 Message Date
Daniel Norman
8ce099c2cd Remove usages of bugfix flag cleanup_accessibility_warning_dialog.
Flag has been in Trunkfood for over a month.

Includes one mechanical refactor to move a method from a now-removed
file into a private method in the class that uses it: createDisableDialog

(This flag guarded a preliminary cleanup and minor bug fix for
b/303511250, but the actual feature for b/303511250 is tracked in a
different flag 'skip_accessibility_warning_dialog_for_trusted_services')

Bug: 303511250
Test: existing tests in Presubmit (no change to behavior)
Change-Id: Iccf439adb2806e988310f503fb3891a6bd022054
2024-03-19 23:05:07 +00:00
Manish Singh
b41979a012 Merge "Don't show private accounts when locked" into main 2024-03-19 18:09:25 +00:00
josephpv
4cebe66d71 Update strings in private space hide when locked settings page
Recording link:
b/330221666#comment2
screenshot :
go/ss/Ja2xyxVm4wjDF6P.png
go/ss/56Kujyq6WfBLtHG.png
go/ss/9wvcJTXnarizyU5.png

Bug: 330221666
Bug: 330327338

Test: Manual. Verified strings are updated as per UX mocks
Change-Id: I053bd2558503eb58fcf196eb0988bfa007583704
2024-03-19 17:05:28 +00:00
Treehugger Robot
937693d538 Merge "Add new Cellular Network Security page" into main 2024-03-19 16:15:32 +00:00
Manish Singh
e157ba8f39 Rename the name of private profile creation from Settings
Bug: 324844478
Test: manual
Change-Id: I9d2a2e3a2aa73e3eeea4fd08c45c9f9d654ea5d4
2024-03-19 15:52:27 +00:00
Joseph Vincent
6ec3ac32a5 Merge "To skip face enrollment for PS unlock setup based on intent extra" into main 2024-03-19 13:28:10 +00:00
josephpv
f9bc323633 To skip face enrollment for PS unlock setup based on intent extra
For private space lock setup as part of both PS setup and separate lock
form private space settings we need to show only traditional unlock
factors and Fingerprint but not show Face enrolment even on devices
where Face unlock is supported by hardware.
Once LSKF is enrolled it should be followed by Fingerprint enrollment
flow and after that Face enrollment should not be shown and exit lock
setup flow.

Currently for separate profile lock setup ACTION_SET_NEW_PASSWORD intent
is used in private space setup.
With this intent the options of LSKF+fingerprint+Face is shown in
devices supporting both fingerprint and face hardware. After the LSKF
ennrollment BiometricEnrollActivity is started which continues with
fingerprint and Face enrollment.

With this change we are passing an extra along with the intent to enroll
fingerprint only. Based on the intent extra value if set even if hardware
support exists the lock enrollment for the profile will support only
LSKF and fingerprint enrollment but not start Face enrollment.

User will still have the option to enroll Face from the dedicated settings
entrypoint in private space settings.

Recording link : b/323839067#comment4

Bug: 323839067
Test: Manual, verified option for face enrollment is shown or not shown
based on the intent extra. When extra is not passed the behaviour will be
default.

Change-Id: Idf92084052e02df9ca89f288c618796750e563e6
2024-03-19 11:58:08 +00:00
Chaohui Wang
732636cbd5 Merge "Refactor AutomaticDataSwitchingPreference" into main 2024-03-19 11:14:25 +00:00
Manish Singh
bb8652e1e8 Merge "Update Trusted credentials page for private profile" into main 2024-03-19 10:01:26 +00:00
Manish Singh
acafaf94b9 Merge "Support private profile in spinner adapters" into main 2024-03-19 09:54:58 +00:00
Haijie Hong
ba80f1934e Merge "Add event for Spatial Audio toggle in Settings" into main 2024-03-19 09:52:01 +00:00
Haijie Hong
b2d6c06c5c Add event for Spatial Audio toggle in Settings
Bug: 322279959
Test: atest BluetoothDetailsSpatialAudioControllerTest
Change-Id: Id0a3e4c0bcdce80c25326c83db7913a51462ef58
2024-03-19 15:29:45 +08:00
Chaohui Wang
bfd8a517be Refactor AutomaticDataSwitchingPreference
Split into AutomaticDataSwitchingPreference.kt, and use
isMobileDataPolicyEnabledFlow.

Bug: 329061940
Test: manual - Set Automatic data switching
Test: unit test
Change-Id: I878ed70328307c0a5dba6dfb461ff5a85efbcf88
2024-03-19 14:17:20 +08:00
Chaohui Wang
a3507d535f Fix APN network type not updated
The issue is caused by SettingsDropdownCheckBox's interface is updated,
but ApnNetworkTypeCheckBox not updated.

Update ApnNetworkTypeCheckBox to fix.

Bug: 329547692
Test: manual - update network type
Test: unit test
Change-Id: I4a5a1ad7d9d97960799f5ba0d89b5178ce410b6e
2024-03-19 13:59:11 +08:00
Vincent Wang
177867af12 Merge "Show calibtation result in FingerprintSettings & EnrollEnrolling if results are available" into 24D1-dev 2024-03-19 05:37:39 +00:00
George Chang
1df6f6a976 Merge "Revert "settings(dev): Remove NFC stack logging control"" into 24D1-dev 2024-03-19 05:06:34 +00:00
Vincent Wang
118abc5568 Show calibtation result in FingerprintSettings & EnrollEnrolling
if results are available

Bug: b/326155807
Test: Enroll multiple fingerprints and check if
        calibration isn't triggered.

Change-Id: I006db64f001fb70d2bb294a15a2d3efc77e2da25
Merged-In: I006db64f001fb70d2bb294a15a2d3efc77e2da25
2024-03-19 02:32:58 +00:00
yomna
5599de4fb5 Add new Cellular Network Security page
Test: m & atest CellularSecurityNotificationsDividerControllerTest CellularSecurityNotificationsPreferenceControllerTest CellularSecurityEncryptionDividerControllerTest CellularSecurityPreferenceControllerTest
Bug: b/318428717
Change-Id: I4a6ec5f47beb36bd455e04c2e6c4cea0ba65110f
2024-03-18 21:22:10 +00:00
Chun-Ku Lin
59a329cae5 Merge "Make QS shortcut type as default preferred shortcut for A11yService that associate with a TileService" into main 2024-03-18 17:20:43 +00:00
Eran Messeri
7011cfeb8b Merge "Auth-bound keys usability: Update strings" into main 2024-03-18 14:58:58 +00:00
Vincent Wang
1a498d030d Merge "Show calibtation result in FingerprintSettings & EnrollEnrolling if results are available" into main 2024-03-18 14:34:24 +00:00
Bill Lin
aee3dd3fb3 Merge "Revert "Prevent full-screen face enroll on tablet"" into main 2024-03-18 10:15:22 +00:00
Vincent Wang
6666bb97b4 Show calibtation result in FingerprintSettings & EnrollEnrolling
if results are available

Bug: b/326155807
Test: Enroll multiple fingerprints and check if
        calibration isn't triggered.

Change-Id: I006db64f001fb70d2bb294a15a2d3efc77e2da25
2024-03-18 09:07:46 +00:00
Jakub Rotkiewicz
1c4d2116da Merge "Refactor Bluetooth Codec settings to dynamic ListPreference" into main 2024-03-18 08:21:57 +00:00
chelseahao
74f65ed315 Remove flag, use new api for auto on in settings.
Test: atest com.android.settings.bluetooth
Bug: b/316822488 b/316985153
Change-Id: I8bc7651fd6e33175a3f95cce050b9a957ac6f241
2024-03-18 15:59:58 +08:00
Chaohui Wang
21d5f4160b Merge "Enforce BaseUserRestriction for DISALLOW_CONFIG_SCREEN_TIMEOUT" into main 2024-03-18 05:43:44 +00:00
Chaohui Wang
be49e61d0f Enforce BaseUserRestriction for DISALLOW_CONFIG_BRIGHTNESS
Fix: 329205638
Test: pm set-user-restriction --user 0 no_config_brightness 1
Change-Id: Icacf051789ea40d23cd29c16168fbeb204cf8f5b
2024-03-18 03:32:54 +00:00
Chun-Ku Lin
5cdf972b50 Make QS shortcut type as default preferred shortcut for A11yService that
associate with a TileService

Bug: 322712028
Test: manual (Turn on the shortcut for the first time for various
feature with or without tile. Verify only the A11yService with tile
would show QS as the shortcut when directly turn on the main shortcut
toggle)
Test: atest com.android.settings.accessibility

Flag: aconfig android.view.accessibility.a11y_qs_shortcut
Change-Id: I569b417639d2db8b7eddd818a2b9037ed4be2509
2024-03-18 00:14:43 +00:00
Manish Singh
c5e07bb662 Don't show private accounts when locked
screen recoriding - https://drive.google.com/file/d/1_QzXJgISWhiYFGOGQkqDw6ZMxlVmojH_/view?usp=drive_link&resourcekey=0-64S56eFqFukR2ez4yKQlpQ

Bug: 324574475
Test: manual
Change-Id: I08eafbd66ee81d2ea539993d2d96c28b89a6dad0
2024-03-15 17:20:17 +00:00
Manish Singh
d7ff6fe966 Support private profile in spinner adapters
Screenshot - https://screenshot.googleplex.com/35czwQHeevX75pj
Video - https://drive.google.com/file/d/1LkYPJ3i8llArnQBE3ieLPYMctEOw3xdp/view?usp=sharing&resourcekey=0-j-3-VV4OyXJKBPXwAqJvKg

Bug: 328565911
Bug: 313610609
Bug: 302082696
Test: manual
Test: atest UserAdapterTest
Test: atest StylusDevicesControllerTest
Change-Id: If8395eba5cc73809ab4abc95bc13067451c38b8f
2024-03-15 17:16:57 +00:00
Manish Singh
e5028048a0 Update Trusted credentials page for private profile
screen recording - https://drive.google.com/file/d/1XuDEkgOGSIvHlk1q5r7-EX13BGld0OWh/view?usp=sharing&resourcekey=0-FKRl_ddBn2HAkxfnV2dfKg

Bug: 307896268
Test: manual
Change-Id: Ic4b438282686704deef2a051b5c302b7fae49edc
2024-03-15 17:12:34 +00:00
Manish Singh
3b4e29e68d Merge "Return my user id" into main 2024-03-15 16:55:36 +00:00
Eran Messeri
47973b88ac Auth-bound keys usability: Update strings
Update the strings for the warning shown to the user when they are about
to remove their screen lock and there are authentication-bound keys
that would be invalidated.

These strings are provided by Android UXW.

Additionally, apply the new string to all types of device lock screen:
Pattern, password and unknown.

Bug: 302109605
Test: Manual, flashed a device and added different types of screen lock.
Change-Id: Ida6f5f16c5aa1671f3f2c1358160b8173a1d1407
2024-03-15 14:55:51 +00:00
Prince Donkor
5f35b28015 Merge "Toggle Home controls when user selects Home Control Panel Dream" into main 2024-03-15 13:35:08 +00:00
Bill Lin
0bcfc38307 Revert "Prevent full-screen face enroll on tablet"
This reverts commit 812d880ee7.

Reason for revert: Block face enrollment b/316900124

Change-Id: I457ecb7ee8babdc3a15085a1600246b0eff4bd1d
2024-03-15 13:17:40 +00:00
Manish Singh
20b7cdcda8 Return my user id
Since the current context is the correct one, we can simply return
myUserId - just like for the managed profile.

Bug: 329784721
Test: manual
Change-Id: Ifbc13b0d87ba7b06c6d04c3442bbac0580c4cf3e
2024-03-15 12:25:51 +00:00
Allen Su
4e8b442383 Merge "[ToA] Move IO to background thread" into main 2024-03-15 10:49:58 +00:00
Treehugger Robot
cef373c705 Merge "Support Private Space in battery usage." into main 2024-03-15 09:46:38 +00:00
Chaohui Wang
67579d564b New countryIfOriginLabel
And display this label as fallback when Regulatory Image is missing.

Bug: 329378943
Test: manual - on SIMs
Test: unit test
Change-Id: I0b8851da20face9ca444b3e6456a4a662b944b65
Merged-In: I0b8851da20face9ca444b3e6456a4a662b944b65
2024-03-15 09:23:31 +00:00
Chaohui Wang
167f9d4166 Merge "New countryIfOriginLabel" into main 2024-03-15 08:46:14 +00:00
Joseph Vincent
f2f44f50de Merge "Add entrypoint for Learn More in PS settings & Setup intro" into main 2024-03-15 07:39:16 +00:00
Chaohui Wang
87318b10cd New countryIfOriginLabel
And display this label as fallback when Regulatory Image is missing.

Bug: 329378943
Test: manual - on SIMs
Test: unit test
Change-Id: I0b8851da20face9ca444b3e6456a4a662b944b65
2024-03-15 15:25:55 +08:00
Allen Su
bb62c74bda [ToA] Move IO to background thread
Bug: 295826542
Bug: 312324895
Test: atest TermsOfAddressNotSpecifiedControllerTest, atest
TermsOfAddressNeutralControllerTest, atest
TermsOfAddressMasculineControllerTest, atest TermsOfAddressFeminineControllerTest

Change-Id: I45808815401f2caa24ffc03d634a4b2c90dfd55e
2024-03-15 07:23:34 +00:00
David Liu
033080b61d Fix toolbar keyboard navigation and touch.
- toolbar default has touchscreenBlocksFocus enabled which make toolbar not focusable when touch screen present. Explicitly set touchscreenBlocksFocus to false make the toolbar can be focus when keyboard navigation.
- Remove focusableInTouchMode which breaks normal touch control. Read https://android-developers.googleblog.com/2008/12/touch-mode.html for more details.

Fix: 327025582
Fix: 324420544
Test: manual test with keyboard and touch navigation

Change-Id: I6cad869e3a51926405a6f3ae894daa5416050bf8
(cherry picked from commit 9b63fbb772)
2024-03-15 06:40:57 +00:00
George Chang
b5d57eaa58 Revert "settings(dev): Remove NFC stack logging control"
This reverts commit a5bd1cf34f.

Bug: 329776725
Test: manual turn on/off debug logging.
Merged-In: I3c6026e230c7d35f04d9771442fadbf040a84b94
Change-Id: Ica004bb5f22636777287acfe1226b0f6a650d4f7
2024-03-15 05:55:41 +00:00
mxyyiyi
c9e8b8a011 Support Private Space in battery usage.
- Use database cache for single-user single-profile
- Reload battery usage info in other cases

Bug: 299032923
Test: manual
Change-Id: I5e524a094422639eedbf6e07eda498f3f72fccae
2024-03-15 11:13:34 +08:00
Chaohui Wang
18aa0c353c Merge "Filter out empty phone number" into main 2024-03-15 03:08:16 +00:00
Andy Wickham
07109c158a Allows for system navigation settings to be added dynamically.
This allows for controller-backed preferences to be added or
overridden via xml.

Similarly, if the controllers cause all of the preferences for
2 or 3 button nav to be unavailable, we hide the settings button.

Bug: 324036308
Test: Manual and unit tests
Flag: NA
Change-Id: I2371f3173076172489966728ac69c8767570cd56
2024-03-14 20:07:33 +00:00
Jakub Rotkiewicz
89612e53d7 Refactor Bluetooth Codec settings to dynamic ListPreference
Fetch supported codecs from native and present to user using
ListPreference.

Bug: 305779598
Bug: 311451118
Bug: 323319530
Tag: #feature
Test: atest SettingsRoboTests:com.android.settings.development.bluetooth.AbstractBluetoothListPreferenceController
Test: atest SettingsRoboTests:com.android.settings.development.bluetooth.BluetoothCodecListPreferenceControllerTest

Change-Id: Iedbfd01c0d1b59df8a073f4e9aedca3913e6d45f
2024-03-14 11:00:35 +00:00
Olivier Nshimiye
a4babe7463 Merge "Add enable_private_space_features flag check for Private Space implementation" into main 2024-03-14 09:48:27 +00:00