Commit Graph

1056 Commits

Author SHA1 Message Date
Bonian Chen
57998a10e6 Merge "[Settings] Code reformat" into rvc-dev am: 73d3367901 am: fcfb72f8fc
Change-Id: Ic7434542efaea8559e3f4e87a8db83b517e74e56
2020-05-07 16:50:14 +00:00
Bonian Chen
bfdf45e565 [Settings] Code reformat
Code reformat.

Bug: 155962136
Test: build pass
Change-Id: Icb56f72af925f2b47cd8867156ca12fc9a6e6347
2020-05-07 19:00:58 +08:00
Bonian Chen
cc6375e61d Merge "[Settings] Mobile network not updated based on SIM change" into rvc-dev am: 3a132d7c9a
Change-Id: Ifc2f3a614b42cb04bfeb3bd4123db0fca6fc0a3a
2020-05-07 05:07:09 +00:00
Bonian Chen
3dec052a06 [Settings] Mobile network not updated based on SIM change
SIM status and configuration change need to update the screen.

Bug: 155520761
Test: manual
Change-Id: I18f0f599b2299b1a93115a00025f0c0dd7ecb450
2020-05-06 19:20:18 +08:00
Bonian Chen
441d085d94 Merge "[Settings] Code refactor" into rvc-dev am: 1de5f2e799
Change-Id: I0e5602e0ad69b980cde0de231d30bb77595637d6
2020-05-05 16:12:38 +00:00
Bonian Chen
0065f2e460 [Settings] Code refactor
Code refactor.

Bug: 141833767
Test: manual
Change-Id: I3fa9dcc630b7612c1af3300024dee4f8deb6b308
2020-05-05 10:01:09 +00:00
TreeHugger Robot
2fb7f3e5bb Merge "Enable some settings pages to use paralleled-loading method" into rvc-dev am: 18490b2dc8
Change-Id: I7bd50f81b088c8dc1ffcf92e23dc8be06e1d0f8e
2020-05-05 09:34:13 +00:00
TreeHugger Robot
18490b2dc8 Merge "Enable some settings pages to use paralleled-loading method" into rvc-dev 2020-05-05 09:23:13 +00:00
Bonian Chen
d36b2bb72d Merge "[Settings] Refactor for performance" into rvc-dev am: cdab906c45
Change-Id: I9be77fe1909f88a43eabb876f5de8e2010354015
2020-05-05 08:43:09 +00:00
Bonian Chen
cdab906c45 Merge "[Settings] Refactor for performance" into rvc-dev 2020-05-05 08:34:01 +00:00
Treehugger Robot
703989060f Merge "Settings: Hide carrier settings version if empty" am: 04b1e2415c am: 72f8fa1c90
Change-Id: If9a837c99d37164ce48678d166f20d1821a31fdf
2020-05-05 08:30:54 +00:00
Treehugger Robot
72f8fa1c90 Merge "Settings: Hide carrier settings version if empty" am: 04b1e2415c
Change-Id: I5ed35dc059aae3c9d13f9fe02f7106ca075cf112
2020-05-05 08:15:36 +00:00
Bonian Chen
a33b11edd7 Merge "[Settings] Query historical data in background" into rvc-dev am: e017bb84ce
Change-Id: I65a99661958f8081b58b341e0573ff719d7d450a
2020-05-05 06:46:21 +00:00
TreeHugger Robot
865c74f9d6 Merge "There are two same items in manual selection page, remove one item" into rvc-dev am: c2729a517e
Change-Id: Ia44ced213f2ba547f0f64efcfaf8d9ce6bf6c6db
2020-05-05 06:46:14 +00:00
Bonian Chen
e017bb84ce Merge "[Settings] Query historical data in background" into rvc-dev 2020-05-05 06:35:39 +00:00
TreeHugger Robot
c2729a517e Merge "There are two same items in manual selection page, remove one item" into rvc-dev 2020-05-05 06:29:14 +00:00
SongFerngWang
abf31a44c8 There are two same items in manual selection page, remove one item
Bug: 155703755
Test: To check UI. PASS
Change-Id: I8c9fb80ab761599abdfd6640410fdccedec444d0
2020-05-05 03:59:15 +00:00
SongFerng Wang
004083a21f Merge "Remove the second network scan." into rvc-dev am: 28754bf6a8
Change-Id: Ic1bc6791cf56171349f81273fa9a7b7c210a194e
2020-05-05 03:33:35 +00:00
Bonian Chen
e96b23a251 Merge "[Settings] Avoid from crash" into rvc-dev am: 7ff5f56ea6
Change-Id: Iadad44a8f094c5e589409434dfc5ff54a9dc283b
2020-05-05 03:33:29 +00:00
Bonian Chen
24314ee382 Merge "[Settings] Adopt TelephonyBasePreferenceController" into rvc-dev am: fb015a3c24
Change-Id: I97309575254b6d316275f4365bc8fa102ae18447
2020-05-05 03:33:00 +00:00
SongFerng Wang
28754bf6a8 Merge "Remove the second network scan." into rvc-dev 2020-05-05 03:20:53 +00:00
Bonian Chen
7ff5f56ea6 Merge "[Settings] Avoid from crash" into rvc-dev 2020-05-05 03:17:50 +00:00
Bonian Chen
fb015a3c24 Merge "[Settings] Adopt TelephonyBasePreferenceController" into rvc-dev 2020-05-05 03:17:18 +00:00
SongFerngWang
b7f98f7667 Remove the second network scan.
Fix: 153427564
Test: make RunSettingsRoboTests ROBOTEST_FILTER=NetworkSelectSettingsTest
(PASS)

Change-Id: If593fc4a4dd463bbc178b4864ad0ba01bb421b09
2020-05-04 22:31:15 +08:00
Wang Han
f05b2d22fc Settings: Hide carrier settings version if empty
* This gives bad UX if empty as it stays copyable
   and "clickable".

Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com>
Change-Id: Ia54a1d130e77b4440753f0ce69ae1726cc2c08d9
2020-05-04 13:39:30 +02:00
Bonian Chen
32e7ea78b2 Merge "[Settings] Code refactor" into rvc-dev am: 1ab100e936
Change-Id: I091835b2c37c5dea6ad6d5bec1ef9aa586c602b2
2020-05-04 10:57:41 +00:00
Bonian Chen
7bb7200eab Merge "[Settings] Enable access from non-UI thread" into rvc-dev am: 068eb89251
Change-Id: I2174f9bfe34c5360ee3146b095c0e070efe52768
2020-05-04 10:57:34 +00:00
Bonian Chen
1ab100e936 Merge "[Settings] Code refactor" into rvc-dev 2020-05-04 10:41:47 +00:00
Bonian Chen
068eb89251 Merge "[Settings] Enable access from non-UI thread" into rvc-dev 2020-05-04 10:41:16 +00:00
Bonian Chen
9d6ba23df3 Merge "[Settings] Code refactor for availability session" into rvc-dev am: 07431066c4
Change-Id: Ie4645e45cb3318f2ae8882c2d98131994f0b7c87
2020-05-04 09:02:47 +00:00
Bonian Chen
2e5af24106 [Settings] Crash avoidance am: 017cc4e48f
Change-Id: I042c1b5332c18c780400e7ea47f70eb44b597cfc
2020-05-04 09:02:21 +00:00
Bonian Chen
07431066c4 Merge "[Settings] Code refactor for availability session" into rvc-dev 2020-05-04 08:49:21 +00:00
Bonian Chen
7ea8e7ef1e [Settings] Code refactor for availability session
Code refactor for session design of availability status config.

Bug: 141833767
Test: manual
Change-Id: Ia4982bc4036abbcff5ee1a4bba69bdf6f70ad657
2020-05-04 14:35:23 +08:00
Bonian Chen
017cc4e48f [Settings] Crash avoidance
Avoid crash when NullPointer.

Bug: 155248992
Test: manual
Change-Id: I5e4b46dcdf7ff21713b3f77fc9e20f503800b8e2
2020-05-04 14:11:09 +08:00
Bonian Chen
3d62032fed [Settings] Query historical data in background
Move the query of historical data into background thread to avoid from
blocking other query operation in UI thread,

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: I61e414d70136a0025ddd7373a4f34a99acb89510
2020-05-04 11:57:44 +08:00
Bonian Chen
d231727e3b [Settings] Code refactor
Move some work out of constructor of
EnabledNetworkModePreferenceController.
Which could avoid callbacks before init() been invoked.

Bug: 141833767
Test: make RunSettingsRoboTests -j
ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=EnabledNetworkModePreferenceControllerTest
Change-Id: I11f25d130a746c75184a21a8991177b02ad237f0

Change-Id: I6aa58a8d9d15b1524bf03f425e3eae3a0254593e
2020-05-04 11:48:09 +08:00
Bonian Chen
2a7767ee26 [Settings] Adopt TelephonyBasePreferenceController
Adopt TelephonyBasePreferenceController for better support on multi-SIM
environment.

Bug: 143996139
Test: make RunSettingsRoboTests -j
ROBOTEST_FILTER=DefaultSubscriptionControllerTest
Test: make RunSettingsRoboTests -j
ROBOTEST_FILTER=DisableSimFooterPreferenceControllerTest

Change-Id: I8a9c6efa927be1cb4a7ab4ebe816dcad9f20bd70
2020-05-04 11:23:11 +08:00
Bonian Chen
19507e7585 [Settings] Enable access from non-UI thread
To support query from settings intelligent, these listeners need to
support accessing from non-UI thread.

Bug: 149543756
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=ActiveSubsciptionsListenerTest
Change-Id: I768f41f76d0223634be2b728d33fa0cfcc69fe69
2020-05-04 11:07:41 +08:00
Bonian Chen
a9de4477e6 [Settings] Avoid from crash
Avoid from crash when updateState() performed before
displayPreference().

Bug: 141833767
Test: make RunSettingsRoboTests -j
ROBOTEST_FILTER=ApnPreferenceControllerTest

Change-Id: I4008010077c61930487fef01af306ccdfd69e38f
2020-05-04 10:59:58 +08:00
Sunny Shao
6d60248053 Enable some settings pages to use paralleled-loading method
- Here these pages include AppInfoDashboardFragment, ConnectedDeviceDashboardFragment,
  DevelopmentSettingsDashboardFragment, NetworkDashboardFragment, ConfigureNotificationSettings.
- The TimeSpentInAppPreferenceController use the LiveDataController.

Fixes: 135299529
Bug: 137558156
Test: compilation
Change-Id: I455a16536c9966184f1b2bd81d1f1217f3e09f9d
2020-05-04 10:34:23 +08:00
Treehugger Robot
ebea74264a Merge changes I6194592d,I5a02f847 am: 44146c8e3b
Change-Id: I2ebc5edd89fb32b2698c8cfd6acb20342c9cec17
2020-04-30 03:17:19 +00:00
Malcolm Chen
b6fa2277f6 Define a helper link for 5G limitation in DSDS footer. am: 5e68080b1f
Change-Id: I3377b9cbc1d4722a8a96c18f40d1118e476c4ef7
2020-04-30 03:17:16 +00:00
Treehugger Robot
44146c8e3b Merge changes I6194592d,I5a02f847
* changes:
  Add check of canConnectTo5GInDsds to show NrDisabledInDsdsFooter
  Define a helper link for 5G limitation in DSDS footer.
2020-04-30 02:56:34 +00:00
Treehugger Robot
99c2ccf984 Merge "Disable 'Mobile data' selection after removing SIM" am: 87d1e30f17 am: d6859736a4
Change-Id: I77a6c089aec6fe57f79ef7dc7f6630ee8fc68ae7
2020-04-29 23:01:07 +00:00
Treehugger Robot
d6859736a4 Merge "Disable 'Mobile data' selection after removing SIM" am: 87d1e30f17
Change-Id: I14dc87ff0f185bdbfb5734b6501f727e2cb19792
2020-04-29 22:50:24 +00:00
Grace Jia
7098379555 Disable 'Mobile data' selection after removing SIM
Bug: 153895858
Test: Manually remove SIM and test
Change-Id: I5934b01c047172ae2269e77e2fe0945aacba4ca1
Exempt-From-Owner-Approval: Telephony settings
2020-04-29 22:34:29 +00:00
Zoey Chen
e6b7e24a09 Merge "Improve the performance of displaying preference." into rvc-dev 2020-04-29 05:57:12 +00:00
zoey chen
84587b1aa3 Improve the performance of displaying preference.
- Set a variable to record the status then replace getAvailabilityStatus() with it.

Test: manual test, use command to run MobileNetworkSettings and record it.
Bug: 154061428
Change-Id: Ia13a75a3821bb6c17d0dfeffb5043f47b60adf61
2020-04-29 11:21:36 +08:00
Brad Ebinger
e6fae38169 Fix NPE if CarrierConfigManager is not available
Fixes: 155147094
Test: Test: m RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.network.telephony
Change-Id: Iecf3e385a88d18c7578eb520449f4042324e21f5
2020-04-28 11:27:27 -07:00
Yanting Yang
96127fe621 Remove sub-text from slice builder
We would like to remove all sub-text from Settings Search. But slice
view does not support API to configure the sub-text visibility.
Therefore, the only way is to remove the sub-text from slices directly.

Since Settings slices are also invoked by other apps, we can not
directly remove the sub-text.

Finally, we decide to check the caller's uid. If it comes from Settings
Search, we will return the slice without the sub-text.

Bug: 143118037
Test: visual, robotests
Change-Id: Iac72f1683a2c930592634e0599058890d86f669d
2020-04-28 14:15:16 +08:00