Commit Graph

1651 Commits

Author SHA1 Message Date
Torne (Richard Coles)
185acfc5ae Remove WebView fallback package handling.
There is no longer a special "fallback package" state for WebView that
means it should not be able to have its enabled/disabled state
controlled by the user. Remove the code used to implement this in
Settings.

Bug: 129470358
Test: verify that WebView's enable/disable button is not greyed out
Change-Id: Ifc0921511a71282a77f239e5ff5955e60fab6e2c
2019-03-28 14:11:50 -04:00
Fan Zhang
0a83cd82a1 Merge "exit app info page if app is a hidden system module." 2019-03-27 19:50:41 +00:00
TreeHugger Robot
cb79edf72d Merge "Address API council comments." 2019-03-27 19:43:36 +00:00
Fan Zhang
d646ad7778 exit app info page if app is a hidden system module.
Fixes: 120546598
Test: robotest
Change-Id: I763ce9d65904e2b0c2a6144776c42881a1269c52
2019-03-27 12:39:10 -07:00
TreeHugger Robot
f11c4c242a Merge "Change icons for disable and enable button" 2019-03-27 08:06:33 +00:00
tmfang
ebf7b888d6 Change icons for disable and enable button
Test: visual
Fixes: 124116610
Change-Id: Ia300eeba36d853117699d3bec724373df2e354d3
2019-03-27 10:53:24 +08:00
Wei Wang
1a90162afd Address API council comments.
Bug: 123587501
Test: Manual
Change-Id: I72582ca6d8da8b1fe7bc4fc1b4b4db1fad6ca7a7
2019-03-26 14:06:16 -07:00
Salvador Martinez
66320c2c47 Add a help URI for each ManageApplications subclass
This just adds the ability to add help pages to each ManageApplications
subclass. We can remove any we don't end up needing later.

Test: robotests pass
Bug: 121442558
Change-Id: I7aac30aa081d93efaa473248cf259e45ae63870c
2019-03-26 11:27:03 -07:00
TreeHugger Robot
5826f427e2 Merge "Remove shadow from "Apps and Notifications"" 2019-03-22 05:19:36 +00:00
tmfang
aed8f361fc Remove shadow from "Apps and Notifications"
- Also create a util method to reuse it in different class.

Test: visual
Fixes: 128437380
Change-Id: I0e136feed3aead8c37e381095daebded55ef298d
2019-03-22 11:08:15 +08:00
Fan Zhang
e3cee29472 Merge "Remove reference to R.id.summary_container." 2019-03-21 23:41:58 +00:00
TreeHugger Robot
55cbba6073 Merge "Use "Disable"/"Enable" for system app" 2019-03-21 04:45:23 +00:00
Fan Zhang
01bb0f9bcb Merge "Create a page to manage dnd permission for individual app" 2019-03-19 17:14:07 +00:00
tmfang
0d79b61634 Use "Disable"/"Enable" for system app
- Also modify warning message for disable dialog.

Bug: 124116610
Bug: 128769312

Test: visual
Change-Id: I2f68f51538d3dd17898aa668dae52d1d8e955ec7
2019-03-19 19:39:27 +08:00
Fan Zhang
9d98344122 Disable draw overlay for most of Settings.
Fixes: 120484087
Test: robotests
Change-Id: I1f7c8e83bd5054525bde5ca35fac55b7c9586c7c
2019-03-18 14:54:39 -07:00
Fan Zhang
5bb2a87b7f Create a page to manage dnd permission for individual app
- Change the original ZenAccessPage to
  - Remove the inline switch
  - Make the preference click target go into the new detail page
  - Some formatting/style change.

- Create a new detail page for zen access.
  - Exit if app didn't declare this permission
  - Preset the switch toggle to their current permission grant state
  - Move the warning dialog logic from ZenAccessSettings to here.

- Move some common functionality into ZenAccessController, a static
  helper class

Bug: 128547723
Test: robotest
Change-Id: I1ebb32396869d07ff4283b300bd716506298c9b5
2019-03-18 14:42:31 -07:00
TreeHugger Robot
e7668660d5 Merge "Move a few classes around for easier ownership control" 2019-03-18 12:06:30 +00:00
TreeHugger Robot
b07c5371b7 Merge "Use short format to avoid truncated problem" 2019-03-18 04:49:14 +00:00
Fan Zhang
d3b848713d Remove reference to R.id.summary_container.
It's deleted in another CL.

Fixes: 123317946
Test: visual/robo
Change-Id: I7b461ba68e8b56946e4effc26850776881236ec7
2019-03-15 15:41:47 -07:00
Fan Zhang
5db43105e8 Move a few classes around for easier ownership control
Bug: 128547723
Test: rebuild
Change-Id: I8f0dcf30fee44eaae60e10510620fb518cded68f
2019-03-15 15:32:33 -07:00
tmfang
d26e1d68fd Use short format to avoid truncated problem
Test: visual
Fixes: 126871866
Change-Id: I19db315d163a870c92215fba78f1551f025dc5d3
2019-03-09 17:54:01 +08:00
Hai Zhang
93cfd2e28e Use a boolean Consumer instead of RoleManagerCallback.
And use RemoteCallback for it under the hood. This removes one AIDL
interface and allows using lambda, while aligning with what
PermissionControllerService does.

Bug: 127691087
Test: manual
Change-Id: I7af28be2df5f84ffcd040a80884efe7c08e2d067
2019-03-08 14:33:30 -08:00
Hai Zhang
729f1bb48b Use RoleControllerService for role related APIs.
Move isApplicationQualifiedForRole() and isRoleVisible() from
PermissionControllerService to RoleControllerService.

Bug: 127691087
Test: manual
Change-Id: I87edb1bc457fbbec3d9a87054eaad5024ed91310
2019-03-07 21:33:56 -08:00
TreeHugger Robot
d8b73f832f Merge "Use PermissionControllerService.isRoleVisible() in app info shortcut." 2019-03-04 22:49:23 +00:00
Svet Ganov
cfa412f2e2 Slice and dice app ops - Settings
Update the code to only pull and query the trsuted
portion of the last/historical app op data.

Test: manual

bug:111061782

Change-Id: I55b8be1c6715ff60c7b31c80db21029fea595c8f
2019-03-01 23:20:21 -08:00
TreeHugger Robot
32924c702d Merge "Migrate all default app shortcut preference to use roles." 2019-03-01 18:34:29 +00:00
Hai Zhang
617e745c4d Use PermissionControllerService.isRoleVisible() in app info shortcut.
Use the new PermissionControllerService.isRoleVisible() to hide roles
that are not visible.

Bug: 124452117
Bug: 124457823
Test: manual
Change-Id: I4c61a2760dc62ecd8a52fba9e133e96a447c4a29
2019-02-28 17:02:43 -08:00
Hai Zhang
3064ca585e Migrate all default app shortcut preference to use roles.
Bug: 124452117
Test: build
Change-Id: I19375dc21bfcd932a263c49330dc9a040a446beb
2019-02-28 13:51:21 -08:00
Zhi An Ng
c6b4170460 Merge "Disable system alert window permissions on low ram devices" 2019-02-27 17:06:50 +00:00
TreeHugger Robot
b80a409a21 Merge "Create a preference controller for "App info"" 2019-02-27 03:02:46 +00:00
Ng Zhi An
b97bdc38da Disable system alert window permissions on low ram devices
Bug: 63697002
Bug: 117832554
Test: adb am start-activity -a
android.settings.action.MANAGE_OVERLAY_PERMISSION
Change-Id: I44c64001cd07fd4934cdc55f455384cebd5c9cfb
2019-02-26 17:58:43 -08:00
Fan Zhang
71d5e90a6e Include uid in device admin pref id.
Fixes: 124979213
Test: robotests
Change-Id: I50114db79e9b5278bc916fbbba6353c5f19df24f
2019-02-26 10:49:53 -08:00
tmfang
826879ed63 Create a preference controller for "App info"
We try to avoid managing too many preferences in a controller.
So, we create another controller to manage all apps info preference.

RecentAppsPreferenceController and AllAppsInfoPreferenceController
share same state of recent apps in order to improve the performance.

Test: visual, robo test
Fixes: 126134996
Change-Id: I1d8a175b213831415797437c64fd9d432864f9d3
2019-02-26 19:34:46 +08:00
tmfang
ac74050a7c Improve launch time for Apps & notifications page
In original design, we reload usage data at least thrice
for showing recent apps.

For now, we only reload usage data once in constuctor.
And we reload data again when we are calling updateState.

Test: Open App & notifications page, and then I compare the lauch time
with P platform device.
Fixes: 126013076

Change-Id: Ida769f28a4419125e1948e36658686ee55bf51a5
2019-02-26 15:08:22 +08:00
TreeHugger Robot
343b0211fe Merge "Add app entities widget for recently opened apps" 2019-02-23 02:15:26 +00:00
Hongming Jin
41fb813614 Merge "Migrate emegency default app to role manager." 2019-02-21 20:37:53 +00:00
tmfang
7de5314676 Add app entities widget for recently opened apps
If there is no recently opened app should be shown,
just show up an "All apps" preference.

If there are some recently opened apps, we show up
result with app entites controller.

- Clean up some useless ui. (category)
- User BasePreferenceController
- Modify test cases.

Test: robotest, visual
Change-Id: I411f61ed32eaaed97921941fd5026f1d65308d00
Fixes: 123538183
2019-02-21 16:23:18 +08:00
Hongming Jin
6c728dc924 Migrate emegency default app to role manager.
Bug: 123293861
Test: atest DefaultEmergencyPickerTest
Change-Id: I7bd9e2655b22a35fc3268091d38c6770911d4046
2019-02-20 11:46:02 -08:00
Hai Zhang
7bd98d2519 Use MATCH_ALL to query available browsers.
Browser intent resolution has been special for a long time, and we
need to pass MATCH_ALL to get all the candidates, then do manual
filtering later.

Bug: 116216651
Test: manual
Change-Id: I5e9b7b907005f73b7c54c3253c872d85ef7c4863
2019-02-20 11:28:01 -08:00
tmfang
7fb266f30b Fix janky in App info screen
If a Recycle view inside in a NestedScrollView,
The times of calling recyclerView#onCreateViewHolder()
is requal to its data set.

When there are large set of apps need to be shown,
RecyclerView will need to take many time to call
onCreateViewHolder for each item.

So, it causes the screen is janky or freeze UI when page
is loading large data set.

For now, we get rid of NestedScrollView, just use RecycleView
and AppBarLayout to have same bahavior for spinner.

Fixes: 124384314
Fixes: 123036231
Fixes: 122964660
Fixes: 123088178

Test: 1. Select show system in App info screen. Observe whether there
is any janky.
2. Select show system in App info screen, and then change device
orientation. Observer whether there is any janky.
3. Go to Settings > Apps & notifications> Advanced > Special app access >
Select "battery optimization", and then Tap drop down and select "all
apps". Observe whether ther is any janky.

Change-Id: Icd65e91eec3b32476d80cc12e9c4baa71151306a
2019-02-18 17:52:03 +08:00
Fan Zhang
7db118e367 Mass clean up: don't cast class when not needed.
Bug: none
Test: rebuild
Change-Id: Ie3f58a3d5ae99ade28a33dcac80c18de90d4d5b2
2019-02-14 12:26:09 -08:00
TreeHugger Robot
9ffe6f2d7e Merge "Use correct uid when querying usage data for specific user." 2019-02-05 22:11:04 +00:00
TreeHugger Robot
6b3db61e53 Merge "Use role for App info default phone shortcut." 2019-01-30 22:23:40 +00:00
Doris Ling
97866f0b50 Use correct uid when querying usage data for specific user.
- the data usage list shows usage data for each app, and also the
aggregated data for work apps and other user. When user clicks on the
app item, we will shows the detail usage data for that item using the
app item key. However, if the app item is not for app but for user, the
key will not be the app uid, but a key built from the user id. So,
querying using the key will not get any data.
- for app item corresponding for user, need to sum up all usage data
for the uids associated with the user.

Change-Id: I1a185ee6b4d59e477f3a03cade97d85d6982e416
Fixes: 122200400
Test: make RunSettingsRoboTests
2019-01-30 13:51:28 -08:00
TreeHugger Robot
f660e72009 Merge "Remove empty space in Usage access" 2019-01-30 07:04:25 +00:00
TreeHugger Robot
c5a42cc528 Merge "Remove dead code." 2019-01-30 03:22:09 +00:00
Fan Zhang
c3fd289969 Remove dead code.
Bug: n/a
Test: rebuild
Change-Id: I71f8d9d99bbff1186e8df518ec8d27db3447ffbe
2019-01-29 16:27:31 -08:00
tmfang
465ffcd48d Remove empty space in Usage access
When there is no need to show filter component,
we don't need to set an extra padding top.

Test: robotest, visual
Change-Id: Ieaa65ed9785a06f0737aefaf102d0c857002bbdd
Fixes: 123037802
2019-01-29 20:02:49 +08:00
TreeHugger Robot
4c6da2929f Merge "Add a More item for Special app access page." 2019-01-28 23:53:11 +00:00
Hai Zhang
912c07cf58 Add a More item for Special app access page.
This allows users to toggle non-exclusive roles, such as the temporary
SMS access (non-exclusive) role.

Bug: 110557011
Test: atest MorePreferenceControllerTest
Change-Id: Id9c0338ef2996aaa741c3da8104e867f32050f3a
2019-01-28 11:55:19 -08:00