TreeHugger Robot
5f87b783af
Merge "Fine tune the homepage scrolling behavior" into sc-v2-dev am: 244df10d90
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16182700
Change-Id: Ic2903d78e94cdf49d655b51ce84be85be9a4d634
2021-11-05 11:37:13 +00:00
TreeHugger Robot
244df10d90
Merge "Fine tune the homepage scrolling behavior" into sc-v2-dev
2021-11-05 11:22:49 +00:00
Jason Chiu
ae5327d4bb
Fine tune the homepage scrolling behavior
...
Scroll to the highlight position before showing homepage.
Bug: 199017944
Bug: 204946469
Test: visual
Change-Id: I11708f42180a3af22855ac7b5f53460f737ed208
2021-11-05 18:21:59 +08:00
Arc Wang
3a655fd1ec
[Large screen] Set SplitPairRule for DeepLinkHomepageActivity am: 82eeacf275
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16183661
Change-Id: I7369fb99dea1ecd7b00a5fb399441a1cde8b0e68
2021-11-05 09:34:51 +00:00
Arc Wang
82eeacf275
[Large screen] Set SplitPairRule for DeepLinkHomepageActivity
...
Setting app should set SplitPairRule for all the alias of
SettingsHomepageActivity to handle all the different
launch cases.
Bug: 204156913
Bug: 204399375
Test: manual
1. Launch settings in unfold screen
2. Fold screen
3. Launch wallpaper app
4. Unfold screen
Change-Id: I3ad33a750ef19390bc8dc3fb4dc6f1c80630d57f
2021-11-05 08:33:59 +00:00
TreeHugger Robot
54fec9c294
Merge "[Large screen] SplitListener may not provide correct information" into sc-v2-dev am: 672185ffe7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16183654
Change-Id: I0ec9b59130b9e5b5849cad1bd095823b45204ed3
2021-11-05 04:56:14 +00:00
TreeHugger Robot
672185ffe7
Merge "[Large screen] SplitListener may not provide correct information" into sc-v2-dev
2021-11-05 04:39:50 +00:00
Arc Wang
488f79cab5
[Large screen] SplitListener may not provide correct information
...
SettingsActivity may send Settings 2-pane deep link Intent to
SettingsHomepageActivity if split callback tells that there is no
SplitInfo.
Wallpaper app sends deep link Intent to SettingsHomepageActivity,
and then SettingsHomepageActivity starts Wallpaper app page.
The flow should be 2-pane organized but the split callback tells
that splitInfos is empty.
This change checks if the Intent is from SettingsHomepageActivity
to prevent the Intent loop by the bug.
Bug: 205206004
Test: manual
Long click Launcher -> Wallpaper & style
Change-Id: I6b9d76c136238e556384e891ae1700ae7c1bb41f
2021-11-05 11:07:33 +08:00
Joe Bolinger
ba9f4f66a8
Merge "Set a min height for pattern setup." into sc-v2-dev am: 774c2181ea
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16194774
Change-Id: I18756d98be500c0337278161909766ad157aec81
2021-11-05 03:01:18 +00:00
Joe Bolinger
774c2181ea
Merge "Set a min height for pattern setup." into sc-v2-dev
2021-11-05 02:45:07 +00:00
TreeHugger Robot
d34752cce6
Merge "Register rule for wallpaper entry" into sc-v2-dev am: 6c24e5bc33
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16180475
Change-Id: If731d818bef7f8bc3e20144ac9e45930f88ecd43
2021-11-05 01:12:45 +00:00
TreeHugger Robot
6c24e5bc33
Merge "Register rule for wallpaper entry" into sc-v2-dev
2021-11-05 01:00:08 +00:00
Joe Bolinger
e55568a7ba
Set a min height for pattern setup.
...
Fix: 194022156
Test: manual (set pattern in SUW with largest font/display size)
Change-Id: I82a0bb5aec122e9d65e4b17ea45166091deea02a
2021-11-05 00:24:36 +00:00
TreeHugger Robot
c1935f79d6
Merge "[Large screen] Check if it's in 2-pane before 2-pane deep link flow" into sc-v2-dev am: ea216fd2f3
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16151659
Change-Id: I00976f8dbb0ed7449f8bd7865bc84242c8de533f
2021-11-04 11:31:07 +00:00
TreeHugger Robot
ea216fd2f3
Merge "[Large screen] Check if it's in 2-pane before 2-pane deep link flow" into sc-v2-dev
2021-11-04 11:06:19 +00:00
Tsung-Mao Fang
b3db40a02b
Register rule for wallpaper entry
...
We should keep consistent split rule for wallpaper and other home menu
item. So, we create this cl to register the split rule for wallpaper.
Also, I do some minor refactoring in this cl for reusing existing
method and better code quality.
Test: Go to wallpaper, and click back key. App can close.
Fix: 204406425
Fix: 204364572
Change-Id: Ia7de9483b351d1121cc26c4af1cb8a89ad0a16bc
2021-11-04 18:48:59 +08:00
Arc Wang
e80b74de3a
[Large screen] Check if it's in 2-pane before 2-pane deep link flow
...
The callback of SplitStateObserver.SplitStateListener can have one
or more active splits when there is already 2-pane in Activity stack.
This change prevent unnecessary 2-pane deep link flow if the Activity
is already in 2-pane activity stack.
This solution does not work if the Activity was started in a new task.
(e.g., Intent.FLAG_ACTIVITY_NEW_TASK, launchMode singleTask).
Bug: 201379454
Bug: 201620626
Bug: 204398432
Bug: 204397936
Bug: 197609195
Bug: 197609197
Bug: 204501179
Bug: 204959335
Bug: 204845334
Test: manual
1. Settings -> Apps > Default apps > Opening links.
2. Click back button should back to Default apps page.
Change-Id: I04aaceed47a8f2754a4e17c53b49252f61e0a1d1
2021-11-04 17:20:17 +08:00
TreeHugger Robot
ac476ff63b
Merge "Remove the text for untethered bt device" into sc-v2-dev am: 8118b9ff29
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16170316
Change-Id: I89ae3ac6b59ff776e745c5885f03ff529f9c7677
2021-11-04 04:25:46 +00:00
TreeHugger Robot
8118b9ff29
Merge "Remove the text for untethered bt device" into sc-v2-dev
2021-11-04 04:08:45 +00:00
TreeHugger Robot
631c67dc8e
Merge "Add package name check for the calling app" into sc-v2-dev am: 12b7fd54ec
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16062219
Change-Id: I248616eaed0c9c3d19612d702b97e851f1847e2a
2021-11-04 03:07:48 +00:00
TreeHugger Robot
d7bd386313
Merge "To use the getLaunchedFromPackage to get the actual package name" into sc-v2-dev am: 3b84fd462f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16062214
Change-Id: Iec793d2d8f629bcb5d92cccf889e919db6450f54
2021-11-04 03:07:40 +00:00
TreeHugger Robot
12b7fd54ec
Merge "Add package name check for the calling app" into sc-v2-dev
2021-11-04 03:01:33 +00:00
Hugh Chen
ab3a70cf1e
Remove the text for untethered bt device
...
Bug: 204066796
Test: make -j64 RunSettingsRoboTests
Change-Id: I35fec4ff998332e6937fc9c360ea488b35b477f8
2021-11-04 02:52:37 +00:00
TreeHugger Robot
3b84fd462f
Merge "To use the getLaunchedFromPackage to get the actual package name" into sc-v2-dev
2021-11-04 02:51:01 +00:00
Jason Chiu
3b3203cd50
Merge "Search experience improvement for large screen" into sc-v2-dev am: 80dd47633c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16101571
Change-Id: Ib9b823860dc063f1295d329491c0f8c7f99a4d89
2021-11-03 12:23:46 +00:00
Jason Chiu
80dd47633c
Merge "Search experience improvement for large screen" into sc-v2-dev
2021-11-03 12:08:35 +00:00
Jason Chiu
e427cc6752
Search experience improvement for large screen
...
- Support fragment and direct link in SearchResultTrampoline
- Start activity for SI case and start deep link trampoline for others
- Disable menu highlight whenever the search bar is clicked
- Don't overwrite SettingsApplication's homepage activity in
SliceDeepLinkHomepageActivity
- Scroll to highlighted menu entry after homepage is loaded to prevent
UI overlapping
Bug: 201724410
Test: manual, robotest build pass
Change-Id: I5115d17d829e85036000da2e80f0e5b0598c733f
2021-11-03 18:44:01 +08:00
Wesley Wang
e67f12f9b7
Merge "Move optimization mode backup timing into onPause" into sc-v2-dev am: bf9f91f0ad
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16177444
Change-Id: I033d0ff341cae7cdb320abebfd1da765c6fa8e74
2021-11-03 06:55:06 +00:00
Jason Chiu
56dde819dc
Merge "Define a constant Sliceable#NO_RES for no resource cases" into sc-v2-dev am: 1565bba600
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16177442
Change-Id: I6a3448e6e54666b45f6f67288593034a03d50d64
2021-11-03 06:54:55 +00:00
Wesley Wang
bf9f91f0ad
Merge "Move optimization mode backup timing into onPause" into sc-v2-dev
2021-11-03 06:41:42 +00:00
Jason Chiu
1565bba600
Merge "Define a constant Sliceable#NO_RES for no resource cases" into sc-v2-dev
2021-11-03 06:38:46 +00:00
TreeHugger Robot
3be2b733f2
Merge "Adjust optimize page logging timing" into sc-v2-dev am: b4e13a7af0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16170324
Change-Id: I4639aea50ec1cdb528f4f300c59550194f89ca60
2021-11-03 05:29:56 +00:00
TreeHugger Robot
b4e13a7af0
Merge "Adjust optimize page logging timing" into sc-v2-dev
2021-11-03 05:17:40 +00:00
Wesley.CW Wang
9b6eac28f3
Move optimization mode backup timing into onPause
...
- Move to onPause to avoid some corner case (like kill apps from recent
app won't trigger onDestroy)
Bug: 195306545
Test: make SettingsRoboTests
Change-Id: I89445a7138c30e6c869ce1c5c9a3f818997d99a7
2021-11-03 12:38:10 +08:00
Jason Chiu
9fc0f18181
Define a constant Sliceable#NO_RES for no resource cases
...
Fix: 204733076
Test: build
Change-Id: Ifa3b9db0e915a3ec056ad68a9a1862811594d423
2021-11-03 12:23:49 +08:00
Wesley.CW Wang
7fb4cbf005
Adjust optimize page logging timing
...
- Log the optimize mode only when leave this page and mode changed
- Update mOptimizationMode at onResume to make sure the state is sync
with framework
Bug: 195306545
Test: make SettingsRoboTests
Change-Id: Iab116220cd7d2b1bdb1c170c4b47016c763bf4fe
2021-11-03 12:05:15 +08:00
ykhung
b85bf67314
Fix NPE issue of usage detailed page learn more button click event am: 8f0291cd1a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16174737
Change-Id: I06e12f5250b7abe8ce5546cf3c91952f6704fe6e
2021-11-02 18:13:07 +00:00
ykhung
8f0291cd1a
Fix NPE issue of usage detailed page learn more button click event
...
root cause: some OEMs can not provide valid intent for help & feedback
solution: check the intent is vaild or not before show up the help content
Bug: 204844010
Test: make RunSettingsRoboTests
Change-Id: I4e7a7c926205be1179d55d33ada345024c8a44ab
2021-11-02 16:34:34 +00:00
ykhung
00bc734b6a
Avoid intermediate touch hover effect when a11y is enabled am: ae5bddc5e5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16170323
Change-Id: Ibcf69b3ff520458b486fdecd0ec92d8983167bac
2021-11-02 10:30:50 +00:00
ykhung
ae5bddc5e5
Avoid intermediate touch hover effect when a11y is enabled
...
Bug: 201501553
Test: make SettingsRoboTests
Change-Id: I08e64a73547f71281fa94dc56ba8fe08312ebed0
2021-11-02 16:47:31 +08:00
Jason Chiu
026b1b5df6
Merge changes from topic "slice-highlight" into sc-v2-dev am: 6821b6be32
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16151654
Change-Id: Ib03d41631d8bf961fa3ff3957eb5452411da7792
2021-11-02 02:28:16 +00:00
Jason Chiu
6821b6be32
Merge changes from topic "slice-highlight" into sc-v2-dev
...
* changes:
Add highlight menu keys for all toggle pref controllers and custom slices
Support slice deep links highlighting menu entries
2021-11-02 02:14:09 +00:00
TreeHugger Robot
cdf991a7ba
Merge "Revert "Update animation for fingerprint edu page"" into sc-v2-dev am: faf0721f2c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16167410
Change-Id: Iea2d9bad655ee100c9aba65310307e8c988cfa7e
2021-11-01 21:52:44 +00:00
TreeHugger Robot
faf0721f2c
Merge "Revert "Update animation for fingerprint edu page"" into sc-v2-dev
2021-11-01 21:37:29 +00:00
Daniel Chapin
ba0a012b57
Revert "Update animation for fingerprint edu page"
...
Revert submission 16091075-update_lottie_fp_edu
Reason for revert: Droidfood Blocking Bug: 204719520
Reverted Changes:
I0c3b1ad93:Update animation for fingerprint edu page
Id07ee17fa:Update animation for fingerprint edu page
Change-Id: I0f301491c2b526443a40b916ac2d98093d80a759
2021-11-01 19:36:00 +00:00
Bonian Chen
7f94d2ba0e
Merge "[Crash] finish activity without super#onResume()" into sc-v2-dev am: 5d1400f8b2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16005289
Change-Id: I2b2c907e8341e1b80cc6145998dccc7a5dfab8cf
2021-11-01 14:06:24 +00:00
Bonian Chen
5d1400f8b2
Merge "[Crash] finish activity without super#onResume()" into sc-v2-dev
2021-11-01 13:56:03 +00:00
TreeHugger Robot
137f9acac1
Merge "Optimize battery optimize page control flow" into sc-v2-dev am: c6a5bcc933
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16138630
Change-Id: Ic9d497517b6778c413909917d485575a054dc331
2021-11-01 08:07:13 +00:00
TreeHugger Robot
c6a5bcc933
Merge "Optimize battery optimize page control flow" into sc-v2-dev
2021-11-01 07:53:21 +00:00
Jason Chiu
2989c50a23
Add highlight menu keys for all toggle pref controllers and custom slices
...
Bug: 204695404
Test: manual, robotest build pass, unit
Change-Id: Iad2e28ada8ddb766ffa7eff2c8dc581250cbd6f8
2021-11-01 15:00:18 +08:00