Mill Chen
5d0f4efcfa
Merge "Add subtitle for Do not disturb" into qt-dev am: cf9b3d2e87
...
am: 8350576f01
2019-04-17 02:21:51 -07:00
Mill Chen
992f431b1e
Merge "Remove On/Off string from Night light slice" into qt-dev am: 0ce66b9329
...
am: bc8089527d
2019-04-17 02:20:46 -07:00
Mill Chen
8350576f01
Merge "Add subtitle for Do not disturb" into qt-dev
...
am: cf9b3d2e87
2019-04-17 02:16:51 -07:00
Mill Chen
bc8089527d
Merge "Remove On/Off string from Night light slice" into qt-dev
...
am: 0ce66b9329
2019-04-17 02:15:47 -07:00
TreeHugger Robot
cf9b3d2e87
Merge "Add subtitle for Do not disturb" into qt-dev
2019-04-17 09:08:17 +00:00
TreeHugger Robot
0ce66b9329
Merge "Remove On/Off string from Night light slice" into qt-dev
2019-04-17 09:03:07 +00:00
Arc Wang
0e248383c1
Merge "Hide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network" into qt-dev am: a713243db4
...
am: 0045e34d84
2019-04-16 22:27:34 -07:00
Alex Salo
77b5cf96cb
Merge "Check for attention permissions" into qt-dev am: e991b05b29
...
am: 7e3a9da21b
2019-04-16 21:27:29 -07:00
Arc Wang
0045e34d84
Merge "Hide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network" into qt-dev
...
am: a713243db4
2019-04-16 19:30:54 -07:00
Alex Salo
7e3a9da21b
Merge "Check for attention permissions" into qt-dev
...
am: e991b05b29
2019-04-16 18:42:44 -07:00
Arc Wang
a713243db4
Merge "Hide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network" into qt-dev
2019-04-17 01:07:12 +00:00
lindatseng
5ab057a9ec
Merge "Enforce min value on panel slices slider" into qt-dev am: cef4e42dc2
...
am: 4c9bf6de55
2019-04-16 17:26:01 -07:00
Lei Yu
73a2b49860
Merge "Hide Mobile preference for secondary user" into qt-dev am: ad06c36882
...
am: 8f9c60652f
2019-04-16 16:32:40 -07:00
Linda Tseng
f99fb5cf55
Merge "Add entry animation to Settings Panels." into qt-dev am: 71df263db9
...
am: 668055d8e5
2019-04-16 15:19:56 -07:00
lindatseng
4c9bf6de55
Merge "Enforce min value on panel slices slider" into qt-dev
...
am: cef4e42dc2
2019-04-16 15:07:26 -07:00
TreeHugger Robot
e991b05b29
Merge "Check for attention permissions" into qt-dev
2019-04-16 22:02:43 +00:00
Lei Yu
8f9c60652f
Merge "Hide Mobile preference for secondary user" into qt-dev
...
am: ad06c36882
2019-04-16 14:48:35 -07:00
TreeHugger Robot
cef4e42dc2
Merge "Enforce min value on panel slices slider" into qt-dev
2019-04-16 21:18:05 +00:00
Linda Tseng
668055d8e5
Merge "Add entry animation to Settings Panels." into qt-dev
...
am: 71df263db9
2019-04-16 13:51:55 -07:00
Lei Yu
ad06c36882
Merge "Hide Mobile preference for secondary user" into qt-dev
2019-04-16 20:47:17 +00:00
Lei Yu
a595b19f79
Merge "Disable Mobile settings in one condition." into qt-dev am: 421ca22a58
...
am: c53b29300a
2019-04-16 13:46:49 -07:00
Salvador Martinez
1a9366230e
Merge "Change dark theme screen to toggle" into qt-dev am: 3b8a0b82bf
...
am: 5e44955e57
2019-04-16 13:31:50 -07:00
Yi-Ling Chuang
3ae9c00186
Merge "Hide filter spinner when data is loading." into qt-dev am: 03c461b3ee
...
am: 95a850bc64
2019-04-16 13:22:55 -07:00
Lei Yu
c53b29300a
Merge "Disable Mobile settings in one condition." into qt-dev
...
am: 421ca22a58
2019-04-16 12:24:50 -07:00
Salvador Martinez
5e44955e57
Merge "Change dark theme screen to toggle" into qt-dev
...
am: 3b8a0b82bf
2019-04-16 12:15:34 -07:00
Yi-Ling Chuang
95a850bc64
Merge "Hide filter spinner when data is loading." into qt-dev
...
am: 03c461b3ee
2019-04-16 12:07:59 -07:00
Linda Tseng
71df263db9
Merge "Add entry animation to Settings Panels." into qt-dev
2019-04-16 18:57:47 +00:00
TreeHugger Robot
421ca22a58
Merge "Disable Mobile settings in one condition." into qt-dev
2019-04-16 18:20:11 +00:00
TreeHugger Robot
3b8a0b82bf
Merge "Change dark theme screen to toggle" into qt-dev
2019-04-16 18:16:54 +00:00
Yanting Yang
d264cd1f78
Merge "Clean up NotificationChannelSlice" into qt-dev am: 1fa45975eb
...
am: 18e0119391
2019-04-16 11:12:28 -07:00
TreeHugger Robot
03c461b3ee
Merge "Hide filter spinner when data is loading." into qt-dev
2019-04-16 18:07:24 +00:00
Raff Tsai
26bc6a9137
Merge "Tint battery fix icon" into qt-dev am: 77c56714ed
...
am: fbab258c8b
2019-04-16 10:53:05 -07:00
Alex Salo
c821ae1ee6
Check for attention permissions
...
If attention package does not have sufficient permissions - disable the
setting.
Bug: 130246574, 130350903
Test: make RunSettingsRoboTests and manually confirmed
Change-Id: Ia7a86c940522e72f7e895d6aec7500f1ef6f9889
2019-04-16 17:43:15 +00:00
Yanting Yang
18e0119391
Merge "Clean up NotificationChannelSlice" into qt-dev
...
am: 1fa45975eb
2019-04-16 10:25:53 -07:00
Raff Tsai
fbab258c8b
Merge "Tint battery fix icon" into qt-dev
...
am: 77c56714ed
2019-04-16 10:13:51 -07:00
TreeHugger Robot
1fa45975eb
Merge "Clean up NotificationChannelSlice" into qt-dev
2019-04-16 16:31:22 +00:00
lindatseng
fadedb321c
Enforce min value on panel slices slider
...
We did not set the min value on slider slices when converting them
from preference to slices, which makes the slices all have min 0.
However, there are some slider which should have min value greater
than 0, for example, call and alarm.
We should get the min value and apply it to slider slice to make it
consistent with what we have in settings pref.
Test: Manual verification
Test: make -j40 RunSettingRobotests
Test: atest VolumeSeekBarPreferenceControllerTest
Fixes: 130439216
Fixes: 130358208
Change-Id: Ib4399c36c7da3ac41a6d46a6c150f0ec1b9b0b0f
2019-04-16 16:30:08 +00:00
Matthew Fritze
b6fdd25c23
Add entry animation to Settings Panels.
...
Settings Panels as a dialog have a default animation for entering the
screen, but Slices complicate the animation. While the dialog enters the
screen, Slices begin to bind, thus changing the height of the dialog as
it enters, causing perceived bounce / jank in the animation.
This CL is cherry-picked/based on ag/6671083 but do the following modification:
(See the original commit message for the whole concept)
When trying to load all the Slices, there are few possible situations:
1. Slice starts loading slowly, starting at state LOADED_NONE
2. Slice is loading in progress, having state LOADED_PARTIAL
3. Slice is loaded, but there's error return from the Slice data (We don't
need to show the Slice in this case)
4. Slice is loaded, progress to state LOADED_ALL
5. Slice starts from state LOADED_NONE, but never progress to the next state
because it crashes at setting backend.
Notice that there are two cases that the state will stay at LOADED_NONE and
we can't distinguish them.
Hence, we decide to do the following:
If Slice is with error (case 3) we remove the slice from the list and mark it
loaded.
If Slice is loaded with LOADED_ALL (case 4, which is the ideal case), we mark
it as loaded.
In the other cases, we fire a handler to mark the slice loaded anyway after
250ms timeout.
When all the slices are marked loaded (which should happen after 250ms timeout,
we will animate the panel out. Although there might be slices which are still
partial loaded, we can still have the slice in the panel once it is ready.
The panel might bounce/jank in this case, but at least it will still showing
correctly, and should show up smoothly in most cases.
The solution to this problem is twofold:
1. Load all Slices first
2. Create a custom animation to draw the panel once the recyclerview has
been laid out.
Test: Manual/Visual inspection
Test: make -j40 RunSettingsRobotests
Bug: 123942159
Change-Id: I639a707aa4ba3f906bd6f9752c92727aaba28142
2019-04-16 16:29:04 +00:00
TreeHugger Robot
77c56714ed
Merge "Tint battery fix icon" into qt-dev
2019-04-16 16:25:34 +00:00
Fan Zhang
4c0cf18c4d
Merge "Correct the state when prevent ringing page is launched." into qt-dev am: 957da73a7d
...
am: 7f7b9e7736
2019-04-16 08:45:18 -07:00
Amin Shaikh
f1cf5a684f
Merge "Create TintDrawable in Settings." into qt-dev am: c4e7cf594c
...
am: 900d8c9e12
2019-04-16 08:38:38 -07:00
Fan Zhang
7f7b9e7736
Merge "Correct the state when prevent ringing page is launched." into qt-dev
...
am: 957da73a7d
2019-04-16 08:33:30 -07:00
Amin Shaikh
900d8c9e12
Merge "Create TintDrawable in Settings." into qt-dev
...
am: c4e7cf594c
2019-04-16 08:28:24 -07:00
Fan Zhang
957da73a7d
Merge "Correct the state when prevent ringing page is launched." into qt-dev
2019-04-16 15:22:26 +00:00
TreeHugger Robot
c4e7cf594c
Merge "Create TintDrawable in Settings." into qt-dev
2019-04-16 15:16:26 +00:00
Yanting Yang
ce3359f4d4
Clean up NotificationChannelSlice
...
- Remove unused variable.
- Change function interface.
Bug: 123065955
Test: visual, robotests
Change-Id: I39c0a92539d45cdbc11bd9090a3ab97a72482632
2019-04-16 23:08:40 +08:00
Lei Yu
4ee2e00c18
Merge "Add remote volume slider conditionally." into qt-dev am: ee6825fd5b
...
am: 65628c28a9
2019-04-16 06:15:00 -07:00
Lei Yu
65628c28a9
Merge "Add remote volume slider conditionally." into qt-dev
...
am: ee6825fd5b
2019-04-16 05:58:13 -07:00
TreeHugger Robot
ee6825fd5b
Merge "Add remote volume slider conditionally." into qt-dev
2019-04-16 12:46:55 +00:00
Chandan Nath
1e89e94ad8
Merge "If backup service is not available, remove Settings->Backup and Backup->"Backup is disabled by admin" from search results." into qt-dev am: 2ec2c6330e
...
am: 552c951808
2019-04-16 04:51:48 -07:00
