- If only has the default carrier config just return, to
avoid popping up the the VoLTE screen when it's disabled
by the carrier.
Bug: 332647055
Test: manual
Flag: NONE bugfix
Change-Id: I71bc02f5044535d48726a531e36d57df73bc0f5f
If activity is finishing or destroyed, getting activity context will return null results in settings app force close.
Do not call scan callback if network select activity is finishing or destroyed.
Test: build pass and run NetworkSelectSettingsTest unit test pass.
Bug: 372123288
Change-Id: I28307490c75fe04d54dcf1637f33f4b9ba1fe635
This reverts commit 2545f06558.
Reason for revert: DroidMonitor created revert due to b/374650528.Will be verified through ABTD for standard investigation.
Change-Id: Ifa3f061b7954dc2b5780b768fefb9358c597fdc0
If activity is finishing or destroyed, getting activity context will return null results in settings app force close.
Directly return if network select activity is finishing or destroyed when handling network scan callback.
Bug: 372123288
Change-Id: Ia8c89569761b66da58cafd0140ceda29ac7d678c
The root cause is SubscriptionManager.OnSubscriptionsChangedListener
.onSubscriptionsChanged() not invoked in some cases.
Even the SubscriptionManager.addOnSubscriptionsChangedListener's doc
says the onSubscriptionsChanged() method will also be invoked once
initially when calling it, there still case that the
onSubscriptionsChanged() method is not invoked initially.
For example, when the onSubscriptionsChanged event never happens before,
on a device never ever has any subscriptions.
Adding a .onStart { emit(Unit) } to fix.
Also make the subscriptionsChangedFlow() a shared flow to mitigate the
extra emit cost.
Bug: 369276595
Flag: EXEMPT bug fix
Test: manual - factory reset & no any sim
Test: atest SubscriptionRepositoryTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9969334647b4b9439f549c0c0b2543fb3dec8813)
Merged-In: Ic32a5666f14373926b5dfedb5dedadb4369acfc7
Change-Id: Ic32a5666f14373926b5dfedb5dedadb4369acfc7
When startSimOnboardingActivity, so we enforce the
no_config_mobile_networks when insert psim.
Fix: 366370519
Flag: EXEMPT bug fix
Test: manual - set no_config_mobile_networks and insert psim
Change-Id: I0d4e85262924cc55a035ebeb2038ae08c0052ef6
If disallowed, not show mobile related search results.
Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search Mobile Settings
Test: atest MobileNetworkSettingsSearchIndexTest
Change-Id: I79b984f41f09dd9612bcd0c9942089756d5d365d
- Phone process may not exist in some situation. It shall catch the
exception to avoid Settings crash.
Flag: EXEMPT bugfix
fix: 365669913
Test: build pass
Change-Id: I2b95f46b8887a9c8416fb4a5724537ad27e86850
For MobileNetworkSummaryController to use, so it no longer use
MobileNetworkRepository.
Fix: 366097262
Flag: EXEMPT refactor
Test: manual - on Network & internet
Test: atest MobileNetworkSummaryRepositoryTest
Change-Id: I8a9d52af8e230fc407a4339c27f73ef79d512b24
Which unifies whether we should sim settings on some related pages.
Before this change, we check SubscriptionUtil.isSimHardwareVisible()
and / or Utils.isWifiOnly().
After this change, we unified logic to,
canChangeSimSettings() =
packageManager.hasSystemFeature(PackageManager.FEATURE_TELEPHONY) &&
userManager.isAdminUser
Fix: 365924140
Flag: EXEMPT bug fix
Test: manual - check Network & internet
Test: unit tests
Change-Id: Ibf83237e3d0088f78c96a1b39ee8f1e3a9c756ea
Which can be used in MobileNetworkSummaryController in the future.
Bug: 366097262
Flag: EXEMPT refactor
Test: manual - check Network & internet
Test: unit tests
Change-Id: Ia74af993646c2e1d53817f1e9f8ac3ef0b8fa97a
- Since the posspoint Wi-Fi entry can be connected even if the entry is not saved
- Allow to launch Wi-Fi details when the entry is connected but not saved
Bug: 363151879
Flag: EXEMPT bugfix
Test: Manual testing
atest -c NetworkProviderSettingsTest
Change-Id: I004b8a33bdd07cb92e167039949919f255c5303e
To avoid the dsds dialog status to reset.
Bug: 364668360
Test: verify enabling DSDS mode
Flag: EXEMPT bugfix
Change-Id: I80a8abd896856740fad1f98de50c79034a4cc602
The error dialog text for SIM switching is not accurate.
This CL updates the error dialog text for SIM switching.
Bug: 363265948
Change-Id: I8b0348fc791cc4d4ce84e1b33f1fe99fb4e03ed7
Test: NA
Flag: EXEMPT bugfix
Currently, this setting depends on whether wifi calling is supported,
since wifi calling could takes some time to provision after sim is
turned on, this state could be wrong when set cross sim calling.
Use wifiCallingReadyFlow() to retrieve the latest state, and update
setting when state changes.
Fix: 352736998
Fix: 348529996
Flag: EXEMPT bug fix
Test: manual - by turn on / off sim
Change-Id: Id4b099e0c5d7cf47b007f37e6f278d1c46e58659
Use this instead of mSubscriptionInfoEntity, so MobileNetworkSettings
not closed unexpectedly.
Bug: 358238959
Flag: EXEMPT bug fix
Test: force stop settings & settings search - mobile settings
Test: adb shell am start -a android.settings.NETWORK_OPERATOR_SETTINGS
Change-Id: I34286da808600d8b9faa0da85a59665707ecfde3
When sub id is invalid.
Bug: 325956182
Flag: EXEMPT bug fix
Test: adb shell am start -a android.settings.NETWORK_OPERATOR_SETTINGS
Change-Id: I09995095e2f38030eca0c9b5898d910530ee6237
Currently in TelephonyProvider, it uses tm.getSimSpecificCarrierId() to
get the specific carrier id to retrieve the apns, update Settings to
match.
Fix: 360917123
Flag: EXEMPT bug fix
Test: manual - new apn
Test: atest ApnRepositoryTest
Change-Id: I982e0026acdf34ccec7508c41f83718894f7da57
And also the flag.
Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - Network & internet
Change-Id: Icb3427f6624db0442c05f5e149dbe522d1497e83
Also support settings search for video calling.
Fix: 233327342
Flag: EXEMPT bug fix
Test: manual - on mobile settings
Test: manual - search video calling
Test: unit test
Change-Id: Ic4a25849f77f1759fa157931d428daa9e6854ff2
Which also avoid calling from main thread.
Bug: 356684993
Flag: EXEMPT bug fix
Test: manual - on SIMs
Test: atest EuiccRepositoryTest
Change-Id: I0b11b0bd1e8a4b5754781e888fd220fa3080a212
getProvisioningStatusForCapability still need the IllegalArgumentException when the subId is -1.
Bug: 346600036
Test: manual test. Disable sim and the settings did not crash.
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:37e1d258f88c5129035501d6ced1dab6627da102)
Merged-In: Ib5c41ab9214cf34a17ef02864dccffb5371cfe3a
Change-Id: Ib5c41ab9214cf34a17ef02864dccffb5371cfe3a
getProvisioningStatusForCapability still need the IllegalArgumentException when the subId is -1.
Bug: 346600036
Test: manual test. Disable sim and the settings did not crash.
Flag: EXEMPT bugfix
Change-Id: Ib5c41ab9214cf34a17ef02864dccffb5371cfe3a
The ProvisioningManager.getProvisioningStatusForCapability() throws UnsupportedOperationException when the capability is not supported.
Bug: 346600036
Test: NA
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:370445b773aa7ec69c83904dfdcd2e8f182bb777)
Merged-In: Ib682b336fdfc4c79a8b3e2fa5ccac8fe9c4e7ba1
Change-Id: Ib682b336fdfc4c79a8b3e2fa5ccac8fe9c4e7ba1
The ProvisioningManager.getProvisioningStatusForCapability() throws UnsupportedOperationException when the capability is not supported.
Bug: 346600036
Change-Id: Ib682b336fdfc4c79a8b3e2fa5ccac8fe9c4e7ba1
Test: NA
Flag: EXEMPT bugfix
To be shared with video calling and VoLTE features.
Bug: 233327342
Flag: EXEMPT bug fix
Test: manual - on Mobile Settings
Test: atest ImsFeatureRepositoryTest
Change-Id: Ic7bcb532c4bd32c6f7ac4af1eebdd8a70a86ff29
