Commit Graph

3588 Commits

Author SHA1 Message Date
Nikhil Nayunigari
487a4774d1 Add ethernet interface details settings subpage
Adds a click listener to the ethernet interface row and displays a
settings subpage with interface connection status.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest SettingsRoboTests:
com.android.settings.network.NetworkProviderSettingsTest

Change-Id: Id64ce3657b47dd4ca70d425dd3d13227c8468d2c
2025-02-19 04:55:22 +00:00
Nikhil Nayunigari
0afd3f64a5 Merge "Display one row item per Ethernet interface" into main 2025-02-18 15:39:43 -08:00
Liana Kazanova (xWF)
a17dfe4ecc Merge changes from topic "revert-31790253-UHOKZZQOPA" into main
* changes:
  Revert "Make Satellite UI updatable during receiving callback (P..."
  Revert "Modify the default satellite category title."
2025-02-18 10:46:03 -08:00
Nikhil Nayunigari
25c5971e89 Display one row item per Ethernet interface
This change adds a preference category to host rows for ethernet
interfaces.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest
SettingsRoboTests:
com.android.settings.network.NetworkProviderSettingsTest

Bug: 369889610

Change-Id: Idb37cbf17f06db2c9a217659affb35d9dcebadf3
2025-02-18 09:41:49 -08:00
Liana Kazanova (xWF)
790fa6e00e Revert "Make Satellite UI updatable during receiving callback (P..."
Revert submission 31790253

Reason for revert: DroidMonitor: Potential culprit for http://b/397368653 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:31790253

Change-Id: I851046019821fff0d132efb0b00cbff1e3ecbe72
2025-02-18 09:35:50 -08:00
Hakjun Choi
0be57cf311 Merge "Clean up aconfig flag carrier_enabled_satellite_flag" into main 2025-02-18 03:29:48 -08:00
Treehugger Robot
8fda02a7de Merge "Fix crash due to display name is not set to View." into main 2025-02-18 03:11:16 -08:00
tom hsu
04006ccb48 Fix crash due to display name is not set to View.
Flag: EXEMPT bug fix
Fix: b/396700275
Test: manual test
Change-Id: I2a70c4e31c182f99cc4fb3da93ce7911da005429
2025-02-18 10:04:34 +00:00
Hakjun Choi
1a53ea7a05 Clean up aconfig flag carrier_enabled_satellite_flag
Bug: 393951373
FLAG: EXEMPT flag clean up
Test: atest NetworkSelectSettingsTest WifiCallingSettingsForSubTest SatelliteSettingsPreferenceControllerTest
Test: manual test in live network
Change-Id: I154e9be8a8c771fafb37af078be7b495f18b6100
2025-02-18 08:41:14 +00:00
Aleksander Morgado
c9aaa03d7b Merge changes from topic "settings-visibility-return-fixes" into main
* changes:
  Return DISABLED_FOR_USER in deviceinfo/simstatus availability if not admin user
  Return UNSUPPORTED_ON_DEVICE in deviceinfo/simstatus when no telephony
  Added unit tests for SimStatusPreferenceController visibility
  Return DISABLED_FOR_USER in IMEI availability if not admin user
  Return UNSUPPORTED_ON_DEVICE in network/imei when no telephony
  Added unit test for MobileNetworkImeiPreferenceController visibility
  Added unit tests for ImeiInfoPreferenceController visibility
  Return UNSUPPORTED_ON_DEVICE in network/phonenumber when no telephony
2025-02-18 00:10:26 -08:00
tom hsu
9df2e6fdc9 Make Satellite UI updatable during receiving callback (Part II)
- Refactor code
 - Make Satellite category and preference be updatable by callback.

Flag: EXEMPT bug fix
Fix: b/396233604
Fix: b/382664790
Test: atest pass
Change-Id: I55423317d82589312ce4a2f851b32b242529e922
2025-02-18 06:32:33 +00:00
tom hsu
048be18c5e Make Satellite UI updatable during receiving callback (part I)
- Refactor code
 - Make Satellite category and preference be updatable by callback.

Flag: EXEMPT bug fix
Fix: 396233604
Test: atest pass
Change-Id: If2e3d9b82950f05c4911ee7ce3bb41fb26e0d3e4
2025-02-18 06:19:47 +00:00
tom hsu
543e446150 Fix test error of SatelliteSettingsPreferenceControllerTest
- Root cause is wrong Resouce string got.

Flag: EXEMPT bug fix
Fix: b/396571641
Test: atest passed
Change-Id: I25a4c7fff0ea20ab3c6e7fde99e1fba2b0288dfd
2025-02-17 11:28:47 +00:00
Aleksander Morgado
64fb695d9b Return DISABLED_FOR_USER in IMEI availability if not admin user
The correct return when checking for the IMEI field availability
for non-admin users is DISABLED_FOR_USER.

UNSUPPORTED_ON_DEVICE should only be used when the setting is
unconditionally hidden as the device does not support the feature.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest ImeiInfoPreferenceControllerTest
Test: atest MobileNetworkImeiPreferenceControllerTest

Change-Id: I4ee89a84953993daad539d33d3a2e576540c580f
2025-02-17 00:44:30 -08:00
Aleksander Morgado
2a0ad1efdf Return UNSUPPORTED_ON_DEVICE in network/imei when no telephony
If the device does not have any telephony support (either via the
build-time config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag),
returning UNSUPPORTED_ON_DEVICE makes more sense than
CONDITIONALLY_UNAVAILABLE, as there is no runtime change that would
make it available.

This change also aligns the behavior with the deviceinfo/imei
entry.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest MobileNetworkImeiPreferenceControllerTest
Change-Id: Ia01cf3812f8343eabd8ea6970b691ac71432e8bd
2025-02-17 00:44:30 -08:00
Aleksander Morgado
a66d27c488 Return UNSUPPORTED_ON_DEVICE in network/phonenumber when no telephony
If the device does not have any telephony support (either via the
build-time config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag),
returning UNSUPPORTED_ON_DEVICE makes more sense than
CONDITIONALLY_UNAVAILABLE, as there is no runtime change that would
make it available.

This change also aligns the behavior with the deviceinfo/phonenumber
entry.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: I5f2392969fad1884a89de3870ad37be5601fbe37
2025-02-17 00:44:30 -08:00
Nikhil Nayunigari
2c90d30415 Merge "Changes to add Ethernet settings row item" into main 2025-02-15 11:46:13 -08:00
Nikhil Nayunigari
bfd3722e06 Changes to add Ethernet settings row item
Adds EthernetSettings row item to NetworkProviderSettings and its
controller.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest
SettingsRoboTests:
com.android.settings.network.EthernetSwitchPreferenceControllerTest

Change-Id: I27965ad0c8563657b17e0aa6d3bd19b97fcf5615
2025-02-15 18:20:46 +00:00
tom hsu
bb80fe2df1 [Satellite Settings] Show device's app info on Satellite settings page.
- Shows device apps' info up to 3 on Satellite settings' page.
 - Add a new page to show all device's app info with Satellite supported.

Flag: com.android.internal.telephony.flags.satellite_25q4_apis
Fix: b/395813844
Test: atest pass
Change-Id: Ibd5e1c74b636639082ec9477f2b6796bcbc8340d
2025-02-14 06:40:10 -08:00
tom hsu
63242bc3ff [Satellite Settings] Add a new API to SatelliteRepository
Flag: com.android.internal.telephony.flags.satellite_25q4_apis
Bug: b/395813844
Test: atest pass
Change-Id: Ife9e370dbcb3694adfd0bfbcc2ec2a742fbc4434
2025-02-14 06:39:45 -08:00
SongFerng Wang
b7d640ef36 Merge "Check if ECBMode when activate SIM card" into main 2025-02-13 18:41:42 -08:00
songferngwang
538fb34027 Check if ECBMode when activate SIM card
If in ECBMode, start ACTION_SHOW_NOTICE_ECM_BLOCK_OTHERS to show a
dialog instead.

This align with the deactivate sim case

Bug: 393298086
Test: atest SubscriptionActivationRepositoryTest
Test: adb shell cmd phone emergency-callback-mode
Flag: EXEMPT bugfix
Change-Id: Id40d087b7d2d3ca99504ec75bac1c5e29c67258d
2025-02-13 12:04:07 +00:00
Aleksander Morgado
bd56a0efd3 Merge changes from topic "hide-phone-number" into main
* changes:
  Phone number only available if telephony capable
  Phone number only available for admin users
  Added unit test for MobileNetworkPhoneNumberPreferenceController visibility
  Added unit tests for PhoneNumberPreferenceController visibility
2025-02-13 00:06:32 -08:00
Treehugger Robot
793a6802ac Merge "Fix accessibility issues in Private DNS Settings" into main 2025-02-12 21:08:22 -08:00
Weng Su
b3938a0244 Fix accessibility issues in Private DNS Settings
- Keep the Save button enabled at all times

- Show error in the Hostname view to remind the user
  - "The field is required" error
  - "The hostname you typed isn't valid" error

Bug: 386323822
Flag: EXEMPT bugfix
Test: Manual testing
atest -c PrivateDnsModeDialogPreferenceTest \
         PrivateDnsPreferenceControllerTest

Change-Id: I63973bd5001b838d7f27827e6a6d4ac96ac78ca9
2025-02-13 12:05:25 +08:00
SongFerng Wang
b8388cd90f Merge "Fix popping up the the VoLTE screen when it's disabled by the carrier." into main am: 9dc07f4e19 am: 4fec2b9e47
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3481415

Change-Id: I195bc0554e509f1cf3a391609a77f934f1cbdb80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-12 19:42:39 -08:00
Aleksander Morgado
731df0fa98 Phone number only available if telephony capable
The Phone Number field in either the about or network details pages
should not be shown if the device does not have telephony
capabilities.

Bug: 392808943
Flag: EXEMPT bugfix
Test: atest PhoneNumberPreferenceControllerTest
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: I04f682cc829d5dc7879e6cdacdaebc55a3b6fd2c
2025-02-11 18:43:40 +00:00
Aleksander Morgado
571103b891 Phone number only available for admin users
The phone number is hidden to non-admin users, following the same
reasoning that exists for other telephony-specific fields like the
baseband IMEI.

Bug: 392808943
Flag: EXEMPT bugfix
Test: atest PhoneNumberPreferenceControllerTest
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: I4e612219d0c7439930e91b3e1d6e368a0dfd073e
2025-02-11 18:30:42 +00:00
Jacky Wang
a2e663dadd [Catalyst] Move PreferenceRestrictionMixin
NO_IFTTT=Catalyst only

Bug: 377600992
Flag: EXEMPT refactor
Test: atest
Change-Id: I3c26a5a56d8fd6e887e4ff4d38d8e8eb97844672
2025-02-11 20:18:43 +08:00
Jacky Wang
afbcf06654 [Catalyst] Move metrics class
NO_IFTTT=Catalyst only

Bug: 389886085
Flag: EXEMPT refactor
Test: atest
Change-Id: I8c24a4edf768aa2286adf66f16077e962080bb48
2025-02-11 20:18:30 +08:00
SongFerng Wang
30af231cc4 Merge "Handle the sim switch for restricted ss mode case" into main 2025-02-10 20:25:41 -08:00
Treehugger Robot
1b1fa4810f Merge "[Satellite] Add satellite string for KDDI if no entitlement" into main 2025-02-10 19:30:27 -08:00
songferngwang
2d5a231a46 Handle the sim switch for restricted ss mode case
The restricted ss mode case is the device lock the sim switch function
in the single sim mode. For this case, UI did not use sim onboarding
flow, and use the sim switch dialog.

Bug: 393151990
Test: verify the sim switch function in the restricted ss mode.
Flag: EXEMPT bugfix
Change-Id: I04439f254010052c78a702618d972a9cf54cece0
2025-02-11 02:26:46 +00:00
tom hsu
292f1bdd01 [Satellite] Add satellite string for KDDI if no entitlement
- Currently Android only handles Satellite w/ entitlement for any notifications. Some carriers such as KDDI have no entitlement for satellite service, so this change is to add some strings to avoid any confuse to Android user on satellite service.

Flag: EXEMPT resource update
Fix: b/382387532
Test: Manual test
Test: atest pass
Change-Id: I835787c9e0fe29eeecec0470e9bd6b38939abd8c
2025-02-10 18:26:35 -08:00
Tomasz Wasilczyk
f38579f786 Merge "Fix settings crashes on missing Telephony features" into main 2025-02-10 09:20:25 -08:00
Jack Yu
94ecf1f216 Merge "Removed the flag enable_modem_cipher_transparency_unsol_events" into main 2025-02-10 00:47:42 -08:00
pengfeix
4fa2836aa5 Fix popping up the the VoLTE screen when it's disabled by the carrier.
- If only has the default carrier config just return, to
  avoid popping up the the VoLTE screen when it's disabled
  by the carrier.

Bug: 332647055
Test: manual
Flag: NONE bugfix
Change-Id: I71bc02f5044535d48726a531e36d57df73bc0f5f
2025-02-10 08:23:23 +05:30
Tomasz Wasilczyk
6a311b9f5b Fix settings crashes on missing Telephony features
Bug: 310710841
Test: open settings app
Flag: EXEMPT bugfix
Change-Id: Ic96585fb34902de54ec838c5692673b33edd2c27
2025-02-08 21:34:21 -08:00
Sunny Shao
e9f0fdcd66 [Catalyst] Implement metrics/tags for Settings Catalyst
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: Ia879883c3f29cd7ac286b431680d66ab52e87db0
2025-02-08 08:37:35 +00:00
Jack Yu
a8db4d190e Removed the flag enable_modem_cipher_transparency_unsol_events
Removed the 24Q3 flag enable_modem_cipher_transparency_unsol_events

Bug: 283336425
Test: atest FrameworksTelephonyTests
Test: Basic telephony functionality tests
Flag: EXEMPT flag cleanup
Change-Id: I08e206d721f99f9422a117dbe009561b434a43bf
2025-02-07 15:41:18 -08:00
Sunny Shao
916643c8fe [Catalyst] Implement metrics/tags for "Mobile data"
Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I9990c8295b26b4b4ed85db41179a8c93d07f48cd
2025-02-07 06:06:51 +00:00
tom hsu
d9b78ebc97 Fix crash due to over limited length.
Flag: EXEMPT bug fix
Fix: b/388404115
Test: Manual test
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a66f9dc3629586c3543952566f05f1b720dfa50c)
Merged-In: I5c72c3c9ca9cb2e4058959abc5a0b4fdd60907bf
Change-Id: I5c72c3c9ca9cb2e4058959abc5a0b4fdd60907bf
2025-02-05 23:55:33 -08:00
Treehugger Robot
60dd62bbc1 Merge "Fix crash due to over limited length." into main 2025-02-05 23:09:41 -08:00
Sunny Shao
4f2e409a3e [Catalyst] Update the permissions
NO_IFTTT=Catalyst only

Bug: 392691854
Bug: 392691083
Test: devtool
Flag: EXEMPT bugfix
Change-Id: Id7809ab699745fff4ef040d4a7141498a58e04e8
2025-02-06 05:20:47 +00:00
tom hsu
a66f9dc362 Fix crash due to over limited length.
Flag: EXEMPT bug fix
Bug: b/388404115
Test: Manual test
Change-Id: I5c72c3c9ca9cb2e4058959abc5a0b4fdd60907bf
2025-02-05 18:17:41 -08:00
Treehugger Robot
c47c644696 Merge "[Catalyst] Remove the INTERACT_ACROSS_PROFILES for Mobile data" into main 2025-02-05 12:46:00 -08:00
Sunny Shao
d533c3e568 [Catalyst] Remove the INTERACT_ACROSS_PROFILES for Mobile data
NO_IFTTT=Catalyst only

Bug: 385282727
Flag: com.android.settings.flags.catalyst_mobile_network_list
Test: devtool
Change-Id: Ic664f6e8974eceaf74c8741d6122a2d0e3e679c9
2025-02-05 05:58:39 +00:00
Hakjun Choi
be6525024d Merge "Clean up aconfig flag oem_enabled_satellite_flag" into main 2025-02-04 19:31:29 -08:00
Jacky Wang
e1c3d8a7b3 [Catalyst] Implement AirplaneModePreference.tags
NO_IFTTT=Catalyst only

Bug: 388061003
Flag: com.android.settings.flags.catalyst
Test: N/A
Change-Id: I3d51a390b0ef792c5f8497e68bd232ef0bd6f752
2025-02-04 18:48:54 +08:00
Jacky Wang
2e265d4a7a [Catalyst] Introduce SettingsContract file
The new file contains all contract constants for external usages (e.g.
slice, external Get/Set API). Also reuse existing constants in
SettingsSlicesContract.

NO_IFTTT=Catalyst only

Bug: 388061003
Flag: EXEMPT refactor
Test: atest
Change-Id: I449b7b6cf82e1e102f2c96a21835191605f09943
2025-02-04 18:24:46 +08:00