Matthew Fritze
54ed30e735
Merge "Revert "resolve merge conflicts of 9feab7a8a5 to oc-mr1-dev"" into oc-mr1-dev am: 21b22f0154
...
am: 8c0d24cb6d
2017-08-01 01:13:22 +00:00
Matthew Fritze
8c0d24cb6d
Merge "Revert "resolve merge conflicts of 9feab7a8a5 to oc-mr1-dev"" into oc-mr1-dev
...
am: 21b22f0154
2017-08-01 01:01:35 +00:00
Matthew Fritze
21b22f0154
Merge "Revert "resolve merge conflicts of 9feab7a8a5 to oc-mr1-dev"" into oc-mr1-dev
2017-08-01 00:59:44 +00:00
Matthew Fritze
fdbf4f057b
Revert "resolve merge conflicts of 9feab7a8a5 to oc-mr1-dev"
...
This reverts commit a504291eef
2017-08-01 00:51:34 +00:00
Fan Zhang
a0a165b71a
Merge "Fix search indexing for game controller "use vibrator"" into oc-mr1-dev am: 5e9b138691
...
am: 1f62645592
2017-08-01 00:42:41 +00:00
Fan Zhang
1f62645592
Merge "Fix search indexing for game controller "use vibrator"" into oc-mr1-dev
...
am: 5e9b138691
2017-08-01 00:41:26 +00:00
Matthew Fritze
68ae06ab17
resolve merge conflicts of 9feab7a8a5 to oc-mr1-dev am: a504291eef
...
am: 44a17e6c51
2017-08-01 00:39:55 +00:00
TreeHugger Robot
5e9b138691
Merge "Fix search indexing for game controller "use vibrator"" into oc-mr1-dev
2017-08-01 00:38:45 +00:00
Matthew Fritze
5d4a45da39
Merge "resolve merge conflicts of a03a707f74 to oc-mr1-dev-plus-aosp" into oc-mr1-dev-plus-aosp
...
am: 7907bd215d
2017-08-01 00:35:36 +00:00
Matthew Fritze
44a17e6c51
resolve merge conflicts of 9feab7a8a5 to oc-mr1-dev
...
am: a504291eef
2017-08-01 00:35:20 +00:00
Eric Schwarzenbach
7f509d341e
Merge "Make only the "Add Network" WifiDialog fullscreen." into oc-mr1-dev am: 5e888ad7b6
...
am: 666d70ea76
2017-08-01 00:29:04 +00:00
Matthew Fritze
7907bd215d
Merge "resolve merge conflicts of a03a707f74 to oc-mr1-dev-plus-aosp" into oc-mr1-dev-plus-aosp
2017-08-01 00:28:57 +00:00
Matthew Fritze
57b641eee8
resolve merge conflicts of a03a707f74 to oc-mr1-dev-plus-aosp
...
Test: I solemnly swear I tested this conflict resolution.
Change-Id: Icca7a8cc2632b35c54421cb8398c8deb4e670032
2017-07-31 17:24:17 -07:00
Eric Schwarzenbach
666d70ea76
Merge "Make only the "Add Network" WifiDialog fullscreen." into oc-mr1-dev
...
am: 5e888ad7b6
2017-08-01 00:17:31 +00:00
Matthew Fritze
a504291eef
resolve merge conflicts of 9feab7a8a5 to oc-mr1-dev
...
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I382d6f881cbfebb7692cbe49a14d9a7cc04d824e
2017-07-31 17:10:24 -07:00
TreeHugger Robot
5e888ad7b6
Merge "Make only the "Add Network" WifiDialog fullscreen." into oc-mr1-dev
2017-08-01 00:02:38 +00:00
jackqdyulei
30420ae268
Merge "Add shadow and wrapper classes" into oc-mr1-dev am: 1b2408433a
...
am: 04c28ab23c
2017-07-31 23:52:47 +00:00
Matthew Fritze
334db456a6
Merge "Fix DataUsageSummary non-indexable keys" into oc-mr1-dev am: 2972b5c992
...
am: 56f5ac21a5
2017-07-31 23:52:20 +00:00
Matthew Fritze
a03a707f74
Merge "Add INTENT_ONLY as a ResultPayload Availibility" into oc-dr1-dev
...
am: 9feab7a8a5
2017-07-31 23:50:03 +00:00
jackqdyulei
c65e873d3e
Merge "Use package from sipper if default is null" into oc-dr1-dev
...
am: ca24d0435b
2017-07-31 23:49:07 +00:00
jackqdyulei
04c28ab23c
Merge "Add shadow and wrapper classes" into oc-mr1-dev
...
am: 1b2408433a
2017-07-31 23:48:51 +00:00
TreeHugger Robot
9feab7a8a5
Merge "Add INTENT_ONLY as a ResultPayload Availibility" into oc-dr1-dev
2017-07-31 23:48:02 +00:00
Matthew Fritze
56f5ac21a5
Merge "Fix DataUsageSummary non-indexable keys" into oc-mr1-dev
...
am: 2972b5c992
2017-07-31 23:45:31 +00:00
TreeHugger Robot
1b2408433a
Merge "Add shadow and wrapper classes" into oc-mr1-dev
2017-07-31 23:44:43 +00:00
TreeHugger Robot
ca24d0435b
Merge "Use package from sipper if default is null" into oc-dr1-dev
2017-07-31 23:42:49 +00:00
TreeHugger Robot
2972b5c992
Merge "Fix DataUsageSummary non-indexable keys" into oc-mr1-dev
2017-07-31 23:35:29 +00:00
Matthew Fritze
621c24861c
Fix DataUsageSummary non-indexable keys
...
Indexing in DataUsage was not conventional, since it
blocked adding XML based on current sim status rather than
indexing everything and changing non-indexabe keys.
Manual merge for: ag/2631595
Change-Id: I7bb3cdb0f11772bbaefb6c21c61eb63bd0b17c7e
Fixes: 64193449
Test: robotests
2017-07-31 14:20:31 -07:00
Alex Kulesza
b509f87040
Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev am: 8fd9c28b7e am: b76fe783e0
...
am: 5252372c15
2017-07-31 20:22:49 +00:00
Fan Zhang
543d7f1414
Merge "Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev am: 9064072ed7 am: 1b62cfb973" into oc-mr1-dev-plus-aosp
...
am: 6d591a3682
2017-07-31 20:22:05 +00:00
jackqdyulei
7620f6555a
Merge "Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev am: d6c9a8b5b2 am: 68af5f3a5d" into oc-mr1-dev-plus-aosp
...
am: d8664d6cba
2017-07-31 20:20:47 +00:00
jackqdyulei
2955995268
Merge "Use package from sipper if default is null" into oc-mr1-dev am: 8be9d6519f
...
am: 6399937d47
2017-07-31 20:20:20 +00:00
Alex Kulesza
5252372c15
Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev am: 8fd9c28b7e
...
am: b76fe783e0
2017-07-31 19:33:55 +00:00
jackqdyulei
1f0f6317f6
Use package from sipper if default is null
...
The BatteryEntry need a background thread to update the
package name and icon. However in InstalledAppDetails we
don't have this thread and it is unnecessary because we
already has the package name.
This cl:
1. Use the mPackageName from InstalledAppDetails directly in
BatteryEntry
2. Double check the defaultPackageName in AdvancedPowerUsageDetail,
use packageName from sipper if default is null
Bug: 64127162
Test: RunSettingsRoboTests
Change-Id: I5d21afca17f177817976758c28ed86b3a10e95eb
Merged-In: I5d21afca17f177817976758c28ed86b3a10e95eb
2017-07-31 12:33:10 -07:00
Alex Kulesza
b76fe783e0
Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev
...
am: 8fd9c28b7e
2017-07-31 19:30:16 +00:00
Alex Kulesza
e9216ccbd3
Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev
...
am: 8fd9c28b7e
2017-07-31 19:30:16 +00:00
Android Build Merger (Role)
6d591a3682
Merge "Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev am: 9064072ed7 am: 1b62cfb973" into oc-mr1-dev-plus-aosp
2017-07-31 19:28:45 +00:00
Fan Zhang
b43867dc5e
Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev am: 9064072ed7
...
am: 1b62cfb973
2017-07-31 19:28:28 +00:00
Android Build Merger (Role)
d8664d6cba
Merge "Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev am: d6c9a8b5b2 am: 68af5f3a5d" into oc-mr1-dev-plus-aosp
2017-07-31 19:28:21 +00:00
jackqdyulei
7bea7b2cdd
Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev am: d6c9a8b5b2
...
am: 68af5f3a5d
2017-07-31 19:27:46 +00:00
jackqdyulei
6399937d47
Merge "Use package from sipper if default is null" into oc-mr1-dev
...
am: 8be9d6519f
2017-07-31 19:27:34 +00:00
TreeHugger Robot
8fd9c28b7e
Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev
2017-07-31 19:19:03 +00:00
Fan Zhang
1b62cfb973
Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev
...
am: 9064072ed7
2017-07-31 19:12:11 +00:00
jackqdyulei
68af5f3a5d
Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev
...
am: d6c9a8b5b2
2017-07-31 19:11:31 +00:00
Fan Zhang
56538f1775
Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev
...
am: 9064072ed7
2017-07-31 19:09:10 +00:00
jackqdyulei
b3a488c40c
Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev
...
am: d6c9a8b5b2
2017-07-31 19:08:31 +00:00
TreeHugger Robot
8be9d6519f
Merge "Use package from sipper if default is null" into oc-mr1-dev
2017-07-31 18:58:22 +00:00
TreeHugger Robot
9064072ed7
Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev
2017-07-31 18:56:02 +00:00
TreeHugger Robot
d6c9a8b5b2
Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev
2017-07-31 18:55:40 +00:00
Matthew Fritze
9a70472ff9
Add INTENT_ONLY as a ResultPayload Availibility
...
Test: robotests
Bug: 64165583
Change-Id: I1bb8fd3f331c8b8aabda55afe329471a9c5ef0c9
2017-07-31 08:18:20 -07:00
Alex Kulesza
4a121ecfae
Fixing bug in UsageGraph rendering.
...
The calculateLocalPaths() method of UsageGraph converts a set of paths
in (milliseconds, percent) coordinates into the actual pixel values that
will be used for drawing. For the most part this is a one to one
process, but not always: input points that are too closely spaced to
draw accurately are skipped. The last point in the path, however, is
never skipped, in order to ensure that the graph ends at the correct
location.
The previous implementation of this method had a bug: the y-coordinates
of points that were skipped would be stored indefinitely (in the local
variable pendingYLoc) and then added back at the very end of the path
(under the condition i == mPaths.size() - 1 && pendingYLoc !=
PATH_DELIM). Under the right conditions, this led to the strange uptick
at the end of the graph seen in the associated bug.
This CL fixes the problem and attempts to make the logic slightly
clearer. It also adds tests, one of which (_similarPointMiddle) fails
for the previous code.
In more detail, previously pendingXLoc was used to hold the last x
coordinate seen, while pendingYLoc was used to hold the last *skipped* y
coordinate, or PATH_DELIM otherwise. The difference between these was
somewhat subtle and hard to understand from a quick read of the code,
and there was a bug: pendingYLoc never got reset to PATH_DELIM even if
later points were added. In this CL I have removed the pendingLoc
variables in favor of a single lx/ly pair, which always holds the local
coordinates of the most recent point, and I added an explicit boolean
skippedLastPoint to track whether the point (lx, ly) has already been
added or was skipped.
Bug: 64065296
Test: make RunSettingsRoboTests
Change-Id: I45ccffea1280d851bfae5143c2e84d188e133731
2017-07-31 11:12:17 -04:00
