Commit Graph

2120 Commits

Author SHA1 Message Date
Matías Hernández
a588f3ebc4 Fix missing mode title and menu
By moving these from onStart to onResume. Looks like a recent change to Settings broke this.

Bug: 391543900
Test: manual
Flag: EXEMPT Trivial bugfix
Change-Id: Ie9b8bd08e8513e7c6c2f1baeab4801af2fbe1cae
2025-01-22 14:57:48 +01:00
Jacky Wang
041bc113eb Remove MainSwitchPreference.updateStatus
NO_IFTTT=Update API

Bug: 391092187
Flag: EXEMPT library
Test: atest&manual
Change-Id: I6e31857d8ca7084c737fd69f63b33f6a58cf3022
2025-01-21 07:44:43 +08:00
Fan Wu
8d318b21d8 [Catalyst] Update RangeValue usages to IntRangeValuePreference
Bug: 388167302

Test: atest and manual

Flag: EXEMPT refactor

NO_IFTTT=refactor

Change-Id: If7412da90a5b5c1b4e3c31ea36361eae9e8bb8b9
2025-01-20 03:23:57 +00:00
Fan Wu
297941ba2f [Catalyst] Remove PreferenceMetadata usages
Classes that implement PersistentPreference don't need to implement PreferenceMetadata

Bug: 388167302
Test: atest and manual
Flag: EXEMPT refactor
NO_IFTTT=refactor

Change-Id: Icf7d5eb4bbd426eb7e8dd562eda3c0a775457a3e
2025-01-16 17:46:28 -08:00
Yining Liu
8b94618dd8 Merge "Notification on lockscreen settings: add WhatToShowController" into main 2025-01-16 15:38:58 -08:00
Ioana Alexandru
878f860fd3 Merge "Rename SettingsEnableZenModeDialog to EnableDndDialogFragment" into main 2025-01-16 08:39:36 -08:00
Yining Liu
50577a6c36 Notification on lockscreen settings: add WhatToShowController
Add WhatToShowController to handle the visibility change of the
preference category when the global setting changes.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: manual
Change-Id: I432e4c865402ac8bee32f0f79b3cf2bdce7cc882
2025-01-16 16:11:33 +00:00
Ioana Alexandru
07534f76a9 Rename SettingsEnableZenModeDialog to EnableDndDialogFragment
We also renamed the base EnableZenModeDialog to
EnableDndDialogFactory, see other CL in topic.

Flag: EXEMPT trivial rename
Test: builds
Bug: 388261320
Change-Id: Iaa2043bbb8d1f62482d0c38d0951da4025676f27
2025-01-15 17:42:23 +01:00
Julia Reynolds
e5359b283e Align history styling with Settings
Fixes: 335717550
Bug: 349652992
Test: manual- view history in all states with new styling enabled and disabled
Flag: EXEMPT bug fix
Change-Id: I8ccf5d848691f954cb1b0a79c773ad76ab6c371a
2025-01-14 16:05:25 -08:00
Julia Reynolds
41896428ea Layout improvements for notification pages
Changes for upcoming theming changes in Settings:
- replacing some margins with padding
- merging some (switch pref + info pref) combos into a single preference.
I flagged the one that was already launched, but changed the other directly
- added some section headers (unflagged)
- moved all app wide notification settings to a single section (unflagged)
- changed two plain text prefs into TopIntroPreference, the dedicated pref
type for that sort of UI
- fixed some UI issues with 'Show more categories' appearing too often
- removed a duplicate notifcation channel label (unflagged)
- replaced a button layout preference with ButtonPreference (unflagged)

Test: manual review with is_expressive_design_enabled on and off
Test: atest com.android.settings.notification.app
Flag: EXEMPT this feature is not using aconfig for flagging
Bug: 349652992
Change-Id: I2acd7b2eb9dbcf6929143bfde99cd67163f1f95d
2025-01-09 17:07:53 -05:00
Treehugger Robot
be203ea17d Merge "Fix NPE on modes page when schedule has no days" into main 2025-01-08 11:17:09 -08:00
Matías Hernández
5098df9b6c Fix NPE on modes page when schedule has no days
Fixes: 387088843
Test: atest ZenModeTriggerUpdatePreferenceControllerTest
Flag: EXEMPT trivial bugfix
Change-Id: I3b845784f5923521d7f3f6cae9d6d27a21f55361
2025-01-08 19:14:40 +01:00
Yuri Lin
5979b88c7c Merge "Send APP_NOTIFICATION_PROMOTION_SETTINGS intent to the preference" into main 2025-01-06 10:59:50 -08:00
Matías Hernández
837a3477ab Merge "Remove incorrect call to Window.addFlags with a system flag" into main 2025-01-06 07:16:05 -08:00
Matías Hernández
e0510a62eb Remove incorrect call to Window.addFlags with a system flag
The same flag is being (correctly) added in onCreate, so on top of being wrong this was also completely unnecessary.

Bug: 368579654
Test: atest NotificationAccessConfirmationActivityTest
Flag: EXEMPT bugfix

Change-Id: I539fca77a1d136bdd0e4892993020884430b8a4e
2025-01-03 14:54:52 +01:00
Yining Liu
9d200f1f38 Merge changes I1dffab01,I6e34ef9b,Ia8d472ea,Icf4e7003 into main
* changes:
  Notification on lockscreen settings: adapt text view for large font
  Inverse toggles on the notifications on locks screen settings page
  Update appearance of notifications on locks screen settings page
  Remove description from notifications on locks screen settings page
2025-01-02 16:11:51 -08:00
Yuri Lin
023509c895 Send APP_NOTIFICATION_PROMOTION_SETTINGS intent to the preference
This adds APP_NOTIFICATION_PROMOTION_SETTINGS to the set of intents that can go to AppNotificationSettings, and additionally adds the appropriate highlight key when the fragment is started with that intent action.

Flag: android.app.ui_rich_ongoing
Test: manual with flag on & off via sending intents over adb; AppNotificationSettingsTest
Bug: 369150427
Change-Id: I1c48fdae161979f1a221f7c57e83e94f6aadc306
2025-01-02 11:04:22 -05:00
Treehugger Robot
e095ce3124 Merge "[Catalyst] Provide screen key to @ProvidePreferenceScreen" into main 2024-12-27 05:33:47 -08:00
Treehugger Robot
f4aa62fb64 Merge "[Catalyst] Implement get{Read,Write}Permissions for Media volume" into main 2024-12-27 01:18:10 -08:00
Jacky Wang
cfcf20c70a [Catalyst] Provide screen key to @ProvidePreferenceScreen
NO_IFTTT=Catalyst only

Bug: 386179791
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: Ie8106ec45a32e4a61826512fc62746c9ffc47d9c
2024-12-27 17:14:27 +08:00
Treehugger Robot
062d721d03 Merge "[Catalyst] Implement get{Read,Write}Permissions for Call volume" into main 2024-12-27 00:44:48 -08:00
Treehugger Robot
610295560b Merge "[Catalyst] Implement get{Read,Write}Permissions for Ring volume" into main 2024-12-27 00:24:50 -08:00
Mill Chen
35b6dbd032 [Catalyst] Implement get{Read,Write}Permissions for Call volume
NO_IFTTT=Catalyst only

Fix: 386142831
Test: devtool
Flag: com.android.settings.flags.catalyst_sound_screen
Change-Id: I5ead6fa83dd6ce84f10c7352b60b354f1471f6c9
2024-12-27 04:53:09 +00:00
Mill Chen
c210dc981c [Catalyst] Implement get{Read,Write}Permissions for Media volume
NO_IFTTT=Catalyst only

Fix: 386143376
Test: devtool
Flag: com.android.settings.flags.catalyst_sound_screen
Change-Id: I1909c32ae1d067b095208b4a65ad53bd7080acf1
2024-12-27 04:45:51 +00:00
Mill Chen
5da3d3390a [Catalyst] Implement get{Read,Write}Permissions for Ring volume
NO_IFTTT=Catalyst only

Fix: 386143268
Test: devtool
Flag: com.android.settings.flags.catalyst_sound_screen
Change-Id: I8ed7fa1d6a857d64896b33a80e17f7e08808bbaf
2024-12-27 04:37:43 +00:00
Yining Liu
38537f8129 Inverse toggles on the notifications on locks screen settings page
Inverse the toggles on the notifications on locks screen settings page
to consistently make ON = SHOW.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: manual, atest LockScreenNotificationShowSensitiveControllerTest
Change-Id: I6e34ef9b89f4c0ad058bf740bafb3c83790201c0
2024-12-27 00:06:47 +00:00
Yining Liu
7c8e313d11 Remove description from notifications on locks screen settings page
Remove the text descriptions for the notifications minimalism
style from the notifications on locks screen settings page.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: manual
Change-Id: Icf4e70033dab7aea829a09a6277b47da66efbd01
2024-12-27 00:06:46 +00:00
Yuri Lin
d5c0851c0b Add setting for promoted (live) notifications
Add a switch to control whether live notifications are permitted for an app, at the top of the app's notification settings page. This controls canPostPromotedNotifications() for that app.

Bug: 369150427
Flag: android.app.ui_rich_ongoing
Test: manual, PromotedNotificationsPreferenceControllerTest
Change-Id: I3a7c05721f1e879fb5fb0f5fb5f283dedbd195da
2024-12-26 11:09:08 -05:00
Jacky Wang
821d320051 [Catalyst] Update permission check API signature
NO_IFTTT=Catalyst only

Bug: 374115149
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: Ib13a5fddd517e3e260815b753b55c008e24d70d8
2024-12-13 16:09:58 +08:00
Yining Liu
b4cbd1913b Merge "Use the new logging event for "Notifications on lock screen" in Settings" into main 2024-12-10 17:52:21 +00:00
Matías Hernández
5cf2306221 Merge "Use different "None" strings for Messages and Calls in Modes breakthrough" into main 2024-12-10 15:58:06 +00:00
Matías Hernández
6ba4109c2b Use different "None" strings for Messages and Calls in Modes breakthrough
Bug: 330870672
Test: manual
Flag: android.app.modes_ui
Change-Id: I33c6ebce9281313d5d1cb483b82dfd90d1ff48a1
2024-12-10 12:47:31 +01:00
Marcelo Arteiro
8577c10535 Migrate materialColor* attributes into colors
The new color were already introduces in a previous CL ag/30322786

This CL is about replacing the attribute usage by the new color resources, which should work the same but cannot be overwritten, or styled, guaranteeing consistency across the OS.

The old attributes will be removed in CL: ag/29910036

Bug: 374273611
Test: presubmit
Flag: EXEMPT Un-flaggable refactor of private color resources
Change-Id: I05b5261054bcb6de40e4e40d633025495f3dd01f
2024-12-06 16:55:33 +00:00
Yining Liu
6946108798 Use the new logging event for "Notifications on lock screen" in Settings
Bug: 367455695
Change-Id: I7310e625d2415dbad5da25d4c1b02e359f169010
Test: Build
Flag: com.android.server.notification.notification_lock_screen_settings
2024-12-05 23:33:58 +00:00
Yining Liu
85aa7f7c86 Replace the existing notifications on lock screen preferences with new page
Replace the existing notifications on lock screen preferences with the new
notifications on lock screen page entries.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: Manual, Settings - Display & touch - Lockscreen; Settings - Security &
privacy - More security & privacy

Change-Id: I858f84db8b5c09895d6b196426b32b3bfbd80d15
2024-12-04 22:08:25 +00:00
Yining Liu
81d390968b Implement the preference switch for minimalism on ls settings page
Implement the preference switch for notification minimalism on the
notifications on lock screen settings page. The illustrations and
summaries will also update when switching the preference. This
preference will hide when the main toggle is unset or when the lock
screen notification minimalism feature flag is disabled.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: adb shell settings get secure \
 lock_screen_notification_minimalism <1|0>
Change-Id: Ie6596e518bd1aa2e828587d7d174b57256aec45b
2024-12-04 22:08:25 +00:00
Yining Liu
bd6561accf Implement the Hide seen notifications toggle
Implement the Hide seen notifications toggle on the notifications on
lock screen page. The toggle will become invisible
when the main toggle is unset or when the lock screen notification
minimalism feature flag is disabled.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: adb shell settings get secure \
 lock_screen_show_notifications <1|0>
Change-Id: I6f94be3295dfbaa978d145d113e03cacc1a232fc
2024-12-04 22:08:24 +00:00
Yining Liu
4c507b1132 Implement the hide silent notifications toggle
Implement the hide silent notifications toggle on the notifications
on lock screen page. This toggle will become invisible when the main
toggle is unset. This toogle will replace the existing Notifications
- notifications on the lock screen - hide silent conversations and
notifications preference when the flag is enabled.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: adb shell settings put secure \
 lock_screen_show_silent_notifications <1|0>
Change-Id: Icc0b26afd199ec3f14237fd1cdb27981383ae69f
2024-12-04 22:03:12 +00:00
Yining Liu
c16c9b2df6 Implement the show sensitive content toggle
Implement the show sensitive content only when unlocked toggle on the
notifications on lock screen page. The toggle will become invisible
when the main toggle is unset or when there's no screen locks.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: adb shell settings get secure \
 lock_screen_allow_private_notifications <1|0>
Change-Id: I174478540c4cc2e2df7047049671266041dd41cf
2024-12-04 18:53:35 +00:00
Yining Liu
0d75a26a68 Implement the main switch of notifications on lock screen
Add the ability of controlling whether to show notifs on the lock
screen (secure setting: lock_screen_show_notifications) to the new
lock screen notification settings page main switch. This switch also
listens to the change of lock_screen_show_notifications to update
its status in case of other places change the value.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: atest LockScreenNotificationsPreferenceControllerTest
Change-Id: Id598d508ac383563a0d9413578251eb22ed4ca90
2024-12-04 18:53:32 +00:00
Yining Liu
9836d6a69a Add the new settings page for lock screen notifs
Add a new empty settings page, which is flag-guarded. When the flag
is disabled, show the original Notifications on lock screen
tri-state switch, otherwise show the new page.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: atest LockScreenNotificationsPreferenceControllerTest

Change-Id: I8a81ad651626f39380767b2c9cfa2f1c19d0e7c5
2024-12-04 00:30:05 +00:00
Treehugger Robot
f92c187b11 Merge "[Catalyst] Ring volume migration (2/n)" into main 2024-12-02 10:41:39 +00:00
Mill Chen
a2b94eafde [Catalyst] Ring volume migration (2/n)
NO_IFTTT=migrate other feature from controller

Bug: 373978964
Test: atest SeparateRingVolumePreferenceTest
Flag: com.android.settings.flags.catalyst_sound_screen
Change-Id: I4aba4c6688e4284fb23570ac999acf7b4039854d
2024-11-29 17:10:11 +00:00
Treehugger Robot
8ff5f0cfc5 Merge "[Settings] Fix inconsistent ringtone keyword search" into main 2024-11-29 03:27:08 +00:00
Jacky Wang
8a97245b3d [Catalyst] Add sensitivity level
NO_IFTTT=Catalyst only

Bug: 380457585
Flag: com.android.settings.flags.catalyst
Test: Manual
Change-Id: Ia98a925011723738e1a16cc0e0c3d703d3dbd505
2024-11-29 07:36:13 +08:00
Wilson Wu
409e5f5697 [Settings] Fix inconsistent ringtone keyword search
The settings keyword search result is based on xml.
Hide the phone ringtone preference if the device
support ringtone vibration.

Flag: EXEMPT bugfix
Bug: 379006466
Test: atest PhoneRingtonePreferenceControllerTest
Change-Id: I42d2518c524ab26525445f766e14049c59a8d6ee
2024-11-28 03:42:01 +00:00
Jacky Wang
e635f1e0ed [Catalyst] Support Getter API for settings service
NO_IFTTT=Catalyst only

Bug: 373895596
Flag: com.android.settings.flags.catalyst_service
Test: devtool
Change-Id: I367f350d2192d1285bf355a9e45c2d9bec11fa44
2024-11-16 08:06:28 +08:00
Matías Hernández
0cf61ba759 Merge "Hide the blurb for custom-manual types" into main 2024-11-14 23:32:00 +00:00
Matías Hernández
1f24f061b4 Hide the blurb for custom-manual types
Fixes: 377691826
Test: manual
Flag: android.app.modes_ui
Change-Id: I3c959f32c7ae1cc2c95fb4e9180e2f871ed3ee91
2024-11-14 20:26:40 +00:00
Matías Hernández
0baf70a4b3 Exclude implicit modes from the summary of the Modes entry in Settings
They are called "Do Not Disturb (App)" which places alphabetically near the top (in English). This can often result in a summary like "DND, Bedtime, DND (App)", which looks silly.

Fixes: 379089451
Test: atest ZenModeSummaryHelperTest
Flag: android.app.modes_ui
Change-Id: Id41caee09cca874297ca12d2ac934aed3f9a43ab
2024-11-14 15:33:54 +00:00