Commit Graph

1467 Commits

Author SHA1 Message Date
Jason Chiu
d2b586c939 Merge "[Safer intents] Accessibility" into main 2024-03-27 02:03:11 +00:00
Marcus Ge
660defe7a6 Merge changes I60d2b23a,I7cb15a46 into main
* changes:
  [Accessibility] Color Contrast address talkback bugs
  [Accessibility] Color Contrast address UX bugs
2024-03-26 20:26:10 +00:00
marcusge
9ec6673b3f [Accessibility] Color Contrast address talkback bugs
Test: local raven device
Bug: 329352987
Bug: 329192396
Bug: 329187057
Flag: aconfig
com.android.settings.accessibility.enable_color_contrast_control

Change-Id: I60d2b23acb2e406db15f348ba7881577e55a8868
2024-03-26 19:08:42 +00:00
Chun-Ku Lin
4c9d268fdf Rename AccessibilityGestureNavigationTutorial to AccessibilityShortcutsTutorial
AccessibilityGestureNavigationTutorial is not only for displaying
tutorial for accessibility gesture shortcut. It's used for display the
tutorials for all the selected accessibility shortcuts. Renamed the
class to match it's responsibility.

Bug: N/A
Flag: EXEMPT Strict mechanical refactors
Test: build succeed locally

Change-Id: I1dd212abc660454e77f18f770c2ecc17be320eaa
2024-03-26 01:13:28 +00:00
Chun-Ku Lin
3aee92e2e8 Update a11y edit shortcut screen's text and tutorial text
Bug: 323792194

Test: manual
Test: atest com.android.settings.accessibility
Test: atest com.android.settings.accessibility.shortcuts

Flag: N/A simple string changes

NO_IFTTT=Introduce new IfThisThenThat lint

Change-Id: I7ba4096d669453c33257880407e85ffe76d358f8
2024-03-25 22:19:10 +00:00
Jason Chiu
d785397930 [Safer intents] Accessibility
To avoid implicit intents, make intents launch explicitly.

Bug: 323061508
Test: build
Change-Id: I5be489f4e6b855156b8dd6b8e54b0b6116f728ad
2024-03-25 17:05:41 +08:00
Jay Thomas Sullivan
f8b405462a [ECM] Legacy code: treat DEFAULT as ALLOWED (st)
This modifies pre-flag behavior so that MODE_DEFAULT (of
OP_ACCESS_RESTRICTED_SETTINGS) is treated the
same as MODE_ALLOWED.

The reason is that we've change the default op mode (of
OP_ACCESS_RESTRICTED_SETTINGS) to MODE_DEFAULT. Since legacy code
doesn't understand what MODE_DEFAULT means, we need to mitigate the
impact of reverted flags.

Bug: 329488185
Test: atest SpaPrivilegedLibTests
Test: atest
com.android.settings.applications.specialaccess.notificationaccess
Test: atest com.android.settings.datausage
Test: atest PremiumSmsAccessTest
Test: atest RestrictedPreferenceHelperTest
Test: atest
CtsPermissionUiTestCases:android.permissionui.cts.EnhancedConfirmationManagerTest

Change-Id: I957c75870018a9d4d2d2e122ee3bb2252b338cb2
2024-03-21 20:24:29 -07:00
Daniel Norman
88feeec3c1 Merge "Remove usages of bugfix flag cleanup_accessibility_warning_dialog." into main 2024-03-20 17:49:34 +00:00
Fiona Campbell
9c50f2c61d Merge "Ensure only either RBC or even dimmer can be on" into main 2024-03-20 16:08:54 +00:00
Fiona Campbell
9a71b86c42 Ensure only either RBC or even dimmer can be on
Not Both

Even dimmer is the successor to RBC, so we shouldn't enable both
simultaneously, they are not compatible

Bug: 179428400
Test: manual, atest DisplayServiceTests
Change-Id: I18d5a9c7418b8141afd4b67d121a96cb50ba5274
2024-03-20 11:07:16 +00:00
Daniel Norman
8ce099c2cd Remove usages of bugfix flag cleanup_accessibility_warning_dialog.
Flag has been in Trunkfood for over a month.

Includes one mechanical refactor to move a method from a now-removed
file into a private method in the class that uses it: createDisableDialog

(This flag guarded a preliminary cleanup and minor bug fix for
b/303511250, but the actual feature for b/303511250 is tracked in a
different flag 'skip_accessibility_warning_dialog_for_trusted_services')

Bug: 303511250
Test: existing tests in Presubmit (no change to behavior)
Change-Id: Iccf439adb2806e988310f503fb3891a6bd022054
2024-03-19 23:05:07 +00:00
Chun-Ku Lin
5cdf972b50 Make QS shortcut type as default preferred shortcut for A11yService that
associate with a TileService

Bug: 322712028
Test: manual (Turn on the shortcut for the first time for various
feature with or without tile. Verify only the A11yService with tile
would show QS as the shortcut when directly turn on the main shortcut
toggle)
Test: atest com.android.settings.accessibility

Flag: aconfig android.view.accessibility.a11y_qs_shortcut
Change-Id: I569b417639d2db8b7eddd818a2b9037ed4be2509
2024-03-18 00:14:43 +00:00
Chun-Ku Lin
958d17bb69 Merge "Reflect QS shortcut changes in a11y pages." into main 2024-03-13 16:02:59 +00:00
Wilson Wu
ab589363b4 Merge "Fix keyboard vibration settings delay" into main 2024-03-13 08:32:48 +00:00
Angela Wang
0517422918 Merge "Fix logging format and add test cases" into main 2024-03-13 08:27:24 +00:00
Wilson Wu
f2174611b8 Fix keyboard vibration settings delay
The default settings observer delay is 10s for
background service. It cause the apps get the
settings update delay and lead a unsync behavior.

Update the settings change without delay.

Bug: 327094397
Test: Manual test with bug steps
Test: atest KeyboardVibrationTogglePreferenceControllerTest
Change-Id: Ib1c23ec9e1442e8397c7a36ffa157594ac64a9b3
2024-03-13 06:33:08 +00:00
Chun-Ku Lin
deba8599d8 Reflect QS shortcut changes in a11y pages.
Bug: 314843909

Test: manual (modify qs tiles in QS panel while the a11y page is open,
verify the a11y page reflect the qs changes)
Test: atest com.android.settings.accessibility
Test: atest com.android.settings.accessibility.shortcuts

Flag: ACONFIG android.view.accessibility.a11y_qs_shortcut

Change-Id: Ie5b46459faab902912a214ca131eb5d0b105a7ef
2024-03-12 01:32:00 +00:00
Chun-Ku Lin
9cf7f6e861 Merge "Show QS shortcut option if the a11y feature provides a tile." into main 2024-03-08 17:20:15 +00:00
Wilson Wu
4406de67e0 Merge "Add fixed amplitude check for keyboard vibration" into main 2024-03-07 04:30:36 +00:00
Chun-Ku Lin
8b67c17a7b Show QS shortcut option if the a11y feature provides a tile.
Bug: 314852953
Test: atest com.android.settings.accessibility
Test: atest com.android.settings.accessibility.shortcuts
Test: manual
Flag: ACONFIG android.view.accessibility.a11y_qs_shortcut STAGING
Change-Id: Id7a6b3adfd4c4f3cb2b9f7fe15269b57a3d00543
2024-03-06 20:26:28 +00:00
Wilson Wu
fd45101eee Add fixed amplitude check for keyboard vibration
Make sure the keybaord vibration settings only show
up when fixed amplitude provided to avoid any unsync
behavior with platform.

Bug: 326027376
Test: atest KeyboardVibrationTogglePreferenceControllerTest
Change-Id: I3b4e06660e3eaa6ce537b72831073f092cba37e2
2024-03-06 12:33:07 +00:00
Isaac Chai
46369353ed Adding Settings preference for single finger panning feature
Test: Locally tested on device +
MagnificationOneFingerPanningPreferenceControllerTest
Bug: 282039824

Change-Id: I1d1a649060cba862c8f333e6e76184fade2dcdce
2024-03-05 19:10:59 +00:00
Riley Jones
ee25100639 Merge "Change EditShortcutsPreferenceFragment to use a Preference for subtitle/description" into main 2024-03-05 02:53:47 +00:00
Roy Chou
79ee7bc941 Merge "chore(magnification): remove onResume overrides for controllers in ToggleScreenMagnificationPreferenceFragment" into main 2024-03-05 01:32:33 +00:00
Riley Jones
f8237aee94 Change EditShortcutsPreferenceFragment to use a Preference for subtitle/description
Replaces PreferenceCategory with unselectable Preference to better match desired visuals

Screenshot at https://x20web.corp.google.com/users/jo/jonesriley/dragToEdit/editScreenWithSubtitle.png

Flag: N/A
Test: N/A
Bug: 323388734
Change-Id: Ia1b333bc246ea4dd98070a646d5a8a1716ccbcee
2024-03-04 22:45:11 +00:00
Angela Wang
6089d3edd6 Merge "Replaces HearingDevicePairingDetail with HearingDevicePairingFragment" into main 2024-03-04 06:53:19 +00:00
Roy Chou
654e43b2e8 chore(magnification): remove onResume overrides for controllers in ToggleScreenMagnificationPreferenceFragment
As b/186731461, so far MagnificationModePreferenceController and other
magnification preference controllers are only used in
ToggleScreenMagnificationPreferenceFragment, which is DashboardFragment.
Since DashboardFragment already updates preference state in its
onResume, so we can remove the onResume overrides in those controllers.
Besides, we can also remove the LifeCycle dependency for the controllers
since it's not used anymore.

Bug: 186731461
Flag: NA
Test: manually
      atest ToggleScreenMagnificationPreferenceFragmentTest
      atest MagnificationAlwaysOnPreferenceControllerTest
      atest MagnificationFollowTypingPreferenceControllerTest
      atest MagnificationJoystickPreferenceControllerTest
      atest MagnificationModePreferenceControllerTest
Change-Id: I379a6a3a985c9d8b7a37bbb878b84cee1bd6adfb
2024-03-04 03:44:59 +00:00
Shaowei Shen
624e1beca8 Merge "[A11y Setting] Add keyboard keys preferences under A11y page" into main 2024-03-01 13:37:03 +00:00
shaoweishen
a5f5ff4add [A11y Setting] Add keyboard keys preferences under A11y page
Bug: 325851068
Test: make RunSettingsRoboTests
Change-Id: Ic7eb1ec9e260a95d040bee784cbff479a4f087d0
2024-03-01 12:05:30 +00:00
Daniel Norman
b13637cea9 Merge "Add Chun-Ku to A11y Settings OWNERS" into main am: 951cd157de am: af3c4de3c3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2985032

Change-Id: Ife119a2250976b6c03fa17f1d9079e7d43b6ff7e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-29 22:28:19 +00:00
Daniel Norman
af3c4de3c3 Merge "Add Chun-Ku to A11y Settings OWNERS" into main am: 951cd157de
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2985032

Change-Id: I66e884b014a5162ea02312fd31030bde7beb859d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-29 21:43:19 +00:00
Marcus Ge
12108acc07 Merge "[Accessibility] Add basic metrics logging for color contrast" into main 2024-02-29 21:04:23 +00:00
Daniel Norman
b9e38fa9f0 Add Chun-Ku to A11y Settings OWNERS
Change-Id: Ia82f9f2196a33518faf2b7f345ad354990f7cf74
Test: n/a
Bug: n/a
2024-02-29 21:04:02 +00:00
marcusge
16d82ccd0a [Accessibility] Add basic metrics logging for color contrast
proto was merged in ag/26383954

Bug: 241805782
Test: atest

Change-Id: Ic2e6bcb27aecc386582e6f268d3b4f40387f2742
2024-02-28 20:33:05 +00:00
Marcus Ge
747d0afa21 Merge changes I69049a13,I7fcc01b8 into main
* changes:
  [Accessibility] Migrate high text contrast under feature flag
  [Accessibility] Add contrast control screen UI and setup entry point
2024-02-28 19:38:27 +00:00
Jason Hsu
429291b70a Merge changes Id1ed4455,I73e62733 into main
* changes:
  Make Preferences more visible with colored rounded rectangle background and an arrow icon
  Provides BackgroundPreference that can set background statically or dynamically
2024-02-28 04:01:06 +00:00
marcusge
7fb14e1e54 [Accessibility] Migrate high text contrast under feature flag
Add Maximize Text contrast into contrast screen and hide it in "Display size and text" under feature flag

Test: manually
Bug: 241805782
Flag: aconfig
com.android.settings.accessibility.enable_color_contrast_control

Change-Id: I69049a136beba00a311c3c94fc9a49b0219a870e
2024-02-27 23:59:32 +00:00
marcusge
cddd7b3660 [Accessibility] Add contrast control screen UI and setup entry point
Bug: 241805782
Test: atest, local raven device
Screenshot: attached on bug
Flag: aconfig
com.android.settings.accessibility.enable_color_contrast_control

Change-Id: I7fcc01b822b460c6585c41a5831575ba0ffbcc93
2024-02-27 23:36:52 +00:00
Angela Wang
6e78a34d9c Replaces HearingDevicePairingDetail with HearingDevicePairingFragment
The new pairing page includes new UI for "See more devices" buttton and
can show MFi + ASHA devices in the pairing list while these devices only
advertise MFi HAS uuid in pairing mode.

As allowed by "Flag Cleanup Policy", this change finishes the rollout of trunkfood flag new_hearing_device_pairing_page by defaulting to the "true" state.

Bug: 307473972
Test: atest HearingAidPairingDialogFragmentTest
Test: atest AddDevicePreferenceControllerTest
Change-Id: I6c3377d535139d62791548557c581317d1878e9d
2024-02-27 14:28:59 +00:00
Angela Wang
956168070e Updates messages for hearing devices related page
1. Removes the footer in hearing devices page
2. Moves the footer message to top intro of hearing devices pairing
   page

Bug: 321840161
Test: build pass, only simple UI change
Change-Id: I0554f0e6d12f78c1df3efba23792e9c0dc3f061f
2024-02-27 11:15:22 +00:00
Angela Wang
4a2b4a87d7 Redirects to connected devices page in a11y pairing page
With UX flow change, clicking "View more devices" button will redirect to connected devices page rather than connected device pairing page.

Bug: 321840161
Test: atest ViewAllBluetoothDevicesPreferenceControllerTest
Change-Id: Icfc03a463e2aaaf3db3c75524c112028b1fd6655
2024-02-27 07:35:36 +00:00
jasonwshsu
d23c2867c6 Make Preferences more visible with colored rounded rectangle background and an arrow icon
Bug: 320709814
Test: atest ArrowPreferenceTest
Change-Id: Id1ed44554010ae0df901cceba2624a1b56661df6
2024-02-26 05:57:11 +00:00
jasonwshsu
6dc0e30b56 Provides BackgroundPreference that can set background statically or dynamically
Bug: 320709814
Test: atest BackgroundPreferenceTest
Change-Id: I73e62733e6afd032ce980a4d6db0f4ca4573e770
2024-02-26 05:56:47 +00:00
Riley Jones
14ec4f08c3 Merge "DragToEdit Dynaimc Title" into main 2024-02-23 19:46:13 +00:00
jasonwshsu
8d80de8446 Fix logging format and add test cases
For logging purpose, CachedBluetoothDevice#toString is more clear then BluetoothDevice#toString, so change to use CachedBluetoothDevice#toString

Bug: 307890347
Test: atest HearingDevicePairingFragmentTest
Change-Id: Ia0af65565ca7067fa6c4d5db286c3739fb65c1d2
2024-02-23 16:19:20 +00:00
Hani Kazmi
206300962f Replace ECM AppOps call with service
A new ECM service was introcuded in changeId
I831391e4437b51b3312b5273a2360bd029a3d8ee.

We begin calling it, and update/cleanup method signatures to match.

Note: There are two feature flags:

1. enhancedConfirmationModeApisEnabled - read only, protects the
   mainline API.

2. extendEcmToAllSettings - runtime - gates calls to the above APIs.

We use both so we can ramp up in teamfood as needed.

Bug: 297372999
Test: Tested on device
Test: atest SpaPrivilegedLibTests
Test: atest com.android.settings.applications.specialaccess.notificationaccess
Test: atest com.android.settings.datausage
Test: atest PremiumSmsAccessTest
Test: atest RestrictedPreferenceHelperTest
Change-Id: I945ec51df5cd63de548a8ffdd1acc4f09f2301e5
2024-02-21 14:43:02 +00:00
Riley Jones
43420f16af DragToEdit Dynaimc Title
Bug: 323388734
Test: atest EditShortcutsPreferenceFragmentTest
Flag: aconfig edit_shortcut_dynamic_title true

Change-Id: I74785054e4f846db04d13a54bd6695e4690f5b8b
2024-02-16 23:03:12 +00:00
Angela Wang
4972c58783 New hearing device pairing page: ignore bonded device
The device might still in advertising mode even if it's bonded. We can
just ignore this kind of devices in the scanning result.

Bug: 307890347
Test: manual test
Change-Id: I782cc62edd4fec779f5f55444425b32a77f85e5e
2024-02-07 10:22:24 +00:00
Angela Wang
3ca9ef8edc New hearing device pairing page: check gatt status
Checks the gatt status in `onConnectionStateChange()` and `onServiceDiscovered()` callbacks. Disconnects and removes the gatt from the `mConnectingGattList` if the gatt status is not success in these callbacks.

Bug: 307890347
Test: manual test
Change-Id: Iab09f13b2ff3d33e5c4d6a8710736307c26b17e7
2024-02-07 08:54:41 +00:00
Ahmad Khalil
92fb442d09 Merge "Fix notification vibration demos in settings" into main 2024-02-01 13:59:24 +00:00