Commit Graph

55737 Commits

Author SHA1 Message Date
hoffc
a9002d157c Fix force close for updating UI after activity destroyed.
If activity is finishing or destroyed, getting activity context will return null results in settings app force close.

Do not call scan callback if network select activity is finishing or destroyed.

Test: build pass and run NetworkSelectSettingsTest unit test pass.

Bug: 372123288
Change-Id: I28307490c75fe04d54dcf1637f33f4b9ba1fe635
2024-10-22 06:25:37 +00:00
Dongzhuo Zhang
b34562ef91 Merge "Swtich to use DefaultAccount related API to get and set default account for handling contacts." into main 2024-10-21 22:53:32 +00:00
Riley Jones
be18186757 Merge "Removes the A11y tutorial that displays on change to gesture navigation" into main 2024-10-21 17:59:10 +00:00
Pechetty Sravani (xWF)
0123edbb75 Merge "Revert "Fix force close for updating UI after activity destroyed."" into main am: 0583090e98 am: 4e2320c2c0
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3313692

Change-Id: I12a6c6cde4d177b4935e9c1f69e2e4d53e2981d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-21 10:39:50 +00:00
Treehugger Robot
a868c602f1 Merge "Redesign the update logic of Allow Background Usage Page." into main 2024-10-21 10:27:18 +00:00
Treehugger Robot
0dbc16d2e0 Merge "Make NetworkProviderSettings extend RestrictedDashboardFragment" into main 2024-10-21 10:21:02 +00:00
Pechetty Sravani (xWF)
0583090e98 Merge "Revert "Fix force close for updating UI after activity destroyed."" into main 2024-10-21 09:49:30 +00:00
Jason Chiu
8189b40067 Make NetworkProviderSettings extend RestrictedDashboardFragment
RestrictedSettingsFragment is deprecated and no longer supported. To be
compatible with catalyst, change the super class to
RestrictedDashboardFragment.

Bug: 372733639
Test: atest NetworkProviderSettingsTest, manual tests with user restrictions
Flag: EXEMPT N/A
Change-Id: I02b08363dadd5739a1d348f099d439b9f82ffb18
2024-10-21 09:11:16 +00:00
mxyyiyi
1732fa8db0 Redesign the update logic of Allow Background Usage Page.
- Use one Controller to manage preferences related to battery Optimization Mode.
- Move optimization mode & preferences status update logic from Fragment to Controller.

Bug: 373544647
Test: atest AdvancedPowerUsageDetailTest  PowerBackgroundUsageDetailTest BatteryOptimizationModePreferenceControllerTest BackgroundUsageAllowabilityPreferenceControllerTest
Flag: EXEMPT for simple fix
Change-Id: I2b1fed837fb4904e4118ab51c1d0cda36c0f6198
2024-10-21 16:51:14 +08:00
Pechetty Sravani (xWF)
bd44c86041 Revert "Fix force close for updating UI after activity destroyed."
This reverts commit 2545f06558.

Reason for revert: DroidMonitor created revert due  to b/374650528.Will be verified through ABTD for standard investigation.

Change-Id: Ifa3f061b7954dc2b5780b768fefb9358c597fdc0
2024-10-21 06:18:31 +00:00
Treehugger Robot
ffcd548694 Merge "Fix force close for updating UI after activity destroyed." into main am: b083196e76 am: bc05a87483
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3298551

Change-Id: I005b4589f5077a40a47bd58bb2d05c6c358b48fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-21 04:55:18 +00:00
Treehugger Robot
b083196e76 Merge "Fix force close for updating UI after activity destroyed." into main 2024-10-21 04:11:01 +00:00
Chaohui Wang
95dc9fc7d8 Merge "Redirect to new APN edit page" into main 2024-10-21 01:14:25 +00:00
Daniel Norman
41440ff248 Removes overrides for shortcut-required service toggling.
These are unnecessary now that shortcut enabling is done via
A11yManager#enableShortcutsForTargets which handles enabling
a shortcut-required service if necessary, controlled by the
rolled out a11yQsShortcut flag.

These also cause a race condition conflict when attempting to toggle a
service that does not require a warning, causing it to disable the
service immediately after enabling.

Bug: 324653372
Flag: android.view.accessibility.a11y_qs_shortcut
Test: Toggle a shortcut-required service that does not require
      a warning; service is started correctly.
Test: Repeat for a service that does require a warning
Change-Id: Iff44d87faf8a5d2eb9b6643dd582c2b697ad0b5d
2024-10-18 20:26:31 +00:00
Chun-Ku Lin
abdb92453f Merge "Create an empty color and motion screen with Catalyst Infra" into main 2024-10-18 20:26:09 +00:00
Chun-Ku Lin
688cc94413 Create an empty color and motion screen with Catalyst Infra
Bug: 373451690
Test: atest ColorAndMotionScreenTest
Flag: com.android.settings.flags.catalyst_accessibility_color_and_motion
Change-Id: I4bfa5ec4d15bd745d691f586e49318b1b0a9bf6c
2024-10-18 18:36:13 +00:00
Daniel Norman
29641287d8 Merge "Hides the Edit Shortcut top preference when empty." into main 2024-10-18 17:29:37 +00:00
Treehugger Robot
bd76128c25 Merge "[Catalyst] Location screen migration" into main 2024-10-18 12:10:50 +00:00
Jason Chiu
99488fd104 [Catalyst] Location screen migration
- Add a flag for the migration
- Add the skeleton of the screen

Test: atest LocationScreenTest
Bug: 368360458
Flag: com.android.settings.flags.catalyst_location_settings
Change-Id: Id8b7d748210d1cacf99e3d61236706029b862289
2024-10-18 18:56:37 +08:00
Jason Chiu
8b66033c96 Merge "[Catalyst] SIMs screen migration" into main 2024-10-18 10:19:47 +00:00
Treehugger Robot
4f63ee455c Merge "[Catalyst] Bluetooth screen migration" into main 2024-10-18 10:17:29 +00:00
Jason Chiu
97f2c3dfb4 [Catalyst] Bluetooth screen migration
- Add a flag for the migration
- Add the skeleton of the screen

Test: atest BluetoothDashboardScreenTest
Bug: 372774767
Flag: com.android.settings.flags.catalyst_bluetooth_switchbar_screen
Change-Id: I48e446532d3e839ae55880095a496e3ac4790c81
2024-10-18 17:00:49 +08:00
Jason Chiu
af1e8f7353 [Catalyst] SIMs screen migration
- Add a flag for the migration
- Add the skeleton of the screen

Test: atest MobileNetworkListScreenTest
Bug: 368355368
Flag: com.android.settings.flags.catalyst_mobile_network_list
Change-Id: I9d5d57b78d8f2c7d2bc6fd02e402fcdaf5b97bdf
2024-10-18 16:22:08 +08:00
Jacky Wang
f788c33aa4 Merge "Add Battery skeleton page and corresponding TS flag" into main 2024-10-18 07:59:41 +00:00
Chaohui Wang
d0d3879fa4 Redirect to new APN edit page
Bug: 374226933
Flag: EXEMPT clean up
Test: am start -a android.intent.action.INSERT
          -d content://telephony/carriers --ei sub_id 2
Test: am start -a android.intent.action.EDIT
          -d content://telephony/carriers/208 --ei sub_id 2
Change-Id: I1c5e3a271e1dc85930d73b5b56b3e655821c858b
2024-10-18 15:45:17 +08:00
Treehugger Robot
e82f8ed137 Merge "Refine biometrics accessibility interactor" into main 2024-10-18 07:35:36 +00:00
Chaohui Wang
bf5c04e16b Remove TelephonyManagerConstants
- Must migrated to TelephonyManager directly
- Except NETWORK_MODE_UNKNOWN not in TelephonyManager, moved to
  newly created NetworkModes
- Move addNrToLteNetworkMode() and reduceNrToLteNetworkMode() to
  NetworkModes and adding tests

Bug: 373771849
Flag: EXEMPT refactor
Test: manual - on sims settings
Test: unit tests
Change-Id: I0781a59905415aa7896510ad086d19da48e8ba37
2024-10-18 12:02:53 +08:00
Jason Chiu
8797e3b8ea Merge "Move the annotation right before String" into main 2024-10-18 01:41:04 +00:00
Dongzhuo Zhang
8e3e3ea973 Swtich to use DefaultAccount related API to get and set default account for handling contacts.
Test: atest SettingsRoboTests:com.android.settings.applications.contacts.ContactsStorageSettingsTest
atest SettingsRoboTests:com.android.settings.applications.contacts.ContactsStoragePreferenceControllerTest
Bug: 368641291
Flag: com.android.settings.flags.enable_contacts_default_account_in_settings
Change-Id: I1164c120881714d051a6acc34e75d2b5de0f01b5
2024-10-18 00:55:34 +00:00
Daniel Norman
4c3473134c Hides the Edit Shortcut top preference when empty.
This fixes an issue where this page was presenting an inaccurate
preference list count to TalkBack because it was including this empty
preference.

(Uses the same flag as other fixes for this same bug, even though the
flag name doesn't make sense here.)

Test: atest EditShortcutsPreferenceFragmentTest
Test: Confirm preference invisible when editing a single feature,
      opened from the Settings app
Test: Confirm preference invisible when editing a single feature,
      opened from the FAB Drag-to-Edit
Test: Confirm preference still visible when editing multiple features,
      opened from the FAB Drag-to-Edit
Test: Confirm TalkBack announces correct item counts in both cases,
      including when editing Magnification which has an "advanced"
      preference that gets replaced with the triple-tap shortcut.
Bug: 318607873
Flag: com.android.settings.accessibility.toggle_feature_fragment_collection_info
Change-Id: I2e1eb7f66022c1a47d1f96a914294fd8da25549c
2024-10-18 00:18:54 +00:00
Piotr Wilczyński
ddef40edd0 Merge "Set the same density to all displays" into main 2024-10-17 15:17:59 +00:00
Jacky Wang
0901eb736d Merge "Simplify settings datastore calls" into main 2024-10-17 12:31:36 +00:00
Fan Wu
136244ab2a Add Battery skeleton page and corresponding TS flag
Test: atest
Bug: 372774754
Flag: com.android.settings.flags.catalyst_power_usage_summary_screen
Change-Id: I2ce7581d0f7fdce3516fef415efdf562c63e38d4
2024-10-17 10:06:48 +00:00
Treehugger Robot
115f4a804e Merge "[expressive design] Migrate App info page." into main 2024-10-17 09:32:23 +00:00
MiltonWu
033b7e5620 Refine biometrics accessibility interactor
1. support non-flow version isEnabled
2. support send announment

Bug: 372385781
Test: Function works w/o build break
Flag: EXEMPT feature flag protected on override project
Change-Id: I2867edf9e9b9cc9190888e257a203acd7877ab3b
2024-10-17 08:39:44 +00:00
Jason Chiu
ae5f82d36b Move the annotation right before String
Fix: 374015480
Test: build
Flag: EXEMPT N/A
Change-Id: Id4eb78319b10f63a0a8959643b63ed9a598f24af
2024-10-17 15:02:58 +08:00
Joshua Mccloskey
1d6b6cef69 Merge "Added error message to error state." into main 2024-10-17 06:47:11 +00:00
Yuchen
29a163888f [expressive design] Migrate App info page.
Test: visual
Bug: 360916599
Flag: EXEMPT bug fix
Change-Id: Icd98e1616288606b629cae7f9d9232a6efbfcaf3
2024-10-17 06:02:48 +00:00
Xinyi Mao
efb5fa5003 Merge "Use BatteryOptimizeUtils to add packageName into PowerSaveWhitelistUserApps allowlist, which will set app into Unrestricted Mode" into main 2024-10-17 04:59:43 +00:00
Jacky Wang
db3b6ee073 Simplify settings datastore calls
NO_IFTTT=Code refactor

Bug: 364899400
Flag: EXEMPT test
Test: atest DialPadTonePreferenceTest
Change-Id: Ifb4ab11e07b37952dfb3cc78d25383d563d5749d
2024-10-17 11:33:24 +08:00
Shaowei Shen
3836bfa202 Merge "[Physical Keyboard] Add slow keys dialog" into main 2024-10-17 02:06:01 +00:00
Treehugger Robot
73742e3c34 Merge "Provide icon for catalyst screens" into main 2024-10-17 01:51:10 +00:00
Treehugger Robot
421bd753c4 Merge "Migrate Text Reading" into main 2024-10-17 00:49:14 +00:00
Jaewan Kim
198579affb Merge "Enable Linux terminal app via developer settings" into main am: fcc6b6ce7c am: 49be3eebd5
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3293590

Change-Id: Icd327f4e45c3cef1eabed2a30f38ecbf2fa86a12
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-17 00:03:28 +00:00
Jacky Wang
9b62ec9616 Provide icon for catalyst screens
Bug: 335132588
Flag: EXEMPT N/A
Test: Manual
Change-Id: I520529c3bf4a7db01889d08683f55b0efb21eae4
2024-10-17 07:38:24 +08:00
Riley Jones
c850dfac26 Removes the A11y tutorial that displays on change to gesture navigation
Switching to gesture navigation puts button mode in FAB,
so there's no longer a need to show a gesture tutorial.

Test: change navigation modes. Verify no tutorial is shown for either option
Flag: android.provider.a11y_standalone_gesture_enabled
Bug: 371027085
Change-Id: I71e33efea3e25d22b0bc41c33b17de11f9ef2d64
2024-10-16 18:58:35 +00:00
Jaewan Kim
591d4fd932 Enable Linux terminal app via developer settings
Bug: 369246712
Test: `atest SettingsRoboTests`, try toggle the option, \
  and try search with 'Linux'.
Flag: RELEASE_AVF_SUPPORT_CUSTOM_VM_WITH_PARAVIRTUALIZED_DEVICES
Change-Id: Ibdcf00de04f09fe5b03ba53857904945354ed844
2024-10-16 15:49:12 +00:00
Treehugger Robot
2f80653aab Merge "Fix a crash in PhysicalKeyboardFragment" into main 2024-10-16 14:44:34 +00:00
Tetiana Meronyk
b0706be4af Set availability of AddUserWhenLockedPreference before it gets displayed.
This prevents flickering if the preference is meant to be hidden.

Bug: 373269781
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ibf1e1915e9ad872bdaaba30fb7fa9047665531f7
2024-10-16 13:28:54 +00:00
Sunny Shao
3d2f06fd7b Migrate Text Reading
Add the skeleton of the Text Reading

Test: atest TextReadingScreenTest
Bug: 372776688
Flag: com.android.settings.flags.catalyst_text_reading_screen
Change-Id: Ic5afa8da5ee7ea02d9ce9479c14d2c71e751dee4
2024-10-16 21:16:39 +08:00