Commit Graph

450 Commits

Author SHA1 Message Date
Yuchen
2b504a2762 [Expressive design] Remove extra background of MainSwitchPreference.
Bug: 349681531
Flag: EXEMPT bug fix
Test: Visual
Change-Id: Ib3a0e81b0bd1efbe85ce3992d343ae312e610dd3
2024-12-06 05:36:29 +00:00
Treehugger Robot
6b98c4e74b Merge "[SPA] Add biometric authentication for package modification" into main 2024-12-02 15:39:51 +00:00
Shraddha Basantwani
32e388ad31 [SPA] Add biometric authentication for package modification
Add an extra step of Lock Screen for disabling, force-stopping or
uninstalling updates for protected packages

UI Change Details : https://drive.google.com/drive/folders/1w7gKTmCxQ_j-9GQnIpEfF5_gmQ27b8l_?resourcekey=0-brLdN8VfqVPGm2FMwfrmkQ&usp=drive_link
Bug: 352504490, 344865740
Test: atest AppButtonsPreferenceControllerTest PackageInfoPresenterTest
Flag: EXEMPT High Security Bug
Change-Id: I0c494e307b02229d751de118abcc89e4e61a6861
2024-12-02 09:36:05 +00:00
Jacky Wang
36684ec80d [Catalyst] Migrate SIMs entry point
NO_IFTTT=Catalyst only

Bug: 368355368
Flag: com.android.settings.flags.catalyst_network_provider_and_internet_screen
Test: Manual
Change-Id: I2f3526c1ccb50490b955ad5f98c19d9ce2f5f21d
2024-12-02 11:26:37 +08:00
Pawan Wagh
57ca4d313e Add AppInfo setting for page size appcompat
Adding preference which set the page size app compat
for given app.

Test: m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk
Flag: page_size_app_compat_setting
Bug: 371049373
Change-Id: I91d014594e99e174f55010ca57aa19edc2071255
2024-11-27 05:48:12 +00:00
Chaohui Wang
470a4a86af Set InstallUnknownAppsListModel override check
Set switchifBlockedByAdminOverrideCheckedValueTo = false

Since the user actually not allowed to install unknown apps when the
restrictions are enforced, we should display unchecked status.

Fix: 380205192
Flag: EXEMPT bug fix
Test: manual - on Install unknown apps
Change-Id: Ia2b2b6bce8b3b37f153e0c91cbeaf69486501407
2024-11-22 12:10:52 +08:00
Chaohui Wang
a2ccf8979d [expressive design] SimsSection
Bug: 349681531
Flag: EXEMPT bug fix
Test: visual
Change-Id: I2d38ad81ce93d47819fa82d46f1c11a9b8c9271d
2024-11-18 18:45:53 +08:00
Chris Antol
22306eb982 Add Special App Access page for WRITE_SYSTEM_PREFERENCES permission
Bug: 374848822
Flag: com.android.settingslib.flags.write_system_preference_permission_enabled
Flag: com.android.settingslib.flags.settings_catalyst
Test: in-app test
Change-Id: I8116e40108175d2606b0c24655d457c1f04afc35
2024-11-15 01:36:04 +00:00
Treehugger Robot
115f4a804e Merge "[expressive design] Migrate App info page." into main 2024-10-17 09:32:23 +00:00
Yuchen
29a163888f [expressive design] Migrate App info page.
Test: visual
Bug: 360916599
Flag: EXEMPT bug fix
Change-Id: Icd98e1616288606b629cae7f9d9232a6efbfcaf3
2024-10-17 06:02:48 +00:00
mxyyiyi
7bfa060c5f Take as Unrestricted Mode in the UI if current Mode is Unknown.
- Battery usage mode MODE_UNKNOWN is (1) apps in allowlist and (2) app's OP_RUN_ANY_IN_BACKGROUND = MODE_IGNORED.
For this case, mode should be displayed as Unrestricted on UI since it is in allowlist; and should be logged as unknown mode for the potential compatibility issues.

- After Backup & Restore, the MODE_UNKNOWN will be reset to Optimized(Default) Mode on target device.

Bug: 372831500
Test: manual
Test: atest BatteryOptimizeUtilsTest
Test: atest AppOptModeSharedPreferencesUtilsTest
Flag: EXEMPT for simple fix
Change-Id: Ic18e026f71a4a50ffa1711e2ca0782aeb8b33076
2024-10-15 15:53:29 +08:00
Chaohui Wang
bab2edd0ef Fix SpaSearchLandingActivity.isValidCall()
SettingsIntelligence sometimes starts SearchResultTrampoline first,
in this case, SearchResultTrampoline checks if the call is valid, then
SearchResultTrampoline will start this SpaSearchLandingActivity, allow
this use case.

Fix: 370186204
Flag: EXEMPT bug fix
Test: manual - search roaming
Change-Id: Ib6b2c1d3b8754f478a637dda8e9df77a91b24d9e
2024-10-10 06:25:00 +00:00
Chaohui Wang
73fb290969 Check DISALLOW_CONFIG_MOBILE_NETWORKS when search
If disallowed, not show mobile related search results.

Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search Mobile Settings
Test: atest MobileNetworkSettingsSearchIndexTest
Change-Id: I79b984f41f09dd9612bcd0c9942089756d5d365d
2024-09-23 11:17:55 +08:00
Chaohui Wang
777a179bd6 Create MobileNetworkSummaryRepository
For MobileNetworkSummaryController to use, so it no longer use
MobileNetworkRepository.

Fix: 366097262
Flag: EXEMPT refactor
Test: manual - on Network & internet
Test: atest MobileNetworkSummaryRepositoryTest
Change-Id: I8a9d52af8e230fc407a4339c27f73ef79d512b24
2024-09-18 13:07:50 +08:00
Chaohui Wang
a6db1aabb6 Create SimRepository
Which unifies whether we should sim settings on some related pages.

Before this change, we check SubscriptionUtil.isSimHardwareVisible()
and / or Utils.isWifiOnly().

After this change, we unified logic to,
canChangeSimSettings() =
  packageManager.hasSystemFeature(PackageManager.FEATURE_TELEPHONY) &&
    userManager.isAdminUser

Fix: 365924140
Flag: EXEMPT bug fix
Test: manual - check Network & internet
Test: unit tests
Change-Id: Ibf83237e3d0088f78c96a1b39ee8f1e3a9c756ea
2024-09-12 08:59:26 +00:00
Chaohui Wang
426cbd623d [Safer intents] App Time Spent Preference
Set package com.android.internal.R.string.config_systemWellbeing to the
intent.

Fix: 356117796
Flag: EXEMPT bug fix
Test: manual - on App info
Test: atest AppTimeSpentPreferenceTest
Change-Id: I2af7b53a75fe5c6915dd9781406039822789c18c
2024-09-04 11:18:28 +08:00
Chaohui Wang
f74e90787e Create EuiccRepository
Which also avoid calling from main thread.

Bug: 356684993
Flag: EXEMPT bug fix
Test: manual - on SIMs
Test: atest EuiccRepositoryTest
Change-Id: I0b11b0bd1e8a4b5754781e888fd220fa3080a212
2024-08-29 11:34:19 +08:00
Chaohui Wang
6afa25df8b Encode SpaSearchLandingKey with Base64
To ensure the landing key is the same as the indexing key.

Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search roaming
Test: unit test
Change-Id: I26ce712feaa83e9e70a3eb39039e5c3527f24cca
2024-08-16 16:00:02 +08:00
Chaohui Wang
874c818b31 Settings search for Vo5G
Also adding keywords support to MobileNetworkSettingsSearchItem.

Fix: 262684662
Flag: EXEMPT bug fix
Test: manual - search vo5g
Change-Id: Ic73b76a2a7b2ef238b167fe3673835298d8939fd
2024-07-31 17:47:21 +08:00
Chaohui Wang
7009c008f9 Fix search for MMS Message
Also display multiple results when there are multiple MMS Message on
different SIMs.

When doing indexing, we not also log sub id as part of the key.
When user clicks the result, using SpaSearchLandingActivity to do the
redirection, set arguments to the fragment.

Fix: 352245817
Flag: EXEMPT bug fix
Test: manual - search mms
Test: unit test
Change-Id: Id47a1151cb418c18f68f97e3be33dcd21c5f5102
2024-07-30 11:34:24 +08:00
Chaohui Wang
7477f4ea9a Show category when search "Mobile data"
The displayed category is "SIMs".

Bug: 346776183
Flag: EXEMPT bug fix
Test: manual - search "Mobile data"
Test: unit test
Change-Id: If3c395281e96603193e7476a9e76d1f9e9213531
2024-07-30 09:48:28 +08:00
Yuchen Sun
028dd20d96 Merge "Clean up slice from spa and move androidx.slice dependency to Settings." into main 2024-07-18 08:26:05 +00:00
Yuchen Sun
93036e2045 Clean up slice from spa and move androidx.slice dependency to Settings.
Test: build successfully
Flag: EXEMPT clean up
Bug: 352442832
Change-Id: Ifc222a91991d4924f1cb7b5c1e7fd90968bfed26
2024-07-18 08:25:48 +00:00
Chaohui Wang
fb0583404f Always set cross sim calling
By CrossSimCallingViewModel, in SIMs and per SIM settings page.
To ensure the status is always right, including the case after the
onboarding set up finished.

Fix: 347882381
Fix: 348529996
Flag: EXEMPT bug fix
Test: manual - turn on / off "Automatic data switching" on SIMs
Test: manual - turn off "Automatic data switching" during onboarding
Change-Id: Icc2eacb67850fa7b3aa0fe310cd09a0e0147912b
2024-07-16 17:46:23 +08:00
Chaohui Wang
cacc9a88b2 Revert^2 "Support search "Mobile data""
This reverts commit 979de75952.

Reason for revert: Failed CarDeveloperOptions tests fixed.

Change-Id: Ic0bdf47ab3cb40dbadebb738c0c5842e4e1bf9c8
2024-07-15 02:03:06 +00:00
Pechetty Sravani
979de75952 Revert "Support search "Mobile data""
This reverts commit 50d9e342e8.

Reason for revert: Droidmonitor created revert due to b/352668970. Will be verifying through ABTD before submission.

Change-Id: I5e0c48830425c51963b7669b75979cb8b67e770c
2024-07-12 07:40:28 +00:00
Chaohui Wang
50d9e342e8 Support search "Mobile data"
- Added SpaSearchRepository to index the SPA search data.
- Added SpaSearchLandingActivity, which can only be called by SI.

Fix: 346776183
Flag: EXEMPT bug fix
Test: manual - search "Mobile data"
Test: unit test
Change-Id: Icaff41fe085edd371fd75bc8101dd52028f90da5
2024-07-12 03:52:03 +00:00
Julia Reynolds
bb10c9f4df Fix IndexOutOfBoundsException
Test: none, MonkeyComboTest_StabilityMonkey
Fixes: 341614935
Flag: EXEMPT bugfix
Change-Id: Id52bcbc40145d7dca477425322e317abc2268a59
2024-07-03 09:32:59 -04:00
Steve Statia
d26521f7bb Merge "Fix to hide Display over other apps permission setting for the Scone application." into main 2024-07-01 17:18:23 +00:00
SongFerng Wang
183a191cbf Merge "Add condition for askEveryTime of SMS at Primary Sim" into main 2024-07-01 08:01:50 +00:00
Steve Statia
2a3e96b4b5 Fix to hide Display over other apps permission setting for the Scone
application.

Flag: EXEMPT bugfix

Bug: 349195999
Test: manually testing that the setting is removed from Adaptive
Connectivity Services advanced settings page.

Change-Id: I3f306d24040f500c7fed4f44309e9f58f5f766be
2024-06-28 22:12:50 +00:00
songferngwang
1892d20ce8 Add condition for askEveryTime of SMS at Primary Sim
Using the config_sms_ask_every_time_support control the askEveryTime

Bug: 349169874
Test: atest PrimarySimRepositoryTest
Flag: EXEMPT bugfix

Change-Id: Ida82ed3a6b5264f8d8c5997584e9fd27f25bf09f
2024-06-28 05:17:38 +00:00
Chaohui Wang
7ef8b0c518 Export SpaDestination.startFromExportedActivity
To be called from other exported activity in the future.

Bug: 346776183
Flag: EXEMPT refactor
Test: adb shell am start \
          -a android.settings.REQUEST_MEDIA_ROUTING_CONTROL
Test: unit test
Change-Id: Ica105ab3b56d33e4cd2fe1bb1c1218ef2f219ab3
2024-06-27 14:16:58 +08:00
tomhsu
75509bd06b Avoid to change preference UI content from tapping outside of dialog.
Flag: EXEMPT bug fix
Fix: 335763360
Test: atest passed.
Test: Manual test passed.
Change-Id: Iec5e98f74f0009ab2d3bc21bc590229514192f93
2024-06-26 02:38:25 +00:00
Chaohui Wang
ec59cd0c8b Move mobile data logic into MobileDataRepository
Bug: 347224962
Flag: EXEMPT refactor
Test: manual on Mobile Settings
Test: unit
Change-Id: I2b54f9e6c4addafd31d7d96f2a44870cd54fe185
2024-06-20 11:49:06 +08:00
SongFerng Wang
0cc20946c8 Merge "Add metricsCategory for dualsim and apnEdit" into main 2024-06-14 09:25:47 +00:00
songferngwang
d4e467ed4a Add metricsCategory for dualsim and apnEdit
Bug: 347091697
Test: Build pass
Change-Id: I783a45269112d91d79c00af41c0052ba488603d2
2024-06-13 23:00:29 +00:00
Chaohui Wang
2717f70ac0 InternetPreferenceController V2 (3/n)
Add DataSubscriptionRepository, when cellular connection,
show the active subscription name.

Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - on Internet
Test: unit test
Change-Id: If2a3e7f8df1b1ed89bc760ec5165182b3e9b64a8
2024-06-12 15:33:38 +08:00
Tom Hsu
c417d19839 Merge "Avoid to save result of blank input." into main 2024-06-06 08:43:37 +00:00
tomhsu
6be77d05cb Avoid to save result of blank input.
- Disable "Save" button if no input or only space chars.

fix: 335763360
Test: Manual test
Test: atest pass
Change-Id: Ied5f98ec0ce7d1f38f626211cb9f465781781cd8
2024-06-06 07:27:04 +00:00
Chaohui Wang
3362e5d14a Refactor PrintSettings (1/n)
Add PrintRepository for display Print services.

Bug: 320076351
Flag: com.android.settings.flags.refactor_print_settings
Test: manual
Test: unit test
Change-Id: I1ea52508d504161675eeffeb3ec077caa641cb2c
2024-06-05 13:14:08 +00:00
Chaohui Wang
f557b1f45b Merge "Move logic about hide system / root UID apps" into main 2024-06-05 04:00:16 +00:00
SongFerng Wang
ded1c459b0 Merge "To hide the mobile data when there is no active sim" into main 2024-05-30 10:59:32 +00:00
songferngwang
b48ec2f772 To hide the mobile data when there is no active sim
Bug: 343633243
Test: verified the UI
Change-Id: I77055a9c1cdb7e94c0339f4255b4799b7b6e02ac
2024-05-30 09:24:25 +00:00
Chaohui Wang
1bfea5d472 Check if ECBMode when deactivate SIM card
If in ECBMode, start ACTION_SHOW_NOTICE_ECM_BLOCK_OTHERS to show a
dialog instead.

This align with the current airplane mode switch.

Fix: 191943857
Test: adb shell cmd phone emergency-callback-mode
Test: unit test
Change-Id: Icf646cd76990d621121b4367ec0fd02a3880b85c
2024-05-30 16:37:51 +08:00
Chaohui Wang
942622575a Disable "Reset app preference" during call
Reset app preference will dismiss all the notification, disable
"Reset app preference" during call so in call notification not get
dismissed.

Fix: 342627537
Test: manual - try "Reset app preference" during call
Change-Id: Ida9961ca30dc80c05d4de5bc9faac3203967f3d3
2024-05-30 05:44:14 +00:00
Tom Hsu
49abe4c03d Merge "Fix when edittext only has space and cause name look like blank" into main 2024-05-29 05:08:07 +00:00
tomhsu
d5556c59e9 Fix when edittext only has space and cause name look like blank
fix: 335763360
Test: Manual test. see b/335763360#comment14
Test: atest passed
Change-Id: I9ebae13039d7b78b7acfea545a89d3096aa82c31
2024-05-29 03:42:35 +00:00
SongFerng Wang
b462f9fa11 Merge "The pages of sim onboarding flow is wrong." into main 2024-05-28 19:58:55 +00:00
songferngwang
98efa51681 The pages of sim onboarding flow is wrong.
Switch from SS mode to DSDS mode, the esim status will use the last
status. It causes the condition of page selection is wrong.

Bug: 342972402
Test: atest SimOnboardingPageProviderTest
Change-Id: I8bb0b5f2802ec24f10467bac179ce54d13a9755e
2024-05-28 08:47:23 +00:00