Android/packages_apps_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
145,272 Commits 1 Branch 0 Tags
48b13e5cb15d5969d3d7c935d6205846cff03a7d
Commit Graph

7 Commits

Author SHA1 Message Date
Matías Hernández
b3468ca88a (Once more) fix minimum height of mode name edit box for a11y 
We had fixed this before and then regressed when moving to TextInputLayout, so added a proper test this time.

Fixes: 380207192
Test: atest ZenModeEditNamePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: Ic25b0a5a6997e7b3bb26bf26ed7e8e92654a1c11
 2024-12-02 16:06:58 +01:00
Yuri Lin
539bae8db4 Add missing paren 
Bug: n/a comment only
Test: n/a comment only
Flag: android.app.modes_ui

Change-Id: Ia43b76e969fcd9a5ad1d682ffb99fc1b48644f93
 2024-10-03 21:14:50 +00:00
Matías Hernández
b1e28233c1 Use TextInputLayout for the name field in the create/rename mode page 
In addition to looking nicer, this fixes two accessibility issues ("no hint when text is entered" and "reason for disabled button is unclear").

This requires a bit of theme merging black magic, because TextInputLayout requires a Theme.AppCompat descendant, which the Settings theme isn't.

Fixes: 356398157
Fixes: 370654542
Fixes: 369942776
Test: atest ZenModeEditNamePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I92d8ec044dabc6daed5d755e206120ec7abc143e
 2024-10-03 14:14:34 +02:00
Treehugger Robot
2be56f27f3 Merge "Make the name EditText at least 48dp high in the Mode rename page" into main 2024-09-30 17:39:10 +00:00
Matías Hernández
71671897d7 Make the name EditText at least 48dp high in the Mode rename page 
Touch targets should be at a minimum 48x48 dp; this view was 47 dp high. ¯\_(ツ)_/¯

Fixes: 369963437
Test: manual
Flag: android.app.modes_ui
Change-Id: I8fda0cd505f02abb561e24e583b3ab509b5ef4dd
 2024-09-30 18:04:46 +02:00
Matías Hernández
f620f85484 Add a header before the icon list in the new/rename mode screen 
Also fixed paddings a bit (e.g. Done button was too close to the icon grid).

Fixes: 369503296
Test: manual
Flag: android.app.modes_ui
Change-Id: Ic7b7dc9584db1f04b448fce828a8ec70cf17f06a
 2024-09-26 15:25:01 +02:00
Matías Hernández
574fcaf1b2 Add mode: Choose name and icon for new custom modes 
This also unifies the "icon picker" screen with the new "add mode" screen since in both cases we want to edit name and icon together (and not save updates until the user confirms).

Bug: 326442408
Bug: 346278854
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I8a9d07ba0b6c55f3abc1b9884f278d51d178dc83
 2024-07-06 22:12:58 +00:00