Commit Graph

31219 Commits

Author SHA1 Message Date
TreeHugger Robot
46ff5abc5b Merge "Incorrect checkbox icon in dynamic group panel" into rvc-dev am: 766e060c75
Change-Id: I0989c5e7ac206ffe1e339801c4885b2523a2dd36
2020-04-22 07:45:54 +00:00
Bonian Chen
d436727a3e Merge "[Settings] To avoid from crash when callback" into rvc-dev am: af05f6303d
Change-Id: Ica383ae78a7b4b921bcbf2b303f68b65d94da61b
2020-04-22 07:45:47 +00:00
TreeHugger Robot
766e060c75 Merge "Incorrect checkbox icon in dynamic group panel" into rvc-dev 2020-04-22 07:16:42 +00:00
Bonian Chen
af05f6303d Merge "[Settings] To avoid from crash when callback" into rvc-dev 2020-04-22 07:00:12 +00:00
Jason Chiu
499364c9fd Merge "Fix the incorrect title of Panel" into rvc-dev am: 1f91111c3a
Change-Id: Ife2fade68a4cc565111adb773986c45707840a6e
2020-04-22 06:47:16 +00:00
Jason Chiu
1f91111c3a Merge "Fix the incorrect title of Panel" into rvc-dev 2020-04-22 06:30:12 +00:00
Jason Chiu
4bbc85eb54 Fix the incorrect title of Panel
Since panel activity is singleInstance, a newer panel will reuse the
same fragment as the previous panel when they are displayed one after
another.

Panel fragment has two kinds of exclusive header layout which shouldn't
be showed at the same time, so we have to reset their visible states
when creating panel content.

Fixes: 154668079
Test: robotest
Change-Id: I701a7cde4b43322fbc63ae1cb74c41dd23b37c0c
2020-04-22 06:29:57 +00:00
Tim Peng
55ce33fbe7 Incorrect checkbox icon in dynamic group panel
-Mutate icon to prevent modifying the original resource

Bug: 154673054
Test: build pass
Change-Id: I0e1a6506cb951f80f316649d27c7728132c05be6
2020-04-22 13:50:46 +08:00
TreeHugger Robot
607549b764 Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev am: d2291d447e
Change-Id: I83bbce8da2482ca8f3eac6dc83644fc5b5056c2d
2020-04-22 05:31:53 +00:00
TreeHugger Robot
d2291d447e Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev 2020-04-22 05:18:34 +00:00
Bonian Chen
290c27c79e Merge "[Settings] Fix DataUsageSummaryPreferenceControllerTest" into rvc-dev am: 8f26e88bd9
Change-Id: I3ace138206b89eb73e3ac638ae9b01fa6aec2848
2020-04-22 04:41:13 +00:00
Bonian Chen
8f26e88bd9 Merge "[Settings] Fix DataUsageSummaryPreferenceControllerTest" into rvc-dev 2020-04-22 04:27:43 +00:00
Zhen Zhang
904a61ddfd Merge "Add ethernet tether option into AllInOneTetherSettings" into rvc-dev am: 92340eb89e
Change-Id: I76743b3f353bf8c01f3f62966ecdde7ccd549509
2020-04-22 03:06:18 +00:00
Zhen Zhang
92340eb89e Merge "Add ethernet tether option into AllInOneTetherSettings" into rvc-dev 2020-04-22 02:52:58 +00:00
Bonian Chen
61b9714a34 [Settings] Fix DataUsageSummaryPreferenceControllerTest
Fix test case of DataUsageSummaryPreferenceControllerTest

Bug: 154562264
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I0b3366c86b0a621b9dda88bbcde6e118d37995b7
2020-04-22 10:39:42 +08:00
tim peng
7bd9cea220 Merge "The volume slider should not show for the unselected device" into rvc-dev am: 24205d4632
Change-Id: I93e705d1185862dacc04f8038327d7c3727af725
2020-04-22 01:18:50 +00:00
tim peng
24205d4632 Merge "The volume slider should not show for the unselected device" into rvc-dev 2020-04-22 01:00:33 +00:00
TreeHugger Robot
cfceb02890 Merge "Notification history a11y fixes" into rvc-dev am: f11da4c787
Change-Id: Ib7717f8112cf2024d05e9fc75a13fd060bbf6364
2020-04-21 21:37:09 +00:00
TreeHugger Robot
f11da4c787 Merge "Notification history a11y fixes" into rvc-dev 2020-04-21 21:22:44 +00:00
Beverly
4922aa006a Notification history a11y fixes
- When clicking the expand/collapse button to see the posted
notifications from an app in the last 24 hours, refocus accessibility on
the button so the entire button (contentDescription + clickability) are
announced. Previously only the contentDescription update was being
announced.

- Fix local context menu of NotificationHistory elements by calling the
super method in performAccessibilityAction

Test: manual
Fixes: 153396313
Fixes: 153518629
Change-Id: I3d847ec1f2b72dcf411c6c7c7fe2dc061ccfde26
2020-04-21 14:54:45 -04:00
Yanting Yang
bfe16291a3 Fix breadcrumb of search results provided by Settings
Settings Search need Settings to provide custom site map pairs to
build up full breadcrumb for the search results from Gesture Settings
page.

Bug: 147851992
Bug: 151206664
Test: visual and robotests
Change-Id: I4a61e6da48755184954c2c90834578030ffc2e10
2020-04-21 19:11:45 +08:00
Pavel Grafov
8d8eb618e7 Merge "Stop disabling wifi toggle when tethering is restricted" into rvc-dev am: 9341983324
Change-Id: Ia3a28b881005c732d0158890b68de22d97703068
2020-04-21 10:52:43 +00:00
Pavel Grafov
9341983324 Merge "Stop disabling wifi toggle when tethering is restricted" into rvc-dev 2020-04-21 10:40:12 +00:00
Jason Hsu
d31f5d58d8 Merge "Show default description only if description and html description are empty" into rvc-dev am: 0055a74794
Change-Id: I4a4fa05ec2f2a1a6aa615030a446d46ef9065caf
2020-04-21 09:44:20 +00:00
TreeHugger Robot
aade7d4eb2 Merge "[Wi-Fi] Show not show Wi-Fi edit UI for never connected open Wi-Fi networks" into rvc-dev am: 8a80769a7e
Change-Id: If95a32057db5aa8bfb9f6cd3c3896333c6b9cc84
2020-04-21 09:42:21 +00:00
Jason Hsu
0055a74794 Merge "Show default description only if description and html description are empty" into rvc-dev 2020-04-21 09:41:15 +00:00
TreeHugger Robot
8a80769a7e Merge "[Wi-Fi] Show not show Wi-Fi edit UI for never connected open Wi-Fi networks" into rvc-dev 2020-04-21 09:20:52 +00:00
Tim Peng
e94de7fbb2 The volume slider should not show for the unselected device
-Design changes

Bug: 154555379
Test: Manual test
Change-Id: Icb127867911bc4bba0b77ce374332451b23f1215
2020-04-21 09:10:02 +00:00
Bonian Chen
f09a56e322 Merge "[Settings] Refactor test case DataUsageSummaryPreferenceControllerTest" into rvc-dev am: 6fb4a18ded
Change-Id: I6d8e2ed82aba6c03763128d311de5b9d7b42f1c0
2020-04-21 08:57:45 +00:00
Alex Johnston
cdc42618c9 Merge "Update Wi-Fi configs restrictions" into rvc-dev am: 56f06c59a1
Change-Id: Iee667169f8b996270611ca5e53f71c6e7065734d
2020-04-21 08:57:40 +00:00
Bonian Chen
6fb4a18ded Merge "[Settings] Refactor test case DataUsageSummaryPreferenceControllerTest" into rvc-dev 2020-04-21 08:48:36 +00:00
Alex Johnston
56f06c59a1 Merge "Update Wi-Fi configs restrictions" into rvc-dev 2020-04-21 08:41:10 +00:00
Bonian Chen
c1eb5bf440 Merge "[Settings] Code refactor" into rvc-dev am: 5bc8aa7961
Change-Id: Ie76ffbf51abd1550f40a053d32e2dc65afac6cf9
2020-04-21 08:25:47 +00:00
Bonian Chen
5bc8aa7961 Merge "[Settings] Code refactor" into rvc-dev 2020-04-21 08:21:28 +00:00
Bonian Chen
ab0c02393e Merge "[Settings] Support of DSDS API" into rvc-dev am: 57c2df4c7c
Change-Id: I54de1254ccb967fc40d1b3533b67d725feb0baa7
2020-04-21 08:18:28 +00:00
Arc Wang
205b585cf3 [Wi-Fi] Show not show Wi-Fi edit UI for never connected open Wi-Fi networks
When users click a Wi-Fi network and it's
WifiConfiguration.getNetworkSelectionStatus().hasEverConnected()
is false, WifiSettings2 will launch the Wi-Fi edit UI for users
to edit password again.
It's not necessary to show the Wi-Fi edit UI if the Wi-Fi network
is a open network.

Bug: 154548505
Test: manual
      Click a never connected secure Wi-Fi and edit UI shows.
      Click a never connected open Wi-Fi and edit UI does not show.
Change-Id: Ie8489aff001942f92fbfaafd772f84b1b4a09cf4
2020-04-21 16:04:03 +08:00
Bonian Chen
57c2df4c7c Merge "[Settings] Support of DSDS API" into rvc-dev 2020-04-21 07:55:07 +00:00
Bonian Chen
dcef423720 [Settings] Refactor test case DataUsageSummaryPreferenceControllerTest
Refactor test case of DataUsageSummaryPreferenceControllerTest

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: Ieb551a32d87c53cbd0765e19e710f1f0469da9d5
2020-04-21 15:08:27 +08:00
Bonian Chen
0f47147543 [Settings] To avoid from crash when callback
Callback from SubscriptionManager and PhoneStateListner may comes in
under the case of Preference not available.

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingPreferenceControllerTest
Change-Id: I50b83b4488d272f6482bde5f09b57d59e6fc27a3
2020-04-21 15:02:14 +08:00
Xiangyu/Malcolm Chen
88bf3999d1 Merge "Define a helper link for 5G limitation in DSDS footer." into rvc-dev am: eb27c7d94a
Change-Id: I1123f2c8bf6a4bbc6fe2a4c84813446fc9df3eef
2020-04-21 07:01:26 +00:00
Bonian Chen
5b6c7a976e Merge "[Settings] Avoid from EUICC access blocking main thread" into rvc-dev am: 7606dfd931
Change-Id: I3b9f0c36b51c1a27976e3d40aaaec257c137f256
2020-04-21 07:01:17 +00:00
Xiangyu/Malcolm Chen
eb27c7d94a Merge "Define a helper link for 5G limitation in DSDS footer." into rvc-dev 2020-04-21 06:47:18 +00:00
Bonian Chen
9bc2f7f8bc [Settings] Code refactor
Minor code refactor

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: I060e7c880d91a0e5059610c5ceae319d47c19c7a
2020-04-21 14:43:48 +08:00
Bonian Chen
7606dfd931 Merge "[Settings] Avoid from EUICC access blocking main thread" into rvc-dev 2020-04-21 06:40:40 +00:00
tim peng
c118a89a68 Merge "Change the wording from "Stop casting" to "Stop"" into rvc-dev am: 58f9d0c7b9
Change-Id: Ie53b603df317bbc96d64d0796551745f3754bce9
2020-04-21 06:10:05 +00:00
tim peng
58f9d0c7b9 Merge "Change the wording from "Stop casting" to "Stop"" into rvc-dev 2020-04-21 05:51:25 +00:00
tim peng
ab1a5a5fa0 Merge "Hide volume slider in Output Switcher when volume adjustment is restricted" into rvc-dev am: db86b2ef2a
Change-Id: Ia7455d79077b2cc0ec08916bdc66cb30e6ea4616
2020-04-21 02:34:26 +00:00
Tim Peng
4fe1de57a5 Change the wording from "Stop casting" to "Stop"
-The string is freezed. Reuse current "Stop" string

Bug: 153705889
Test: make -j42 RunSettingsRoboTests
Change-Id: I39184dcbfda5937677ab171a66ad5dcbbb8e6b68
2020-04-21 10:22:15 +08:00
tim peng
db86b2ef2a Merge "Hide volume slider in Output Switcher when volume adjustment is restricted" into rvc-dev 2020-04-21 02:17:30 +00:00
jasonwshsu
f74c0a72b6 Show default description only if description and html description are empty
* AccessibilitySettings only get the description to pass to the
ToggleFeaturePreferenceFragment
* ToggleFeaturePreferenceFragment handle the default description logic

Bug: 154092127
Test: make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.accessibility.AccessibilitySettingsTest"
Change-Id: I516a393aeef1472ca5d185d477a2b0b108fc5342
2020-04-21 01:34:22 +00:00