Commit Graph

2966 Commits

Author SHA1 Message Date
Charlotte Lu
495ab9d09e Merge "Add [ssid] is blocked for wep network" into main 2024-01-18 09:42:13 +00:00
Charlotte Lu
a38b151118 Add [ssid] is blocked for wep network
Test: Visual Test
Fix: 320829123
Change-Id: Ia742e8b3e622c4c44a69daca20ca64edc6f9f826
2024-01-18 16:44:52 +08:00
Charlotte Lu
77615e83d2 Merge "Adjusting the apn action items" into main 2024-01-18 07:38:22 +00:00
Charlotte Lu
e0f6540fd1 Adjusting the apn action items
Test: Visual Test
Fix: 320617647
Change-Id: If3fddab5b45140b2c66a3487c08b421a1bd3b78a
2024-01-18 13:04:06 +08:00
Charlotte Lu
1eb4bc0c5f Merge "Duplicate apn entry" into main 2024-01-18 04:00:58 +00:00
SongFerng Wang
7e2fc39678 Merge "Remove the phone number at Rename page" into main 2024-01-17 09:08:49 +00:00
Charlotte Lu
031aa3417d Duplicate apn entry
Test: Visual Test
Fix: 319194851
Change-Id: I491655bb80a17cc9fc99d47f1e1ac5824eb11921
2024-01-17 15:58:24 +08:00
SongFerngWang
4366ceea15 Remove the phone number at Rename page
Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: Build pass
Change-Id: I6e77f2a8858e17e3e56c01769e6eb5b4fd478a04
2024-01-17 15:11:55 +08:00
Chaohui Wang
8a5bf167c1 Merge "Catch IllegalStateException when get carrier config" into main 2024-01-16 03:37:13 +00:00
Charlotte Lu
89b966fff5 Merge "When apn is read only, hide the save button." into main 2024-01-15 08:54:51 +00:00
Chaohui Wang
9a6a0865de Catch IllegalStateException when get carrier config
Fix: 319149441
Test: manual - on System Update page
Test: unit test
Change-Id: I484a036b2ce086531b20e1a5ca7e541934bc4c07
2024-01-15 16:52:06 +08:00
Charlotte Lu
f8bc0841bc When apn is read only, hide the save button.
Test: Visual Test
Fix: 320200491
Change-Id: I8280fdaa3643a982137936473d827b8502a6e023
2024-01-15 15:39:49 +08:00
Hyunho Shin
4130a95c5d Merge "Add the condtions to show the pSIM conversion menu" into main 2024-01-15 05:12:40 +00:00
Hyunho
3d2c417236 Add the condtions to show the pSIM conversion menu
if the value of carrier config and current SIM's carrier is matched, then the pSIM conversion menu will show

Bug: b/319527964
Test: manual test (b/319527964#comment3)
Change-Id: I82025447f43c0151ba58edd77c6f8b7e8aff660d
2024-01-13 03:48:07 +00:00
Hakjun Choi
197a10a0a9 Filter out satellite plmn when in SAT mode
[SAT-070] : PLMNs associated with SAT MODE, as specified in SAT-008, should not be displayed or selectable in Manual Selection/Network Operator Menu

Bug: 316264277
Test: Manual test with pixel in live network
Test: atest NetworkSelectSettingsTest

Change-Id: Ic100772c97fa1ab18d7e63b654e397d8a80eda8a
2024-01-11 07:14:30 +00:00
Sunny Shao
bee65b4109 Merge "Revert^2 "Nullability Annotations replacement"" into main 2024-01-10 08:35:06 +00:00
Sunny Shao
076ed573eb Revert^2 "Nullability Annotations replacement"
This reverts commit 19d1d3d15d.

Reason for revert: revert it because this is not the root cause.

bug: 316867690
Change-Id: I0f168dbb64044aa720202af7b1040afd4f028c9c
2024-01-10 07:34:01 +00:00
Hyunho
b6a6b1e91a Add the config to show the pSIM conversion menu and set it to false
Bug: b/314881248
Test: manual done
Change-Id: I258471182cb9092fade50881f52f7299c10c8da2
2024-01-10 06:00:12 +00:00
Charlotte Lu
d442ac8db1 mmsc can be ""
Test: Visual Test
Fix: 319063785
Change-Id: I8909412b1debee06fa461de9e9230a991bc046e1
2024-01-08 09:43:34 +00:00
Chaohui Wang
601fe12ea9 Merge "Show "0 B used" when no data usage this cycle" into main 2024-01-08 05:39:47 +00:00
Joonhun Shin
43d6a231e0 Merge "Data only device(without FEATURE_TELEPHON_CALLING) : Add try/catch to handle UnsupportedOperationException" into main 2024-01-08 02:06:46 +00:00
Chaohui Wang
f28d119560 Show "0 B used" when no data usage this cycle
When the latest cycle has no data usage, currently it shows all time
usage without cycle info, which could confuse user.

Change to "0 B used used xxx - xxx" to fix this issue.

Fix: 292346951
Test: manual - on Mobile Settings
Test: unit tests
Change-Id: Ic06fd63a3bc049d70538d0a3cd1fa3d62dbd71d7
2024-01-06 19:05:47 +08:00
Chaohui Wang
df5c4f69a8 Fix DataUsageSummaryPreferenceController ANR
By off load data loading to background.

Fix: 295260929
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ib2ef19301b1e97af8a7f3861829779c3b70da4a4
2024-01-05 16:07:28 +08:00
Treehugger Robot
e8d26737a6 Merge "Reset telephony stack during Reset Mobile Network flow" into main 2024-01-05 04:49:29 +00:00
Rambo Wang
4c384506d5 Reset telephony stack during Reset Mobile Network flow
This CL introduces two more steps to restart Phone process and RILD
during the Reset mobile network flow by the help of the
TelephonyContentProvider which has been used by Pixel Adaptive
Connectivity Services ("SCONE") for a while.

The additional reset options can resolve issues like resources leak
and internal state stuck, effectively recover telephony stack into
fresh state.

The reset options are performed in the background and have no impact
on UX of the reset flow.

Bug: 271921464
Test: ResetNetworkOperationBuilderTest
Test: Feature test with both flag on and off
Change-Id: If09d20d79e908dd43f3f654fb7cca7f713b7f03a
2024-01-05 03:53:21 +00:00
joonhunshin
37d4fb736e Data only device(without FEATURE_TELEPHON_CALLING) : Add try/catch to handle UnsupportedOperationException
If the device does not have Telephony feature calling, the some of interfaces in TelephonyManager throw UnsupportedOperationException.

Bug: 297989574
Test: oriole with ATT SIM, boot completed
      APM/data/wifi on/off, browse setting menu
Change-Id: Ifa9092cd8d9a00039e9d93d5fd9fc4dabed633c8
2024-01-05 03:04:14 +00:00
Chaohui Wang
7cbfc40681 Migrate NetworkOperatorPreference to Kotlin
Bug: 293845605
Test: manual - with SIM Settings
Test: unit test
Change-Id: I5c21085a4ec9c2f53f93867813ba298690f161ff
2024-01-04 13:02:31 +08:00
Chaohui Wang
3bd2e55b23 Fix SIM Settings crash when IllegalArgumentException
By catch exception.

Fix: 318460644
Test: manual - with SIM Settings
Test: unit test
Change-Id: I99025125b5fe71c6507afc355a881af8948d6a7a
2024-01-04 10:47:48 +08:00
Chaohui Wang
e3b527a2bf Refactor CellInfoUtil
Unify and simplify the logic, and add unit test.

Bug: 293845605
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I5467b92baa8e47fbd400c7a21fd39fd5ec90ed3a
2024-01-03 13:41:45 +08:00
Chaohui Wang
355144675a Fix ANR in WifiCallingPreferenceController.getAvailabilityStatus
Move the following to background thread to avoid block main thread,
- MobileNetworkUtils.isWifiCallingEnabled(mContext, mSubId, null)
- MobileNetworkUtils.buildPhoneAccountConfigureIntent()
- getSummaryForWfcMode()
- Call State

Since WifiCallingPreferenceController no longer calculate availability
in getAvailabilityStatus(), also update the
CallingPreferenceCategoryController accordingly.

Also introduce ImsMmTelRepository for split business logic for easy
testing.

Fix: 292401934
Test: manual - on Mobile Settings
Test: unit test
Change-Id: If92e2c8f6e137e40b83e578294c03c1b917eef8e
2023-12-29 17:16:49 +08:00
Sunny Shao
946f52b2a1 Merge "Revert "Nullability Annotations replacement"" into main 2023-12-29 03:18:24 +00:00
Sunny Shao
19d1d3d15d Revert "Nullability Annotations replacement"
This reverts commit cf0501e4d7.

Reason for revert: b/317462033, it seems a flaky but revert it first.

Change-Id: Ie1d5e279cca6477fc17d8c27c1ecda8d7a6b2553
2023-12-29 02:28:24 +00:00
Chaohui Wang
b26ae73c39 Merge changes from topic "AutoSelectPreferenceController" into main
* changes:
  Clean up ServiceStateStatus
  Improve AutoSelectPreferenceController
2023-12-28 10:41:10 +00:00
SongFerng Wang
19dbb00acb Merge "Using carrier config for hiding 3G item at preferred network mode" into main 2023-12-28 09:40:26 +00:00
Chaohui Wang
851996d01c Clean up ServiceStateStatus
And LifecycleCallback*, which is no longer used.

Bug: 299068234
Test: m Settings
Change-Id: I29ce5609db2a4b249477da1bcbb0502fa04902fa
2023-12-28 16:58:42 +08:00
Chaohui Wang
2ec3840987 Improve AutoSelectPreferenceController
Deprecate ServiceStateStatus (which could produce wrong value),
and replaced with serviceStateFlow.

Fix: 299068234
Test: manual - turn auto select off and on
Test: unit test
Change-Id: I42fe160500c68cc9ee0fe383121f64146ddbb7f2
2023-12-28 16:58:42 +08:00
SongFerng Wang
ce45ac011d Using carrier config for hiding 3G item at preferred network mode
Bug: 310639009
Bug: 301214162
Change-Id: Id3a85f46954311ff668f7175b672ac954a6e984e
Test: build pass. local test. atest EnabledNetworkModePreferenceControllerTest
2023-12-28 08:28:17 +00:00
SongFerng Wang
4ee6d84eb4 Merge "Using ACTION_SIM_CARD_STATE_CHANGED to detect simSlotMapping is complete" into main 2023-12-26 06:47:44 +00:00
Chaohui Wang
956894caff Fix lateinit property allowedNetworkTypesFlow
Which has not been initialized.

Convert it to factory to fix.

Fix: 317353030
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ie5f22d47cb3f3fe036c706ba77ed3bdaad0b54a2
2023-12-25 12:28:14 +08:00
Rambo Wang
5e27df82ee Merge "Support reset IMS stack in Reset Mobile Network flow" into main 2023-12-22 18:19:37 +00:00
rambowang
41ba9dc658 Support reset IMS stack in Reset Mobile Network flow
Reset the IMS stack for the specified subscription
with the help of API TelephonyManager#resetIms.

Bug: 271921464
Test: ResetNetworkOperationBuilderTest
Change-Id: I61575f18bcc300f362000dc7f4257b9d794b6b69
2023-12-22 10:33:46 -06:00
Chaohui Wang
a5d537053a Merge "Show "MMS messages" when mobile data is off" into main 2023-12-22 09:08:12 +00:00
SongFerng Wang
ba2a86ad9f Using ACTION_SIM_CARD_STATE_CHANGED to detect simSlotMapping is complete
Sometime modem can't return the GET_SIM_STATUS immediately, so that the settings send the sim switching too early after simSlotMapping.

Bug: 291733084
Change-Id: If547c8b02020bc86c83915334e29945176a4ee9f
Test: tester will test it manually.
2023-12-22 05:57:53 +00:00
Chaohui Wang
ce18c81da6 Show "MMS messages" when mobile data is off
For some corner case,
- Single SIM, data off, auto switch on (although hidden)
- Dual SIM, default data off, auto switch on

Bug: 303759893
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I70dd792ecff590f34100efaaf6ee4efcc2b759fd
2023-12-20 17:07:45 +08:00
Chaohui Wang
28b85b5810 Refresh "Choose network" summary when service state changes
This summary display service connection state, which should be refreshed
when service state changes.

Fix: 313026209
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I6ca2f89e05f21460a7db055f037919b6ebd19182
2023-12-20 16:19:08 +08:00
sunnyshao
cf0501e4d7 Nullability Annotations replacement
-- Replace the android.annotation.Nullable / android.annotation.NonNull
   with androidx.annotation.Nullable / androidx.annotation.NonNull

Bug: 316867690
Test: build pass
Change-Id: I0c1da55dfb09ece855151c47e0492d6f46538621
2023-12-20 08:50:09 +08:00
Chaohui Wang
007ef134b6 Hide MMS messages if switch mobile data automatically
Per designer's comment, hide the "MMS messages" if user cannot use it to
control MMS.

Fix: 303759893
Test: manual - turn "Switch mobile data automatically" on / off
Test: unit test
Change-Id: I874524c0cedb48f7daf87f32920e26428ae78c89
2023-12-15 17:00:22 +08:00
Charlotte Lu
2ed4bfb67a Merge "Provide confirmation if creating new APN is not filled in enough and add a save button." into main 2023-12-14 06:23:01 +00:00
Charlotte Lu
92c0c12ddd Provide confirmation if creating new APN is not filled in enough and add a save button.
Test: Visual Test
Fix: 315112333, 315111729
Change-Id: Ic0044ca03baae138247489715c084980c01ae9b2
2023-12-14 13:40:02 +08:00
Jan Tomljanovic
db1402a4df Always confirm eSim removal.
Test: atest DeleteSimProfilePreferenceControllerTest
Bug: 313604661

Change-Id: I0c43790bf43bedcc2e8075aa7be0b25876c731b4
2023-12-12 15:57:19 +00:00