Commit Graph

1648 Commits

Author SHA1 Message Date
Sunny Shao
a02483adc9 [Catalyst] Refactor some Text Reading items
Test: atest TextReadingPreferenceFragment
Bug: 372776688
Flag: com.android.settings.flags.catalyst_text_reading_screen
Change-Id: I49aa91ca6f441814d6aaeb86826291a155a306f1
2024-12-09 12:55:30 +08:00
Riley Jones
dec6b37fe4 Merge "Cleanup deprecated functions in AccessibilityUtil" into main 2024-12-06 18:25:34 +00:00
Riley Jones
6107fd8591 Cleanup deprecated functions in AccessibilityUtil
Flag: EXEMPT code cleanup
Bug: 367414968
Test: atest com.android.settings.accessibility
Change-Id: If69a964720fc91ce0ad3661f956c4818f4f2f9dd
2024-12-05 23:45:33 +00:00
Daniel Norman
908bd398bd Adds null checks on callers of Nullable method getA11yServiceInfo().
Also renames mPackageName to mFeatureName. This string is used as the
user-visible feature name, e.g. TalkBack, not the APK package name.

Fix: 382054546
Test: n/a (existing presubmit)
Flag: EXEMPT minor bugfix
Change-Id: I1ce6902612d89bbb68bddf30227ca231ea98dce7
2024-12-04 19:41:07 +00:00
Daniel Norman
4a84a244b2 Merge "Updates A11y Shortcut animations to not loop in code." into main 2024-12-04 18:37:28 +00:00
Daniel Norman
5862b31f21 Updates A11y Shortcut animations to not loop in code.
Continuously repeated animations go against accessibility guidelines
to avoid unstoppable motion.

The animation files themselves have been updated to loop twice
so that the user can still see the animation temporarily.
The loop restarts if the user exits and enters the page again.

Bug: 370661517
Flag: EXEMPT minor bugfix with resource changes
Test: Manually observe animations
Change-Id: I52348a094680ef345bf8c2b12ab91c9406bf5cb4
2024-12-04 00:14:09 +00:00
Riley Jones
6d1c378972 Merge "Cleaning up quick settings flag in Settings app" into main 2024-12-03 22:03:04 +00:00
Riley Jones
acccaff128 Cleaning up quick settings flag in Settings app
Removes all instances of a11y_qs_enabled. Any code that would be nontrivial to remove has been deprecated for later cleanup.

Test: atest com.android.settings.accessibility
Flag: EXEMPT flag cleanup
Bug: 367414968

Change-Id: I81f3c9cee377535eaa552a170d58ec1a79d1da65
2024-12-02 20:38:10 +00:00
Jacky Wang
8a97245b3d [Catalyst] Add sensitivity level
NO_IFTTT=Catalyst only

Bug: 380457585
Flag: com.android.settings.flags.catalyst
Test: Manual
Change-Id: Ia98a925011723738e1a16cc0e0c3d703d3dbd505
2024-11-29 07:36:13 +08:00
Treehugger Robot
1fd937f8ba Merge "[Catalyst] Vibration and haptics main switch migration" into main 2024-11-28 23:20:02 +00:00
Lais Andrade
08a7f6a5e7 [Catalyst] Vibration and haptics main switch migration
- Migrate "Use Vibration & haptics" main toggle in
  vibration settings screen.

- Add screen for VibrationScreen dashboard fragment

NO_IFTTT=introducing preference metadata files, no change in preference
controllers required.

Bug: 368360218
Flag: com.android.settings.flags.catalyst_vibration_intensity_screen
Test: VibrationIntensityScreenTest
      VibrationScreenTest
      VibrationMainSwitchPreferenceTest
Change-Id: I1dee7fdd59e093bd2dd12204554fe5198e7b76b4
2024-11-28 12:18:16 +00:00
Pawan Wagh
cc66323613 Revert "Turn off voice access in 16KB mode"
This reverts commit 6de4093876.

Reason for revert: b/335443194 is fixed now

Change-Id: Id2c4584835766e9620234233b6594c0dd59b68e9
2024-11-27 22:32:08 +00:00
Riley Jones
3b5b88f650 Merge "Makes all custom caption settings unsearchable when custom captions are not active." into main 2024-11-25 21:40:20 +00:00
Daniel Norman
b4dbc50d6a Merge "Cleanup flag "check_prebundled_is_preinstalled"" into main 2024-11-25 20:45:50 +00:00
Daniel Norman
9808ee15bd Merge "Cleanup flag "audio_balance_state_description"" into main 2024-11-25 20:45:16 +00:00
Riley Jones
6f8e823e0e Makes all custom caption settings unsearchable when custom captions are not active.
Unifies all custom caption controllers under a base controller, whose searchability is directly determined by CaptionHelper#getCustomCaptionAvailability().

Test: atest CaptionHelperTest
Bug: 353757664
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: If44e6eca4c72aa4413cd0a6e8735dbb22c7abe62
2024-11-25 18:59:01 +00:00
Jacky Wang
1413f7428c [Catalyst] Update ColorAndMotionScreen
Add icon and launch intent for ColorAndMotionScreen, also update the
entrypoint preference key to make it identical with screen key.

Bug: 373451690
Flag: com.android.settings.flags.catalyst_accessibility_color_and_motion
Test: atest
Change-Id: I1040d6fa5e8c89ddb6117a4b7671fd22c5a96578
2024-11-25 11:59:35 +08:00
Jacky Wang
8e73d0f51e [Catalyst] Update RemoveAnimationsPreference
Bug: 373451690
Flag: com.android.settings.flags.catalyst_accessibility_color_and_motion
Test: atest & devtool
Change-Id: Id648febf32bebb391f1277e28f58ddb0d5130d59
2024-11-23 06:24:13 +08:00
Cam Bickel
330834b819 Cleanup flag "audio_balance_state_description"
Bug: b/319575109
Test: atest BalanceSeekBarTest
Flag: EXEMPT flag cleanup
Change-Id: I5057a7732f5986533ff8a6b0ebf60e8a55a1dc9f
2024-11-22 17:41:25 +00:00
Cam Bickel
de0e5cdff9 Cleanup flag "check_prebundled_is_preinstalled"
Bug: b/353888087
Test: atest AccessibilitySettingsTest
Flag: EXEMPT flag cleanup
Change-Id: Ia16cc83b1d499bac3845c7397ae1ac3e4c97ae91
2024-11-22 17:27:10 +00:00
Camden Bickel
fdd29cdce6 Merge "Cleanup flag "never_restrict_a11y_activity"" into main 2024-11-22 17:03:51 +00:00
Cam Bickel
4072d43123 Cleanup flag "never_restrict_a11y_activity"
Full flag name: "never_restrict_accessibility_activity"

Bug: b/331990900
Test: atest RestrictedPreferenceHelperTest
Flag: EXEMPT flag cleanup
Change-Id: I365ed105043cb4835075b8b9016b41862f82021c
2024-11-21 23:22:27 +00:00
Daniel Norman
9ef696d0e8 Migrate Remove Animations preference to Catalyst backend.
This preference (and its test) has no flagging, but its parent
page 'Color and motion' is flagged for Catalyst migration.

This preference looks identical before and after migration.

Fix: 373451690
Flag: com.android.settings.flags.catalyst_accessibility_color_and_motion
Test: atest RemoveAnimationsPreferenceTest
Test: Enable our flag, and top-level Catalyst flag;
      Toggle the setting in Settings > Accessibility;
      Observe expected changes to animation behavior;
Change-Id: I07dbe45a120780439393d7cfd46a749025b7ab0c
2024-11-19 23:10:37 +00:00
Menghan Li
2dbb5f0c66 Merge "fix(ColorCorrection): Palette preview text contrast Issue" into main 2024-11-15 01:16:35 +00:00
Menghan Li
80f8b87e28 fix(ColorCorrection): Palette preview text contrast Issue
Root Cause: The palette preview's text color inherits dynamic colors from the BC pattern, leading to insufficient contrast against some backgrounds. This wasn't a problem in the original design, as the BC pattern was introduced later.

Solution: Set the palette preview text color to textColorPrimary to ensure the text remains legible against a wider range of background colors.

Bug: 378775277
Flag: EXEMPT bugfix
Test: atest PaletteListPreferenceTest

Change-Id: I8efb9f9d916d618b450df169292202e499d8ac0d
2024-11-14 13:03:17 +00:00
Roy Chou
04715ae017 Merge "feat(brightness suw): adjust brightness toggles UI and remove autobrightness standalone page" into main 2024-11-13 08:22:07 +00:00
Candice
f959debbe5 Enable HearingAids#AudioRouting page search if the device supports hearing aid
Enable searching in the AccessibilityAudioRoutingFragment only if the
page is available and the device supports hearing aid.

Bug: 353853318
Test: atest AccessibiilityAudioRoutingFragmentTest
Test: Manually. Add screen recording of search results to the bug
Test: Manually set the support to hearing aids to false and verify that searches to the page contents are not available
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: I6786c51438d49ff9bb1d458d312ec09bd16098a4
2024-11-11 13:37:34 +00:00
Riley Jones
5a06b74ef1 Merge "Caption settings cleanup" into main 2024-11-08 21:06:11 +00:00
Riley Jones
b3eea625ec Caption settings cleanup
Bug: 353757664
Test: atest com.android.settings.accessibility
Test: Manually verify conditions described in bug
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: Iff25702843e5dd3e7ebcca1a13f190d48cf83e7a
2024-11-08 19:09:06 +00:00
Roy Chou
c2d0b25753 feat(brightness suw): adjust brightness toggles UI and remove autobrightness standalone page
Based on the UX alignment in doc and figma, we remove the autobrightness
detailed page to make the consistency with other Vision settings, and
update the brightness preference icons and summaries.

Bug: 377289685
Flag: com.android.settings.accessibility.add_brightness_settings_in_suw
Test: manually
Change-Id: If4038de07dec7eeb38d3c057affba737849e23c9
2024-11-04 16:22:46 +00:00
Candice
db622c1aea Allow connected Hearing Aid devices to be searched by names
Bug: 353847080
Test: atest AvailableHearingDevicePreferenceControllerTest
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: I634c5ce7b31ae5d7f78a006b9cedc0725794482a
2024-11-04 09:14:00 +00:00
Candice
898d1e07ad Allow saved Hearing Aid devices to be searched by names
Bug: 353847080
Test: atest SavedHearingDevicePreferenceControllerTest
Test: Manually. Add video to the bug
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: Ic20a74bf6ffa28a82eeb44a0651861d2ff22e246
2024-11-04 09:10:53 +00:00
Candice
48d984511a Enable HearingAid page search if the device supports hearing aid
Bug: 353847080
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Test: atest AccessibilityHearingAidsFragmentTest
Test: let the HearingAidHelper return false in supporting availability and check if the items exist during search
Change-Id: I6b6ffddb5ccd44795db292d1ddc3b60f69166b2a
2024-10-28 14:39:39 +00:00
Treehugger Robot
384c432857 Merge "Removes overrides for shortcut-required service toggling." into main 2024-10-23 16:49:20 +00:00
Jacky Wang
b05a1aa543 Remove backing fields for ColorAndMotionScreen
Bug: 373451690
Flag: EXEMPT refactor
Test: atest
Change-Id: I371bd221b6079c9816725e5253e110eef423fc5e
2024-10-22 17:42:38 +08:00
Daniel Norman
41440ff248 Removes overrides for shortcut-required service toggling.
These are unnecessary now that shortcut enabling is done via
A11yManager#enableShortcutsForTargets which handles enabling
a shortcut-required service if necessary, controlled by the
rolled out a11yQsShortcut flag.

These also cause a race condition conflict when attempting to toggle a
service that does not require a warning, causing it to disable the
service immediately after enabling.

Bug: 324653372
Flag: android.view.accessibility.a11y_qs_shortcut
Test: Toggle a shortcut-required service that does not require
      a warning; service is started correctly.
Test: Repeat for a service that does require a warning
Change-Id: Iff44d87faf8a5d2eb9b6643dd582c2b697ad0b5d
2024-10-18 20:26:31 +00:00
Chun-Ku Lin
abdb92453f Merge "Create an empty color and motion screen with Catalyst Infra" into main 2024-10-18 20:26:09 +00:00
Chun-Ku Lin
688cc94413 Create an empty color and motion screen with Catalyst Infra
Bug: 373451690
Test: atest ColorAndMotionScreenTest
Flag: com.android.settings.flags.catalyst_accessibility_color_and_motion
Change-Id: I4bfa5ec4d15bd745d691f586e49318b1b0a9bf6c
2024-10-18 18:36:13 +00:00
Daniel Norman
29641287d8 Merge "Hides the Edit Shortcut top preference when empty." into main 2024-10-18 17:29:37 +00:00
Daniel Norman
4c3473134c Hides the Edit Shortcut top preference when empty.
This fixes an issue where this page was presenting an inaccurate
preference list count to TalkBack because it was including this empty
preference.

(Uses the same flag as other fixes for this same bug, even though the
flag name doesn't make sense here.)

Test: atest EditShortcutsPreferenceFragmentTest
Test: Confirm preference invisible when editing a single feature,
      opened from the Settings app
Test: Confirm preference invisible when editing a single feature,
      opened from the FAB Drag-to-Edit
Test: Confirm preference still visible when editing multiple features,
      opened from the FAB Drag-to-Edit
Test: Confirm TalkBack announces correct item counts in both cases,
      including when editing Magnification which has an "advanced"
      preference that gets replaced with the triple-tap shortcut.
Bug: 318607873
Flag: com.android.settings.accessibility.toggle_feature_fragment_collection_info
Change-Id: I2e1eb7f66022c1a47d1f96a914294fd8da25549c
2024-10-18 00:18:54 +00:00
Piotr Wilczyński
ddef40edd0 Merge "Set the same density to all displays" into main 2024-10-17 15:17:59 +00:00
Treehugger Robot
421bd753c4 Merge "Migrate Text Reading" into main 2024-10-17 00:49:14 +00:00
Sunny Shao
3d2f06fd7b Migrate Text Reading
Add the skeleton of the Text Reading

Test: atest TextReadingScreenTest
Bug: 372776688
Flag: com.android.settings.flags.catalyst_text_reading_screen
Change-Id: Ic5afa8da5ee7ea02d9ce9479c14d2c71e751dee4
2024-10-16 21:16:39 +08:00
Piotr Wilczyński
2f9f582310 Set the same density to all displays
Bug: 324439718
Test: manual
Test: atest DisplaySizeDataTest
Test: atest ScreenResolutionFragmentTest
Flag: EXEMPT bugfix
Change-Id: Ibe8b15be8968545c701a872103c1c20fa698228f
2024-10-16 12:50:57 +00:00
Mill Chen
b923194def [Catalyst] Vibration and haptics screen migration
- Add a flag for vibration and haptics migration
- Add skeleton of vibration and haptics

Bug: 368360218
Test: atest VibrationIntensityScreenTest
Flag: com.android.settings.flags.catalyst_vibration_intensity_screen
Change-Id: I0117f570fe9bf92e61974984d00c0bd5be684fff
2024-10-15 04:44:09 +00:00
Candice
2e914a311f Make Extra Dim main toggle and shortcut searchable
Since the Extra Dim main toggle and shortcut preferences are created in
codes, we override `getRawDataToIndex` to return the corresponding index raw data.

Bug: 354778552
Test: atest ToggleReduceBrightColorsPreferenceTest
Test: Manually check the preferences are searchable in Settings search
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: I1642e96273cd16f35b23350af0ede3b1247ef067
2024-10-11 16:54:53 +00:00
Riley Jones
a75ba56192 Merge "Provides an ordered array of shortcut types so Settings presents shortcuts in the desired order" into main 2024-10-10 23:00:13 +00:00
Treehugger Robot
4bcad87e0d Merge "Pass the actual quantity/count to the MessageFormat and let it decide" into main 2024-10-10 22:43:31 +00:00
Riley Jones
ea06748ee2 Provides an ordered array of shortcut types so Settings presents shortcuts in the desired order
NO_IFTTT=corrects ui order
Flag: android.provider.a11y_standalone_gesture_enabled
Test: atest AccessibilityUtilTest
Bug: 371463731

Change-Id: Ia1864076faa281cf57c469a2d0d34f859858d859
2024-10-10 20:12:04 +00:00
Chun-Ku Lin
0a6d37b871 Pass the actual quantity/count to the MessageFormat and let it decide
Bug: 185400417
Test: manual (the autoclick location has changed to Settings > System >
Trackpad & mouse > Pointer & touch accessibility > Autoclick)
Flag: EXEMPT low risk localization fix

Change-Id: Iee63b87513550a6758db9dce376e88a12a51d9f8
2024-10-10 01:03:44 +00:00