Commit Graph

3029 Commits

Author SHA1 Message Date
Matías Hernández
3c01a5cf05 Fix OWNERS for Settings > Notification Special Access
Change-Id: I2b2009f418810039874b33c32ebe4f5218fb78a1
2025-02-11 09:20:09 -08:00
Xin Li
cfa19e11a6 Merge 24Q4 (ab/12406339) into aosp-main-future
Bug: 370570306
Merged-In: Ie90e7495dd4a134538bae6e3e08eea0d02134b14
Change-Id: I20517e9ee410e95f2cbeb1247c0c0288ed9f006f
2024-11-11 21:38:40 -08:00
Treehugger Robot
9a0ba22e79 Merge "Add a check to ensure that intent data is available before proceeding." into main 2024-09-27 09:54:21 +00:00
Abdelrahman Daim
996afd17a1 Protect the Settings application from potential null pointer exceptions.
Summary: The app bar is not available, causing a null pointer exception.

Test: Successful Build on master branch

Change-Id: I36849606f6587d6e7f004ae21e1a6e6a5206735a
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-25 17:02:37 -07:00
Abdelrahman Daim
3be2314fac Add a check to ensure that intent data is available before proceeding.
Summary: There are instances where intent data is absent, leading to a crash while trying to retrieve the schema. This change adds a null check to prevent attempted access when there's no data.

Test: Successful Build on master branch

Change-Id: Ie83bd3243f2c79102061d3fa43d809b3ef3c6c78
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-24 12:21:22 -07:00
Maryam Dehaini
6a6a3efe57 Merge "Change "Open by default" setting page selection to radio buttons" into main 2024-09-23 22:45:07 +00:00
Maryam Dehaini
11825b0bc7 Change "Open by default" setting page selection to radio buttons
Selection to open page in app or browser needs to be displayed via radio
buttons as discussed here: http://b/346622495#comment14

Bug: 359262490
Test: Open links in app and browser
Flag: EXEMPT small UI change
Change-Id: Ib23084bcc7f899b97b59019775584807e5b70d7e
2024-09-23 14:32:08 -07:00
Edgar Wang
28d45b49e8 Refactor layout of ProcessStatsPreference
- only this preference use AppPreference.setProgress()
- create layout to handle progressbar in this class

Bug: 365506467
Test: atest
Flag: EXEMPT bugfix
Change-Id: Ie0daf4e4fc1736943afe243566392d57c63fe65a
2024-09-09 11:24:32 +00:00
Chris Antol
78ee160c20 Only check INTERACT_ACROSS_USERS_FULL when user handle is not current
Bug: 326057017
Change-Id: I83ab4461f28e7f40c676099213c840a1a7dc932a
Test: atest; open app info pages from both primary and secondary profile -> verify they open as expected
Flag: EXEMPT bug fix
2024-08-29 19:53:08 +00:00
Fan Wu
d3b3edd451 Checks cross user permission before handling intent
Bug: 326057017

Test: atest

Flag: EXEMPT bug fix
Change-Id: I3444e55b22b7487f96b0e3e9deb3f844c4c4723a
2024-08-27 21:50:01 +00:00
Matías Hernández
c85e48b0aa Merge "Rename DND Access to Priority Modes Access in Settings" into main 2024-08-19 17:18:26 +00:00
Matías Hernández
fe1d29699e Rename DND Access to Priority Modes Access in Settings
Bug: 360384256
Test: manual
Flag: android.app.modes_ui
Change-Id: If01a14cfac8cf5660cf93ef10bce6a334472a0b9
2024-08-19 16:42:18 +02:00
Julia Reynolds
55a0d3b0e0 Merge "Don't show permission page in profiles" into main 2024-08-19 13:51:00 +00:00
Julia Reynolds
2ffd79a626 Don't show permission page in profiles
Unless the permission is already granted

Test: manual, launch com.android.settings.Settings$ZenAccessDetailSettingsActivity from primary and profile
Flag: EXEMPT bugfix
Bug: 326572419
Change-Id: I6fd22dcdd1cfe336155a1b74df3dbca65e60b6a4
2024-08-16 14:46:51 -04:00
Zoey Chen
291e496075 [Settings] Should create header again when adding it to the listview
Bug: 291545021
Test: manual
Flag: EXEMPT bugfix
Change-Id: I9d76814d98b67b1eb0078765a2b5bd6949cff446
2024-08-14 03:53:21 +00:00
Oli Thompson
2a8b7039b0 Fix UnsupportedOperationException from immutable set
change immutable set to HashSet

Flag: android.app.admin.flags.backup_connected_apps_settings
Bug: 355817689
Test: manually tested
Change-Id: I983d9b3f979e5659669a4a318f03e720623a47b4
2024-07-30 10:49:36 +00:00
Dipankar Bhardwaj
64e01615cb Add null check before PackageManager operations
Change-Id: I401fa2585975848e4b7301ccbadd8386b8ca17b9
Test: n/a
Bug: 353206855
Flag: EXEMPT minor NPE fix
2024-07-22 13:41:59 +00:00
Julia Reynolds
54a357fc3a Remove unneeded AsyncTask
Change-Id: I962a61c7a73f1d7a464ee76284f1d4175d04e62a
2024-06-14 14:42:50 +00:00
Julie Pan
7eac19fc3f Merge "Remove beccahughes@google.com from src/com/android/settings/applications/credentials/OWNERS" into main am: ce2a5e07e2 am: 33e2eb32fa
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3118591

Change-Id: I44916de88f8c594814f46d5ccd36ec910981926c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-06 20:15:33 +00:00
Julie Pan
33e2eb32fa Merge "Remove beccahughes@google.com from src/com/android/settings/applications/credentials/OWNERS" into main am: ce2a5e07e2
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3118591

Change-Id: I46352b557bef347fd55d89c0fbdd29d87d52c1bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-06 19:54:52 +00:00
Owner Cleanup Bot
88ab066a66 Remove beccahughes@google.com from src/com/android/settings/applications/credentials/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote CR -1 and the bot
will abandon it. Vote CR +1/2 to approve this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/beccahughes@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I8563f73848a4e32ff3da4b1eaf34253374d9012c
2024-06-06 17:47:53 +00:00
Lifu Tang
c233ecca5c Change the relative time format to LONG
The `SHORT` format, which abbreviates relative time as 'x min.
ago,' presents an accessibility issue for screen readers like
TalkBack. TalkBack announces this as 'x minimum. Ago', and the
dot after "min" is treated as period and causes a full-stop.

Attempts to directly modify TalkBack's pronunciation of this
text have proven difficult. Given the ample space available in
the user interface, using abbreviations isn't necessary.
Switching to the `LONG` format ('x minutes ago') would resolve
this accessibility problem while also making the interface
clearer for all users.

Bug: 318323722
Change-Id: I42ba960bd8d5d8fc8a9cb895ecf24c56dab6d2c4
2024-05-29 20:52:18 +00:00
Amith Yamasani
5953a3386c Merge "Add a source parameter for resrictions logging" into main 2024-05-23 18:54:49 +00:00
Amith Yamasani
8b37c093b7 Add a source parameter for resrictions logging
Modify existing callers to use the new parameter

Bug: 341112680
Test: statsd_testdrive 866
      Manually change battery restriction level for an app
Flag: android.app.app_restrictions_api
Change-Id: I66f23341b90f96eb3091b94ab6db512570988643
2024-05-22 16:15:29 +00:00
Treehugger Robot
4bbb31db66 Merge "Add additional right padding for the button view" into main 2024-05-22 08:22:02 +00:00
Jerry Shi
96b5e6af05 Add additional right padding for the button view
Test: locally built and tested for both LRT and RTL locales
Bug: 332495504
Change-Id: I4db57a7cb038863dc7db3bb69bf94b95886f0cf3
2024-05-21 20:31:44 -07:00
Oli Thompson
383b7960f1 Backup connected apps settings
Save the preference for connected apps for backup and restore

Flag: android.app.admin.backup_connected_apps_settings
Bug: 175067666
Test: manual

Change-Id: Ic46fbd1ab82f551ecf89caf800e41d6afe48fc68
2024-05-17 13:18:29 +00:00
Jerry Shi
07b7679319 Properly handle the autofill provider names, making sure place holder
name is properly filtered out.

Bug: 337040395
Test: locally built and tested
Change-Id: I081064c6103f79fe966a36d0eea854ee9893bce3
2024-05-15 10:11:29 -07:00
Jerry Shi
9884f1ccf4 Fix the issue the if primary provider is disabled by work admin, it
should be removed from the settings' storage.

Test: locally built and tested
Bug: 337040395
Change-Id: Ic572cd87f571d93ee0e7fa29157172444c7c36ce
2024-05-13 23:45:54 -07:00
Daniel Kim
f000f82ac2 Merge "Replace credential provider placeholder" into main 2024-05-07 17:53:14 +00:00
Daniel
385f5a0c7b Replace credential provider placeholder
Replace credential provider placeholder with the actual credential
autofill provider.

Bug: 330177328
Test: cts
Change-Id: Ib6c9688b3f728706b1f5ac0faa3f042bb6dc447c
2024-04-30 19:45:55 +00:00
Manish Singh
54461d2679 Merge "Apply personal filter when private tab not shown" into main 2024-04-30 09:55:34 +00:00
Manish Singh
4875662f48 Apply personal filter when private tab not shown
Bug: 336327005
Fix: 337744275
Test: manual
Change-Id: I1c8cbc35f90cd39bb332f9a6b787473779249166
2024-04-29 15:48:24 +00:00
Ivan Chiang
6afb9ece62 Add the different summary for the app store details
When the initiating package is different from the installing package,
show the different summary. E.g WebApk

Test: atest AppInstallerInfoPreferenceTest
Bug: 329140383
Change-Id: Icd5559bce06c059844269d70926b3c0b39589edb
2024-04-25 02:41:33 +00:00
Becca Hughes
862e71b73d Merge "Fix bug where empty section is sometimes shown" into main 2024-04-18 22:08:29 +00:00
Becca Hughes
1c3fb49913 Fix bug where empty section is sometimes shown
There is a bug where the empty section is
sometimes shown for additional providers. This
is because the logic for calculating the
visibility gets the providers and then the
logic for displaying the list gets the providers
and can result in getting out of sync. This aligns
both sets of logic to use the same data.

Test: ondevice & unit
Bug: 330163369
Change-Id: Icf71c78d67d55c929476f8e699d5893e60a49776
2024-04-18 19:52:15 +00:00
Jason Chiu
8d3d975795 Merge "Remove the package name restriction of ACTION_UNINSTALL_PACKAGE" into main 2024-04-18 01:49:09 +00:00
Jason Chiu
5d82f6a648 Remove the package name restriction of ACTION_UNINSTALL_PACKAGE
PackageInstaller has protected the intent action by setting
"android:priority=1".

Test: manual
Fix: 332228634
Change-Id: If0794e5957366d8b26acd0362b59c6c9076a0c4f
2024-04-17 16:26:52 +08:00
Amith Yamasani
7676217e4d Call noteAppRestrictionChanged when toggling restrictions/exemptions
This is to log the reasons for restriction level change and force stop

Bug: 333882527
Test: statsd_testdrive 863
      Toggle battery restrictions manually for an app and verify logging
      of reason
      atest BatteryOptimizeUtilsTest
Change-Id: Ifcc99efc1b6acc5a992f7d952967210b07319f2e
2024-04-16 21:58:40 -07:00
Becca Hughes
2fc40e8be7 Make sure policy transparency is applied in all cases
There are some cases where policy transparency is not
correctly showing up (e.g. on the main setting screen
for the primary provider). This makes sure policy
transparency is fully applied to the end user.

Test: manual on device
Bug: 333597574
Change-Id: I8d6a4c60e40bd2e639127777efdb04f1035c24bc
2024-04-11 16:18:54 +00:00
Song Chun Fan
523fd97cb4 Merge "[Settings/Archive] remove all checks for the archiving system property" into main 2024-04-08 22:36:39 +00:00
Becca Hughes
fba70edef5 Merge "Add provider name to on/off switch talkback" into main 2024-04-08 21:59:37 +00:00
Song Chun Fan
6ae958abd2 [Settings/Archive] remove all checks for the archiving system property
No longer needed

Change-Id: I24bc9a3d7503da1606d29eb3dfa963b0e6bf9d3e
BUG: 331165939
Test: builds
2024-04-08 18:16:11 +00:00
Becca Hughes
0c14078504 Disable primary provider clickable state
Since this view isn't clickable this was
resulting in incorrect talkback
descriptions.

Bug: 322252309
Test: on device manual
Change-Id: I6b00707dbab9081a5ed09cc2383d06baf0397600
2024-04-08 10:05:06 -07:00
Becca Hughes
cf2d635601 Add provider name to on/off switch talkback
Test: ondevice manual
Bug: 322274544

Change-Id: If067b3bea941ae997d9aefe03286d3b223956326
2024-04-08 16:53:58 +00:00
Becca Hughes
13c6b07868 Pass the package name from the intent to the picker fragment
When an app uses the legacy autofill intent to launch the
settings activity we should pass the package name of the
launching app to the picker. If the app is then picked by
the user we will return result_ok to the app and if it
is not picked we will return result_cancel.

Change-Id: I99dbfad2c69ed57ff891c189f726ecc408d9d188
Test: ondevice manual
Bug: 324197609
2024-04-02 17:53:30 +00:00
Becca Hughes
92485a7308 Merge "Implement policy transparency for CredMan" into main 2024-03-29 22:20:11 +00:00
Becca Hughes
9931d03f6f Implement policy transparency for CredMan
This CL implements policy transparency for
Credential Manager settings.

Screenshots:
https://hsv.googleplex.com/5502938857340928
https://hsv.googleplex.com/4999933426925568

Test: on device w/ test dpc
Bug: 318552220
Change-Id: I78e1fa47541c81e6e2d2bf2c13159be01928e77c
2024-03-29 09:56:47 -07:00
Jason Chiu
6ca5c992d7 Merge "[Safer intents] Permission controller" into main 2024-03-29 09:20:28 +00:00
Jason Chiu
cf13dfd4c6 [Safer intents] Permission controller
To avoid implicit intents, make intents launch explicitly.

Test: build, manual
Bug: 323061508
Change-Id: Ib95b417fc8682f690890fc55f321b4fece2c0369
2024-03-28 17:09:37 +08:00