Commit Graph

624 Commits

Author SHA1 Message Date
Diya Bera
ea342bbd82 Merge "Update Identity Check for Fingerprint Settings" into main 2025-03-07 09:49:13 -08:00
Diya Bera
b5482ac6a9 Update Identity Check for Fingerprint Settings
Flag: EXEMPT bug fix
Fixes: 398045898
Test: N/A
Change-Id: Icc71921c331bf445f2c70e9e6a7ac99a2e67f8a5
2025-03-04 20:04:31 +00:00
Jason Chang
00dc2384f4 Merge "(1/n) Fix Wrong button color in lockscreen dialog." into main 2025-03-04 08:40:14 -08:00
Jason Chang
dd4c8d2d1a (1/n) Fix Wrong button color in lockscreen dialog.
Use SUW API ThemeHelper.shouldApplyGlifExpressiveStyle() to update
AlertDialog style.

Flag: EXEMPT use SUW Expressive style API to check

Bug: 390544548

Test: atest SetupSkipDialogTest
Test: build and manually check the UI and its behaviors
Change-Id: I953270f4dc38796c3b64cba8cc3e84c3f4dcc2f2
2025-03-04 07:07:46 +00:00
Treehugger Robot
49f129ee11 Merge "Fix disruptive announcement on PIN/Password set up" into main 2025-03-02 17:32:19 -08:00
Treehugger Robot
34d1075280 Merge "Add content description for password&pin credential view." into main 2025-02-28 15:42:39 -08:00
Hao Dong
1cd98d4993 Add content description for password&pin credential view.
Bug: 384635437
Test: manual test with talkback on on settings device unlock
Flag: EXEMPT for a11y big fix
Change-Id: Ie9edd41dca8274cd69700d2a5dfc7b5fe5a7be8e
2025-02-28 21:24:10 +00:00
Ronald Braunstein
c5777c85f6 Merge "[owners] Remove curtislb@google.com from src/com/android/settings/password/OWNERS" into main am: e71f6991e2 am: b84bb949f2
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3510415

Change-Id: I80493e4a77edbb42f39909986d0618a7d48ab005
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-28 08:50:21 -08:00
Ronald Braunstein
b84bb949f2 Merge "[owners] Remove curtislb@google.com from src/com/android/settings/password/OWNERS" into main am: e71f6991e2
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3510415

Change-Id: I9125dced0a067fb2a2badae1b7e06f5b55b0b1f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-28 08:24:37 -08:00
Ronald Braunstein
e71f6991e2 Merge "[owners] Remove curtislb@google.com from src/com/android/settings/password/OWNERS" into main 2025-02-28 07:55:24 -08:00
Xin Li
911fdcebcf Merge "Merge 25Q1 (ab/12770256) to aosp-main-future" into aosp-main-future 2025-02-27 15:24:25 -08:00
lbill
d334ebb556 Fix disruptive announcement on PIN/Password set up
- Do not invoke deprecated announceForAccessibility()
- Define corresponding content description for PIN & Password

Flag: EXEMPT for a11y bug fixinig
Bug: 384607370
Test: Enabled Talkback, Setup Screen Lock PIN/Password,
ensure the "Password is now set up" for set up password, and
the "PIN is now set up" announced without disruptive announcement

Change-Id: I97c2c7fd8824468fccca8526c4e61ce642fd62ac
2025-02-27 04:21:25 +00:00
Treehugger Robot
7cbc882fb1 Merge "Remove jaggies@google.com from src/com/android/settings/password/OWNERS" into main am: 6893a9d5e3 am: 48fa52217c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2957653

Change-Id: I0ea9bd36ae531e19c21617299fae7bd3e2f01162
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-26 12:40:52 -08:00
Treehugger Robot
6893a9d5e3 Merge "Remove jaggies@google.com from src/com/android/settings/password/OWNERS" into main 2025-02-26 11:48:11 -08:00
Owner Cleanup Bot
a1a3b10c4f [owners] Remove curtislb@google.com from src/com/android/settings/password/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.

Please approve this change and vote the highest CR. This will keep the OWNERs
file tidy.  We ask that you do not ignore this change and approve it
unless you know a reason the OWNER should remain.  It can always be
reverted if needed.

If this change is in error, vote the lowest CR value (i.e. reject the CL)
and the bot will abandon it.

See the owner's recent review activity for context:
https://android-review.googlesource.com/q/curtislb@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I8ad909d8454a59de529ead3af94d503427efad2b
2025-02-26 09:42:02 -08:00
Jason Chang
fdb47cee3b Merge "Fix Talkback should not announce disruptive announcement "Re-enter your PIN" page." into main 2025-02-13 10:39:42 -08:00
Jason Chang
283f7c9107 Fix TalkBack announces disruptive announcement in PIN/PWD page.
Set the description state to A11y Node info for
"Must be at least 4 characters" when enter "Set a password",
"Must be fewer than 17 digits" in the "Set a PIN" or "Set a password"
and "PIN must be at least 4 digit, but a 6-digit PIN is recommended
for adding security"

Flag: EXEMPT bugfix

Bug: 384588020
Bug: 384604918
Bug: 384619356

Test: local build and verify Talkback announcement in PIN/PWD page.
Change-Id: Ib81abdc41dba1eeb854f2c7361362b5d55f8c7c7
2025-02-13 07:03:01 +00:00
Jason Chang
31be904d9b Fix Talkback should not announce disruptive announcement
"Re-enter your PIN" page.

Remove the calling announceForAccessibility() to prevent disruptive
announcement.

Flag: EXEMPT bugfix

Bug: 383259346
Bug: 384608181

Test: local build and verify Talkback announcement in
"Re-enter your PIN" page.

Change-Id: Ide29dde477a095db12eb959dc3d89b6689bd6ab2
2025-02-13 04:34:50 +00:00
Bill Lin
e34c3f9b99 Merge "Fix the SUW setup Pattern view the two steps offset issue" into main 2025-01-21 23:12:37 -08:00
lbill
5b70748ce9 Fix the SUW setup Pattern view the two steps offset issue
Test: manual go through SUW setup Pattern view, and make sure pattern
view do not shift in confirm step
Fixes: 324489595
Flag: EXEMPT bugfix/clean up layout issue

Change-Id: Ia5e6ef8a8c9ecf712f69bfde2bb631dc2605210d
2025-01-21 22:42:36 -08:00
Shawn Lin
d6df87cca6 [Biometric Onboarding & Edu] move screen lock settings to choose lock
- Hide gear menu in LockScreenSafetySource
- Move screen lock settings to ChooseLockGeneric

Bug: 370940762
Test: atest ScreenLockPreferenceDetailsUtilsTest
Flag: com.android.settings.flags.biometrics_onboarding_education

Change-Id: I07c7bb16ecc2ea6e7cd64a4e1d6bf4f493c5b951
2025-01-22 03:28:19 +00:00
Joshua McCloskey
f2e29d4359 A11y pattern view is no longer selectable
Fixes: 386873612
Fixes: 386873927
Test: Verified pattern view is no longer selectable, but cells are still
announced.
Flag: EXEMPT bugfix

Change-Id: If80da276f2a33206c39552b6b86a92c899f865a9
2025-01-17 09:17:18 -08:00
Joshua Mccloskey
496dcd3eb7 Merge "Pattern a11y fix" into main 2025-01-17 09:12:56 -08:00
Joshua McCloskey
ab58cb91a9 Pattern a11y fix
Test: Verified that the next button is no longer disabled, user can
click it
Fixes: 376175416
Flag: EXEMPT bugfix

Change-Id: I30fd80d96b8702e1c8b4bc50dad4c486b220a531
2025-01-16 14:39:44 -08:00
Joshua Mccloskey
0e5717b3a6 Merge "Fixed Pattern SUW a11y bug" into main 2025-01-15 12:34:39 -08:00
Joshua McCloskey
53ac9161d3 Fixed Pattern SUW a11y bug
Test: Verified that setting up a patter nduring SUW no longer announces
a long peice of text after clearing the pattern.
Fixes: 386859835
Flag: EXEMPT bugfix

Change-Id: I7350aba7d3f0665f204758241af02eeaad8cc1d5
2025-01-15 19:17:23 +00:00
Treehugger Robot
e380b4e9b3 Merge "Removed duplicate title in SetupChooseLock" into main 2025-01-02 00:41:24 -08:00
Joshua McCloskey
b6aa1157d6 Removed duplicate title in SetupChooseLock
Test: Verified manully there is only 1 title
Flag: EXEMPT bugfix
Fixes: 380881213
Change-Id: Ib310ee5cd7ec1676d411463846fe6d7cd74cd222
2024-12-12 18:25:00 +00:00
Jason Chang
a55788d3b9 Change resource id to the correct package name
Change resource id to the correct SUW package name.

Flag: EXEMPT bug-fixing

Bug: 383030121

Test: Build and manually then check the UI
Change-Id: I31c8c7e79a65edd7953080a9bd16b638a901d607
2024-12-11 08:10:17 +00:00
Jason Chang
bc26a1decc Change resource id to the correct package name
Change resource id to the correct SUW package name.

Flag: EXEMPT bug-fixing

Bug: 383030121

Test: Build ABTD manually then check the UI
Change-Id: Ic7dce3c0f61abf56e49163240d12ac5da8b627c6
2024-12-10 07:58:16 +00:00
Hao Dong
d31d6d110c Fix work apps interceptor biometric prompt icon.
Use the launching app's package name to get the default logo.

Bug: 369219504
Test: manual test on work profile with testdpc
Flag: EXEMPT bugfix

Change-Id: I2d11079e8f321ae3ee8cc3c5f7b9d1a4104825a9
2024-11-08 07:25:50 +00:00
Jason Chang
c994b58cc6 Merge "Change SUW theme style for Fingerprint and Face enrollment flow (3/n)" into main 2024-11-01 07:22:18 +00:00
Jason Chang
8f0c731fce Change SUW theme style for Fingerprint and Face enrollment flow (3/n)
Apply SUW theme style for Fingerprint and Face enrollment flow

Flag: EXEMPT Using setup library's flag

Bug: 346562327

Test: manually build and perform a visual inspection.
Change-Id: Ia6c4c3dbc78f9ad82b7f503d39e883480b09a92d
2024-10-31 20:11:01 +00:00
Austin Delgado
4c0df13f28 Merge "Force Private Space to always use biometric prompt" into main 2024-10-30 21:03:08 +00:00
Austin Delgado
7c235e3c0c Force Private Space to always use biometric prompt
Bug: 365094949
Bug: 365932447
Bug: 366441553
Test: Verified manually
Flag: android.hardware.biometrics.private_space_bp

Change-Id: I78cb53e6e38c73d7819f7368546f53bc7026f9b5
2024-10-30 19:58:36 +00:00
Jason Chang
005aafde24 Change SUW theme style for Fingerprint and Face enrollment flow (1/n)
Apply SUW theme style for Fingerprint and Face enrollment flow

Flag: EXEMPT Using setup library's flag

Bug: 346562327

Test: manually build and perform a visual inspection.
Change-Id: I7cbcc04290ba1ddee1328afe3e4efbe1f36aff1c
2024-10-30 08:57:16 +00:00
josephpv
6a333a2ac3 Show custom unlock title for private profile
With this change whenever private space is unlocked and has its own lock
different from device lock, it shows a custom title for PS in the unlock
screen.

Custom title for private profile will be  shown in the auth screen while
authentiation of private lock for the below usecase inside PS settings.
- Auth shown while Delete private space from PS settings
- Switching to device screen lock from a separate private space lock
- Changing the private space lock type(Ex: from pattern to PIN)
- Adding a biometric(face/fingerprint) for private profile

When auth screen with custom title is put to background and the screen
is in the recents list and if private space is locked then the auth
scren with the title is removed from recents list along with the other
settings task.

Bug: 323835257
Test: Manual
Change-Id: Ia0cc0b9bb54a429ebe027dc0937320e7fd23cb81
Flag: android.multiuser.show_custom_unlock_title_inside_private_profile
2024-10-03 12:28:43 +00:00
Sparik Hayrapetyan
37c371b1bb Change the message for sequential characters in a password
Change the error message for sequential characters in the password when
the password quality requirement is NUMERIC_COMPLEX or higher. The error
message stays the same in case of PIN.

Screenshots from local testing:
- http://screen/po62FX6aGKoRCU7
- http://screen/BXU6mcJEHMoU4TR
- http://screen/BhCzSDdY83WCQeH

Bug: 299044500
Test: Tested locally, see screenshots
Flag: EXEMPT simple change to an error message

Change-Id: I2e96fef6b5f9a11013fbaa8e231bddc7fa45867f
2024-09-18 11:30:13 +02:00
Treehugger Robot
540ce288ad Merge "(3/N) Biometric error dialog" into main 2024-09-18 00:20:40 +00:00
Diya Bera
8444136cd3 Merge "(1/N) Biometric error dialog" into main 2024-09-17 23:57:50 +00:00
Diya Bera
fc711494b9 (3/N) Biometric error dialog
Add an error dialog to help user recover from biometric error for
for identity check for enrollment, changing LSKF and accessing
biometrics settings

Flag: android.hardware.biometrics.flag.mandatory_biometrics
Bug: 358641110
Bug: 358179610
Test: Manual
Change-Id: Iaf1986d3c1892b6158808bc3ded96145f410dc62
2024-09-17 20:25:01 +00:00
Diya Bera
5335e26b29 (1/N) Biometric error dialog
Add an error dialog to help user recover from biometric error for
identity check feature

Flags: android.hardware.biometrics.flag.mandatory_biometrics
Fixes: 358641110
Fixes: 358179610
Test: atest DevelopmentSettingsDashboardFragmentTest

Change-Id: I6099bc57672b945fa4fa4de98be35bd097403b22
2024-09-17 14:45:51 +00:00
Chun-Wei Wang
32cf2e3a11 Merge "Support alternate button" into main am: 88bbe8fe1d am: 6eccd73996
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3244020

Change-Id: Ia2853f58135f975bf0f6dd687efee52e622eac8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-09 14:34:57 +00:00
Chun-Wei Wang
88bbe8fe1d Merge "Support alternate button" into main 2024-09-09 14:18:11 +00:00
Pavel Grafov
95efbfa8bb Clean up fully rolled out HeadlessSingleUserFixes
Flag was rolled out in Android V.

Bug: 335663055
Test: TH
Flag: EXEMPT flag cleanup
Change-Id: Iaccd1c594f588b40f46e653b83e257f90b048bf4
2024-09-02 16:44:04 +01:00
Priyanka Advani (xWF)
eff79d3365 Revert "Clean up fully rolled out HeadlessSingleUserFixes"
Revert submission 28993807-hdop-cleaup

Reason for revert: Droidmonitor created revert due to b/363275535. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:28993807-hdop-cleaup

Change-Id: I89127e1c6e445adb21dbf96c6bbbec8935bf6296
2024-08-30 19:04:56 +00:00
Pavel Grafov
93c566ef5b Clean up fully rolled out HeadlessSingleUserFixes
Flag was rolled out in Android V.

Bug: 335663055
Test: TH
Flag: EXEMPT flag cleanup
Change-Id: I7de1f400d03662b690f4a77a379994985797a3fe
2024-08-29 17:04:36 +01:00
Chun-Wei Wang
31ebeb690e Support alternate button
Align the behavior of frp and repair to have them
support the alternate button.

Bug: 339735656
Test: presubmit
Change-Id: Ib785db5ef16a68df4980dee451c6b638692adc5f
2024-08-27 10:16:11 +08:00
Treehugger Robot
b3d4b76c69 Merge "Add mandatory biometric prompt to platform surfaces (5/N)" into main 2024-08-15 01:11:42 +00:00
Diya Bera
92ea474b86 Add mandatory biometric prompt to platform surfaces (5/N)
1. For biometric settings, request biometric prompt only after
   successful credential verification and no auth request after
   enrollment

2. Differentiate between mandatory biometrics ineffective error and
   other biometric errors

Flag: android.hardware.biometrics.flags.mandatory_biometrics
Bug: 358176202
Bug: 358179610
Test: atest UtilsTest DevelopmentSettingsDashboardFragmentTest MainClearTest BuildNumberPreferenceControllerTest CombinedBiometricProfileSettingsTest
Change-Id: I778dd5403dd5ab64d8cc39bd88b22c4d39182e94
2024-08-13 04:21:37 +00:00