Chaohui Wang
32d9280e97
Merge "Revert^2 "Migrate to CompoundButton.OnCheckedChangeListener"" into main
2023-11-08 09:05:22 +00:00
Chaohui Wang
478ab50c01
Prevent Erase SIM during call
...
By collecting call state and only enable preference when idle.
Fix: 298893271
Test: manual - on Mobile Settings during call
Test: unit tests
Change-Id: Ifd567a6b68a3efbb0b42bfa0233f7c54eca07ae1
2023-11-08 03:08:56 +00:00
Chaohui Wang
08a1c9876e
Revert^2 "Migrate to CompoundButton.OnCheckedChangeListener"
...
8979681a8d
Change-Id: I60edd3aabf49afbe4aa016af780baa68d928bddf
2023-11-07 14:17:15 +00:00
Sebastian Pickl
8979681a8d
Revert "Migrate to CompoundButton.OnCheckedChangeListener"
...
Revert submission 25147565-onSwitchChanged-CompoundButton
Reason for revert: breaking builds
Bug:309601476
Reverted changes: /q/submissionid:25147565-onSwitchChanged-CompoundButton
Change-Id: Ie746db87d9c642599593aa3d5e5baf6b7ba89c0e
2023-11-07 13:26:36 +00:00
Chaohui Wang
71d1f021af
Migrate to CompoundButton.OnCheckedChangeListener
...
Switch and SwitchCompat are both CompoundButton.
Using CompoundButton in Java will helps migration in the future.
Bug: 306658427
Test: manual - check Settings pages
Change-Id: If2e08a9a9557ec66a3b31ef18cd2e15943098a59
2023-11-07 20:22:27 +08:00
SongFerng Wang
a2b1d8a0a2
Merge "Fix the burst callback issue on the repository" into main am: a23320eedd am: 4362f09737 am: bc4909cafd
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2780887
Change-Id: I009b6ec4bbc2ff46160772f7bd8a773086c5e20b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-11-07 10:55:00 +00:00
SongFerng Wang
bc4909cafd
Merge "Fix the burst callback issue on the repository" into main am: a23320eedd am: 4362f09737
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2780887
Change-Id: I69a30d3d6af7b75177cee4c259786b7acbfdd5cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-11-07 10:11:00 +00:00
SongFerng Wang
4362f09737
Merge "Fix the burst callback issue on the repository" into main am: a23320eedd
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2780887
Change-Id: Ia0f4f76a704973e123cfe5e4c2d571bbea0c861f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-11-07 09:41:19 +00:00
SongFerng Wang
a23320eedd
Merge "Fix the burst callback issue on the repository" into main
2023-11-07 09:11:06 +00:00
SongFerngWang
5eae90d731
To avoid crash IllegalStateException
...
Bug: 308855978
Test: [pass]make RunSettingsRoboTests ROBOTEST_FILTER=NetworkProviderSettingsTest
Change-Id: Ia0a1cbe0326e63b878c3fe7797ca47e25ccc16d4
2023-11-07 16:00:41 +08:00
Chaohui Wang
ddf79703ce
Merge "[Spa] Fix State<T> as a parameter of SwitchPreference" into main
2023-11-06 04:19:30 +00:00
Chaohui Wang
eedc7fd52d
[Spa] Fix State<T> as a parameter of SwitchPreference
...
Bug: 292036686
Test: manual - with Settings
Test: unit tests
Change-Id: I003f3b7f29117258da6ae3c48039fb50c2bee95c
2023-11-05 00:09:27 +08:00
Chaohui Wang
9e72afdca4
New MobileDataEnabledFlow
...
To easily collect the mobile data enabled setting changes.
Bug: 308903704
Test: manual - on DataUsageList
Test: unit tests
Change-Id: I31327f59ac32c1a621e2853e64bd30d7d17e079c
2023-11-03 07:19:26 +08:00
Chaohui Wang
298f65b048
Merge "Finish Mobile Settings if airplane mode is on" into main
2023-11-02 09:06:48 +00:00
Mengjun Leng
1871b8155f
Fix the burst callback issue on the repository
...
Prevents the callback when no sub entities changed to reduce
UI jank, besides, makes both variables mAvailableSubInfoEntityList
and mActiveSubInfoEntityList thread-safe.
Test: Manual
Bug: 279387799
Change-Id: I04f2a780de54e7528be6aeaf62bc8162e499aa97
2023-11-02 07:18:54 +05:30
Chaohui Wang
4ad7c3c2e6
Finish Mobile Settings if airplane mode is on
...
Fix: 298940648
Fix: 299256852
Fix: 295408616
Test: manual - on Mobile Settings then turn on airplane mode
Test: unit tests
Change-Id: Ifb4a287f7494ecb8b5040dbae7620fedfc316fdc
2023-11-01 18:05:42 +08:00
Charlotte Lu
d8630aa4d9
Merge "Show "add access point" when the user selects add Apn." into main
2023-11-01 09:02:47 +00:00
Charlotte Lu
8cbffebb89
Show "add access point" when the user selects add Apn.
...
Fix: 308724447
Test: Visual Test
Change-Id: I7c5a93c426dbb7806e5c21bae22f0dba7f61d870
2023-11-01 14:42:59 +08:00
SongFerng Wang
1742fa2ed0
Merge "To avoid the NullPointerException of UiccSlotInfo" into main
2023-11-01 06:21:49 +00:00
Quang Luong
d30a19395e
Merge "Move to non-static WifiTrackerLib isVerboseLoggingEnabled() methods" into main
2023-11-01 03:26:07 +00:00
Chaohui Wang
e9502c3cc4
Merge "When device has a call, avoid user inactive/active SIM." into udc-qpr-dev am: aab495929f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/25220520
Change-Id: If895e308ce90330c33d6ceaa7551768d0771dce4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-10-31 22:53:24 +00:00
SongFerngWang
0ba519f1b4
To avoid the NullPointerException of UiccSlotInfo
...
Bug: 307599094
Test: Build pass
Change-Id: Ia3b8d29b37f2c9616856e9448c9f346b81229534
2023-10-31 19:54:44 +08:00
Chaohui Wang
5ac8a4e281
Merge "Async load eid in SimEidPreferenceController" into main
2023-10-31 10:02:30 +00:00
Chaohui Wang
fe10785679
Merge "Check MOBILE_DATA_POLICY_MMS_ALWAYS_ALLOWED" into main
2023-10-31 07:15:44 +00:00
tom hsu
61e7550e7e
When device has a call, avoid user inactive/active SIM.
...
Bug: 296314216
Test: atest passed
Change-Id: I1a717d24a87316ccf065a2c02c49dc7e29825905
(cherry picked from commit e7d98dea9d )
Merged-In: I1a717d24a87316ccf065a2c02c49dc7e29825905
2023-10-31 03:08:41 +00:00
Chaohui Wang
b6e44ce818
Async load eid in SimEidPreferenceController
...
Avoid data loading in getAvailabilityStatus() to prevent ANR, override
updateNonIndexableKeys() for search availability.
Fix: 304560734
Test: manual - on "About phone" page
Change-Id: I9994abf3787f5db0edc71ff48d08e549a4b70bf7
2023-10-31 02:44:18 +00:00
Quang Anh Luong
2df8aa26a3
Move to non-static WifiTrackerLib isVerboseLoggingEnabled() methods
...
Bug: 279512950
Test: build
Change-Id: Id2b7bd9d31efbfb190aaacb8d116842dec5bb168
2023-10-31 09:39:08 +09:00
SongFerng Wang
8557ab051c
Merge "Modify the condition of MENU_FIX_CONNECTIVITY" into main
2023-10-30 07:54:34 +00:00
Chaohui Wang
8a5bba1f22
Check MOBILE_DATA_POLICY_MMS_ALWAYS_ALLOWED
...
To know whether MMS is always allowed, should check
isMobileDataPolicyEnabled(MOBILE_DATA_POLICY_MMS_ALWAYS_ALLOWED)
instead of isDataEnabledForApn(ApnSetting.TYPE_MMS).
Fix: 303759893
Test: manual - toggle "MMS messages" switch
Test: unit test
Change-Id: Id0417e569ff4e3dbac1ecff9327b4a964125c122
2023-10-26 11:07:03 +00:00
SongFerngWang
b271e84e42
Modify the condition of MENU_FIX_CONNECTIVITY
...
This condition adds checking "whether wifi is enabled"
Bug: 303100761
Test: build pass. local test
make RunSettingsRoboTests ROBOTEST_FILTER=NetworkProviderSettingsTest ->pass
Change-Id: Ib0aa92a77e7fcdbfd2d37e28474e3ef138275ca5
2023-10-26 14:29:05 +08:00
Charlotte Lu
d061ae4c6a
Get network type from options.
...
Fix: 307633026
Test: Visual Test
Change-Id: Ie251eb24196da6fc9ac578a35695368720edf78b
2023-10-25 14:45:04 +08:00
SongFerng Wang
ae7b0b0996
Merge "Add try-catch for set/get wifiCalling mode" into main
2023-10-24 06:40:24 +00:00
SongFerngWang
5ce87cb03d
Add try-catch for set/get wifiCalling mode
...
The APIs can throw IllegalArgumentExceptionm, the UI need the try-catch.
Bug: 299239773
Bug: 287946939
Test: build pass
Change-Id: I4b413abc985dfa871d3c2d39798b51dc1a686313
2023-10-24 13:47:30 +08:00
Chaohui Wang
15ca95a31b
Migrate to TwoStatePreference
...
SwitchPreference and SwitchPreferenceCompat are both TwoStatePreference.
Using TwoStatePreference in Java will helps migration in the future.
Bug: 306771414
Test: manual - check Settings pages
Change-Id: I84e1d7b09451106797c2b23d127855c6976678ca
2023-10-23 09:28:57 +00:00
Treehugger Robot
f7f2f0600b
Merge "Only allow clearing of Euicc Data by owner or demo user" into main am: f1cbe74e08 am: ad49e33f01 am: c200d097e9
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2264402
Change-Id: I53046b290eebcfc8647f19e66539dbb84f34afee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-10-20 10:12:38 +00:00
Treehugger Robot
ad49e33f01
Merge "Only allow clearing of Euicc Data by owner or demo user" into main am: f1cbe74e08
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2264402
Change-Id: Iaf9eed774382c735bed78f43451b89b61b4e275e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-10-20 09:08:47 +00:00
Edward Savage-Jones
922fc6067d
Only allow clearing of Euicc Data by owner or demo user
...
Secondary users should not be able to erase downloaded SIMs
is a similar way that they are not be able to factory reset
the device.
Bug: 303488763
Test: On a device with FEATURE_TELEPHONY_EUICC enabled,
create secondary user, enter Settings->System->Reset Options
there should be no option to 'Erase downloaded SIMs'
Change-Id: I4f5326732822bc322ab13a00937f94232ca69228
2023-10-20 08:20:01 +02:00
Chaohui Wang
d1577c5e68
Remove NetworkProviderSimsCategoryController
...
Which no real logic in it, just a proxy of
NetworkProviderSimListController.
Bug: 302628642
Test: manually - on MobileNetworkListFragment
Test: robo test
Change-Id: I4785ac9509f92f5a778e1bda1f8da12e2880589e
2023-10-19 15:56:22 +08:00
Chaohui Wang
dae71fffb4
Dismiss the open dialog if preference is disabled
...
In EnabledNetworkModePreferenceController, to prevent user changing the
value.
Fix: 304952402
Test: manually - open dialog, then received a call
Change-Id: Ia1be0840b061c796f72bf5053870fa9e90bd215f
2023-10-18 19:50:35 +08:00
Chaohui Wang
17f4fd5a08
BluetoothWiFiResetPreferenceController
...
Fix: 280864229
Test: manually rotate the screen
Test: unit test
Change-Id: I950ebae1c371ce05dd17710788eda3dc8bdfd2ca
2023-10-17 17:43:19 +08:00
Chaohui Wang
8603782bc5
Optimize DataUsagePreferenceController
...
Bug: 295260929
Test: manual - on mobile settings
Change-Id: I89a36981771ef21f3c8213ad2039c3577196b493
2023-10-11 20:48:18 +08:00
Charlotte Lu
6a9297df54
Add updateApnType.
...
Fix: 304457374
Test: Visual Test
Change-Id: I29e1feb6d213a8629e670a4d8f8286f9a8b6082f
2023-10-11 14:13:12 +08:00
Charlotte Lu
7be5d1cc43
Add updateApnDataToDatabase.
...
Fix: 304672976
Test: Visual Test
Change-Id: If0ed6b8090a37c5a98ab2eeb29fba61c1173c0a7
2023-10-11 13:38:54 +08:00
Charlotte Lu
5b2de59480
Add validateAndSaveApnData.
...
Fix: 304649927
Test: Visual Test
Change-Id: I900a096a6e27f1db66af204201d4ca2523537c0d
2023-10-11 11:22:39 +08:00
Charlotte Lu
b5b1b48af9
Merge "Add disableInit." into main
2023-10-10 09:43:02 +00:00
Charlotte Lu
7e3b5f4dad
Add disableInit.
...
Fix: 304433155
Test: Visual Test
Change-Id: I61c478a0d21bd321ea806ae9bd5666675e85db73
2023-10-10 14:24:43 +08:00
Charlotte Lu
2faf4cdd57
Use Flags to switch apn insert.
...
Fix: 304184645
Test: Visual Test
Change-Id: Iedba1343e9987a87b1adf6c1f7a8150e647e73d5
2023-10-10 13:00:58 +08:00
Charlotte Lu
2d029133f2
Telephony.Carriers.MVNO_TYPE is Deprecated.
...
Fix: 304180380
Test: Visual Test
Change-Id: Ibd1574e2f5004c27a4aafb94a679db5a60113c62
2023-10-10 10:33:15 +08:00
Charlotte Lu
93fb316f01
Add ApnDataInit.
...
Fix: 298906796
Test: Unit Test
Change-Id: Ibf9e12e4f9c4ee033ad6dc2ca1f2267bf1f21912
2023-10-08 17:54:40 +08:00
Chaohui Wang
4188a571aa
Use network type enum for APN
...
Instead of hardcoded names and values.
Bug: 303971237
Test: unit test
Change-Id: I099a408df7ee35abc886ed5c1d2d09fd31fda7d3
2023-10-08 14:23:37 +08:00