Commit Graph

2661 Commits

Author SHA1 Message Date
SongFerngWang
12066c72f9 Update OpenNetworkSelect UI at main thread
Bug: 270652395
Test: local test and atest AutoSelectPreferenceControllerTest
Change-Id: Idfc7a07106d552c35a94414bb14eac0fbdc3974f
2023-03-17 18:49:38 +08:00
Kweku Adams
9a087d6c19 Merge "Revert "Remove duplicate strings."" into udc-dev 2023-03-16 20:14:16 +00:00
Lifu Tang
caa1b51ef2 Revert "Remove duplicate strings."
Revert submission 19748582-settings_yesno

Reason for revert: Common strings in English could be translated into different strings in other languages.

Reverted changes: /q/submissionid:19748582-settings_yesno

Bug: 272603842
Test: build and open Settings app
Test: atest SettingsRoboTests
Change-Id: Iaad301c5513478fb95e40987ea3ccb4f923d71fa
2023-03-15 22:39:24 +00:00
SongFerngWang
7b9c22348a Avoid ANR when UI query network selection state
Moving the quert network selection state to back ground
and listening the service state to detect the betwork selection
changed.

Bug: 270652395
Test: atest AutoSelectPreferenceControllerTest
Change-Id: I81a597f28cf7ce25ff4eff5100bdb4d29c897a14
(cherry picked from commit 7b80b4ecd9)
2023-03-15 07:54:06 +00:00
Zoey Chen
63978e7e52 [Settings] 1. Show default subId SIM page if get an intent with invalid
subId 2. Fix the hotswap UI issue

Bug: 271635200
Bug: 271347499
Test: local test
Change-Id: Iac61a211fce7bcd85da48cb291f46584cf43f5c5
2023-03-13 08:12:20 +00:00
Treehugger Robot
a38c972ef0 Merge "Adb is disconnecting during Monkey Test Run." am: 821e70ea59 am: c8a58a249d am: 3c62dd3543
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2348443

Change-Id: If51239c47ffc2ebf9c80ce5b8f2e27d8b187a871
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 17:04:09 +00:00
Treehugger Robot
3c62dd3543 Merge "Adb is disconnecting during Monkey Test Run." am: 821e70ea59 am: c8a58a249d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2348443

Change-Id: I8ec06e45f02f48bfec30051159ed8a931a11e2e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 16:27:37 +00:00
Treehugger Robot
c8a58a249d Merge "Adb is disconnecting during Monkey Test Run." am: 821e70ea59
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2348443

Change-Id: I76493ccb15ff2d58045061ef4c62b20f772aab30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 15:53:41 +00:00
Treehugger Robot
821e70ea59 Merge "Adb is disconnecting during Monkey Test Run." 2023-03-10 15:19:15 +00:00
Maciej Żenczykowski
850993d166 Merge "settings: allow enabling ethernet tethering independent of link state" am: 905d584b15 am: f73112b56e am: 7e21dec65e
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2475089

Change-Id: I5e5711aeb90bb8bd860fd8515975f2b7d90ce689
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 05:28:51 +00:00
Maciej Żenczykowski
7e21dec65e Merge "settings: allow enabling ethernet tethering independent of link state" am: 905d584b15 am: f73112b56e
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2475089

Change-Id: I68e8a5898af8426250e1f0eb2d187e977f82dd13
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 04:15:54 +00:00
Maciej Żenczykowski
f73112b56e Merge "settings: allow enabling ethernet tethering independent of link state" am: 905d584b15
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2475089

Change-Id: I3976958e427d18b9b5c3d6ce59cb45969145fa23
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 03:41:54 +00:00
Patrick Rohr
6f9062297f settings: allow enabling ethernet tethering independent of link state
A user should be able to enable tethering even if the interface does not
have link yet. Therefore, the toggle should be active if any interface
is available, independent of its link state.

Test: TH
Bug: 234036868
Change-Id: I2ae25207a766d71217dd6d17f3f9b74ceb261238
2023-03-08 00:57:03 +00:00
SongFerngWang
d1d1ecc9d3 Using upper case country code
According to the ISO 3166-1, the two letters country code is upper case.

Bug: 271753491
Test: build pass and local test
Change-Id: Ia71cb6de45682407e4d988522c50d83659fe0017
2023-03-07 16:27:36 +08:00
SongFerng Wang
d427c0d2d1 Merge "[Settings] Customizable resource for hiding 3G preferred network type" into tm-qpr-dev am: 2b3cbffffd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21551540

Change-Id: I30a31add9ce0d6c8493edf162b57d80b03e4ef5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 17:15:07 +00:00
Bonian Chen
28367dae4d [Settings] Customizable resource for hiding 3G preferred network type
Add a customiazble resource for specifying the carriers that avoiding
from showing 3G option within the preferred network type.

Bug: 261615630
Bug: 247995343
Bug: 268564499
Bug: 265147144
Bug: 267433657
Bug: 240176276
Bug: 266724047
Bug: 265147263
Bug: 242017692
Bug: 220998105
Bug: 209835551
Bug: 237837196
Bug: 239318933
Bug: 247996564
Test: local

Merged-In: I8092372372cb334b5ac1956b869d194b9fcd0523
Merged-In: I5c12ad23a240fbe70630855e5f98b5be83912674
Change-Id: I8092372372cb334b5ac1956b869d194b9fcd0523
2023-03-02 10:47:00 +00:00
Bonian Chen
62e934a039 [Settings] Improve logging to support issue triage
1. Avoid from deprecated warning log
2. Add targetting subscription id into log

Bug: 271126362
Test: local

Change-Id: I6eac2032cc29b193dab009626a9824ee4fb451f5
2023-02-28 17:56:35 +00:00
Bonian Chen
a9717482a7 [Settings] Customizable resource for hiding 3G preferred network type
Add a customiazble resource for specifying the carriers that avoiding
from showing 3G option within the preferred network type.

Bug: 261615630
Bug: 247995343
Bug: 268564499
Bug: 265147144
Bug: 267433657
Bug: 240176276
Bug: 266724047
Bug: 265147263
Bug: 242017692
Bug: 220998105
Bug: 209835551
Bug: 237837196
Bug: 239318933
Bug: 247996564
Test: local

Change-Id: I8092372372cb334b5ac1956b869d194b9fcd0523
2023-02-23 09:04:50 +00:00
Zoey Chen
5645c092a9 [Settings] 1.Clean up unnecessary callback 2. register listener and
manager by subId

Bug: 269742364
Test: manual
Change-Id: Id536dedb200385dc6de5697848f8a68f2302351f
2023-02-18 07:28:56 +00:00
Zoey Chen
93185b6ce0 [Settings] Set callback as default
Bug: N/A
Change-Id: Iff8ef64558db63856a9982ae0d26427f8be7b60c
Test: manual
2023-02-16 07:00:04 +00:00
Aswin Sankar
7807138cb2 Re-add WiFi Calling preference controller
- WiFi calling preference controller was incorrectly removed
from MobileNetworkSettings.
- It was still accessible from Calls & SMS fragment.

Bug: 253698238
Test: Live test by flashing build on Pixel 7
Change-Id: I42b2ca26dfb0bf39ac9a0ec0107f3323d7dfc61b
2023-02-15 18:00:04 -08:00
Zoey Chen
cf9562beff [Settings] Should remove the subcription listener
Bug: 268405538
Change-Id: Ic96fa0b9a294c3de54cea4b3be52d6f2807c0ada
Test: manual
2023-02-15 06:58:10 +00:00
Aswin Sankar
812b59b981 Remove "Backup Calling" button from Settings UI
Pixel will not use 'Backup Calling' setting to enable cross-SIM calling.
Code may live on in aosp for other OEMs.

Revert of 9adfa375ea with changes to
remove lines with "ToDo Deprecate".

Bug:21153988
Test: Live test for cross-SIM calling across both subs.

Change-Id: I90e04ebf9f7bc3a05f459f59775ea7baa18716da
2023-02-14 16:04:50 -08:00
Aswin Sankar
ff8f96c0be Attempt cross-SIM enablement when auto data switch enabled
- For devices that have opted in with overlay config, enabling a 2nd SIM
and modifying 'Switch mobile data automatically' will update cross-SIM
calling enablement.
- These updates will be logged as settings events.

Bug: 260266794
Test: Live tests for cross-SIM calling across both subs.
Change-Id: I64d25ca406877ca5f061064e0a3b23f54c125638
2023-02-14 00:42:58 +00:00
Bonian Chen
6d225b22f1 Merge "[Settings] Unified the source of phone number" 2023-02-13 12:38:14 +00:00
Bonian Chen
dc82f0a0ee Merge "[Settings] Avoid from Guest user to access UI which requires permission for changing mobile networi configurations" 2023-02-13 12:37:45 +00:00
Bonian Chen
c9ace54b03 [Settings] Unified the source of phone number
Route UI access to phone number into a unified util class within
Settings app.

Bug: 265940535
Test: local

Change-Id: Ic747b0044217101d9a6a1e2cd6e59bbdbcd88021
2023-02-13 04:57:18 +00:00
Bonian Chen
6fa898d709 [Settings] Avoid from Guest user to access UI which requires permission
for changing mobile networi configurations

1. Confirm eSIM deletion should not be accessible by the end user
2. Erase eSIMs UI should should not be accessible by the end user

Bug: 260726944
Test: local

Change-Id: I45792fd451dbdc8a0788922480a7fa51f1267a68
2023-02-12 14:19:06 +00:00
Zoey Chen
1278cb5f87 [Settings] Fix the error of checking the null point
Change-Id: Ied5d9d5268d9d6d83b2995ae0e56bf5f0276ad22
Test: manual
2023-02-11 17:22:21 +00:00
Bonian Chen
b73369e874 Merge "[Settings] User with restriction should avoid from having entries through Settings search" 2023-02-10 08:52:55 +00:00
Bonian Chen
5e1c4d15a9 [Settings] User with restriction should avoid from having entries
through Settings search

1. Avoid from generating search report when user been restricted.
2. Guest user should have this restriction but not available, add
   additional rule as a conpensation from UI's perspective.

Bug: 260860114
Test: local

Change-Id: I63ba7f3b10fc812dd1498f17826a15e822879613
2023-02-09 16:42:56 +00:00
SongFerng Wang
327ae0d6db Merge "Add a config to hide the 3G option at preferred network mode UI" into tm-qpr-dev am: be84e27612
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21328340

Change-Id: I013418971db0db3a3e64895423063a88aac3c47c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-09 02:55:44 +00:00
SongFerngWang
e85bb5058d Add a config to hide the 3G option at preferred network mode UI
Add a config config_display_network_mode_3g_option to hide the 3G
option at preferred network mode UI

Bug: 261615630
Test: build pass. local test pass.
atest EnabledNetworkModePreferenceControllerTest

Change-Id: I4f94971add1d1eddc9f7c7458b8fc8fdcec3935e
(cherry picked from commit f7685dd715)
Merged-In: I4f94971add1d1eddc9f7c7458b8fc8fdcec3935e
2023-02-08 07:41:13 +00:00
SongFerngWang
f7685dd715 Add a config to hide the 3G option at preferred network mode UI
Add a config config_display_network_mode_3g_option to hide the 3G
option at preferred network mode UI

Bug: 261615630
Test: build pass. local test pass.
atest EnabledNetworkModePreferenceControllerTest

Change-Id: I4f94971add1d1eddc9f7c7458b8fc8fdcec3935e
2023-02-08 07:48:08 +08:00
Zoey Chen
245def5cad [Settings] Add the CarrierNetworkChange case am: ba7418ecd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21312559

Change-Id: Ie5927ffa717e26bc452c74f5ddb94f84720e9b29
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-07 13:31:29 +00:00
Zoey Chen
ba7418ecd7 [Settings] Add the CarrierNetworkChange case
Bug: 262927206
Test: atest SubscriptionsPreferenceControllerTest
Change-Id: If7eeb185224179d59ab841af0062ec5b98b956e9
Merged-In: If7eeb185224179d59ab841af0062ec5b98b956e9
2023-02-07 10:48:30 +00:00
Zoey Chen
69fe84219a [Settings] Add the CarrierNetworkChange case
Bug: 262927206
Test: atest SubscriptionsPreferenceControllerTest
Change-Id: If7eeb185224179d59ab841af0062ec5b98b956e9
2023-02-07 08:59:14 +00:00
Quang Luong
f4b54b3d49 Fix connected wifi entry not clearing when Wifi is disabled
Connected wifi entry is represented by either
mConnectedWifiEntryPreferenceCategory or
mFirstWifiEntryPreferenceCategory, but we only clear
mConnectedWifiEntryPreferenceCategory when Wifi is disabled. Make sure
to also clear mFirstWifiEntryPreferenceCategory.

Bug: 267815756
Test: manually verify connected wifi is hidden when wifi is disabled
Change-Id: I4c30a658200f1ab90af5ce41a6531f5784a8de5d
2023-02-03 23:54:25 +00:00
Zoey Chen
4fab96ffe5 [Settings] Do not insert subInfo repeatedly
Bug: 264322977
Test: manual
Change-Id: If1e9144c9d682befe5bccd3fa506ad82e2807b09
2023-01-19 20:25:35 +00:00
Bonian Chen
b079eb6287 Merge "[Settings] Reduce CDMA API access when not required" into tm-qpr-dev am: 147669c893
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/20893163

Change-Id: Iac1f7f8b5de6d6a50591170637c62f379fa6c1da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-19 03:55:55 +00:00
Bonian Chen
147669c893 Merge "[Settings] Reduce CDMA API access when not required" into tm-qpr-dev 2023-01-19 03:21:27 +00:00
Gil Cukierman
36517a0bcd Merge "Change Toggle UX to "Require encryption"" 2023-01-17 14:13:07 +00:00
SongFerng Wang
0ceedc8d04 Merge "Revert "[MEP] psim->esim, don't skip carrierConfigChanged with subId -1"" into tm-qpr-dev am: f71b548285 am: 40838101dd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/20973543

Change-Id: I573b4835887ef22ed832291d881123690b9d5d5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-16 08:58:31 +00:00
SongFerng Wang
40838101dd Merge "Revert "[MEP] psim->esim, don't skip carrierConfigChanged with subId -1"" into tm-qpr-dev am: f71b548285
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/20973543

Change-Id: Iff0e0f03886e414c36d508e5b17541514c1171f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-16 08:21:26 +00:00
SongFerng Wang
f71b548285 Merge "Revert "[MEP] psim->esim, don't skip carrierConfigChanged with subId -1"" into tm-qpr-dev 2023-01-16 07:44:37 +00:00
TreeHugger Robot
eac5326a16 Merge "Add toggle for Wi-Fi hotspot" 2023-01-13 06:25:47 +00:00
SongFerng Wang
fe5978cde1 Revert "[MEP] psim->esim, don't skip carrierConfigChanged with subId -1"
This reverts commit 078ecbd765.

Reason for revert: The in-market device have error by some unknown reasons at b/264371574. To revert it, then the settings wait the 25s, it can protect the system has enough time for enabling esim.

Change-Id: Ic17380f549c764306851ad5cba6360f68df9b9b5
2023-01-13 04:18:34 +00:00
Weng Su
f779e6c9d3 Add toggle for Wi-Fi hotspot
- Add Wi-Fi hotspot toggle with vertical divider

- Disable preference and toggle when Data Saver is enabled

Bug: 245569117
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=TetherSettingsTest
make RunSettingsRoboTests ROBOTEST_FILTER=WifiTetherPreferenceControllerTest
atest -c TetheringManagerModelTest

Change-Id: Ic2baf7d3d0a7bf9527da38d24ecc511b7c91265a
2023-01-13 08:52:54 +08:00
Gil Cukierman
0251b272aa Change Toggle UX to "Require encryption"
Changes the UX of enable/disable null ciphers to
"Require encryption". The default value is off, making
the default behavior equivalent to the previous version
of the toggle.

Test: atest NullAlgorithmsPreferenceControllerTest
Test: Manual testing in cuttlefish
Bug: 264540492
Change-Id: Iaa0c9c259559a205aacad9fb9af8de6b54782c8d
2023-01-11 18:42:05 +00:00
Bonian Chen
4785c8a7ec [Settings] Reduce CDMA API access when not required
Avoid from accessing CDMA roaming API to reduce some latency on UI.

Bug: 263294530
Bug: 264656126
Test: local

Change-Id: I5c74636d8418a379724676e1f854c8adff5d4387
Merged-In: I5c74636d8418a379724676e1f854c8adff5d4387
2023-01-11 08:58:31 +00:00