Commit Graph

200 Commits

Author SHA1 Message Date
Fan Zhang
3181e1aceb Change search fab to search bar.
- Remove search fab from layout xml
- Change RelativeLayout to CoordinatorLayout so we can use prebuilt
  scrolling behavior
- Minor update to theme so search bar background works in dark mode for
  the homepage activity.

Change-Id: If7408c12684be65137e04ae3bb4137204c2d77e0
Fixes: 117508596
Test: robotests, visual
2018-10-10 16:29:22 -07:00
TreeHugger Robot
6fa4dfedd1 Merge "Fix Homepage wrong color in dark theme" 2018-09-18 18:26:47 +00:00
Raff Tsai
0a39e43316 Fix Homepage wrong color in dark theme
Change-Id: Id22f8baff0b97c0e7081fb8c68241bc8d0d01a45
Fixes: 113964702
Fixes: 115789360
Test: manual
2018-09-18 07:14:57 +08:00
Philip P. Moltmann
a5918a6a68 Make Settings use system-api restricted icon.
Test: Browsed around settings
Bug: 110953302
Change-Id: I1b19be721719ed8946cb558b93119b1b0e173794
2018-09-17 15:48:31 -07:00
Raff Tsai
43a7b18f21 Modify Settings homepage layout
- Add BottomNavigationView which has two tabs
- Remove BottomSheet in layout files

Change-Id: I493290fa9dee0566c73c5c9d7fbba10b71b4e2b4
Fixes: 113266753
Test: visual
2018-09-05 11:55:16 +08:00
tmfang
db00a3177a Refactor add network page
WifiDialog.java can be launched as "full screen mode"
in some use cases. However the way it's done is that
it uses theme to fake the full screen appearance.
It just feels hacky to use a dialog for full screen UI.
So, we created an "AddNetworkFragment" to make this
page can look like a normal fragment.

Also, clean up some useless code about "full screen mode"
of WifiDialog.

Change-Id: Iedd04c6a8e403cbceb872313314e1cba0d514246
Fixes: 111875856
Test: robo test, manual test
2018-08-18 00:16:14 +08:00
Raff Tsai
11b17a7e11 Save BottomSheet state when screen rotate
- Save BottomSheet state in onSaveInstanceState
- When Settings starts from saved state, we don't need to
  add fragment. Because FragmentManager already contains
  fragment instance.
- Fix status bar color

Change-Id: Ic8779b8253040554409e735bd57bd9001c1d56fd
Fixes: 112428378
Test: make RunSettingsRoboTests
2018-08-14 09:56:27 +08:00
TreeHugger Robot
27c9e13c92 Merge "Fix RequestPermissionActivity crash" 2018-08-09 15:58:56 +00:00
tmfang
fe50f43f3f Fix RequestPermissionActivity crash
- Dialog needs to use AppCompat theme.
- Activity needs to finish itself when user closed AlertDialog.
If we don't fix it, you can see a window after AlertDialog was dismissed.

Change-Id: Idfbd6b68bcdd3b577f1459657b635b7af9397276
Fixes: 112018696
Test: robo test, manual test
2018-08-09 12:48:58 +08:00
Fan Zhang
25d9f3812b [Dynamic Home] Make a new page for all top level settings
Since we are moving conditionals/suggestions to a different place, there
is no need to use DashboardSummary to display top level settings any
more. We can simplify a lot of code for top level settings and reduce it
to a standard DashboardFragment.

- Create a new DashboardFragment + xml for all top level internal items
- Add a PreferenceController to provide summary for Network & internet
  item.
- Mark a bunch of things deprecated for future work.

Bug: 110405144
Test: robotests
Change-Id: I9f778777131c28eb836b722e089e026a59f5ddc6
2018-08-08 17:20:15 -07:00
tmfang
9d4a806f28 Settings crashes on opening Wi-Fi Add network
Since Theme_Settings_NoActionBar extends from Theme.DeviceDefault.Settings,
so it carshed when AppCompatDelegateImpl tried to get AppCompat theme from WifiDialog.

Test: visual inspection, robo
Change-Id: I751b771fdfa9ad2261baa5a06274f6bb0a70d677
Fixes: 111804691
2018-07-27 13:49:29 +08:00
Fan Zhang
c00b042678 Merge changes from topic "migrate-alerdialog-androidx"
* changes:
  Migrate all AlertDialogs to AndroidX version
  Migrate all AlertDialogs to AndroidX version
2018-07-20 21:52:06 +00:00
Mill Chen
dff64a02cf Fix color of status bar
- Set true value to windowLightStatusBar

Bug: 111665984
Test: rebuild
Change-Id: I9808256be052e383656976555cfca5baf60634c6
2018-07-20 15:16:35 +08:00
tmfang
5bd7151413 Migrate all AlertDialogs to AndroidX version
- Let test cases can be compatible with AndroidX AlertDialog.
- Theme of Transparent needs to support AndroidX AlertDialog.

Change-Id: I0789b66f52feef30ebab7fb824d0e39d5ae9cc96
Fixes: 111413092
Test: make RunSettingsRoboTests -j56
2018-07-20 13:38:58 +08:00
Raff Tsai
0810afee9b Fix AlertDialog corner and color accent
- Add some attributes in Theme.AlertDialog

Change-Id: Ifb9ca98ee11f6c82cda4a576d10b5fde54f788be
Fixes: 110917586
Test: mannual
2018-07-18 15:40:51 +08:00
Salvador Martinez
210ddd075a Fix dialogs in Theme.Settings
Theme.Settings was explicitly using a Light theme. This CL
changes it to DayNight so that it properly changes colors in
night mode.

Test: visual inspection, screenshot
Bug: 111397440
Change-Id: I20088a9021ddfe7d6e92c3b52ce4ca65ada07983
2018-07-17 15:45:29 -07:00
Fan Zhang
a122be1c35 Move non-theme styles to styles.xml
1. Move SUW related themes into its own theme file.
2. Move non-theme styles into styles.xml
3. Move theme styles to themes.xml
4. Group all TextAppearence together in styles.xml
5. And remove some unused resources

Bug: 111454230
Test: manual
Change-Id: I1067a01cf1960bc72ec92528177ac5fcbd4faa3a
2018-07-16 17:59:07 -07:00
Fan Zhang
dec6b8cd38 Remove more unused theme customization
Bug: 111454230
Test: manual
Change-Id: I704247ffe1092165365f7604f17372c79afd46ed
2018-07-16 16:14:56 -07:00
Fan Zhang
612fc1ea40 Clean up theme part 1: move attrs to attrs.xml
And remove unused theme and layouts.

Bug: 111454230
Test: rebuild
Change-Id: Iaf418a9a3dc014fc0eac096e60b0e4581c6ededb
2018-07-16 14:00:20 -07:00
Fan Zhang
1b11c68642 Remove custom style for preferenceFragmentStyle
Bug: 111454230
Test: manual
Change-Id: I84d3ba3876c636461afaeb6d77a8a759b339f733
2018-07-13 18:13:41 -07:00
Fan Zhang
81b4d99ae3 Fix a crash when setting lock pattern in SUW
Change-Id: Ic2f1bc5946014d126f2d600966764e1f00be6559
Fixes: 111381755
Test: manual in SUW
2018-07-12 12:06:17 -07:00
Raff Tsai
00d42c510d Modify icon color and fix search bar corner
- add android:colorAccent attribute in theme
- fix wrong xmlns

Change-Id: Ia8a0a715edf40959c952f8982298a830bedfa156
Fixes: 111359684
Test: manual
2018-07-12 17:32:46 +08:00
tmfang
27c84de325 Settings Fragment Migration (Build pass app)
This patch focused on fixing compile errors and some runtime errors.

Test: We can't test it now. But we will have an integration test later.
Bug: 110259478
Change-Id: I16c471ddcd0fa1460c665b7f74d86fcace5ee67b
2018-07-11 18:24:51 -07:00
Kevin Chyn
0be7e64ffd Merge changes from topic "face-settings"
* changes:
  3/n: Remove all faces when Pin/Pattern/Pass is removed
  2/n: Add face to ChooseLock*
  1/n Start adding Face settings (base, intro)
2018-07-03 00:51:49 +00:00
Raff Tsai
082f8ee93c Revert "Revert "First commit of dynamic home page feature""
This reverts commit 457f6ef140.

Reason for revert: fix the color check in repohook

Test: make RunSettingsRoboTests

Change-Id: I1b466c412138dfb0f2bffc4270a8932fe3b81c94
2018-07-02 16:02:26 +08:00
Kevin Chyn
4882e875ae 1/n Start adding Face settings (base, intro)
This change refactors common biometric settings code as well to minimize
duplicated code in areas such as:
    Preference Controller
    EnrollBase
    EnrollIntro

This change also updates ChooseLock to have Face + Pin/Pattern/Pass

Bug: 110589286

Test: Fingerprint settings/enrollment still works
Test: make -j56 RunSettingsRoboTests
Change-Id: Ie35406a01b85617423beece42683ac086e9bc4a7
2018-06-29 18:19:34 -07:00
Lei Yu
457f6ef140 Revert "First commit of dynamic home page feature"
This reverts commit 3515bc7259.

Reason for revert: CLs in this topic break color check in repohook.

Bug: 110960820
Change-Id: I5934b6baf65515ebbc4e4660ed99747dd581f526
2018-06-29 00:21:14 +00:00
Raff Tsai
3515bc7259 First commit of dynamic home page feature
- Add SettingsHomepageActivity
- Add feature flag
- Use com.google.android.material_material library

Change-Id: I325be249f739d3b03dc2f0d722319f5771e2313b
2018-06-28 11:46:37 +08:00
Fan Zhang
36e61e191a Misc style updates to fix some GAR issues
- Increase tap target height for add wifi dialog entries.
- Increase tap height for vpn editor fields
- Tap target area for switchbar toggle

Change-Id: I0d0e350dd4236cd4fe73fa190fb79ca50de2da60
Fixes: 79871635
Fixes: 79887410
Test: visual
2018-05-17 15:03:18 -07:00
Andrew Sapperstein
823cd12415 Update inherited actionBarStyle to DeviceDefault.
Was using a Material style. Now it's using the DeviceDefault one that
Theme.DeviceDefault.Settings uses.

Bug: 69314526
Test: visual inspection
Change-Id: I5ce1bbb51a8d067fce226ff4a41fdea64106156a
2018-04-08 12:33:27 -07:00
Jyun LuoLai
dbcc3d4176 Let battery status icon has consist UI in PowerSummaryPage
Change-Id: Ia82adb4a964cb63c656c70a7277c76991c6b2505
Fixes: 76219062
Test: Manual test & make RunSettingsRoboTests
2018-03-29 15:52:34 +08:00
Jyun LuoLai
11960ce2ce Fix PATTERN UI to align PIN&PASSWORD screen
Change-Id: I475e90ab11a9821fc21623dcfdd3854914a7eb04
Fixes: 69002501
Test: Manual test & make RunSettingsRoboTests
2018-03-21 09:36:50 +08:00
jackqdyulei
92757b2454 Add controller for battery saver button
Bug: 72228477
Test: RunSettingsRoboTests
Change-Id: Iae9096a10553ea761d099e1e72c1de56b693bac0
2018-02-08 15:19:00 -08:00
Andrew Sapperstein
26e35dac79 Delete WPS settings.
Removes the WPS PIN and Push button settings, all of
the strings, and related code.

Change-Id: I1c7a35ffc8491c57e07accba9b1b5f5407b01831
Fixes: 72421239
Test: deletes code, robotests
2018-02-07 13:57:57 -08:00
Maurice Lam
f5b42777c1 Support GLIF v3 for lock screen settings
Also removed setup_divider_color because it's unused and is causing
a lint error.

Test: cd tests/robotests && mma
Bug: 72702989
Change-Id: I81894be6458439f688c0144d1136d3d7f75afa25
2018-01-30 21:01:42 -08:00
Fan Zhang
9de4999015 Move styleActionBar to onStart()
Change-Id: I002c266acc0e1095269e92eb7988b1ab505e48ff
Fixes: 72097389
Test: robotest
2018-01-17 17:29:33 -08:00
Fan Zhang
46b5474be4 Update master switch style
- When off, background grey
- When on, background accent
- Switch toggle always white, only change the slider color during on/off

Change-Id: I0ca49439f4e20e75517d503f28cc3068930591e8
Bug: 69462439
Test: robotests
2018-01-10 15:52:20 -08:00
Ajay Nadathur
a248b34ce3 Add rounded corners to wifi connection dialog
bug: 69930374
Test: Manually tested and verified
Change-Id: I458c12d3642f9866a00eb1b0f9a5b8a323465892
2017-12-19 14:47:08 -08:00
Ajay Nadathur
4f3885a767 Update dialog styles to material 2
Bug: 69930374
Test: Manually tested
Change-Id: I4215d0283cbbfcc929b891f5b419b52b1de8598a
2017-12-15 13:52:43 -08:00
Maurice Lam
e9a6e8f1e5 Use default primary color for choose lock screens
Make the settings screens that inherit from SuwThemeGlif use the
default blue primary color.

Test: Manual
Bug: 63143321
Change-Id: I07026139a5e0562c192ec1ca9304d5cd3647d5b0
2017-08-15 19:30:14 -07:00
Fan Zhang
f559395603 Use preference theme from SettingsLib
Bug: 36663882
Test: rerun robotests
Change-Id: I9f0f51a9d070191f5bf8f3315fef4d997d6213c3
2017-07-10 14:56:49 -07:00
Andrew Sapperstein
893cb0987a Add search bar to SearchActivity.
Styling doesn't look exactly right yet but there's a bar.
Creates an ItemDecoration to add a spacer above the first view.

Removes the action bar and replaces it with a SearchView
inside of a CardView.

Remaining work: pixel pushing

Bug: 37477506
Test: make RunSettingsRoboTests
Change-Id: I4a0f0c91c51ff5820b61a596520d80a3337c3466
2017-06-01 11:01:00 -07:00
Anna Galusza
50d359aa38 Merge "Update Setup Wizard Vision Settings colors." into oc-dev am: 221f9245d6
am: 86d10d65ab

Change-Id: I2e1a87c187bf9182b028402ae01d3504e5a637de
2017-04-18 19:48:03 +00:00
Anna Galusza
cc7de0c36d Update Setup Wizard Vision Settings colors.
Bug: 34470898
Test: UI updates only.

Change-Id: I8693004637f31a433c6911a4c99d5dd1426d76f1
2017-04-13 20:29:45 +00:00
Maurice Lam
e0e81b68c6 Make GLIF v2 available to OEMs
Rename GLIF Pixel to GLIF v2 and make available to OEMs. In this
model settings read the EXTRA_THEME from the intent and picks between
GLIF and GLIF v2.

Test: Manual
Bug: 36857917
Change-Id: I4899a3d041abaf0b97843cf14affc8d6f9587a22
2017-04-05 21:59:28 +00:00
Stefanot
dfb842a811 Add new theme in Settings.
We add this style so activities can use SuwThemeGlif.Light theme but
also use Settings default window animations.

Test: RunSettingsRoboTests

BUG: 35959708
Change-Id: Iaedfbf4b9321ff4d32ab44c57b01d9d4a24e0d03
2017-03-15 18:18:49 +00:00
Fan Zhang
fbefd9ea01 Add dividers on a few preferences
Fix: 36023418
Fix: 36058273

Test: visual
- On top of emergency preference
- On top of footer preference

Change-Id: Iefbbf0ad410d46c466f919ecb60b572dd6f1ea28
2017-03-08 15:29:25 -08:00
Fan Zhang
a6986e7ed2 Misc fix for secondary user
- Theme fix: action bar and status bar color now have enough contrast
  for SUW theme.
- Fix a ConcurrentModificationError when switching between users
  quickly.

Change-Id: If31f88e36f1d4c5d7f90bc9d128041f0e0a81ff9
Fix: 35948464
Test: make RunSettingsRoboTests
2017-03-08 13:09:17 -08:00
Fan Zhang
1faaf6ea66 Use light status bar theme in confirm credential activity
Change-Id: I21443fd4eedf3ec9760e751a39d624e0c75530d5
Fix: 35996219
Test: visual
2017-03-07 13:44:18 -08:00
Jason Monk
6fca98f905 Switch references to colorError
Test: make
Change-Id: I0ed10d78763642cecc5ba8e8e15a097d51280946
2017-02-24 14:57:31 -05:00