The wrong background color of CollapsingToolbarLayout appears in some
pages like "All apps" page or "Password and accounts" page. This symptom
can be observed in these pages when the work profile is enabled and the
line count of title is 1.
This issue is caused by updating the title of the page many times. In
these pages that have the tab view, the structure of the page differs
from a general setting page. The title of the page is coming from
BaseActivity, ProfileSelectFragment, PersonalFragment and WorkFragment,
in which the page that has the issue has an empty string from
ProfileSelectFragment. That is causing the CollapsingTollbarLayout has
the different line count during the process of setting the title.
Since the pages that have the tab view are different from the general
pages in Settings, the title should be set separately for those pages.
Adding a method to get the title resource ID so the page extending from
ProfileSelectFragment can set its title.
Bug: 192914660
Test: visual test and manual test
1) Enable work profile
2) Navigate to All apps page
3) The page should have the correct background color in the
CollapsingToolbarLayout
Change-Id: I52ef9729f3cad56161ea3d87ba25429dfcdb26ef
Revert submission 16169565-b/199120420
Reason for revert: Breaking Build (b/207471332)
Reverted Changes:
Ibc101a249:Receiving a broadcast message when home screen is ...
I18628552a:Sending broadcast message when home screen is read...
Change-Id: Ie985295c7a643c6243f8025eaf007a882b651546
Prior to this cl, if user opens settings app
in single-pane first and navigates to
the search page, then rotate the device,
user observed the search page was still shown
with full screen.
Because we didn't register correct split rule,
it causes the abormal behavior on two-pane mode.
In order to register correct rule, we also need
to assign correct component name while opening the
search page.
Fix: 206896763
Test: Rebuilt apk and verify the behavior
Change-Id: I7343467aa716d71da63f2ad0a034dc6c1b7fd415
Since the fingerprint registration sometimes has a hardware dependency,
to bring a better UX, make the flow full screen on large screen devices.
Bug: 197717071
Test: Try to register a new fingerprint and see the pages are full
screen.
Change-Id: I5dcb720a8b6a58bd9fc67ecae35f730c20a2c4d3
Set window title for activity, so it won't announce
"Settings" again.
Test: Run the talkback and do not observe issue
Fix: 200749911
Change-Id: Ied973916bdd43562424b97eadea2b3a413c712ec
Security option index values are currently converted using
toBinaryString() which converts indexes to binary String. Thus
index values doesn't match the expected Security config values in
SoftApConfiguration.
This commit uses toString() API to avoid index mismatch.
Bug: 197497991
Test: manual test
atest -c WifiTetherSecurityPreferenceControllerTest
Change-Id: I43d236d071a8141845f312c63b1a693fde254358
* changes:
[Provider Model] Internal cleanup - remove Provider Model flag and deprecated legacy UI part.3
[Provider Model] Internal cleanup - remove Provider Model flag and deprecated legacy UI part.2
[Provider Model] Internal cleanup - remove Provider Model flag and deprecated legacy UI
In a high level, I created two versions of app bar layout.
One for single pane design, another for two-pane design.
Then, app initilizes two different layouts in the beginning,
we simply show/hide one version while app is receiving the
configuration changes update.
Test: Rebuilt apk and observed the screen.
Bug: 195293058
Change-Id: Icd19ea02ab1be4e964701b22ae9e20c9e00d3c0d
- Use a synchronous API to make SettingsActivity start deep link intent
in onCreate
- Change SettingsHomepageActivity from an alias to a real activity
- Clean up redundant codes
Fix: 206585572
Test: Manual, robotest build pass
Change-Id: Idf42c026f593bb5801a13cae250d1523030b7092
