Commit Graph

52842 Commits

Author SHA1 Message Date
Tom Hsu
2625ca4e7d Merge "Settings: Fix force close for telephony callback exceeding limitation" into main am: 380a136e50 am: bca026c182
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2995004

Change-Id: I2c15c609239927bd2a87da19c99c8f3ee34e9a63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-25 07:14:10 +00:00
Treehugger Robot
ddd539d590 Merge "Use the correct Edge to Edge flag" into main 2024-03-25 07:01:00 +00:00
Tom Hsu
380a136e50 Merge "Settings: Fix force close for telephony callback exceeding limitation" into main 2024-03-25 06:49:08 +00:00
SongFerng Wang
a3b28762cb Merge "To gray out the next button if the user does not select two sim" into main 2024-03-25 03:15:08 +00:00
Tom Hsu
af5e80b7d8 Merge "Enforce BaseUserRestriction for DISALLOW_CONFIG_BRIGHTNESS" into main 2024-03-25 03:00:38 +00:00
Yiyi Shen
9ba24a5d2d Merge "[Audiosharing] Support sharing dialog when click media devices." into main 2024-03-25 02:44:35 +00:00
Sunny Shao
8d4ba6d904 Use the correct Edge to Edge flag
- Use the correct flag to fix the navigation bar problem.

Fixes: 330217912
Test: manual test
Change-Id: I37869d5cc713be2b03bc8e9206ff1e0dcee8512e
2024-03-25 09:19:11 +08:00
Himanshu Gupta
8735770fa8 Merge "Disable PS entry point and Activity when PS is not allowed." into main 2024-03-24 14:45:32 +00:00
Jay Sullivan
67a237efca Merge "[ECM] Legacy code: treat DEFAULT as ALLOWED (st)" into main 2024-03-22 19:30:56 +00:00
Allen Su
071f1e6331 Merge "[ToA]Cache system gender to reduce unnecessary IPC" into main 2024-03-22 16:15:16 +00:00
Jason Hsu
73706c1d77 Merge "Add intent to open hearing device settings page and pairing page" into main 2024-03-22 15:10:47 +00:00
songferngwang
774b34c56b To gray out the next button if the user does not select two sim
- gray out the next button
- add the format for phone number

Bug: 329535069
Test: manual test. To verify the UI
atest SimOnboardingSelectSimTest

Change-Id: I8dd62e3da9567a518d22d615f6974659900ef1bb
2024-03-22 14:46:17 +00:00
Himanshu Gupta
5e451db395 Disable PS entry point and Activity when PS is not allowed.
In this change we disable:
1. Security Center Entry point
2. PrivateSpaceAuthenticationActivity

when private profile is not present and cannot be added.

Additionally, the intent exposing PrivateSpaceAuthenticationActivity
is also non-exported and changed to a better name.

Bug: 328578044
Test: Manual build and flash
Change-Id: I13d298316c6d719d0b06e4969989ea1da83dd4c6
2024-03-22 13:44:23 +00:00
Yomna Nasser
fe82ebc310 Merge "Guard CellularSecurityPreferenceController with FEATURE_TELEPHONY" into main 2024-03-22 13:41:59 +00:00
tomhsu
7465e27d85 Enforce BaseUserRestriction for DISALLOW_CONFIG_BRIGHTNESS
- For Adaptive brightness

Fix: 330855652
Test: Manual test. see b/330855652
Change-Id: Iea848c9d92abdf152d3eb827fbe1fb141f4687d7
2024-03-22 11:50:22 +00:00
Joseph Vincent
4230ad4b07 Merge "Add a preference in reset options to delete private space" into main 2024-03-22 10:01:19 +00:00
jasonwshsu
4fad32be20 Add intent to open hearing device settings page and pairing page
* Hearing devices quick settings tile need to launch related page

Bug: 291423171
Test: Add intent only
Change-Id: I59d2ac06505029852dd6cd2ca16c86f201e4148c
2024-03-22 17:35:51 +08:00
Allen Su
ab18169773 [ToA]Cache system gender to reduce unnecessary IPC
Bug: 312324895
Test: atest TermsOfAddressNotSpecifiedControllerTest
atest TermsOfAddressNeutralControllerTest
atest TermsOfAddressMasculineControllerTest
atest TermsOfAddressFeminineControllerTest

Change-Id: Idee2cc1ece673092c94307b8812f032f7826c16a
2024-03-22 09:17:09 +00:00
Sunny Shao
e352753093 Merge "Handle the Edge to Edge problem" into main 2024-03-22 08:28:17 +00:00
Yiling Chuang
38337dc8b8 Merge "Revert "Add a new tip type for wireless charging."" into main 2024-03-22 06:39:08 +00:00
Yiyi Shen
87629f2470 [Audiosharing] Support sharing dialog when click media devices.
Instead of directly stop audio sharing, clicking on media devices will
lead to different sharing dialogs based on different scenarios. The
scenarios are align to cases when a new device is connected.

Test: atest
Bug: 305620450
Fix: 327259953
Change-Id: Ibb591cb1a59f31c8f0be4f3e72e45378b17e3809
2024-03-22 14:11:11 +08:00
Jay Thomas Sullivan
f8b405462a [ECM] Legacy code: treat DEFAULT as ALLOWED (st)
This modifies pre-flag behavior so that MODE_DEFAULT (of
OP_ACCESS_RESTRICTED_SETTINGS) is treated the
same as MODE_ALLOWED.

The reason is that we've change the default op mode (of
OP_ACCESS_RESTRICTED_SETTINGS) to MODE_DEFAULT. Since legacy code
doesn't understand what MODE_DEFAULT means, we need to mitigate the
impact of reverted flags.

Bug: 329488185
Test: atest SpaPrivilegedLibTests
Test: atest
com.android.settings.applications.specialaccess.notificationaccess
Test: atest com.android.settings.datausage
Test: atest PremiumSmsAccessTest
Test: atest RestrictedPreferenceHelperTest
Test: atest
CtsPermissionUiTestCases:android.permissionui.cts.EnhancedConfirmationManagerTest

Change-Id: I957c75870018a9d4d2d2e122ee3bb2252b338cb2
2024-03-21 20:24:29 -07:00
Yiling Chuang
21b1efa944 Revert "Add a new tip type for wireless charging."
This reverts commit f709de6d27.

Reason for revert: feature no longer needed

Change-Id: Ie5aab651406d1085c363c73559197eee2b178da4
2024-03-22 03:08:03 +00:00
Edgar Wang
1a683a1007 Merge "Listen Developer option enable state" into main 2024-03-22 01:13:17 +00:00
josephpv
43c8d3a3f8 Add a preference in reset options to delete private space
This takses care to add an entry point in Settings->System->Reset
options->Delete private space when private space feature is supported on
the device. Entry point appears both when private space exists and also
when private is not created.
On selecting asks for user authentication and on successful
authentication using device lock shows a dialog asking for
confirmation and calls for deletion private space.

Based on this entrypoint it would not be possible to guess if private
space exists on the device.

Recording link : b/329041740#comment3

Bug: 329041740
Test: atest ResetOptionsDeletePrivateSpaceControllerTest and verified
this doesn't give away existence of private space

Change-Id: I9a5b908e7a3f9edaf609cf7e6a87f9842d689ce6
2024-03-21 21:54:52 +00:00
Jonas Larsson
4b2d4ae984 Guard CellularSecurityPreferenceController with FEATURE_TELEPHONY
TelephonyManager is only available if
Packagemanager.hasSystemFeature(PackageManager.FEATURE_TELEPHONY)
returns true. If false we should return UNSUPPORTED_ON_DEVICE.

Bug: 330726177
Test: m & manual
Change-Id: I1c2a1cb1f61b58f448ef207b2391dd9c262f6848
2024-03-21 17:14:56 +00:00
Chelsea Hao
14b1831fda Merge "Remove flag, use new api for auto on in settings." into main 2024-03-21 13:09:03 +00:00
Jakub Rotkiewicz
de27acef86 Refactor Bluetooth Codec settings to dynamic ListPreference
Fetch supported codecs from native and present to user using
ListPreference.

Bug: 305779598
Bug: 311451118
Bug: 323319530
Tag: #feature
Test: atest SettingsRoboTests:com.android.settings.development.bluetooth.AbstractBluetoothListPreferenceController
Test: atest SettingsRoboTests:com.android.settings.development.bluetooth.BluetoothCodecListPreferenceControllerTest

Merged-In: Iedbfd01c0d1b59df8a073f4e9aedca3913e6d45f
Change-Id: I90ed0d83c3250c64789e27707b0b7bff30043335
2024-03-21 11:06:18 +00:00
Sunny Shao
458ed92600 Handle the Edge to Edge problem
- Fix the navigation bar overlapped problem in sub-pages.
- Use a workaround solution to handle Homepage statusbar problem.

Bug: 328622648
Fixes: 330217912
Test: manual test
Change-Id: I67a65e2af10def84bf743d4d3cd0047098423ffe
2024-03-21 19:04:58 +08:00
Chaohui Wang
f091754518 Merge "Fix readOnlyApnFields not applied" into main 2024-03-21 09:52:41 +00:00
hoffc
ef2e171b50 Settings: Fix force close for telephony callback exceeding limitation
When sub info changed, new telephony callback will be registered but old telephony callback not un-registered. Finally result in force close for registered telephony callback count exceeding its allowed.

No need to re-registered the telephony callback for one sub if registered.

Bug: 328716180

Change-Id: Ia0c3b311b5b5cc77f061d81ec21250abde2fa9f4
2024-03-21 17:32:13 +08:00
Chaohui Wang
54b03da369 Fix readOnlyApnFields not applied
Some enabled not set correctly.

Remove the enabled values, and check readOnlyApnFields directly to fix.

Fix: 330566517
Test: manual with carrier config KEY_READ_ONLY_APN_FIELDS_STRING_ARRAY
Test: unit test
Change-Id: Ifd6d4a0d9a96a900c9d124c9e357562e84bbc6c7
2024-03-21 16:32:38 +08:00
Xinyi Mao
4e56242991 Merge "Update percentage symbol from western sign to arabic sign" into main 2024-03-21 06:41:15 +00:00
mxyyiyi
8ce68baa24 Update percentage symbol from western sign to arabic sign
(https://screenshot.googleplex.com/ALgEzpDKG4BMBB4)

Fix: 322855881
Test: manual
Change-Id: I1335996814a1b80006481f52201a107144497859
2024-03-21 12:09:55 +08:00
Edgar Wang
26a5c73dc7 Listen Developer option enable state
- When developer option disabled, any page in Developer option
  should be closed.

Bug: 293894425
Test: manual

Change-Id: I392b122e885118770be1af2b51c0c7ef92279e1b
2024-03-21 04:08:08 +00:00
Treehugger Robot
cc8c5c8600 Merge "Fix concurrent issue" into main 2024-03-21 03:35:00 +00:00
Daniel Norman
88feeec3c1 Merge "Remove usages of bugfix flag cleanup_accessibility_warning_dialog." into main 2024-03-20 17:49:34 +00:00
josephpv
6a3bd88078 Add message in dialog shown on choosing separate private space lock
Change to add message in the dialog shown on selecting to choose a new
profile lock for private space.

screenshot : go/ss/ASkBCFJuCzp7dkf.png

Bug: 330218365
Test: Manual. Diaog shown as per UX mock
Change-Id: I17f4d7ebf515dc7c95fcae7a5ec5edeb9918ded3
2024-03-20 17:28:45 +00:00
Joseph Vincent
e6a759303c Merge "Update strings in private space hide when locked settings page" into main 2024-03-20 17:28:21 +00:00
Fiona Campbell
9c50f2c61d Merge "Ensure only either RBC or even dimmer can be on" into main 2024-03-20 16:08:54 +00:00
Fiona Campbell
9a71b86c42 Ensure only either RBC or even dimmer can be on
Not Both

Even dimmer is the successor to RBC, so we shouldn't enable both
simultaneously, they are not compatible

Bug: 179428400
Test: manual, atest DisplayServiceTests
Change-Id: I18d5a9c7418b8141afd4b67d121a96cb50ba5274
2024-03-20 11:07:16 +00:00
tomhsu
55899976e9 Fix concurrent issue
- Add a thread lock

Fix: 286495550
Test: make pass
Change-Id: I72877551bda18cf93734d270770a0bd53bab465b
2024-03-20 08:29:43 +00:00
Andy Wickham
cc10abe1c2 Merge "Allows for system navigation settings to be added dynamically." into main 2024-03-20 03:00:10 +00:00
Daniel Norman
8ce099c2cd Remove usages of bugfix flag cleanup_accessibility_warning_dialog.
Flag has been in Trunkfood for over a month.

Includes one mechanical refactor to move a method from a now-removed
file into a private method in the class that uses it: createDisableDialog

(This flag guarded a preliminary cleanup and minor bug fix for
b/303511250, but the actual feature for b/303511250 is tracked in a
different flag 'skip_accessibility_warning_dialog_for_trusted_services')

Bug: 303511250
Test: existing tests in Presubmit (no change to behavior)
Change-Id: Iccf439adb2806e988310f503fb3891a6bd022054
2024-03-19 23:05:07 +00:00
Manish Singh
b41979a012 Merge "Don't show private accounts when locked" into main 2024-03-19 18:09:25 +00:00
josephpv
4cebe66d71 Update strings in private space hide when locked settings page
Recording link:
b/330221666#comment2
screenshot :
go/ss/Ja2xyxVm4wjDF6P.png
go/ss/56Kujyq6WfBLtHG.png
go/ss/9wvcJTXnarizyU5.png

Bug: 330221666
Bug: 330327338

Test: Manual. Verified strings are updated as per UX mocks
Change-Id: I053bd2558503eb58fcf196eb0988bfa007583704
2024-03-19 17:05:28 +00:00
Treehugger Robot
937693d538 Merge "Add new Cellular Network Security page" into main 2024-03-19 16:15:32 +00:00
Joseph Vincent
6ec3ac32a5 Merge "To skip face enrollment for PS unlock setup based on intent extra" into main 2024-03-19 13:28:10 +00:00
josephpv
f9bc323633 To skip face enrollment for PS unlock setup based on intent extra
For private space lock setup as part of both PS setup and separate lock
form private space settings we need to show only traditional unlock
factors and Fingerprint but not show Face enrolment even on devices
where Face unlock is supported by hardware.
Once LSKF is enrolled it should be followed by Fingerprint enrollment
flow and after that Face enrollment should not be shown and exit lock
setup flow.

Currently for separate profile lock setup ACTION_SET_NEW_PASSWORD intent
is used in private space setup.
With this intent the options of LSKF+fingerprint+Face is shown in
devices supporting both fingerprint and face hardware. After the LSKF
ennrollment BiometricEnrollActivity is started which continues with
fingerprint and Face enrollment.

With this change we are passing an extra along with the intent to enroll
fingerprint only. Based on the intent extra value if set even if hardware
support exists the lock enrollment for the profile will support only
LSKF and fingerprint enrollment but not start Face enrollment.

User will still have the option to enroll Face from the dedicated settings
entrypoint in private space settings.

Recording link : b/323839067#comment4

Bug: 323839067
Test: Manual, verified option for face enrollment is shown or not shown
based on the intent extra. When extra is not passed the behaviour will be
default.

Change-Id: Idf92084052e02df9ca89f288c618796750e563e6
2024-03-19 11:58:08 +00:00
Chaohui Wang
732636cbd5 Merge "Refactor AutomaticDataSwitchingPreference" into main 2024-03-19 11:14:25 +00:00