Commit Graph

25193 Commits

Author SHA1 Message Date
Fan Zhang
261d4f521b Merge "Add fancy animation for IA fragment" 2019-02-22 22:51:18 +00:00
Doris Ling
52f2b4fb27 Merge "Disable App data usage preference if there's no usage data." 2019-02-22 22:17:38 +00:00
Lei Yu
2fd46b7079 Merge "Update advanced bt header" 2019-02-22 21:50:04 +00:00
Pavel Grafov
01bfdcc597 Merge "Don't hide "Add user" when disallowed by admin" 2019-02-22 20:11:43 +00:00
Doris Ling
55a189a640 Disable App data usage preference if there's no usage data.
- when there is no usage data at all, launching the app data usage page
will show something blank, as there's no cycle with available usage
data. Check the overall historic usage to make sure that there's
usage data to be shown, otherwise, disable the preference.

Fixes: 123518021
Test: make RunSettingsRoboTests
Change-Id: I2d19f85e8618c41e2c31b9e4259cdc522f69e371
2019-02-22 11:18:29 -08:00
Fan Zhang
22e403f01e Merge "Update subTitle of NotificationChannelSlice" 2019-02-22 17:49:00 +00:00
TreeHugger Robot
bbd57dfb10 Merge "Set the timeout limit of contextual card loading back to 1 second." 2019-02-22 17:30:39 +00:00
Fan Zhang
44815d1a52 Merge "Fix some test cases fail" 2019-02-22 17:22:51 +00:00
TreeHugger Robot
68e32cbd04 Merge "Add onPreferenceClickListener to dnd schedule" 2019-02-22 16:30:34 +00:00
TreeHugger Robot
38d1640da5 Merge "Fix testcase error" 2019-02-22 11:28:23 +00:00
Yi-Ling Chuang
362311766f Set the timeout limit of contextual card loading back to 1 second.
After making card pre binding work in paralell, the loading time is now
less than 1 second.

Bug: 124366297
Test: robotests
Change-Id: Ib5daececa73ed9e9cf62a18971c6042d9150aad7
2019-02-22 18:12:07 +08:00
tmfang
8b414c9a14 Fix some test cases fail
Test: robo test
Fixes: 125599276
Change-Id: I4b1b15f69ff3021e4330bed49ac95ea871b98e92
2019-02-22 17:37:04 +08:00
Raff Tsai
3055df31a0 Fix testcase error
Fixes: 125604750
Test: make RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.wifi.AddNetworkFragmentTest"
Change-Id: Id787c5715d0f60491f123fab58e2b0ca3093bcd9
2019-02-22 16:59:37 +08:00
Mill Chen
23452861e5 Add fancy animation for IA fragment
The animation of IA fragment is very choppy on expanding or collapsing
conditionals. So adding LayoutTransition for IA fragment makes the
animation more smoothly.

Bug: 123536786
Bug: 123537499
Test: visual, robotests
Change-Id: I731db8556ac392c9ab98bd292498ccf6c87295fb
2019-02-22 16:56:14 +08:00
TreeHugger Robot
2a2b31c4ef Merge "[Passpointv2] Implement Wi-Fi detail page for saved network" 2019-02-22 08:06:25 +00:00
cosmohsieh
b5dac6bacf [Passpointv2] Implement Wi-Fi detail page for saved network
Will show a Wi-Fi status detail page when clicking a saved network.

Bug: 124695272
Test: Manual
Change-Id: I5f32cf63f369593ad49c93ceeaace9fb623888e5
2019-02-22 13:35:19 +08:00
TreeHugger Robot
1a7de076ca Merge "Add progress bar for Wi-Fi DPP handshaking" 2019-02-22 05:31:33 +00:00
Arc Wang
8826721803 Add progress bar for Wi-Fi DPP handshaking
Bug: 124127483
Test: manual test
Change-Id: I1c3da5bab98da57ca8cf10509f339e99b01ebdbf
2019-02-22 11:42:08 +08:00
TreeHugger Robot
a1dce5d6d5 Merge "Remove all reference to settings_side_margin." 2019-02-22 03:28:20 +00:00
Youming Ye
da9e92c4f7 Merge "Fix issue that the wifi calling text cannot be customized based on sim" 2019-02-22 01:55:59 +00:00
Michele Berionne
7ebfdd9c06 Merge "Add checks on multisim capabilities." 2019-02-21 21:24:44 +00:00
jackqdyulei
5cb4d251ee Update advanced bt header
1. Add callback to listen to device update
2. Add charging support for bt battery icon
3. When disconnected, only show main icon

Follow CL will update battery icon to show exclamation when it is
low.

Bug: 124455912
Test: RunSettingsRoboTests
Change-Id: I03fb3bf4c4b77711e14b1f2f53733771b525fe4b
2019-02-21 12:43:29 -08:00
Hongming Jin
41fb813614 Merge "Migrate emegency default app to role manager." 2019-02-21 20:37:53 +00:00
TreeHugger Robot
c37171f1eb Merge "Dynamically return the uri of WifiSlice." 2019-02-21 18:55:40 +00:00
Doris Ling
c5a1b4f666 Remove all reference to settings_side_margin.
- since the overlay of the value for bigger screen has been removed,
the side margin is now always 0dp. Remove this dimen value and all
reference to it.

Fixes: 124526984
Test: rebuild and visual
Change-Id: I68ff42513a379111042cab9b34594822544e246e
2019-02-21 10:18:00 -08:00
TreeHugger Robot
f66882f1e1 Merge "developer-options: avoid oem-unlock preference controller crash" 2019-02-21 18:00:23 +00:00
TreeHugger Robot
85fc06d03f Merge "Fix Talkback issue" 2019-02-21 17:23:35 +00:00
Beverly
77f05fe793 Add onPreferenceClickListener to dnd schedule
- Talkback says the preference is clickable

Test: manual
Bug: 124827588
Change-Id: I1cf5ae564eb0a7ddfa60e1c307f00194f9338a13
2019-02-21 11:15:08 -05:00
bohu
9bc365febd developer-options: avoid oem-unlock preference controller crash
If there is no FEATURE_TELEPHONY_CARRIERLOCK.

BUG: 123583878

Test: lunch sdk_phone_x86-eng
make -j
emulator
the Settings->System->Developer options should not crash

Test:
make RunSettingsRoboTests ROBOTEST_FILTER=OemUnlockPreferenceControllerTest
should all pass (12 tests: 11 existing and 1 new)

Change-Id: I18c08c1ff1a7860616b0081ede4eb19dcfa8814b
2019-02-21 08:08:12 -08:00
Yanting Yang
e7f2ec1360 Update subTitle of NotificationChannelSlice
If there are <=3 channels, should not have the "Tap to manage all".

Fixes: 124461104
Test: visual, robotests
Change-Id: Iebb957c65b8ca53f4c5d482041837338b7b3bbf2
2019-02-21 23:57:55 +08:00
Pavel Grafov
19cf0b4580 Don't hide "Add user" when disallowed by admin
Bug: 125226170
Test: atest tests/robotests/src/com/android/settings/users/UserSettingsTest.java
Test: manual, with TestDPC
Change-Id: I347fae04030e04325a5ee5c634f782e554ece263
2019-02-21 13:38:53 +00:00
TreeHugger Robot
7e1bd433e6 Merge changes from topic "homepage_latency"
* changes:
  Make slices precheck executes in parallel.
  Use a better way to bind slice for slice precheck.
2019-02-21 10:10:39 +00:00
Raff Tsai
2d91873dcb Fix Talkback issue
It is a button without text. Talkback will focus on this item.
We hide this item from layout so that Talkback will not find it.

Fixes: 125065965
Test: Test it with Talkback
Change-Id: I143c02b13b9f888fa5837dd2c472cf69bd00edcf
2019-02-21 09:46:39 +00:00
Yi-Ling Chuang
45ee7c2aac Dynamically return the uri of WifiSlice.
WifiSlice is used by both ContextualWifiSlice and WifiSlice itself.
In contextual homepage, we provide contextual_wifi slice for the
homepage. So in our slice pre-check, contextual_wifi slice will gets
pinned and bound. But when it comes to the state where wifi is on but
not connected, it actually returns wifi slice instead of contextual_wifi
slice, which will hit slice not pinned exception as wifi slice never
gets pinned.

Thus, we have to dynamically return the corresponding uri to  avoid this.

Fixes: 124627340
Test: robotests
Change-Id: I54ba255871628bb8eb814442f990a5d1149461e0
2019-02-21 16:14:29 +08:00
Yanting Yang
6934475d69 Merge "Fix preferences ordering issue in AccountSyncSettings" 2019-02-21 07:36:53 +00:00
Yi-Ling Chuang
dde76e6d5c Make slices precheck executes in parallel.
Slice binding takes up sometime which may cause latency.
Thus, making it run in parallel instead of sequentially to improve the
performance and avoid hitting the timeout problem.

Bug: 124366297
Fixes: 123668403
Test: robotests, unit tests
Change-Id: I5d9fa4605f59e2acef65aadf6fce85df36d8fff1
2019-02-21 15:24:28 +08:00
Yi-Ling Chuang
daa8ff36cc Use a better way to bind slice for slice precheck.
Calling Slice.bindSlice() directly will cause the exception stating that
slices are not pinned, which sometimes leads to crash. Hence, change the
way we bind slices which handles pinSlice() for us before onBindSlice().

Bug: 120552892
Test: robotests, unit tests
Change-Id: I3e65c6b79876dbee5db6f19387bc6b675f734161
2019-02-21 14:18:01 +08:00
TreeHugger Robot
5f321d7921 Merge "Replace deprecated KeyguardManager API with new BiometricPrompt one" 2019-02-21 03:05:02 +00:00
TreeHugger Robot
40617d20ac Merge "Add event logging for changing SmsDefaultDialog window attr" 2019-02-20 22:56:29 +00:00
TreeHugger Robot
1de49122d3 Merge "Use MATCH_ALL to query available browsers." 2019-02-20 21:31:21 +00:00
Fan Zhang
f6dc3af6df Add event logging for changing SmsDefaultDialog window attr
Bug: 120484087
Test: manual
Change-Id: Ia5b00f79f2e54cb40377abb18c1ac07891020ae2
2019-02-20 13:13:41 -08:00
Hongming Jin
6c728dc924 Migrate emegency default app to role manager.
Bug: 123293861
Test: atest DefaultEmergencyPickerTest
Change-Id: I7bd9e2655b22a35fc3268091d38c6770911d4046
2019-02-20 11:46:02 -08:00
Hai Zhang
7bd98d2519 Use MATCH_ALL to query available browsers.
Browser intent resolution has been special for a long time, and we
need to pass MATCH_ALL to get all the candidates, then do manual
filtering later.

Bug: 116216651
Test: manual
Change-Id: I5e9b7b907005f73b7c54c3253c872d85ef7c4863
2019-02-20 11:28:01 -08:00
TreeHugger Robot
8febd82f34 Merge "Add pref for notification swipe direction" 2019-02-20 19:06:42 +00:00
Julia Reynolds
14289bd356 Add pref for notification swipe direction
And move that and other settings under an 'advanced' category

Test: robotests
Fixes: 124099692
Change-Id: I89df276a8bc1cd56ce8530239ca02b2c4b43fa65
2019-02-20 10:36:50 -05:00
Yanting Yang
11a157a8e7 Fix preferences ordering issue in AccountSyncSettings
In Pie, it's alphabetical ordering in Accounts > Account sync detail page.
But Q doesn't follow it, intend to keep the same behavior.

Fixes:124382857
Test: visual, robotests
Change-Id: I593a4cc919daa0018d3874d84978e876198aae23
2019-02-20 21:18:28 +08:00
Arc Wang
ffae615d25 Fix camera stop forever after error occurs while sharing or adding network
Restart QrCamera decoding task after Wi-Fi DPP handshake fail or
Wi-Fi connection fail.

Bug: 124128539
Test: manual test
Change-Id: I6d916ed1378f50038089e2c1e2870915ca083d68
2019-02-20 14:29:08 +08:00
Arc Wang
7bdcadbe72 Handle different error codes in DPP
Show error message for corresponding Wi-Fi DPP error code. And

1. To update error message only from each fragment,
   remove some callbacks which calls from fragment to activity.
2. After clicking 'Share Wi-Fi' button, hide it before Wi-Fi DPP handshake completes.
3. Show 'Done' button for some error codes.
4. Use ViewModel to call startEasyConnectAsConfiguratorInitiator and
   startEasyConnectAsEnrolleeInitiator because a lifecycle object
   does not receive an Executor callback after configurator change.
5. In WifiDppQrCodeScannerFragment, show an error message for 10s instead of 2s
   since new added error messages may carry more information.
6. Show a different error message for enrollee handshake success but Wi-Fi
   connection fail case.
7. stop camera when scanned a Wi-Fi DPP QR code for enrollee.
8. In QR code scanner fragment, support to show error message after
    configuration change.

Bug: 124247872
Bug: 124491247
Test: manual test
      atest WifiQrCodeTest
      atest WifiDppConfiguratorActivityTest
      atest WifiDppEnrolleeActivityTest
      atest WifiDppQrCodeGeneratorFragmentTest
      atest WifiDppQrCodeScannerFragmentTest
      atest WifiNetworkListFragmentTest
      atest WifiDppChooseSavedWifiNetworkFragmentTest

Change-Id: Id130215e9ddafac8bc4c68238deda48ce99b4255
2019-02-20 14:28:52 +08:00
Arc Wang
79a3ae860e Replace deprecated KeyguardManager API with new BiometricPrompt one
Use BiometricPrompt to replace KeyguardManager#createConfirmDeviceCredentialIntent

Bug: 124249685
Test: manual test
Change-Id: I7a05b8f1b08471cf9f09b3d4ce1bedc7cd529e72
2019-02-20 14:17:45 +08:00
TreeHugger Robot
0acd013f03 Merge "Add developer menu to enable/disable ART verifier." 2019-02-20 03:55:40 +00:00