Commit Graph

29741 Commits

Author SHA1 Message Date
Zhen Zhang
258fb7f672 Make tether preference controllers extend BasePreferenceController
These controllers extended AbstractPreferenceController, which is not
quite compatible with some of the present framework. Especially for
indexable keys of settings search.

TetherEnabler and AllInOneTetherSettings are refactored based on the
change. Tests are updated.

Bug: 147272749
Test: CodeInspectionTest and other tests of classes touched by this CL
Change-Id: Ic3ad13e735d133c0959a0a309319a6fd5165b015
2020-02-05 10:18:57 -08:00
menghanli
c240b27862 Add back "Tapping Stop will stop x" dialog while turning off an accessibility service
Bug: 146539308
Test: make RunSettingsRoboTests2
Change-Id: Ic572f9245db016bd79a272030f97004a21f4b672
2020-02-03 19:17:34 +08:00
Menghan Li
a85a145686 Merge "Fix "Cannot get activity context when service off"." 2020-02-03 09:28:15 +00:00
TreeHugger Robot
6068d12752 Merge "Use feature flag to show/hide AllInOneTetherSettings" 2020-02-03 08:32:29 +00:00
menghanli
8e881181a8 Fix "Cannot get activity context when service off".
1. Unify getPrefContext() usage in Accessibility Settings
2. Correct the dialog emuns order

Test: local test
Change-Id: Idc51f7b15b5813bbae7b32e1ae3c7f00c71cea50
2020-02-03 07:13:31 +00:00
Zhen Zhang
36c3446b28 Merge "Add a feature flag for the new tether settings UI" 2020-02-03 06:44:43 +00:00
menghanli
b82931520f Support accessibility shortcut secondary action (11/n)
Refactor current shortcut design to base fragment and provide
protected function to customize the legacy design,
magnification or no need shortcut app.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests2

Change-Id: I51c951ef8f819a1940ddfe33b009b40ed5ec0530
2020-02-02 10:51:44 +08:00
TreeHugger Robot
d4f33b1e26 Merge "Mainline remove hide api SubscriptionInfo.getCardString" 2020-02-01 06:45:02 +00:00
TreeHugger Robot
23331b2983 Merge "[Wi-Fi] Hide Connect button when passpoint is expired" 2020-02-01 05:27:04 +00:00
TreeHugger Robot
b7f0145c02 Merge changes I8194476e,I9d21909f
* changes:
  [Wi-Fi] Fix some test failures of com.android.settings.wifi.details2
  [Wi-Fi] Remove passpoint methods in WifiEntryShell
2020-02-01 05:24:09 +00:00
Bonian Chen
86272795f3 Merge "[Settings] Avoid non-owner from crash mobile data settings" 2020-02-01 05:00:03 +00:00
Automerger Merge Worker
de86f9c950 Merge "Tidy up libcore.timezone APIs" am: 45834d96a8 am: 35ffa52384 am: 798407a441
Change-Id: I486df8f44bcd67baf933853145f7617cf6b0e891
2020-01-31 16:32:04 +00:00
Automerger Merge Worker
798407a441 Merge "Tidy up libcore.timezone APIs" am: 45834d96a8 am: 35ffa52384
Change-Id: I87f4ca96ef592c459c96f12906a86889367bfe7e
2020-01-31 16:30:07 +00:00
Automerger Merge Worker
35ffa52384 Merge "Tidy up libcore.timezone APIs" am: 45834d96a8
Change-Id: I3222600a7fa1d37b7d8e16115ec067d415f2bdba
2020-01-31 16:29:11 +00:00
Automerger Merge Worker
bcf3f23b67 Merge "access system resources with android.R package" am: ef77c1d67f am: 49cd1555f3
Change-Id: Idcb5041776ed072a871bc037df143450c92d458c
2020-01-31 16:00:33 +00:00
Automerger Merge Worker
49cd1555f3 Merge "access system resources with android.R package" am: ef77c1d67f
Change-Id: I663f693f498e3566deb37f6175fc0bb214264118
2020-01-31 15:55:52 +00:00
SongFerngWang
5189dc3860 Mainline remove hide api SubscriptionInfo.getCardString
Bug: 147128878
Test: build pass
Change-Id: Idb44af6a01626013339f5ca05486dd11112a5867
2020-01-31 18:48:09 +08:00
Bonian Chen
7bf8fb5c85 Merge "[Settings] Replace ImsDirectQuery" 2020-01-31 09:56:56 +00:00
Alex Johnston
5c39238a5a Merge "Prevent location for the work profile from being enabled" 2020-01-31 09:49:17 +00:00
Arc Wang
e16ce3dcea [Wi-Fi] Hide Connect button when passpoint is expired
If the passpoint is connected and expired, we still show
Disconnect button.

Bug: 148317997
Test: manual
      Observe a connected passpoint and see Disconnect button.
      Observe a disconnect passpoint and see no Connect button.
      Should add test case in WifiDetailPreferenceController2Test
      at later CL.

Change-Id: I07f22804eccce80c44ac709412cb594faaf6ccb0
2020-01-31 17:06:29 +08:00
Arc Wang
f591fe0901 [Wi-Fi] Remove passpoint methods in WifiEntryShell
Bug: 143326832
Test: build
Change-Id: I9d21909f18df03d50f69447c3f2014b75ecd2d8b
2020-01-31 15:19:35 +08:00
TreeHugger Robot
56743aa5cc Merge "Migrate to SettingsStatsLog from StatsLog" 2020-01-31 01:11:41 +00:00
TreeHugger Robot
1608f9da49 Merge "Support metered choice for subscription WifiEntries" 2020-01-31 00:23:13 +00:00
Zhen Zhang
d2a7f9ae79 Use feature flag to show/hide AllInOneTetherSettings
This partially reverts commit 0ccc849de7
which added a config value. Instead, we will use feature flag to switch
between the fragments.

This CL also adds a postfix to keys in all_tether_prefs to
de-duplicate with keys in tether_prefs and wifi_tether_settings.

Bug: 148182953
Change-Id: I92832c786473990065a965409072e4117a7e75a8
Fix: 148618984
Test: make RunSettingsRoboTests
Test: make RunSettingsRoboTests ROBOTEST_FILTER=CodeInspectionTest
2020-01-30 16:01:42 -08:00
David Su
eb21975e89 Merge "Rename removeDoubleQuotes to sanitizeSsid" 2020-01-30 18:16:57 +00:00
David Su
5676b6fe36 Merge "Migrate WifiManager.isDualModeSupported() to isStaApConcurrencySupported()" 2020-01-30 17:42:41 +00:00
Quang Luong
a59bc1c0f5 Support metered choice for subscription WifiEntries
Add a check for subscription WifiEntries so they can also set their
metered overrides.

Test: manual
Bug: 70983952
Change-Id: Icd45f416e47251f914aa803d5190566746fb9779
2020-01-30 09:07:48 -08:00
Alex Johnston
1867db33c9 Prevent location for the work profile from being enabled
* Previously the user could still enable location for the work profile
  even after enabling DISALLOW_CONFIG_LOCATION. This was because the
  LocationForWorkPreferenceController checked whether the base restriction
  was set and whether the restriction was enforced by the admin in the
  same condition.
* This was fixed by giving the admin precedence and moving the check for
  the base restriction to only be checked if the admin has not enforced
  the DISALLOW_CONFIG_LOCATION or DISALLOW_SHARING_LOCATION restriction.

Bug: 147758996
Test: Manual testing with Settings and TestDPC
      atest com.android.settings.location.LocationForWorkPreferenceControllerTest

Change-Id: Ide341f2dab4f59f26ffa0c929ba412d61b6ebf1a
2020-01-30 16:59:33 +00:00
Bonian Chen
eb2b87aa39 [Settings] Avoid non-owner from crash mobile data settings
Some instance not been initialized under non-owner user mode.

Bug: 146562321
Test: manual
Change-Id: I4f8ac955754cbd8692727a1d0adf283ef3ff512c
2020-01-31 00:33:11 +08:00
Neil Fuller
45834d96a8 Merge "Tidy up libcore.timezone APIs" 2020-01-30 11:25:35 +00:00
govenliu
634044dc0b [Wi-Fi] [a11y] In Wi-Fi data usage page, Talkback should also announce the Progress bar percentage instead of "Progress bar" only.
Add conent description for talkback to announce, if the progress bar is 50%, then before modification is "Progress bar", and after modification is "50% Progress bar".

Bug: 146811265
Test: Add following unit test case to test if content description is correct or not:
      createPref_progressBarShouldSetPercentageContentDescription().

Change-Id: I71483df8e12f08c4c8c96ab3964666bf97872a83
2020-01-30 07:18:18 +00:00
Arc Wang
4ee5d1819b Merge "Remove WifiEntry.METERED_CHOICE_UNKNOWN" 2020-01-30 06:32:07 +00:00
Quang Luong
94f10ec0b5 Remove WifiEntry.METERED_CHOICE_UNKNOWN
METERED_CHOICE_UNKNOWN should represent the default value of the metered
choice, but this can be represented by METERED_CHOICE_AUTO already.

Bug: 70983952
Test: build
Change-Id: I3bea9217e197ff88eba606be9235b1db65158425
2020-01-29 16:45:06 -08:00
Raff Tsai
fcd9f1a870 Fix volume panel crashing
slider position is smaller than min value causes the exception.
Fixed by limit the position within min and max value.

Fixes: 148270968
Test: manual
Change-Id: I3d162f6d2f1035b81b1b2eb915b488084e7ea36e
2020-01-30 08:24:47 +08:00
David Su
8ab62a8750 Migrate WifiManager.isDualModeSupported() to isStaApConcurrencySupported()
isDualModeSupported is being removed, replace it
with isStaApConcurrencySupported.

Bug: 144925765
Test: compiles
Change-Id: Ia3a0417a154ea401579a039113e96ba4578ffd80
2020-01-29 14:46:33 -08:00
TreeHugger Robot
1767201534 Merge "Use MasterSwitchPref vs subclass" 2020-01-29 19:20:48 +00:00
TreeHugger Robot
ecb62abbc5 Merge "Add setting to hide silent notifs in status bar" 2020-01-29 18:35:16 +00:00
Sooraj Sasindran
ef77c1d67f Merge "access system resources with android.R package" 2020-01-29 17:34:53 +00:00
Julia Reynolds
82433b0239 Use MasterSwitchPref vs subclass
MasterSwitchPrefence changed in an incompatible way, but also
added functionality so we no longer need to subclass it.

Test: atest
Fixes: 146503141
Change-Id: I2441c8c265370c138ced13741aa5afd5c2088917
2020-01-29 17:11:45 +00:00
Automerger Merge Worker
9aa72472a5 Merge "[DO NOT MERGE] Update CellIdentityGsm Constructor" am: 0c2cd2a94d am: 1edf46fc74
Change-Id: I8e4241bce34b6a2099c116cbe76d6e84896d6331
2020-01-29 16:37:28 +00:00
Julia Reynolds
86c0007e1d Add setting to hide silent notifs in status bar
Test: atest
Bug: 148444551
Change-Id: If7171ed36984b76552f3f795f0b4652dce5daad3
2020-01-29 11:25:18 -05:00
Sarah Chin
1edf46fc74 Merge "[DO NOT MERGE] Update CellIdentityGsm Constructor"
am: 0c2cd2a94d

Change-Id: Ibce639f419d021ba6abe507381644eb3fd8249ef
2020-01-29 08:14:34 -08:00
Bonian Chen
c820dc191c [Settings] Replace ImsDirectQuery
This is a code refactor to replace
1. Legacy ImsQuery into ImsExecutorQuery
2. ImsDirectQuery into ImsQuery
3. SystemTty into Tty

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceControllerTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingPreferenceControllerTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSettingsForSubTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSliceHelperTest
Change-Id: I239021c60fff47de307ac7e21641bee56e205861
2020-01-30 00:11:55 +08:00
Sarah Chin
0c2cd2a94d Merge "[DO NOT MERGE] Update CellIdentityGsm Constructor" 2020-01-29 15:56:09 +00:00
Alex Johnston
8b15d86c5a Merge "Update string displayed on work pin/password challenge" 2020-01-29 14:10:40 +00:00
Winson Chung
37a67a483e Merge "Updating developer winscope tile to start sysui tracing" 2020-01-29 05:04:49 +00:00
Zhen Zhang
0141e6f943 Add a feature flag for the new tether settings UI
The flag is mirrored from FeatureFlagUtils in framework/base
Bug: 148182953
Bug: 148220934
Test: Build successfully.
Change-Id: Ifada88cb585b3f618b7e2f59f1ceff007ae8eacd
2020-01-28 15:15:42 -08:00
Alex Johnston
28c6b577ad Update string displayed on work pin/password challenge
* The incorrect string was being displayed when the user
  was asked to enter their pin/password.
* Updated the string to include **work** instead of
  **device** when entering a work pin/password.

Bug: 148211118
Test: Manual testing
Change-Id: I2239a5011dec62fd63574bbf75495548ddd0d907
2020-01-28 17:49:33 +00:00
Neil Fuller
7b54a31132 Tidy up libcore.timezone APIs
Tidy up the libcore.timezone APIs to make them as close as possible to
android.timezone. In future, these classes should be repackages to be
the actual android.timezone classes, so the APIs need to be in sync.

Bug: 148086409
Test: treehugger
Change-Id: I8d0521467bb3c3c8741ce98f50cde0ee8c1bec1a
2020-01-28 15:08:31 +00:00
Sooraj Sasindran
a30bdaaaf8 access system resources with android.R package
Bug: 143289541
Test: make
Merged-In: Idc10955639bce7b8e579c50af78056389d44d492
Change-Id: Idc10955639bce7b8e579c50af78056389d44d492
2020-01-27 22:17:28 -08:00