Commit Graph

314 Commits

Author SHA1 Message Date
TreeHugger Robot
a1dce5d6d5 Merge "Remove all reference to settings_side_margin." 2019-02-22 03:28:20 +00:00
Doris Ling
c5a1b4f666 Remove all reference to settings_side_margin.
- since the overlay of the value for bigger screen has been removed,
the side margin is now always 0dp. Remove this dimen value and all
reference to it.

Fixes: 124526984
Test: rebuild and visual
Change-Id: I68ff42513a379111042cab9b34594822544e246e
2019-02-21 10:18:00 -08:00
Sunny Shao
c8786408e5 Enlarge the touch area of the avatar
Use the padding to enlarge touch area.

Fixes: 124797089
Test: manual
Change-Id: Ief2296f015f021ca4d7e4cba0ca14ac0eada972b
2019-02-21 16:45:39 +08:00
Fan Zhang
07207c0113 Misc ui tweaks.
- Update conditional card layout
  - move action button from right side to bottom.
  - Get rid of the forking between small/big screens.

- Update a few icons

Fixes: 121189136
Fixes: 124315564
Fixes: 124316920

Test: visual
Change-Id: I205d9995a2d7ed06ad9d32f3cea74f2840a28aed
2019-02-12 16:14:21 -08:00
Edward Savage-Jones
5042c9b41b Add master audio balance setting
This adds an audio balance slider to accessibility allowing the end
user to adjust the audio balance between left and right channels.

Test: Change Balance through Settings, play audio
Bug: 28390736
Change-Id: I70f22d222ea310fd33ebe4f3fb054f44f69d2548
2019-02-05 14:26:28 -08:00
Arc Wang
4ab826ac5b Set Wi-Fi DPP fragment icons.
1. set fragment icon for WifiDppChooseSavedWifiNetworkFragment
2. set fragment icon of success for WifiDppAddDeviceFragment

All Wi-Fi DPP fragment icons are VectorDrawable of instinct size
24dp draw on a 48dp canvas. Except for ic_devices_check_circle_green,
it's a LayerDrawable of different size. I dynamically change ImageView
layout width & height between these 2 different kind of drawable.

Bug: 122982132
Test: manual test
Change-Id: Idab8cd8b0798363e447da00dc6bc68a86498b8be
2019-01-29 17:02:14 +08:00
Yanting Yang
9a87eab259 Merge "Improve UX of Deferred Setup" 2019-01-29 07:51:33 +00:00
Yanting Yang
2784da75a2 Improve UX of Deferred Setup
Change-Id: I3d0735ef1196b04abaef454529664a8daea53967
Bug: 120485678
Test: visual, robotests
2019-01-29 07:43:46 +00:00
Yi-Ling Chuang
2ef995b712 Adjust contextual card dismissal view
- Increase the height of button clicking area
- Decrease top margin and some other corresponding adjustments.

Bug: 113783548
Test: visual
Change-Id: Iba1cea6c82036ebb9fe2e08d32eb663e0ad026ac
2019-01-19 11:43:25 +08:00
TreeHugger Robot
d24f404b70 Merge "Visual update: adjust button padding in conditional card" 2019-01-16 07:56:33 +00:00
TreeHugger Robot
7109b9a68b Merge "Update the layout of contextual card dismissal view" 2019-01-16 07:34:49 +00:00
Mill Chen
121768d723 Visual update: adjust button padding in conditional card
Decrease the padding of the button in the conditional full card.

Bug: 113451905
Test: visual
Change-Id: Ic625504e06b8764b9b737a8d5b613423e4d8d27e
2019-01-16 14:42:32 +08:00
Yi-Ling Chuang
84acc5666d Update the layout of contextual card dismissal view
- Swap the two buttons.
- Alter margins.

Bug: 113783548
Test: visual
Change-Id: I1d491d0bccb206331789e031310f0adfd34671fd
2019-01-14 16:42:01 +08:00
jackqdyulei
35209f6e6c Update height of SliceView
So it can display 6 items at most, not 4 items

Bug: 120803703
Test: Manual
Change-Id: Id34398903d0f81bebee3e02c024d21ad2e68578f
2019-01-11 10:55:59 -08:00
TreeHugger Robot
8a98decbd6 Merge "Refine the conditionals layout" 2019-01-07 16:52:27 +00:00
Mill Chen
2ac24f2ceb Refine the conditionals layout
1. Add the minWidth for a button in the condition full tile and adjust
the start margin of the button.
2. Decrease the start padding of the conditional header layout.

Bug: 113451905
Test: visual
Change-Id: I4864730b35154c0bd4b0a806815aa912b19ca3d7
2019-01-07 21:34:07 +08:00
tmfang
5c1d3e96a1 Make filter appear floating in ManagerApplication.
Using new layouts to make filter component appear
floating on top of the page.

The layouts contain the NestedScollView and AppBarLayout.
The NestedScrollView was given a layout_behavior which
defined the behavior of AppBarLayout.

Test: visual
Change-Id: Ia76104f80c6b60ac6c8f5937ebface8e9a7238b5
Fixes: 121148001
2019-01-07 19:23:35 +08:00
Yi-Ling Chuang
1f320fa346 Centerize contents of contextual cards and remove white space.
Decrease the minHeight of the two buttons in the dismissal view and have
the contents centered.

Change-Id: I806e8ccae88e693dc222a13940597fd33684ee70
Fixes: 120086509
Test: visual
2019-01-04 15:43:58 +08:00
TreeHugger Robot
f07a7bd684 Merge changes from topic "status_bar_80%_white"
* changes:
  Fine tune items position of homepage
  Make status bar become 80% of white in homepage.
2019-01-04 03:08:44 +00:00
tmfang
191bde1b75 Fine tune items position of homepage
Since homepage becomes full screen and status bar is 80% of white,
some homepage items are overlappd by status bar.

Enlarge padding size and add a space for fixing this problem.

Test: visual
Bug: 116346521

Change-Id: I7bc9e9a08adafb8fe38bedf527199e4db4424fd0
2019-01-03 11:52:20 +08:00
Johnson Lu
cb36eb394c Adjust landscape layout of QR code scanner/generator
Bug: 118794858
Test: RunSettingsRoboTests
Change-Id: Ifaef7c5fe02abbb377efeb0ab345976ab439aeb0
2019-01-03 11:41:26 +08:00
Mill Chen
637c874dff Merge "Fix distortion in conditional cards" 2018-12-28 03:35:21 +00:00
Johnson Lu
7414543635 Show QR Code picture for WiFi sharing
Bug: 118794858
Test: make RunSettingsRoboTests
Change-Id: Ic5a489840ba59262eb444f02d77bf066889a4220
2018-12-27 09:55:44 +08:00
Mill Chen
d973776112 Fix distortion in conditional cards
When setting device font and display size to largest, conditional cards
will get distorted. The fix is to add a different layout for screens that
have smaller than 360dp available width.

Change-Id: I8b61c9d8a568e79045e4a490aa387c801a57f9a7
Fixes: 119505249
Test: visual
2018-12-26 14:39:22 +08:00
Mill Chen
3f3823e456 Add new layout for Slice half card
- Extract dismissal view as a layout xml and reuse it in half card
- fixed minor naming convention

This new layout is composed of custom views and the purpose is to
show slice in half width form in contextual homepage.

Bug: 119655434
Test: visual
Change-Id: I224d8bc1b7f95f969f6a134a316bd80b4cd013ee
2018-12-20 14:32:22 +08:00
Sunny Shao
2f7f14f08c Added FloatingAppBarScrollingViewBehavior
-Added FloatingAppBarScrollingViewBehavior for search bar. It can be scolling,
 transparent and overlapped the scrolling child view.
-Exchanged the position of NestedScrollView and AppBarLayout in
 settings_homepage_container.xml.
-Set the app bar height.

Change-Id: I6ef4c9001a1f893292fcbc825a0a9f2069b7286b
Fixes: 118886724
Test: robotest
2018-12-06 14:24:49 +08:00
Sunny Shao
86b1c7d0b1 Refined the Search Bar layout
Removed the background color of the search bar.
Set the background of the AppBarLayout as transparent.
Set the app bar height.

Bug: 118886724
Test: manual review
Change-Id: I7faedc693ce61d5a5237e8a72909b77b56268a4c
2018-11-30 12:00:15 -08:00
Fan Zhang
a60652a973 Visual update: remove card elevation for homepage cards.
- Replace CardView with MaterialCardView
- Add strokeColor and strokeWidth to MaterialCardView
- Set cardElevation to 0dp.

And remove a few unused layout, clean up color lint whitelist.

Test: rebuild, visual
Change-Id: I34a4b9a985cb85c212e123b8af5353d8c548923a
2018-11-28 10:42:00 -08:00
Yanting Yang
87cd0f9db8 Modify margin for overall contextual settings home screen
- Excluding margin of search bar, it will be modified by b/118886724.

Bug: 119639077
Test: robotests, visual
Change-Id: I6776d69842c952de04864b5439ca2cd2fbdd5e09
2018-11-26 17:43:46 +08:00
Mill Chen
4b19fecd50 Update new UI for conditional collapsibility
- Add a footer view with collapsing button and this view will be
appended to the last position of condition cards when condition
cards are expanded.
- Add a header view with expanding button when condition cards
are in collapsed state.

Bug: 119593268, 113451905
Test: rebuild, visual
Change-Id: I82c20641d1542e45383da48106f8fedea06a68ed
2018-11-20 23:20:53 +00:00
Kevin Chyn
7d7ffda9ae Simplify preview logic
Fixes: 112564159
Bug: 119786386

Test: manual
Change-Id: I42fba5a53248193fbe820e710a863ec9de728d4a
2018-11-19 18:34:31 -08:00
Stanley Wang
1ed36d8b23 Layout updated for file size text wrapping with largest display
This solution will change the portrait layout for
large, larger, and largest of Display size.

Change-Id: Ib00b23553c34c1e69cb84e446f409c38ea7544ef
Fixes: 69074097
Test: manual
2018-11-14 16:31:53 +08:00
TreeHugger Robot
74f3077729 Merge "Update new UI layout of Conditional cards" 2018-11-09 17:49:25 +00:00
Mill Chen
c89c4ceabb Update new UI layout of Conditional cards
Bug: 113451905
Test: visual
Change-Id: I20ec526bd2b5b2679cd7e0e4388a2a897fe6a24d
2018-11-09 11:21:58 +08:00
Fan Zhang
2a98c843e8 Loading suggestions via legacy SuggestionService sometimes
When legacy_suggestion flag is turned on, load Suggestions from
SuggestionService instead of contextual homepage, because contextual
homepage infrastructure might not be availble on all devices.

Bug: 118842099
Test: robo
Change-Id: I91710c005e11be5a9b3dd39ceff670106e7f80c3
2018-11-07 11:55:09 -08:00
Mill Chen
0ca7130403 Update new UI of conditional cards
- Add half-width and full-width layouts for conditional cards
- Keep origin strings of conditional cards, that could make conditional
cards truncate its title and summary in half-width card.
- Add default value of isHalfWidth to each condition controller.

Bug: 113451905
Test: robotests, visual
Change-Id: Ib0055f32c4ab9e73c0e0a57c6b0ef586d52942e0
2018-11-07 16:06:31 +08:00
TreeHugger Robot
1d436aade2 Merge changes from topic "refactor-security-location"
* changes:
  Rename title of Security page
  Move LocationSettings to top level page.
2018-11-06 02:01:17 +00:00
Sunny Shao
201f1f6146 Merge "Added the icon displayed on no account in search bar" 2018-11-05 05:31:03 +00:00
tmfang
54a5d37190 Move LocationSettings to top level page.
- Create some location icons for different scenario.
- Remove Location in Security page.
- Move Location Setting to top level page.

Test: robotest, visual
Bug: 116628158
Change-Id: I3f57ef49a396877bfbeaefea7dc4f4051e0ccc65
2018-11-05 11:24:41 +08:00
Sunny Shao
6dc1cc2a77 Added the icon displayed on no account in search bar
Mofidied the search_bar layout and added this icon in the right side of the search_bar.
Added the hasAccount api in AvatarViewMixin and display this icon when there is no any account in device.
Added the test case of the AvatarViewMixin.

Bug: 117509285
Test: robotest
Change-Id: I6ceaa457af4fb20acd0211ca840df5b530c47e0f
2018-11-05 10:52:11 +08:00
Emily Chuang
7d1fc0d3db Update the layout of contextual cards.
Fixes: 118849830
Test: visual
Change-Id: Ia3f7f155271a22f4f6214fad861475442c23c2f6
2018-11-05 10:49:19 +08:00
Emily Chuang
4b08270d8c Remove "See more" from wifi/bluetooth slices
- Also set the height of SliceView back to wrap_content as the space our
content needs can be satisfied with MODE_LARGE.

Change-Id: Ibaa514ac9c022c2723d99e5104f8d5ec63f14661
Fixes: 118763869
Test: robotests, visual
2018-11-01 12:32:51 -07:00
Fan Zhang
2fa9b7b652 Fix slice card layout so show more button works correctly
Change padding top/bottom to margin, so the sliceview can use the full
288dp height (4 rows + see more button).

Side effect is that ripple doesn't fill the entire cardview. But it
never did anyway.

Change-Id: Ie57187fbe2b8caa2cf9d0dc31d7678eee07085f4
Fixes: 118398695
Test: visual
2018-10-31 11:09:28 +08:00
Fan Zhang
c82b7494ea Delete some unused resources
Test: rebuild
Change-Id: Idbb639605bf92888d71a07a62553e2d943494635
2018-10-26 10:02:04 -07:00
Fan Zhang
5e6e6a14f2 Move all contextual card related classes.
... from homepage to contextualcards.

Test: rebuild
Change-Id: Id7889566ce1e7257eb699d963ae996906fdb58ff
2018-10-26 10:02:04 -07:00
Raff Tsai
db55661271 Change homepage layout
- merge PersonalSettingsFragment and TopLevelSettings together

Bug: 118224579
Test: manual
Change-Id: Ieee50a22babb25023e2a1767793e220862a38363
2018-10-23 19:37:19 +08:00
Emily Chuang
8d9b265620 Give SliceView a height to support four rows and show more button.
The default height of sliceView with MODE_LARGE is 240dp which supports
three rows(including the header) above "show more" button. Since WIFI
and Connected devices use cases require four rows + show more button, we
need to expand the height to fulfill it.

Bug: 117868297
Test: visual
Change-Id: I13b29c3f859d1c117c680432f9a6ad8e71c6acf5
2018-10-17 20:50:20 +08:00
Philip P. Moltmann
92f3a8afe3 Use renamed restricted icon size config-value
Bug: 116797641
Test: Built
Change-Id: I913d7fece475e19969f9d932c0992242308bb02f
2018-10-11 12:42:26 -07:00
felkachang
a6cec47326 Change reset page to be SUW style
The factory reset page and the reset confirmation page is too old to
follow the style of Setup Wizard design. To change the layout and apply
the style for textviews and header.

Bug: 73738836
Test: make -j SettingsRoboTests RunSettingsRoboTests
Change-Id: I1ee3d09e1ef9cac8e25c60a566363d4f7d537eeb
2018-10-03 11:45:49 -07:00
Fan Zhang
394ea1cde5 Merge "Move AppPreference to settingslib, and change imports." 2018-09-25 19:15:19 +00:00