- remove the old sound settings xml
- merge Sound Dashboard metadata into SiybdSettingsActivity instead
and remove Sound Dashboard.
- remove OtherSoundSettings
Bug: 35764802
Test: make RunSettingsRoboTests
Change-Id: I25bb94b375cfe0277b3c961e4bee6fec9a14fb98
- Add a method in VisibilityLoggerMixin to log visible event using
LogMaker, which allows logging additional FIELD_CONTEXT field.
- In Utils.startFragment, add current page's metricsCategory as an extra
to next page.
- In next page's onResume(), extract the previous page's metricsCategory
and send it to VisibilityLoggerMixin.visible()
- Update all caller with additional paramters
Change-Id: I8e1f2597fa465b7d3aa16fa1d21c052a3219694a
Fix: 35359289
Test: RunSettingsRoboTests
- Update title to "Do not disturb preferences"
- Add summary text to reflect the priority only allows preferences
- Refactor the summary handling in ZenModeSettings so that the
controller can get the summary text
Fix: 34975939
Test: make RunSettingsRoboTests
Change-Id: I3ca1dc43fe1d943735a9f625e66c89708a18300a
Increase the tile limit in Settings->Sound so that Ringtones is not
hidden inside the Advances options.
Fix: 35318739
Test: Visual
Change-Id: I08db7b79127226bb6ef8ce8f147e5a90f5939d79
- Use static summary for most items
- Move summary for user setting to user&account setting
Bug: 34975053
Test: RunSettingsRoboTests
Change-Id: I9bf87267778dc5933f97f5d3b9ae0f4f0b8da1a8
Commit 2953f31b61 skipped
RunSettingsRoboTests. The tests started failing because
WorkSoundPreferenceController calls UserManager.isUserUnlocked(int) now
which is not implemented in robolectric.
Fixed by adding a wrapper method to AudioHelper.
Fix: 34819603
Test: make RunSettingsRoboTests
Change-Id: Ia79cc4def9442706752f7e7b9a895ffa8150fd9d
Dead users can't hear, nor see, ringtones. Let's wake them up and give
them a good shake first.
Until then, show a nice friendly "work profile isn't available" message.
Or depending on locale something confusing, egregious, and mismatched
like "work profile isn't available" instead.
Fix: 34735015
Bug: 34734809
Test: make RunSettingsRoboTests && make Settings && adb install -r $OUT/system/priv-app/Settings/Settings.apk && then reboot the device to see what happens
Change-Id: I86e61a7f3f654d7f38f04c43227a31e2f288e18f
Use the centralized registry to look up category key instead.
Bug: 32936784
Test: make RunSettingsRoboTests -j40
Change-Id: I0b8c72d70f93e4b5c58871ac90de41f69ad15653
Use the new callbacks for managed profile being added/removed to update
visibility of work sound settings
Test: make RunSettingsRoboTests
Bug: 31701003
Change-Id: I3167e52102bcf9f18a58e85dd9c3117691c6ad3f
- In new IA, Other Sound no longer is a separate preference screen, but
individual preferences are put directly under SoundSettings.
- Add controllers for each other sounds preference.
- Remove Cast settings from Soundsettings in new IA.
Change-Id: I75d771674ffabfecbd66079bc86844b2ff098b71
Fix: 33944294
Test: make RunSettingsRoboTests
When suppressor exists for the sound effect, the sound summary
should show "muted by ...", not the "Ring volume at ..."
Bug: 31461022
Test: make -j40 RunSettingsRoboTests
Change-Id: I5d6895a7a330c993aac40bdca3bb1c79f8b7fbfe
And remove unneeded app level settings.
Change-Id: I88f506b0704195181d1748a3135f8ee0f39b774f
Test: manual for now. will add tests when have real mocks for the pages
- final round of refactoring SoundSettings to use preference
controller.
- add work sound controller to control all the work profile sound
settings.
Change-Id: Ifa9f9c1f717ca292576f077311fe284325e12651
Fixes: 32276590
Test: make RunSettingsRoboTests
- second round of refactoring SoundSettings to use preference
controller.
- add controller for Emergency broadcast, Vibrate when ring, Phone
ringtone, Alarm ringtone, and Notification ringtone.
Bug: 32276590
Test: make RunSettingsRoboTests
Change-Id: Iaff48ecb27bf156a5c8995de20ce7a440b094cdb
- initial round of refactoring SoundSettings to use DashboardFragment.
- add controller for Cast, Do not disturb, Alarm volume, Media volume,
Ring volume and Notification volume.
Bug: 32276590
Test: make RunSettingsRoboTests
Change-Id: I5c02a344bff5117bfce93d7ccac650fccc82d2b0