Commit Graph

56164 Commits

Author SHA1 Message Date
Jacky Wang
1c78d48489 Merge "Fix memory leak on Accessibility screen" into main 2025-01-09 15:25:19 -08:00
Wenyu Zhang
e031b30d1d a11y: Initialize slider position with cursor area size setting
When the preference loads, initialize the slider position using the
cursor area size value from settings.

In addition, match slider seekbar range and the cursor area size range.

Change-Id: Ib6a8ca8463358a3e2de5ae6be8afd5113a5826be
Bug: b/383901288
Test: ToggleAutoclickCursorAreaSizeControllerTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
2025-01-09 22:31:17 +00:00
Ajay Dudani
b44f5c6b34 Settings: TTS: Use a more accurate SliderPreference for speech rate and pitch
Bug: 349667984
Flag: EXEMPT bugfix
Change-Id: Ie1c214221e2e0e683139cf5f21a44745f4701f05
2025-01-09 14:25:16 -08:00
Julia Reynolds
41896428ea Layout improvements for notification pages
Changes for upcoming theming changes in Settings:
- replacing some margins with padding
- merging some (switch pref + info pref) combos into a single preference.
I flagged the one that was already launched, but changed the other directly
- added some section headers (unflagged)
- moved all app wide notification settings to a single section (unflagged)
- changed two plain text prefs into TopIntroPreference, the dedicated pref
type for that sort of UI
- fixed some UI issues with 'Show more categories' appearing too often
- removed a duplicate notifcation channel label (unflagged)
- replaced a button layout preference with ButtonPreference (unflagged)

Test: manual review with is_expressive_design_enabled on and off
Test: atest com.android.settings.notification.app
Flag: EXEMPT this feature is not using aconfig for flagging
Bug: 349652992
Change-Id: I2acd7b2eb9dbcf6929143bfde99cd67163f1f95d
2025-01-09 17:07:53 -05:00
Lucas Silva
ee449cebde Merge "Add posturing dream trigger to Settings UI" into main 2025-01-09 12:55:19 -08:00
Kasia Krejszeff
3cf730f6b6 Merge "Fix an assumption that UserHandle.myUserId() always returns the main user." into main 2025-01-09 12:37:05 -08:00
Kasia Krejszeff
ad6fbc96cd Fix an assumption that UserHandle.myUserId() always returns the main
user.

In some cases, e.g. in Private Space Storage Info fragment it returns
the Private profile id and this was leading to a crash, see b/378471943.

Bug: 378471943
Test: Manually and presubmit
Flag: com.android.settings.flags.utils_return_user_handle_for_current_user_id
Change-Id: I5f7bedc66ebcac8b0ae265b7189dd1821edb3cd7
2025-01-09 18:25:24 +00:00
Dipankar Bhardwaj
09e4fd3b62 Use RELEASE_OR_PREVIEW_DISPLAY to show android build version
Change-Id: I6746ce0f501756775a3e2f769a36b572845c1ab7
Test: n/a
Bug: 385863350
Flag: EXEMPT minor fix
2025-01-09 10:21:12 -08:00
Treehugger Robot
d7e1504cfe Merge "Allow system services to be optional" into main 2025-01-09 09:13:33 -08:00
YuhanYang
d5e44a0795 Add mouse scrollling speed slide bar
Bug: 383555305
Bug: 84795606
Test: Local DUT with aconfig flags enabled, verified slide bar
      appears and can be updated.
      Verified adjusting slide bar affects scrolling speed.
Flag: com.android.hardware.input.mouse_scrolling_acceleration
Change-Id: Ia66f88ce855ab152a161ef3f81ab643415fad517
2025-01-09 16:32:22 +00:00
arunvoddu
4da20d24c4 [Satellite] Satellite UX changes in SIM settings as per new UX design.
Bug: 382707562
Flag: EXEMPT UX bug fix
Test: Verified UX on device
Change-Id: I9e600d8f1fd6c273329e05a74079f1e03c209c65
2025-01-09 15:32:20 +00:00
Harry Cutts
9b3f964f18 BasePreferenceController: add some nullability annotations
One fixes a NullAway warning reported on change
I32ba2b6b8c05c1379b4d921350050979b1866805, and the other is just nice
to have.

Bug: 245989146
Change-Id: I8a7ffbddf865bab317fdabf5110262bb0626c529
Test: TreeHugger
Flag: EXEMPT unable to flag this kind of change
2025-01-09 14:30:59 +00:00
Jacky Wang
2ac3cdfb22 Fix memory leak on Accessibility screen
The root cause is that androidx.preference.Preference does not implement
equals and hashCode methods, but it is used as Map key (see bug comment2
for more details). Given that Preference.getParent() can find the
category, we can simplify the data structure from Map to List.

Bug: 388696327
Flag: EXEMPT bugfix
Test: Resume/Pause Accessibility screen 100 times
Change-Id: Ib70acbf2147048730f8a4e8fd66731f9efdadecf
2025-01-09 18:57:38 +08:00
Treehugger Robot
b7e1cc472e Merge "[Catalyst] Add back Wi-Fi switch metrics" into main 2025-01-09 02:45:29 -08:00
Harry Cutts
adfb3a489d Merge changes I32ba2b6b,I3f473d28,I717eb2a2 into main
* changes:
  Touchpad: add @NonNull annotations to controller constructors
  Touchpad: mark MetricsFeatureProviders final
  Touchpad: fix some NullAway warnings
2025-01-09 02:38:54 -08:00
Ze Li
18279890cc [Temp bonding] Block users to select temp bond device as primary device for call in "Call audio" under "Audio sharing" page
Test: com.android.settings.connecteddevice.audiosharing.AudioSharingCallAudioPreferenceControllerTest
Bug: 362859132
Flag: com.android.settingslib.flags.enable_temporary_bond_devices_ui
Change-Id: Ideafaa1b113a40219830b8ba2b5156b599481eee
2025-01-09 18:23:54 +08:00
Daniel Huang
723d2fff40 Merge "Remove ACTION_NUMBERING_SYSTEM_SETTINGS relevant implementation" into main 2025-01-09 01:41:54 -08:00
Shaowei Shen
43c9d7d26e Merge "[Physical Keyboard] Fix L18n test bugs" into main 2025-01-09 01:39:02 -08:00
Menghan Li
291e62ffd1 Merge changes from topic "SurveyFeatureProvider_isSurveyAvailable" into main
* changes:
  Add HaTS entrypoint for Magnification page
  Add controller for magnification feedback preference
  Add a new API: checkSurveyAvailable
2025-01-09 01:14:45 -08:00
Chaohui Wang
7e8e683e60 Migrate to AppStorageRepository
Bug: 321861088
Flag: EXEMPT bug fix
Test: manual - on All apps and App info
Test: atest AppStorageSizesControllerTest
Test: atest AppStoragePreferenceTest
Change-Id: I3143de720493cb09854621b115d07e76bebf6699
2025-01-09 16:56:42 +08:00
Angela Wang
44e13bf11e Merge "Remove flag enable_hearing_aid_preset_control" into main 2025-01-09 00:04:19 -08:00
danielwbhuang
63992ac908 Remove ACTION_NUMBERING_SYSTEM_SETTINGS relevant implementation
Bug: 381038747
Flag: android.provider.system_regional_preferences_api_enabled
Test: use test app to try intent ACTION, atest
Change-Id: If40e570a2e1087125ac32db30d7b683af3a0d0b6
2025-01-09 15:05:31 +08:00
Menghan Li
e218280902 Add HaTS entrypoint for Magnification page
This entry point allows users to access and adjust Magnification
settings for low vision accessibility. Visibility is controlled by
the aconfig flag and SurveyFeatureProvider#isSurveyAvailable.

NO_IFTTT=Revisit preference_list scope

Bug: 380346799
Test: atest ToggleScreenMagnificationPreferenceFragmentTest
Flag: com.android.server.accessibility.enable_low_vision_hats
Change-Id: I81a55487734fe7b139391a6c95834c7313e54d7a
2025-01-09 07:01:21 +00:00
Menghan Li
3f67747684 Add controller for magnification feedback preference
The controller's logic determines the visibility of this preference
based on the availability of surveys, as reported by
SurveyFeatureProvider.isSurveyAvailable.

Bug: 380346799
Test: atest MagnificationFeedbackPreferenceControllerTest
Flag: com.android.server.accessibility.enable_low_vision_hats
Change-Id: I7fe7aa4418a6be38e9e7af7efc76a9a25266198b
2025-01-09 07:00:09 +00:00
Joy Babafemi
3dea70443b Merge "Update owners for account settings" into main am: aaa8896873 am: 70d953b3da
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3441082

Change-Id: I75ed20ba97d788ba787f3064b5c4e8a822388aca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-08 20:34:28 -08:00
Treehugger Robot
66f86d4612 Merge "[Catalyst] Move PreferenceCoordinate" into main 2025-01-08 20:34:18 -08:00
Joy Babafemi
aaa8896873 Merge "Update owners for account settings" into main 2025-01-08 19:35:45 -08:00
Shawn Lin
10265d8d90 Merge "[Biometric Onboarding & Edu] Update Set up Face Unlock page" into main 2025-01-08 19:29:47 -08:00
Ajay Dudani
12497cbb42 Merge "Update OWNER of tts settings" into main 2025-01-08 17:03:31 -08:00
Jacky Wang
a29db33025 [Catalyst] Move PreferenceCoordinate
Bug: 388420844
Flag: EXEMPT refactor
Test: N/A
Change-Id: Ieafb4ce4757e0935ffb276127a3e562a6ff0bcfa
2025-01-09 07:57:59 +08:00
Matthew DeVore
926f75ec5f Merge "Use topology listener to detect changes" into main 2025-01-08 15:44:06 -08:00
Alyssa Ketpreechasawat
81d25980f8 Merge "Remove ModuleInfo#isHidden Usage from the source code." into main 2025-01-08 15:33:42 -08:00
Ajay Dudani
072d44c001 Update OWNER of tts settings
Update OWNER of tts settings to current on-device speech team members.

Flag: EXEMPT only changing OWNERS
Change-Id: I0ba6afb3e4a195deef05745ef6997886416446bc
2025-01-08 15:29:41 -08:00
Joy Babafemi
9c13abdc68 Update owners for account settings
Change-Id: I2fe4cf47509aa806e1dfbbd23cea690805c980fa
2025-01-08 14:50:11 -08:00
Lucas Silva
9c4dba40b4 Add posturing dream trigger to Settings UI
Adds ability for users to select posturing as the trigger for when
dreams will be shown.

Bug: 383208131
Test: locally - mp droid and verified posturing option is displayed in
Settings
Flag: android.service.dreams.allow_dream_when_postured

Change-Id: Iae69b9e488181b1e2af7474e3e9879a92b51274c
2025-01-08 14:59:58 -05:00
Weng Su
cd9af665c3 [Catalyst] Add back Wi-Fi switch metrics
- The original Wi-Fi switch metrics is recorded by WifiEnabler.

- Since the design of Catalyst removes WifiEnabler, the metrics needs to be added to Catalyst preference.

NO_IFTTT=Catalyst only

Bug: 388547699
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiSwitchPreferenceTest

Change-Id: I8819e8f660784b8b04c7958b65f4792b5d4d0919
2025-01-09 03:37:06 +08:00
Treehugger Robot
be203ea17d Merge "Fix NPE on modes page when schedule has no days" into main 2025-01-08 11:17:09 -08:00
Matías Hernández
5098df9b6c Fix NPE on modes page when schedule has no days
Fixes: 387088843
Test: atest ZenModeTriggerUpdatePreferenceControllerTest
Flag: EXEMPT trivial bugfix
Change-Id: I3b845784f5923521d7f3f6cae9d6d27a21f55361
2025-01-08 19:14:40 +01:00
Jiaming Liu
f4be314b3f Merge "[AE] Enable AE Split for phones supporting display port" into main 2025-01-08 09:20:08 -08:00
Jason Chang
3e1e855094 Update Fingerprint adding button with expressive design
Flag: EXEMPT flag by System prop (SettingsThemeHelper.isExpressiveTheme)

Bug: 388260897

Test: build and manually check the UI and its behaviors.
Change-Id: I1c6d859f78305d0f14476e12a5bb4e1b0258d06e
2025-01-08 17:03:14 +00:00
Harry Cutts
fb0b459cf0 Touchpad: add @NonNull annotations to controller constructors
...and to some of the preference controller base classes, too, since I
had to work those out anyway.

Bug: 245989146
Test: m
Flag: EXEMPT unable to flag this kind of change
Change-Id: I32ba2b6b8c05c1379b4d921350050979b1866805
2025-01-08 16:36:43 +00:00
Harry Cutts
0e4edf9527 Touchpad: mark MetricsFeatureProviders final
(Fixing some warnings from Android Studio)

Bug: 245989146
Test: m
Flag: EXEMPT refactor
Change-Id: I3f473d281e8a22d108a52e56e6e53ca056e4a829
2025-01-08 16:33:35 +00:00
Harry Cutts
cc30711d59 Merge "Touchpad: replace references to "trackpad" with "touchpad"" into main 2025-01-08 07:39:51 -08:00
Treehugger Robot
e28dcd02bc Merge "Fix sim status details not updated after sim hotswap" into main am: e9bc1949a9 am: 066efe6c55
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3431560

Change-Id: I176e94c9f718a14d5e4593471fadb1b1ef186dba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-08 04:21:29 -08:00
Harry Cutts
ae3e005ff9 Touchpad: fix some NullAway warnings
Change I930e9fc85e09e03da3513e5f8443077fa8ea91b0 triggered some NullAway
warnings that are unrelated to the change, but some are trivial to fix,
for example by replacing member variables with local ones.

At the same time, add some `@NonNull` annotations to overriding methods
on Android Studio's recommendation.

Test: check touchpad gesture tutorial and pointer speed settings work
Test: $ atest SettingsRoboTests:com.android.settings.inputmethod
Bug: 245989146
Flag: EXEMPT refactor
Change-Id: I717eb2a2d68a46dce8ebaa95bef1183d09380f51
2025-01-08 11:53:14 +00:00
Harry Cutts
509fd17515 Touchpad: replace references to "trackpad" with "touchpad"
When we first added the touchpad settings we hadn't settled on whether
to refer to them as "touchpads" or "trackpads" yet. We've since settled
on "touchpad", but that's left us with some Settings code referring to
one and some to the other. Let's standardize on "touchpad" since that's
consistent with user-facing strings and the rest of the input codebase.

This CL doesn't change string identifiers, as I believe that would cause
them to get different Translation Console IDs and thus be retranslated.

Bug: 245989146
Test: m
Test: check strings and icons are still displayed correctly in the
      touchpad settings and tutorial, and that settings toggles and the
      tutorial still work
Test: atest SettingsRoboTests
Flag: EXEMPT refactor
Change-Id: I930e9fc85e09e03da3513e5f8443077fa8ea91b0
2025-01-08 11:52:45 +00:00
Treehugger Robot
e9bc1949a9 Merge "Fix sim status details not updated after sim hotswap" into main 2025-01-08 03:15:55 -08:00
Treehugger Robot
32f8eff7a9 Merge "Add notifications toggle to Settings > Date and Time" into main 2025-01-08 02:01:34 -08:00
Haijie Hong
fd4c6d100d Merge "Add audio sharing entrypoint in device details" into main 2025-01-07 22:32:29 -08:00
YK Hung
172245983c Merge "Create UI lifecycle aware executor factory." into main 2025-01-07 21:45:18 -08:00