Commit Graph

24 Commits

Author SHA1 Message Date
SongFerngWang
f2a8008ae3 The list does not follow the UX dialog design doc in alert dialog.
Please refer the comment#1 at bug and there are change below
- the divider is 4dp
- the item's radius is different in the list.

Bug: 216233391
Test: manual test: check the UI
make RunSettingsRoboTests ROBOTEST_FILTER=SimListDialogFragmentTest (PASS)

Change-Id: I758d60202fcf477aeb49014e60b949e7ad08c082
2022-01-26 12:49:59 +08:00
SongFerngWang
4780be49f3 [MEP] renew the sim confirm dialog UI
- renew the sim confirm dialog

Bug: 199902896
Test: build pass and local UI test
Change-Id: Icb00b3fc32066e21d22cbeca1fdf50e5d7dbef20
2021-12-21 12:51:16 +08:00
TreeHugger Robot
d1586a2619 Merge "Consistent color between status bar and app bar" into sc-dev am: 3d5fd19e9f am: 6fbeadac34
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15076803

Change-Id: Iec6c485a15e053678d96b41c35ff8094289fc936
2021-06-28 04:47:38 +00:00
TreeHugger Robot
3d5fd19e9f Merge "Consistent color between status bar and app bar" into sc-dev 2021-06-28 04:25:09 +00:00
Tsung-Mao Fang
df00a3bc69 Consistent color between status bar and app bar
In Android S, we add the transparent color to navigation bar
and status bar for consistent color between status bar and
app bar. So, we should add this change for oveall setting
theme since most pages should apply new app bar now.

Thus, we don't need to override the subsetting style for different
activities one by one.

Homepage doesn't have new Android S tool bar, so we shouldn't adopt it.

Test: Try to launch all the pages as many as possible.
Fix: 190797935
Change-Id: Ic4083de5477371f1d0eea2d66f020e4469fa3f86
2021-06-23 17:53:59 +08:00
TreeHugger Robot
5b2b10ecbf Merge "Clean up unused code" into sc-dev am: 3928e0b4f1 am: f59cd6f8b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15029689

Change-Id: I75b84d720a30f124d89b8872e0cd5fcc50ced997
2021-06-21 11:54:39 +00:00
Tsung-Mao Fang
53f94d3289 Clean up unused code
Test: Rebuilt apk
Fix: 190142194
Change-Id: I16d18c538b612c6049f561bb524ee1e056255714
2021-06-21 18:17:27 +08:00
TreeHugger Robot
fe0d0b76d4 Merge "Fix dialog color problem in night mode." into sc-dev am: f026108de5 am: 352b6e1b24
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15008367

Change-Id: Icbd87ac0a3e0c2db497938d21746ddc0c9e5655e
2021-06-17 11:21:20 +00:00
Tsung-Mao Fang
1e8a907d91 Fix dialog color problem in night mode.
Assign the suface light and dark color for Dialog.

Test: Rebuilt apk, and see color works well on wifi dialog.
Fix: 190142194
Change-Id: I43d010c70e22639a29a571bfadb4351f41e1a240
2021-06-17 10:08:32 +00:00
Treehugger Robot
e7e7c33de7 Merge "Settings: use framework text colors for SwitchBar" am: b09a17bc9e am: b34692c2b5
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1708559

Change-Id: I15cef0a16d846f68ea331b550b1926caa952d8f6
2021-06-16 15:29:29 +00:00
Tsung-Mao Fang
732ff78505 Fix GAR color constrast issue on dialog
Based on the UX definition, we use color surface
for the background color of dialog.

Test: A11y scanner tool confirms again and no color constrast issue.
Fix: 187396623
Change-Id: I2f89193f7c584e8fc468aa035ce329c22e2ad7f1
2021-05-27 23:00:14 +08:00
Timi Rautamäki
c640453297 Settings: use framework text colors for SwitchBar
* Use framework text colors for SwitchBar also on
   dark mode to properly display disabled colors.
 * Before the patch, a disabled SwitchBar on dark
   mode would look same as an enabled one.

Test: open ´Notifications´-menu of a system app,
      verify SwitchBar text is gray in dark mode.
Signed-off-by: Timi Rautamäki <timi.rautamaki@gmail.com>
Change-Id: Ia2fc5eb3f614d899cb5e519c235f1ea9b86a1527
2021-05-15 11:02:36 +02:00
Jason Chiu
f43f2f80a7 Apply the new search bar background color
Fixes: 182092326
Test: visual, robotest
Change-Id: I95bd73323e8407716261367461f008bafa35e78b
2021-05-06 17:35:40 +08:00
Mill Chen
23d3eccfa3 Integrate new version of MDC-android release
1. Add color fill on scroll
2. Add collapsing title fading

Bug: 183496853
Test: visual verified
Change-Id: I5d0ae0b10d9f0eae843cd4935c075488a960d3f3
2021-04-06 13:23:05 +08:00
Mill Chen
14cfd2f2ca Add CollapsingToolbarLayout for sub settings
Settings app is planning to make toolbar collapsible for next
Android release. This CL is to add a new layout for
CollapsingToolbarLayout in the Settings app and to update the theme
correspondly. This feature will be controlled by feature flag, which
makes Settings app compacitible with the existing layout.

Bug: 174451673
Test: manul test and visual verification
1) Enable the feature and open Settings app
2) Navigate to each sub page and check if toolbar is collapsible

Change-Id: Ibef524bbaa7ae3f0a43db7e40e599f42e009437f
2021-01-11 18:30:20 +08:00
Raff Tsai
41435ad0ea Fix layout issues
- Add fontFamily in TextAppearance.Tab to support change font style
- Overwrite TabTheme to change overscroll effect color

Fixes: 147134904
Fixes: 147136108
Test: manual
Change-Id: Iebb2dea658a295f3c6ece900680f42fb3a772cb4
2020-01-13 03:07:00 +08:00
Salvador Martinez
a2e7357535 Change switch text color to black in dark mode
It seems that the attribute values that are used to text color
in the switch bar are selectors which leads to problems because
they include an alpha value when the switch is "off". This would
cause the contrast between the text and the background to be too
low for GAR. This CL simply makes it so that in dark mode the text
for the switch bar is just true black since adjusting the
attributes would have wide scale implications for all UIs using
device default themes.

Test: visual inspection
Bug: 132755745
Change-Id: I309db82e9bf020fb654e0b93f6ec84380ae092f7
2019-05-30 14:16:52 -07:00
Mill Chen
9862f8632a Revert "Revert "Update dialog background color for dark theme""
This reverts commit 77259dc9bb.

Previously, using a general attribute to change the background color
for alert dialog. It will also impact on the background of other
components. To fix it, we used another attribute to change the dialog
background.

Bug: 132753127
Bug: 132623454
Bug: 129993336
Test: visual
Change-Id: I09091ee8fb45238d0ea94760f2fca5c206299a57
2019-05-17 16:26:10 +08:00
Mill Chen
77259dc9bb Revert "Update dialog background color for dark theme"
This reverts commit 3032628269.

Reason for revert: This will also change the background color of other components within dialog.

Bug: 132753127
Bug: 132623454
Test: visual
Change-Id: I59d4731e84e8d516a01780c4cce70b2d86208098
2019-05-16 14:46:52 +08:00
Mill Chen
3032628269 Update dialog background color for dark theme
Fixes: 129993336
Test: visual
Change-Id: Ie04be80e9b2987a8f7af1c7ecd1628474486bcd0
2019-04-24 15:40:34 +08:00
Salvador Martinez
20e09e05cc Change master switch background and icon color
This CL updates the master switch background color and also
reverts the color of the icons on the left hand side from color
accent back to the default.

Test: visual inspection
Bug: 128769294
Change-Id: Ie02f5049ad628c8564638264e690825f404ee3d9
2019-03-28 13:45:49 -07:00
Salvador Martinez
2bb9930866 Update Settings components for dark theme
This CL updates the colors and properties of various themes and
widgets to make them follow dark theme UI. Specifically, it changes
the color accent and uses true black for the background.

Test: manual inspection
Bug: 111397440
Change-Id: I15214a4c5d4864244af856312d2fc3e3a7e7ce36
2018-11-15 15:00:44 -08:00
Fan Zhang
3181e1aceb Change search fab to search bar.
- Remove search fab from layout xml
- Change RelativeLayout to CoordinatorLayout so we can use prebuilt
  scrolling behavior
- Minor update to theme so search bar background works in dark mode for
  the homepage activity.

Change-Id: If7408c12684be65137e04ae3bb4137204c2d77e0
Fixes: 117508596
Test: robotests, visual
2018-10-10 16:29:22 -07:00
Raff Tsai
0a39e43316 Fix Homepage wrong color in dark theme
Change-Id: Id22f8baff0b97c0e7081fb8c68241bc8d0d01a45
Fixes: 113964702
Fixes: 115789360
Test: manual
2018-09-18 07:14:57 +08:00