Please refer the comment#1 at bug and there are change below
- the divider is 4dp
- the item's radius is different in the list.
Bug: 216233391
Test: manual test: check the UI
make RunSettingsRoboTests ROBOTEST_FILTER=SimListDialogFragmentTest (PASS)
Change-Id: I758d60202fcf477aeb49014e60b949e7ad08c082
In Android S, we add the transparent color to navigation bar
and status bar for consistent color between status bar and
app bar. So, we should add this change for oveall setting
theme since most pages should apply new app bar now.
Thus, we don't need to override the subsetting style for different
activities one by one.
Homepage doesn't have new Android S tool bar, so we shouldn't adopt it.
Test: Try to launch all the pages as many as possible.
Fix: 190797935
Change-Id: Ic4083de5477371f1d0eea2d66f020e4469fa3f86
Assign the suface light and dark color for Dialog.
Test: Rebuilt apk, and see color works well on wifi dialog.
Fix: 190142194
Change-Id: I43d010c70e22639a29a571bfadb4351f41e1a240
Based on the UX definition, we use color surface
for the background color of dialog.
Test: A11y scanner tool confirms again and no color constrast issue.
Fix: 187396623
Change-Id: I2f89193f7c584e8fc468aa035ce329c22e2ad7f1
* Use framework text colors for SwitchBar also on
dark mode to properly display disabled colors.
* Before the patch, a disabled SwitchBar on dark
mode would look same as an enabled one.
Test: open ´Notifications´-menu of a system app,
verify SwitchBar text is gray in dark mode.
Signed-off-by: Timi Rautamäki <timi.rautamaki@gmail.com>
Change-Id: Ia2fc5eb3f614d899cb5e519c235f1ea9b86a1527
Settings app is planning to make toolbar collapsible for next
Android release. This CL is to add a new layout for
CollapsingToolbarLayout in the Settings app and to update the theme
correspondly. This feature will be controlled by feature flag, which
makes Settings app compacitible with the existing layout.
Bug: 174451673
Test: manul test and visual verification
1) Enable the feature and open Settings app
2) Navigate to each sub page and check if toolbar is collapsible
Change-Id: Ibef524bbaa7ae3f0a43db7e40e599f42e009437f
- Add fontFamily in TextAppearance.Tab to support change font style
- Overwrite TabTheme to change overscroll effect color
Fixes: 147134904
Fixes: 147136108
Test: manual
Change-Id: Iebb2dea658a295f3c6ece900680f42fb3a772cb4
It seems that the attribute values that are used to text color
in the switch bar are selectors which leads to problems because
they include an alpha value when the switch is "off". This would
cause the contrast between the text and the background to be too
low for GAR. This CL simply makes it so that in dark mode the text
for the switch bar is just true black since adjusting the
attributes would have wide scale implications for all UIs using
device default themes.
Test: visual inspection
Bug: 132755745
Change-Id: I309db82e9bf020fb654e0b93f6ec84380ae092f7
This reverts commit 77259dc9bb.
Previously, using a general attribute to change the background color
for alert dialog. It will also impact on the background of other
components. To fix it, we used another attribute to change the dialog
background.
Bug: 132753127
Bug: 132623454
Bug: 129993336
Test: visual
Change-Id: I09091ee8fb45238d0ea94760f2fca5c206299a57
This reverts commit 3032628269.
Reason for revert: This will also change the background color of other components within dialog.
Bug: 132753127
Bug: 132623454
Test: visual
Change-Id: I59d4731e84e8d516a01780c4cce70b2d86208098
This CL updates the master switch background color and also
reverts the color of the icons on the left hand side from color
accent back to the default.
Test: visual inspection
Bug: 128769294
Change-Id: Ie02f5049ad628c8564638264e690825f404ee3d9
This CL updates the colors and properties of various themes and
widgets to make them follow dark theme UI. Specifically, it changes
the color accent and uses true black for the background.
Test: manual inspection
Bug: 111397440
Change-Id: I15214a4c5d4864244af856312d2fc3e3a7e7ce36
- Remove search fab from layout xml
- Change RelativeLayout to CoordinatorLayout so we can use prebuilt
scrolling behavior
- Minor update to theme so search bar background works in dark mode for
the homepage activity.
Change-Id: If7408c12684be65137e04ae3bb4137204c2d77e0
Fixes: 117508596
Test: robotests, visual