Commit Graph

24697 Commits

Author SHA1 Message Date
Salvador Martinez
0c388c5f4e Merge "Polish some behaviors of the battery saver schedule screen" 2019-01-10 22:58:55 +00:00
TreeHugger Robot
1bbe4241ee Merge "Fix "Play media to" popup close issue when screen rotate" 2019-01-10 19:43:49 +00:00
Salvador Martinez
cd365b6533 Polish some behaviors of the battery saver schedule screen
This CL removes the line that was showing between the radio
buttons and the seek bar. Additionally it makes it so the seekbar
updates continuously as a user moves it and fixes a visual bug
where it would show 5% regardless of what the user had set it to
when exiting then re-entering the screen.

Test: visual
Change-Id: Icdb9cafe2bdda03d94230d1c8538f4c322b050e9
Fixes: 121388626
Fixes: 121211075
2019-01-10 11:25:48 -08:00
James Lu
7ce23b578a Fix "Play media to" popup close issue when screen rotate
- Avoid calling getListPreference() in onDialogClose() everytime.
  Due to exception in onDialogClose(). Move preference declaration into if condition.
- Add test case for crash case.

Bug: 119744621
Test: make -j50 RunSettingsRoboTests ROBOTEST_FILTER=UpdatableListPreferenceDialogFragmentTest
Change-Id: Ia20b8289a5863136ea74e02e32b537f6967474e8
2019-01-10 17:09:46 +08:00
Pasty Chang
c4e447ce71 Merge "Change to show two footer buttons in SUW lockscreen page." 2019-01-10 07:16:02 +00:00
Stanley Wang
eb735f2909 Merge "Implement the Copyable interface to ImeiInfoPreferenceController" 2019-01-10 07:01:33 +00:00
Pasty Chang
43bb34e15c Merge "Rename prefix from suw to sud" 2019-01-10 06:56:20 +00:00
Arc Wang
b5f945994e Merge changes I6abbfc5d,I1ce1b014
* changes:
  Fix Wi-Fi DPP activity crash after configuration change.
  Implement Wi-Fi DPP flow
2019-01-10 06:04:09 +00:00
Sunny Shao
9f08f6c7b5 Merge "Launch view account page when it's available." 2019-01-10 04:55:11 +00:00
Arc Wang
dcf3f2906f Fix Wi-Fi DPP activity crash after configuration change.
Both QR code and Wi-Fi network data may not come from intent.
After configuration change, the null data will crash the activity.

Bug: 120243131
Test: atest WifiDppConfiguratorActivityTest
Change-Id: I6abbfc5d25431789e8ac9f6ee9dfaaef15b2de33
2019-01-10 12:22:56 +08:00
Arc Wang
a7d51370c8 Implement Wi-Fi DPP flow
1. Wi-Fi DPP hanshake fail UI
2. Show Wi-Fi DPP QR code information field on WifiDppAddDeviceFragment if it's available.
3. Click 'Choose Different Network' button will show WifiDppChooseSavedWifiNetworkFragment
4. After QR code scanner scans success, WifiDppConfiguratorActivity caches WifiQrCode instead
   of just a QR code string

Bug: 122429170
Test: manual test
Change-Id: I1ce1b014ff86903b5a7a8f3575cc98eb1079583c
2019-01-10 12:09:58 +08:00
TreeHugger Robot
da947e902e Merge "Add summary for role-based default apps preference." 2019-01-10 04:00:25 +00:00
Stanley Wang
76ab6e9a99 Implement the Copyable interface to ImeiInfoPreferenceController
Copy the IMEI to clipboard for Copyable.

Change-Id: I3e13bfad8158e4cb4f9fda854661341d4c334e46
Fixes: 73769888
Test: manual and robotests
2019-01-10 04:00:20 +00:00
Kevin Chyn
b8a7e95de2 Merge "Persist token across activity lifecycle" 2019-01-10 03:19:42 +00:00
TreeHugger Robot
be555eddcd Merge changes I2d087f34,Ia2b91315
* changes:
  Filter out unimportant battery tips from slice card.
  Revert "Remove battery saver condition."
2019-01-10 02:31:06 +00:00
Arc Wang
7a14f706e1 Merge "Add more Wi-Fi DPP UI features." 2019-01-10 02:07:31 +00:00
Sunny Shao
7aa9fdd75c Launch view account page when it's available.
- Add to launch the new Contextual Landing Page when user clicks the avatar
  icon and check the matching intent activity exist.
- Use the serialized intent and keeps in config.xml.
- Remove the getAccountSettingsDeeplinkIntent in the AccountFeatureProvider
  which never use again.

Change-Id: I50396af67eb04034572f8c885b4d9aef48a67e9d
Fixes: 122486552
Test: robotest
2019-01-10 09:33:21 +08:00
Yiwei Zhang
a9f902b9c2 Merge "GUP: Display a list of Apps and dialogs" 2019-01-10 00:33:39 +00:00
Fan Zhang
75c143cba9 Filter out unimportant battery tips from slice card.
Change-Id: I2d087f345e44a7dc643715f67c9f516f5541e05e
Fixes: 121115306
Test: robotests
2019-01-09 16:30:45 -08:00
Fan Zhang
0896fa3bee Revert "Remove battery saver condition."
This reverts commit 44b28f4a2b.
Bug: 121115306
Test: robotests

Reason for revert: Change of design

Change-Id: Ia2b9131595d582fd8300367f729fde2b3de81b6e
2019-01-09 15:23:02 -08:00
Hai Zhang
d07b049de1 Add summary for role-based default apps preference.
This change adds summary for role-based default apps preference, based
on what we have now for default apps.

Bug: 110557011
Test: atest RolesPreferenceControllerTest
Change-Id: Ic3dd84dc7ca687ea1de63a856ac3fcf679e1bda9
2019-01-09 14:56:03 -08:00
Kevin Chyn
5652550c84 Persist token across activity lifecycle
Test: token is persisted

Bug: 122372584
Change-Id: Id3221d1a06c48779c743a685a49a70edff6e912c
2019-01-09 14:53:21 -08:00
Fan Zhang
f57f490aa6 Allow OEM customizing max screen timeout value.
Side fix - update string for select timezone.

Change-Id: Id61128b7dfcc27da8ed07225af3b6bec4e93b512
Fixes: 113346164
Fixes: 121986474
Test: robotest
2019-01-09 11:19:48 -08:00
Yiwei Zhang
83c030f1cd GUP: Display a list of Apps and dialogs
1) Add preference controller for gup dashboard and add list preferences
for each entry of the apps
2) Add gup dashboard page to search index
3) Add comprehensive tests for GupPreferenceController

Bug: 119221883
Test: make RunSettingsRoboTests
Change-Id: Ide4934c0dd3901532723e77e74663e5a7b639026
2019-01-10 02:39:08 +08:00
Arc Wang
8eda83d071 Add more Wi-Fi DPP UI features.
1. Use ConstraintLayout to fix footer buttons at bottom
2. ScrollViews have all other UI components excepts footer buttons
3. Use style/SuwGlifButton for buttons
4. Fix scan fragment crash when rotating screen

Bug: 118794978
Test: manual test
Change-Id: I509b0156c4835c75da75fb7ac4c82f55a0b506a1
2019-01-09 18:25:31 +08:00
Cosmo Hsieh
1cb7e12fab Merge "Implement persisting time for onUserSelectionConnectSuccess." 2019-01-09 02:28:09 +00:00
Johnson Lu
9c092dda62 Merge "Implement Wi-Fi DPP flow" 2019-01-09 01:59:01 +00:00
TreeHugger Robot
532c3d7200 Merge "Make Network & internet v2 feature flag be persistent" 2019-01-09 01:18:21 +00:00
Antony Sargent
0a830d4f48 Make Network & internet v2 feature flag be persistent
In ag/5386198 we added a flag to turn on the new features of the network
and internet settings page, but that flag resets to the default value
(currently false) every time you reboot, which is annoying and hostile
for dogfooders. This CL makes the flag persistent.

Bug: 116349402
Test: manual / should be covered by existing tests
Change-Id: I098073e81feb199751e967a9652bec6a6445b95e
2019-01-08 14:17:39 -08:00
Johnson Lu
7bdf8b3d37 Implement Wi-Fi DPP flow
1. As DPP configurator initiator.
2. As DPP enrollee initiator.
3. Pass whole DPP url to DPP API due to API cahnged.

Bug: 122331217
Test: manual test
Change-Id: I8005b78b82453badf253dbde8022ff20722b39fd
2019-01-08 13:42:42 +08:00
cosmohsieh
c1854cae9a Implement persisting time for onUserSelectionConnectSuccess.
When onUserSelectionConnectSuccess callbacks, holding a second for user
to be aware of success connection. Then, go to destory network request dialog.

Bug: 117399926
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi.NetworkRequestDialogFragmentTest
Change-Id: I12d8fb2e8955cf24ddad43d1fe8b863682b6ae32
2019-01-08 12:08:11 +08:00
Nathan Harold
e5e94b95dc Merge "Fix BandMode Dialog Crash on Open due to Style" am: 7588ef1518 am: 7aacdc2c13
am: c015a1bac0

Change-Id: I5d1f931b9b5a6dae87d4effd20ec91d6f9114989
2019-01-07 17:50:20 -08:00
Nathan Harold
c015a1bac0 Merge "Fix BandMode Dialog Crash on Open due to Style" am: 7588ef1518
am: 7aacdc2c13

Change-Id: I50588e17f07d89daa3a989a72080a4fe695b4729
2019-01-07 17:31:14 -08:00
Nathan Harold
7588ef1518 Merge "Fix BandMode Dialog Crash on Open due to Style" 2019-01-08 00:18:21 +00:00
Salvador Martinez
1517be0b7f Remove logging for ssids
This is potentially PII so we should not log this. This change
simply removes the lines of logging code.

Test: changing preference does not result in logging
Bug: 117637133
Change-Id: I620ac4cc4eaaf8227b0694e6cc5f9a85d54bc0e8
2019-01-07 14:35:31 -08:00
TreeHugger Robot
2dbdc888c3 Merge "Fix TODO for mobile network settings" 2019-01-07 20:24:13 +00:00
TreeHugger Robot
af2c9b2646 Merge "Fix ConcurrentModificationException in SliceBackgroundWorker" 2019-01-07 20:11:17 +00:00
Jason Chiu
e19658ac36 Fix ConcurrentModificationException in SliceBackgroundWorker
- Two different threads could call SliceBackgroundWorker.getInstance()
  at the same time and caused ConcurrentModificationException
- Add a new API overloading getInstance for each slice to get a nullable
  worker since there is no result data then
- Only slice provider can create a new worker instance in main thread

Test: robotest
Change-Id: I560529bb6034ec22263418adeb7f3ccebf879196
Fixes: 121043385
2019-01-07 20:10:49 +00:00
Mill Chen
58ae38572a Merge "Implement slice half card" 2019-01-07 08:17:47 +00:00
Mill Chen
6b34d81f36 Merge "Build a way to decide card width" 2019-01-07 08:17:47 +00:00
TreeHugger Robot
577f89deb7 Merge "Refactor slice renderer to handle different card width" 2019-01-07 06:55:31 +00:00
Mill Chen
3559450789 Implement slice half card
To display slice in half width form needs to bind slice, extract the
title and the icon from slice, and finally put the title and the icon
into half card layout.

Bug: 119655434
Test: visual, robotests
Change-Id: Ib390f9a45f0ee609eb9e3499bff74136c7616ac3
2019-01-07 13:39:09 +08:00
Mill Chen
497b3529dc Refactor slice renderer to handle different card width
- Refactor SliceContextualCardRenderer to support for displaying slice
in half/full width card.
- Add two helper classes to separately deal with different card width.

Only the skeleton of the half card helper is put in this CL, the
implementation hasn't been filled in yet. Will implement the detail in
next CL.

Bug: 119655434
Test: visual, robotests
Change-Id: Iacdc90c23bf41cfa7ccae3c0c70a3b663e89307d
2019-01-07 13:34:03 +08:00
TreeHugger Robot
94563cd08b Merge "Improve visual - Collapse the conditionals in all cases" 2019-01-07 05:29:31 +00:00
Mill Chen
8a1bccbc30 Improve visual - Collapse the conditionals in all cases
Changing the threshold value to make collapsing mechanism of conditionals
work in all cases, where the threshold value is changed to 0 from 2.

Bug: 122310542
Test: robotests
Change-Id: I227114acdc6770baa0c133397d08e3ad77f6c572
2019-01-07 05:28:24 +00:00
TreeHugger Robot
d8b3fd3869 Merge "GUP: Add stub UI" 2019-01-05 02:26:04 +00:00
jackqdyulei
b5ce3cd9b0 Fix TODO for mobile network settings
1. Add intent filter to MobileNetworkActivity(new page)
2. Add metrics id
3. Remove obsolete TODOs

Bug: 114749736
Test: Manual
Change-Id: I36f41983dc8cc36ccdf548174fc494044ec1b241
2019-01-04 15:55:09 -08:00
TreeHugger Robot
4e0d53bac8 Merge "Unit test for AppLocationPermissionPreferenceController" 2019-01-04 23:53:38 +00:00
Ruchi Kandoi
8925004b51 Merge "Add support for FEATURE_NFC_ANDROID_BEAM" am: 6827785e52 am: 39845367ab
am: a7c886925f

Change-Id: I08ff3b1bd80e913aeec9800b1c5ddce69543ba3c
2019-01-04 14:19:23 -08:00
Ruchi Kandoi
a7c886925f Merge "Add support for FEATURE_NFC_ANDROID_BEAM" am: 6827785e52
am: 39845367ab

Change-Id: Ia7fc968221a6eb314a9ee384e0dd84d3aa0e84b4
2019-01-04 14:07:48 -08:00