Commit Graph

61 Commits

Author SHA1 Message Date
tomhsu
75509bd06b Avoid to change preference UI content from tapping outside of dialog.
Flag: EXEMPT bug fix
Fix: 335763360
Test: atest passed.
Test: Manual test passed.
Change-Id: Iec5e98f74f0009ab2d3bc21bc590229514192f93
2024-06-26 02:38:25 +00:00
Chaohui Wang
ec59cd0c8b Move mobile data logic into MobileDataRepository
Bug: 347224962
Flag: EXEMPT refactor
Test: manual on Mobile Settings
Test: unit
Change-Id: I2b54f9e6c4addafd31d7d96f2a44870cd54fe185
2024-06-20 11:49:06 +08:00
SongFerng Wang
0cc20946c8 Merge "Add metricsCategory for dualsim and apnEdit" into main 2024-06-14 09:25:47 +00:00
songferngwang
d4e467ed4a Add metricsCategory for dualsim and apnEdit
Bug: 347091697
Test: Build pass
Change-Id: I783a45269112d91d79c00af41c0052ba488603d2
2024-06-13 23:00:29 +00:00
Chaohui Wang
2717f70ac0 InternetPreferenceController V2 (3/n)
Add DataSubscriptionRepository, when cellular connection,
show the active subscription name.

Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - on Internet
Test: unit test
Change-Id: If2a3e7f8df1b1ed89bc760ec5165182b3e9b64a8
2024-06-12 15:33:38 +08:00
tomhsu
6be77d05cb Avoid to save result of blank input.
- Disable "Save" button if no input or only space chars.

fix: 335763360
Test: Manual test
Test: atest pass
Change-Id: Ied5f98ec0ce7d1f38f626211cb9f465781781cd8
2024-06-06 07:27:04 +00:00
SongFerng Wang
ded1c459b0 Merge "To hide the mobile data when there is no active sim" into main 2024-05-30 10:59:32 +00:00
songferngwang
b48ec2f772 To hide the mobile data when there is no active sim
Bug: 343633243
Test: verified the UI
Change-Id: I77055a9c1cdb7e94c0339f4255b4799b7b6e02ac
2024-05-30 09:24:25 +00:00
Chaohui Wang
1bfea5d472 Check if ECBMode when deactivate SIM card
If in ECBMode, start ACTION_SHOW_NOTICE_ECM_BLOCK_OTHERS to show a
dialog instead.

This align with the current airplane mode switch.

Fix: 191943857
Test: adb shell cmd phone emergency-callback-mode
Test: unit test
Change-Id: Icf646cd76990d621121b4367ec0fd02a3880b85c
2024-05-30 16:37:51 +08:00
Tom Hsu
49abe4c03d Merge "Fix when edittext only has space and cause name look like blank" into main 2024-05-29 05:08:07 +00:00
tomhsu
d5556c59e9 Fix when edittext only has space and cause name look like blank
fix: 335763360
Test: Manual test. see b/335763360#comment14
Test: atest passed
Change-Id: I9ebae13039d7b78b7acfea545a89d3096aa82c31
2024-05-29 03:42:35 +00:00
SongFerng Wang
b462f9fa11 Merge "The pages of sim onboarding flow is wrong." into main 2024-05-28 19:58:55 +00:00
songferngwang
98efa51681 The pages of sim onboarding flow is wrong.
Switch from SS mode to DSDS mode, the esim status will use the last
status. It causes the condition of page selection is wrong.

Bug: 342972402
Test: atest SimOnboardingPageProviderTest
Change-Id: I8bb0b5f2802ec24f10467bac179ce54d13a9755e
2024-05-28 08:47:23 +00:00
Chaohui Wang
59a28a244c Setup backup calling for new UI
Backup calling new handles by CrossSimCallingViewModel.
CrossSimCallingViewModel keep monitoring the active SIMs, and setup
backup calling if needed.

Fix: 340444839
Test: manual - SIMs
Test: manual - Mobile Settings
Test: unit test
Change-Id: I0a3451f1e8c3984b2348cf628fb1d91ce7aaecec
2024-05-27 15:16:33 +08:00
Chaohui Wang
881c19480a Fix isSubscriptionEnabledFlow crash
When INVALID_SUBSCRIPTION_ID.

Fix: 338014486
Test: unit test
Change-Id: I97b5f005fb99473c2712f9643704a35cfaeecfac
2024-05-13 11:25:46 +08:00
Chaohui Wang
8c507e871b Catch exception in telephonyRepository.isDataEnabledFlow
And migrate BillingCycleRepository to use it.

Fix: 339197552
Test: manual - on data usage
Test: unit test
Change-Id: Ieac295f37fdbf75d184d66ea11f170652af3ec5f
2024-05-09 15:49:26 +00:00
songferngwang
d3c336a58f To correct the DDS when the user turn on mobile data
If there is only one sim and the DDS is -1, when the user turns
on the mobile data, the settings should correct the dds and set the
mobile data on.

Bug: 339382631
Test: Verify UI
Change-Id: Ib0304dc1370a0d76310da2ce6ce0de12bfb275d8
2024-05-08 11:50:31 +00:00
SongFerng Wang
ceda48c70c Merge "Add the OtherSection for NetworkCellularGroupProvider" into main 2024-05-07 04:58:28 +00:00
songferngwang
8b2305acd4 Add the OtherSection for NetworkCellularGroupProvider
Bug: 338914255
Test: Verified the SIMs UI
Change-Id: I49d5e4126e43054b5d147de15d35805d1e445c38
2024-05-06 10:16:02 +00:00
Chaohui Wang
5058a7f3b5 Adjust padding on SIM onboarding screens
Fix: 330899892
Test: visual - on Sim Onboarding Page
Change-Id: I2f09d8fc20ad9c51bb5d8c9fae703433a7f87ed8
2024-05-06 03:09:02 +00:00
Chaohui Wang
377a7a3054 Check isActivationChangeableFlow in SimPreference
Fix: 336209156
Test: manual - SimPreference
Change-Id: I8745e05dbab9701b9c046137fe76d98880a7b20a
2024-05-01 14:15:36 +00:00
SongFerng Wang
07c7cd6702 Correct the wording of mobile data summary
Bug: 337035270
Change-Id: Idc65508e8d4f68376fdfdba873ad049362445ac2
Test: verify the wording
2024-04-30 07:28:09 +00:00
Treehugger Robot
5ef0fe533e Merge "Prevent blank sim label showing on screen." into main 2024-04-24 05:14:03 +00:00
tomhsu
49e3afc551 Prevent blank sim label showing on screen.
fix: 333642116
Test: Manual test, see b/333642116#14
Change-Id: I776135d8ba609c4ea1fac47cfb765e00f8525497
2024-04-24 05:02:25 +00:00
Chaohui Wang
5ae84662b5 Check isConvertedPsimSubscription in new UI
Bug: 326896614
Test: manual test
Change-Id: I0d3c87a863f58a9e962fb87df5b8001be9edb767
2024-04-22 18:14:20 +08:00
tomhsu
aebb53870c Fixs user input nothing, but save it successfully
- If user inputs nothing, use original sim carrier name instead
 - Add a hint of showing original sim carrier name on edit field.

fix: 333642116
fix: 335763360
Test: Manual test
Test: atest passed
Change-Id: I68fa6bb12c2039899c0a3d0d2aef7f7946b717d1
2024-04-19 05:12:37 +00:00
SongFerng Wang
9a9b22b3ca Merge "Finish the sims page when airplane mode on" into main 2024-04-17 16:44:44 +00:00
songferngwang
f8a48668b0 Finish the sims page when airplane mode on
Bug: 335392575
Test: verify UI
Change-Id: I9d1e4c243e195abe8c917dc83ffed175f7ef74ec
2024-04-17 10:27:46 +00:00
SongFerng Wang
27e947f729 Merge "Set Phone number format as LTR" into main 2024-04-17 08:59:26 +00:00
songferngwang
3219f6da97 Set Phone number format as LTR
Bug: 334339964
Test: verify the phone number format
Change-Id: Ifa5dc394c3d9b8d7565e6200a47b7cb9fb1bba84
2024-04-17 07:10:20 +00:00
SongFerng Wang
15d619f9b4 Merge "Text input in dialog should extend to full width" into main 2024-04-17 06:28:28 +00:00
songferngwang
3daaf1a073 Text input in dialog should extend to full width
Bug: 329710418
Test: verify the UI
Change-Id: I7ff3c390686aa752a42531419ea66eea764e1812
2024-04-16 11:34:24 +00:00
SongFerng Wang
7eaa2b1661 Merge "Add the mobile data into new SIMs page" into main 2024-04-16 08:54:26 +00:00
songferngwang
e471604d32 Add the mobile data into new SIMs page
Bug: 329584989
Test: verify UI.
atest TelephonyRepositoryTest

Change-Id: Ia00ac287ffd0d15ba0c9350b731c3afc1a04b7a0
2024-04-16 07:20:21 +00:00
Chaohui Wang
d305931e3f Add icon to differentiate pSIM and eSIM
Fix: 330096133
Test: manual - on SIMs
Change-Id: I7b7f5d91492d72d66cecf17e52fde1b51ad37832
2024-04-08 16:37:34 +08:00
SongFerng Wang
fd6ae421fd Merge "Add log for setDataEnabledForReason" into main 2024-03-30 15:37:14 +00:00
songferngwang
be3008e09d Add log for setDataEnabledForReason
To know who change the mobile data

Bug: 331843727
Test: NA Adding log only
Change-Id: I3ef5662102761541cd3e0e4662e0acab07c71937
2024-03-29 09:06:34 +00:00
Jason Chiu
0b61e93459 Merge "[Safer intents] Connectivity" into main 2024-03-29 01:11:06 +00:00
Jason Chiu
c53a73ef70 [Safer intents] Connectivity
To avoid implicit intents, make intents launch explicitly.

Bug: 323061508
Test: build
Change-Id: I44ff8a789d933f11ba7e68e52055575245276224
2024-03-26 16:44:48 +08:00
songferngwang
774b34c56b To gray out the next button if the user does not select two sim
- gray out the next button
- add the format for phone number

Bug: 329535069
Test: manual test. To verify the UI
atest SimOnboardingSelectSimTest

Change-Id: I8dd62e3da9567a518d22d615f6974659900ef1bb
2024-03-22 14:46:17 +00:00
Chaohui Wang
bfd8a517be Refactor AutomaticDataSwitchingPreference
Split into AutomaticDataSwitchingPreference.kt, and use
isMobileDataPolicyEnabledFlow.

Bug: 329061940
Test: manual - Set Automatic data switching
Test: unit test
Change-Id: I878ed70328307c0a5dba6dfb461ff5a85efbcf88
2024-03-19 14:17:20 +08:00
Chaohui Wang
08e06a7775 Improve the number on "Label SIM" page
Bug: 318310357
Test: manual - on Mobile Settings
Change-Id: I79149db550e8d84dd2104cbfd72e144dddeb81cd
2024-03-13 14:55:38 +08:00
Chaohui Wang
fd666490ec Merge "Restrict SimPreference" into main 2024-03-11 09:27:49 +00:00
Chaohui Wang
59c8ba7fd0 Use SubscriptionUtil.getFormattedPhoneNumber
For Primary SIM.

Bug: 318310357
Test: manual - on Mobile Settings
Change-Id: Ic8085532fd025bb1e0b6897f5509f485c37a6d56
2024-03-11 15:51:35 +08:00
Chaohui Wang
af43d95332 Restrict SimPreference
Check policy UserManager.DISALLOW_CONFIG_MOBILE_NETWORKS.

Bug: 329000499
Test: manual - on Mobile Settings
Change-Id: I37687299a9ec5c77b59cb231969180872271f4a6
2024-03-11 12:35:11 +08:00
Chaohui Wang
c8edb018a4 Create phoneNumberFlow
Bug: 318310357
Test: manual - on Mobile Settings
Change-Id: Ib80b6c510ebd89650557240add23d914934ba6c9
2024-03-04 13:52:18 +08:00
Chaohui Wang
bec4c9573e Create isSubscriptionEnabledFlow
To better display the isEnable checked state.

Bug: 318310357
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ia595e7445650ad67883f1e7c1a0662cb826565ea
2024-03-02 05:01:28 +00:00
songferngwang
a9695c40e7 Add the error dialogs
When system activate the sim faild, then it shows the error dialog

Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: manual test, verify the error dialog UI
Change-Id: I90d7aa5d3f3ad36d949a505377466f8cdf63b6b4
2024-02-29 09:18:55 +00:00
songferngwang
bb7360b148 Fix PrimarySim show the same sim in the preference list
Bug: 327425969
Test: manual test, verify the UI
Change-Id: I0d3c2163a43a00ec0e4e627b34281e95cc611751
2024-02-28 22:05:35 +00:00
songferngwang
e83d8b22bc [SimOnbarding] correct the sim name at the Primary Sim
The user can modify the name at Label sim page. The primary sim page
should show the name which is modified by the user.

Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: manual test and verify the UI display the correct name.
Change-Id: Ica2a26ead4ec7d61a59bb3846ea07f278d7a1144
2024-02-28 19:00:39 +00:00