Android/packages_apps_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
143,256 Commits 1 Branch 0 Tags
06ab83eb5033397e1745b541d137451e015ea660
Commit Graph

1739 Commits

Author SHA1 Message Date
Treehugger Robot
06ab83eb50 Merge "Fix errorprone issues" into main am: eb2e9e4776 am: bdd44e5242 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3258078

Change-Id: I1249c4cdae2cee729ac60d9e41507c7dc684621e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2024-09-11 18:22:01 +00:00
Treehugger Robot
eb2e9e4776 Merge "Fix errorprone issues" into main 2024-09-11 18:08:19 +00:00
Haijie Hong
1a90869f28 Merge "Make bluetooth profile toggles configurable" into main 2024-09-09 12:56:07 +00:00
Haijie Hong
cd7627c9ff Make bluetooth profile toggles configurable 
BUG: 343317785
Test: atest BluetoothDetailsProfilesControllerTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I5aea110f7a42ffee20a56dbd9d5621f44311cc66
 2024-09-09 13:23:12 +08:00
Cole Faust
9b89e3d643 Fix errorprone issues 
IgnoredPureGetter, LenientFormatStringValidation, ProtocolBufferOrdinal, and ReturnValueIgnored.
https://errorprone.info/bugpatterns

Bug: 253827323
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: Ib0a0335aa04b36924adcbfecc830b7392c0e5bec
 2024-09-06 13:34:50 -07:00
Haijie Hong
680df21339 Merge "Show a dialog if bluetooth key is missing when reconnecting" into main 2024-09-06 08:18:55 +00:00
Haijie Hong
f93aaadad0 Show a dialog if bluetooth key is missing when reconnecting 
Previous change is reverted due to test failure in b/362901443.

BUG: 360031750
Test: atest BluetoothKeyMissingDialogTest
Flag: com.android.settings.flags.enable_bluetooth_key_missing_dialog
Change-Id: I05b940e8aac26c14f93baa19c224ad98c291b891
 2024-09-04 09:05:08 +00:00
Haijie Hong
637984a38d Merge "Make HIGH_QUALITY_AUDIO_PREF_TAG public" into main 2024-09-04 05:17:43 +00:00
Haijie Hong
a43ff10579 Make HIGH_QUALITY_AUDIO_PREF_TAG public 
BUG: 360031750
Test: local tested
Flag: EXEMPT no logic change
Change-Id: Icfb5879f9b44b83c3e4bcfb4628a36b7cefcff01
 2024-09-04 03:23:24 +00:00
Angela Wang
ed519640fa Add hearing device related logs in Settings 
1. The HAC toggle on/off event
2. The "See more devices" button click in hearing device pairing page
3. The preset changed event in Bluetooth device details page

Flag: EXEMPT, simple log
Bug: 361206470
Test: manually check on go/atomviewer
Test: atest BluetoothDetailsHearingAidsPresetsControllerTest
Change-Id: I743ea136ec4cb3370c0463df865db830e73e7997
 2024-09-03 08:06:43 +00:00
Yiyi Shen
abd3889b5c [Audiosharing] Avoid audio sharing dialogs in call 
Test: atest
Bug: 362714470
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: I972d65727865793454de3eb0d9f07926d236afd7
 2024-09-02 13:41:09 +08:00
Haijie Hong
4775f41ec6 Merge "Add help button on the top right corner of more settings page" into main 2024-08-28 05:35:57 +00:00
Haijie Hong
4b04b5e2d4 Use Spatializer in overlay for new device details page 
BUG: 343317785
Test: local tested
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I6c80fac5e74902dd746262e555eb0a5a2e865718
 2024-08-27 13:27:35 +08:00
Haijie Hong
ae26d5d17e Add help button on the top right corner of more settings page 
BUG: 343317785
Test: atest DeviceDetailsFragmentFormatterTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I3053c0495d4c3cfefcd4f77c9114c4c8c8fe08ca
 2024-08-21 20:54:42 +08:00
Haijie Hong
91536001ba Merge "Clean up legacy bluetooth setting flags" into main 2024-08-21 05:45:25 +00:00
Haijie Hong
7723d99684 Merge "Catch IllegalArgumentException when unregister callback" into main 2024-08-20 10:39:13 +00:00
Haijie Hong
52b6929334 Catch IllegalArgumentException when unregister callback 
BUG: 359585188
Test: local test
Flag: EXEMPT minor fix
Change-Id: Ie2e485b922b2bf1163d47c14040e6e3d48f55f86
 2024-08-20 17:17:29 +08:00
Haijie Hong
15a9f1437d Clean up legacy bluetooth setting flags 
BUG: 359415806
Test: atest SettingsRoboTests
Flag: EXEMPT clean up
Change-Id: I7c47d80e61cfb0e3b473106e0784cc96ba639452
 2024-08-20 15:38:32 +08:00
Haijie Hong
7cd4a3987f Add device details more settings page 
BUG: 343317785
Test: atest DeviceDetailsFragmentFormatterTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: Ia9eff049e73e039ac5d0fb26096ab4e9add60315
 2024-08-19 23:41:16 +08:00
Xin Li
0b886fe303 Merge 24Q3 (ab/AP3A.240905.015) to aosp-main-future 
Bug: 347831320
Merged-In: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
Change-Id: I473577d5983daafb368afa5523bad948499cb9a2
 2024-08-14 23:26:30 -07:00
Haijie Hong
c1b24f0a9e Implement Spatial audio toggle domain layer 
BUG: 343317785
Test: atest SpatialAudioInteractorTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: Ic73e56a1ca41f9fa58d5219666478a7edc55059d
 2024-08-14 17:23:14 +08:00
Haijie Hong
41f7c222b6 Rearrange bluetooth device details fragment according to config 
BUG: 343317785
Test: atest DeviceDetailsFragmentFormatterTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I440f85b2c402920e851915ff56fa7b3f5356e807
 2024-08-14 16:06:15 +08:00
Haijie Hong
c2ed6d3242 Move rename button next to the device name 
BUG: 343317785
Test: atest GeneralBluetoothDetailsHeaderControllerTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I87f030ca48d3edac13759fe51499b7e400dbb795
 2024-08-12 12:31:45 +08:00
jasonwshsu
15c6533ef9 Connected devices page did not show correct summary when member device connect 
Root Cause: CsipDeviceManager only refreshes UI when switching member device content.

Solution:
* CsipDeviceManager needs to call refresh() on main device when it's new
  member device added.
* UI widget Settings/BluetoothDevice also need to monitor it's member device status to refresh UI.

Bug: 344947362
Test: atest BluetoothDevicePreferenceTest
Flag: EXEMPT bugfix
Change-Id: I58f9e2fc209d4e87631784d0538b1647228f4c1a
 2024-08-09 09:49:35 +08:00
Xin Li
e2d326beeb Merge 24Q3 (ab/AP3A.240905.001) to aosp-main-future 
Bug: 347831320
Merged-In: I2489a64804f068a957f9be3f87847d6911b24447
Change-Id: I1885ef34f69ac4eb6e76ac903fcacdebe4139ae1
 2024-08-08 11:41:20 -07:00
Angela Wang
e92627e26d Merge "Rename CachedBluetoothDevice.getConnectableProfiles()" into main 2024-08-07 09:52:32 +00:00
Angela Wang
3146a9a08a Merge "Fix LE Audio toggle missing issue for dual mode hearing device" into main 2024-08-06 09:31:28 +00:00
Angela Wang
711d0b269c Rename CachedBluetoothDevice.getConnectableProfiles() 
The original method name implied that the returned profiles were guaranteed to be connectable. However, it actually filters profiles based on user can access the profile in the UI and initiate the connection. Change the method name to getUiAccessibleProfiles() aligns the name with the actual behavior.

Flag: EXEMPT simple renaming
Bug: 356530795
Test: m
Change-Id: Ib7d29a4bf9c213ddcecc567864583165ab97a099
 2024-08-05 07:14:15 +00:00
Haijie Hong
094e040213 Merge "Remove duplicate "lifecycle.addObserver(this)"" into main 2024-08-05 06:58:35 +00:00
Haijie Hong
8e7b62c887 Remove duplicate "lifecycle.addObserver(this)" 
It's already been added in superclass BluetoothDetailsController.

BUG: 343317785
FLAG: EXEMPT simple fix
Test: atest BluetoothDetailsProfilesControllerTest
Test: atest BluetoothDetailsPairOtherControllerTest
Change-Id: I7a9255cea5bb18b29562fa72898356c7a01cd31c
 2024-08-05 13:38:00 +08:00
Angela Wang
a8297a313b Fix LE Audio toggle missing issue for dual mode hearing device 
After the code change of ag/28283226, they hide the LE Audio toggle for
LE Audio only device since turning off the profile may cause this device
no functioning. But the dual mode hearing devices(LE Audio + Asha) are
wrongly recognized as LE Audio only devices since
HearingAidProfile.accessProfileEnabled() return false. This make the
users lost the ability to switch between profiles they preferred.

Make HearingAidProfile.accessProfileEnabled() return true and hide the
Hearing Aid toggle by default since it's also meaningless to turn off
the Asha profile for Asha-only devices.

Flag: com.android.settingslib.flags.asha_profile_access_profile_enabled_true
Bug: 356530795
Test: manual checking the UI
Test: atest BluetoothDetailsProfilesControllerTest
Change-Id: Ica350b4c16c1b07945399bfee1038f7b0824baed
 2024-08-02 07:11:25 +00:00
Tom Hsu
d26c804af1 Merge "[Settings]Check the Satellite modem state instead of enabled state only." into main 2024-08-01 05:27:06 +00:00
tomhsu
90553d91f1 [Settings]Check the Satellite modem state instead of enabled state only. 
Flag: EXEMPT bugfix
Fix: 354806125
Test: Manual test pass
Change-Id: Iaa8d1c9d3df36e40fafda0117234036d9451a4fa
 2024-08-01 03:38:48 +00:00
Yiyi Shen
ec282ed60b Merge "[Audiosharing] Clean up dup codes" into main 2024-07-31 05:20:39 +00:00
Priyanka Advani (xWF)
9bf8ce78b2 Merge "Revert "Change API requestIsEnabled to requestIsSessionStarted"" into main 2024-07-30 18:12:18 +00:00
Chaitanya Cheemala (xWF)
413e85fa7a Revert "Change API requestIsEnabled to requestIsSessionStarted" 
Revert submission 28533501-NTN_check_modem_state

Reason for revert: Likely culprit for b/356320274  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:28533501-NTN_check_modem_state

Change-Id: I4cdb936eb6a27eeee0aba6a5adfcf9cbdfacd5eb
 2024-07-30 09:31:35 +00:00
Haijie Hong
2e12b95c45 Merge "Add multi-toggle preference UI for device details page" into main 2024-07-30 09:25:12 +00:00
Yiyi Shen
7b2435a01c [Audiosharing] Clean up dup codes 
Bug: 305620450
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Test: atest
Change-Id: Ife2bf26d78e522dc51891be633d6635883923de3
 2024-07-30 15:34:09 +08:00
Tom Hsu
d5225c236d Merge "Change API requestIsEnabled to requestIsSessionStarted" into main 2024-07-30 06:51:17 +00:00
Haijie Hong
cc2114a797 Add multi-toggle preference UI for device details page 
BUG: 343317785
Test: atest DeviceSettingRepositoryTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I67e7647fee39e789cc1342943f69e7ddc170d0eb
 2024-07-30 10:59:27 +08:00
tomhsu
b091995671 Change API requestIsEnabled to requestIsSessionStarted 
- Avoid using APM/WIFI/BT in settings app from any transitioning from TN to NTN.

Flag: EXEMPT bugfix
fix: 354806125
Test: Manual test
Change-Id: Id65567971b3d1ea3e177a0cc1e1304446d8fa0e8
 2024-07-30 01:27:58 +00:00
Yuanru Qian
cadfc0187d Merge "Do not cancel bonding during bt pairing when orientation happens." into main 2024-07-29 07:05:55 +00:00
Yuanru Qian
aab162f814 Do not cancel bonding during bt pairing when orientation happens. 
Flag: com.android.settings.flags.disable_bonding_cancellation_for_orientation_change
Bug: b/349542301
Test: locally tested.
Change-Id: I56867eb39ca783b23853318c39e0f25ce1a80e6f
 2024-07-29 05:42:17 +00:00
Haijie Hong
8822907513 Add device to to cached device manager if it's not present 
Bug: 346923808
Test: atest BluetoothDeviceDetailsFragmentTest
Flag: EXEMPT minor bug fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a074f274991f6a172855e0253f49b0a6dd63c758)
Merged-In: Ia4987bc7ec93cb6b54d188922b7232d83d528f2f
Change-Id: Ia4987bc7ec93cb6b54d188922b7232d83d528f2f
 2024-07-26 02:04:14 +00:00
Yuanru Qian
e8f15fd1f5 Merge "Remove ex-team members from OWNERS" into main am: 8303a38d10 am: 97f922d60c 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3191891

Change-Id: I6cb2cd56da335ee064fc4c4ee89c1e56f797cfca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2024-07-24 10:43:15 +00:00
Yuanru Qian
97f922d60c Merge "Remove ex-team members from OWNERS" into main am: 8303a38d10 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3191891

Change-Id: I39c450800b0a3fc08d7cab8e74ff7318f753cbf9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2024-07-24 10:27:41 +00:00
Yuanru Qian
3fac9ad21b Remove ex-team members from OWNERS 
Change-Id: I025d4963e5b63a28fb0fe36df8a4e1fdd76a9b3d
 2024-07-24 09:41:31 +00:00
Haijie Hong
24bf20f033 Don't add profiles to device details page if it's null 
Change-Id: Ia79fa600c87905a6a2cbf8459910d67ffb9d22dd
BUG: 341293298
Test: manually test in tablet
Flag: EXEMPT minor bug fix
 2024-07-24 09:11:46 +00:00
Haijie Hong
de9d706146 Merge "Determine LeAudio toggle visibility after mIsLeAudioOnlyDevice is initialized" into main 2024-07-16 08:14:44 +00:00
Haijie Hong
7a40ecd953 Determine LeAudio toggle visibility after mIsLeAudioOnlyDevice is initialized 
Bug: 352431349
Test: atest BluetoothDetailsProfilesControllerTest
Flag: com.android.settings.flags.hide_le_audio_toggle_for_le_audio_only_device
Change-Id: Ic6a8327f7c8e680a29dfd82407ac8304fc25cf89
 2024-07-16 14:14:52 +08:00