- Keep the Save button enabled at all times
- Show error in the Hostname view to remind the user
- "The field is required" error
- "The hostname you typed isn't valid" error
Bug: 386323822
Flag: EXEMPT bugfix
Test: Manual testing
atest -c PrivateDnsModeDialogPreferenceTest \
PrivateDnsPreferenceControllerTest
Change-Id: I63973bd5001b838d7f27827e6a6d4ac96ac78ca9
Using wrap_content requires to tap on the text specifically, while the
full width usually works for this kind of dialogs.
Change-Id: I95035202c1a3b3bdcbd91a4ff0e60f42392a3ba5
Fixes: 132914632
Test: Screenshot
This option lives in menu. A dialog will show up once this menu
is clicked.
We reuse most of the logic in go/aog/524415 with the following
updates:
1. Use radioGroup instead of directly control radioButton
2. remove bunch of methods if they are only used once.
Following cl will:
1. Remove this feature in development page
2. Add the help link at the bottom of the dialog
3. Disable "Save" button when hostname is invalid.
Bug: 68030013
Test: add for later
Change-Id: I4c6d359dc9c55675858c20e47953ef677b31c3b5
Also includes:
- new layout fragment for private DNS configuration
- PrivateDnsModeDialogPreference handler class
Test: as follows
- built
- flashed
- booted
- runtest frameworks-net passes
- manual interaction with private dns developer option works
Bug: 34953048
Bug: 6413396
Change-Id: I3a5490c21f7f3b3e523a247c287f213d19b75a8b
