Settings: AppLock: Update for kotlin errors

Change-Id: I7115c6e2031d613e59859710f587ee2a26614001
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
This commit is contained in:
Pranav Vashi
2024-03-26 23:14:57 +05:30
committed by Joey
parent 7a44c8f5d1
commit f8ef1252b4
10 changed files with 32 additions and 31 deletions

View File

@@ -36,8 +36,8 @@ class AppLockBiometricPreferenceController(
private val coroutineScope: CoroutineScope private val coroutineScope: CoroutineScope
) : AppLockTogglePreferenceController(context, KEY) { ) : AppLockTogglePreferenceController(context, KEY) {
private val appLockManager = context.getSystemService(AppLockManager::class.java) private val appLockManager = context.getSystemService(AppLockManager::class.java)!!
private val biometricManager = context.getSystemService(BiometricManager::class.java) private val biometricManager = context.getSystemService(BiometricManager::class.java)!!
private var preference: Preference? = null private var preference: Preference? = null
private var isBiometricsAllowed = false private var isBiometricsAllowed = false
@@ -73,4 +73,4 @@ class AppLockBiometricPreferenceController(
super.displayPreference(screen) super.displayPreference(screen)
preference = screen.findPreference(preferenceKey) preference = screen.findPreference(preferenceKey)
} }
} }

View File

@@ -74,7 +74,9 @@ class AppLockCredentialActivity : FragmentActivity() {
override fun onAuthenticationSucceeded(result: BiometricPrompt.AuthenticationResult) { override fun onAuthenticationSucceeded(result: BiometricPrompt.AuthenticationResult) {
waitingForBiometricCallback = false waitingForBiometricCallback = false
appLockManager.unlockPackage(packageName) packageName?.let { nonNullPackageName ->
appLockManager.unlockPackage(nonNullPackageName)
}
ConfirmDeviceCredentialUtils.checkForPendingIntent(this@AppLockCredentialActivity) ConfirmDeviceCredentialUtils.checkForPendingIntent(this@AppLockCredentialActivity)
setResult(Activity.RESULT_OK) setResult(Activity.RESULT_OK)
finish() finish()
@@ -99,7 +101,7 @@ class AppLockCredentialActivity : FragmentActivity() {
statusBarColor = Color.TRANSPARENT statusBarColor = Color.TRANSPARENT
} }
appLockManager = getSystemService(AppLockManager::class.java) appLockManager = getSystemService(AppLockManager::class.java)!!
userManager = UserManager.get(this) userManager = UserManager.get(this)
lockPatternUtils = LockPatternUtils(this) lockPatternUtils = LockPatternUtils(this)

View File

@@ -35,7 +35,7 @@ class AppLockHideAppPC(
private val coroutineScope: CoroutineScope private val coroutineScope: CoroutineScope
) : AppLockTogglePreferenceController(context, KEY) { ) : AppLockTogglePreferenceController(context, KEY) {
private val appLockManager = context.getSystemService(AppLockManager::class.java) private val appLockManager = context.getSystemService(AppLockManager::class.java)!!
private var hideFromLauncher = AppLockManager.DEFAULT_HIDE_IN_LAUNCHER private var hideFromLauncher = AppLockManager.DEFAULT_HIDE_IN_LAUNCHER
private var preference: Preference? = null private var preference: Preference? = null
@@ -67,4 +67,4 @@ class AppLockHideAppPC(
super.displayPreference(screen) super.displayPreference(screen)
preference = screen.findPreference(preferenceKey) preference = screen.findPreference(preferenceKey)
} }
} }

View File

@@ -35,7 +35,7 @@ class AppLockNotificationRedactionPC(
private val coroutineScope: CoroutineScope private val coroutineScope: CoroutineScope
) : AppLockTogglePreferenceController(context, KEY) { ) : AppLockTogglePreferenceController(context, KEY) {
private val appLockManager = context.getSystemService(AppLockManager::class.java) private val appLockManager = context.getSystemService(AppLockManager::class.java)!!
private var shouldRedactNotification = AppLockManager.DEFAULT_REDACT_NOTIFICATION private var shouldRedactNotification = AppLockManager.DEFAULT_REDACT_NOTIFICATION
private var preference: Preference? = null private var preference: Preference? = null
@@ -69,4 +69,4 @@ class AppLockNotificationRedactionPC(
super.displayPreference(screen) super.displayPreference(screen)
preference = screen.findPreference(preferenceKey) preference = screen.findPreference(preferenceKey)
} }
} }

View File

@@ -52,8 +52,7 @@ class AppLockPackageConfigFragment : DashboardFragment() {
requireActivity(), requireActivity(),
this, this,
header?.findViewById(R.id.entity_header) header?.findViewById(R.id.entity_header)
).setRecyclerView(listView, settingsLifecycle) ).setPackageName(packageInfo.packageName)
.setPackageName(packageInfo.packageName)
.setButtonActions( .setButtonActions(
EntityHeaderController.ActionType.ACTION_NONE, EntityHeaderController.ActionType.ACTION_NONE,
EntityHeaderController.ActionType.ACTION_NONE EntityHeaderController.ActionType.ACTION_NONE
@@ -61,7 +60,7 @@ class AppLockPackageConfigFragment : DashboardFragment() {
.bindHeaderButtons() .bindHeaderButtons()
.setLabel(appEntry) .setLabel(appEntry)
.setIcon(appEntry) .setIcon(appEntry)
.done(requireActivity(), false /* rebindActions */) .done(false /* rebindActions */)
} }
override protected fun createPreferenceControllers( override protected fun createPreferenceControllers(

View File

@@ -53,7 +53,7 @@ class AppLockPackageListFragment : DashboardFragment() {
override fun onAttach(context: Context) { override fun onAttach(context: Context) {
super.onAttach(context) super.onAttach(context)
appLockManager = context.getSystemService(AppLockManager::class.java) appLockManager = context.getSystemService(AppLockManager::class.java)!!
pm = context.packageManager pm = context.packageManager
launchablePackages = Utils.launchablePackages(context) launchablePackages = Utils.launchablePackages(context)
whiteListedPackages = resources.getStringArray( whiteListedPackages = resources.getStringArray(
@@ -67,10 +67,10 @@ class AppLockPackageListFragment : DashboardFragment() {
val preferences = withContext(Dispatchers.Default) { val preferences = withContext(Dispatchers.Default) {
pm.getInstalledPackages( pm.getInstalledPackages(
PackageInfoFlags.of(PackageManager.MATCH_ALL.toLong()) PackageInfoFlags.of(PackageManager.MATCH_ALL.toLong())
).filter { ).filter { packageInfo ->
!it.applicationInfo.isSystemApp() || val isSystemApp = packageInfo.applicationInfo?.isSystemApp ?: false
launchablePackages.contains(it.packageName) || !isSystemApp || launchablePackages.contains(packageInfo.packageName) ||
whiteListedPackages.contains(it.packageName) whiteListedPackages.contains(packageInfo.packageName)
}.sortedWith { first, second -> }.sortedWith { first, second ->
getLabel(first).compareTo(getLabel(second)) getLabel(first).compareTo(getLabel(second))
} }
@@ -108,14 +108,14 @@ class AppLockPackageListFragment : DashboardFragment() {
} }
private fun getLabel(packageInfo: PackageInfo) = private fun getLabel(packageInfo: PackageInfo) =
packageInfo.applicationInfo.loadLabel(pm).toString() packageInfo.applicationInfo?.loadLabel(pm).toString()
private fun createPreference(packageInfo: PackageInfo, isProtected: Boolean): Preference { private fun createPreference(packageInfo: PackageInfo, isProtected: Boolean): Preference {
val label = getLabel(packageInfo) val label = getLabel(packageInfo)
return PrimarySwitchPreference(requireContext()).apply { return PrimarySwitchPreference(requireContext()).apply {
key = packageInfo.packageName key = packageInfo.packageName
title = label title = label
icon = packageInfo.applicationInfo.loadIcon(pm) icon = packageInfo.applicationInfo?.loadIcon(pm)
setIconSize(ICON_SIZE_MEDIUM) setIconSize(ICON_SIZE_MEDIUM)
isChecked = isProtected isChecked = isProtected
setOnPreferenceChangeListener { _, newValue -> setOnPreferenceChangeListener { _, newValue ->

View File

@@ -36,7 +36,7 @@ class AppLockPackageProtectionPC(
private val coroutineScope: CoroutineScope private val coroutineScope: CoroutineScope
) : AppLockTogglePreferenceController(context, KEY) { ) : AppLockTogglePreferenceController(context, KEY) {
private val appLockManager = context.getSystemService(AppLockManager::class.java) private val appLockManager = context.getSystemService(AppLockManager::class.java)!!
private var isProtected = false private var isProtected = false
private var preference: Preference? = null private var preference: Preference? = null
@@ -70,4 +70,4 @@ class AppLockPackageProtectionPC(
super.displayPreference(screen) super.displayPreference(screen)
preference = screen.findPreference(preferenceKey) preference = screen.findPreference(preferenceKey)
} }
} }

View File

@@ -54,7 +54,7 @@ class AppLockSettingsPreferenceController(
LifecycleEventObserver { LifecycleEventObserver {
private val lockPatternUtils = LockPatternUtils(context) private val lockPatternUtils = LockPatternUtils(context)
private val appLockManager = context.getSystemService(AppLockManager::class.java) private val appLockManager = context.getSystemService(AppLockManager::class.java)!!
private var preference: Preference? = null private var preference: Preference? = null
private val securityPromptLauncher: ActivityResultLauncher<Intent>? private val securityPromptLauncher: ActivityResultLauncher<Intent>?
@@ -120,7 +120,7 @@ class AppLockSettingsPreferenceController(
val title = mContext.getString(R.string.app_lock_authentication_dialog_title) val title = mContext.getString(R.string.app_lock_authentication_dialog_title)
val intent = Intent().apply { val intent = Intent().apply {
setClassName(SETTINGS_PACKAGE_NAME, setClassName(SETTINGS_PACKAGE_NAME,
ConfirmDeviceCredentialActivity::class.qualifiedName) ConfirmDeviceCredentialActivity::class.qualifiedName!!)
putExtra(KeyguardManager.EXTRA_TITLE, title) putExtra(KeyguardManager.EXTRA_TITLE, title)
} }
securityPromptLauncher.launch(intent) securityPromptLauncher.launch(intent)
@@ -128,4 +128,4 @@ class AppLockSettingsPreferenceController(
} }
return super.handlePreferenceTreeClick(preference) return super.handlePreferenceTreeClick(preference)
} }
} }

View File

@@ -30,7 +30,7 @@ class AppLockTimeoutPreferenceController(
) : BasePreferenceController(context, key), ) : BasePreferenceController(context, key),
Preference.OnPreferenceChangeListener { Preference.OnPreferenceChangeListener {
private val appLockManager = context.getSystemService(AppLockManager::class.java) private val appLockManager = context.getSystemService(AppLockManager::class.java)!!
override fun getAvailabilityStatus() = AVAILABLE override fun getAvailabilityStatus() = AVAILABLE
@@ -44,4 +44,4 @@ class AppLockTimeoutPreferenceController(
appLockManager.timeout = (newValue as String).toLong() appLockManager.timeout = (newValue as String).toLong()
return true return true
} }
} }

View File

@@ -17,7 +17,8 @@
package com.android.settings.security.applock; package com.android.settings.security.applock;
import android.content.Context import android.content.Context
import android.widget.Switch import android.widget.CompoundButton
import android.widget.CompoundButton.OnCheckedChangeListener
import androidx.preference.Preference import androidx.preference.Preference
import androidx.preference.PreferenceScreen import androidx.preference.PreferenceScreen
@@ -25,13 +26,12 @@ import androidx.preference.PreferenceScreen
import com.android.settings.R import com.android.settings.R
import com.android.settings.core.TogglePreferenceController import com.android.settings.core.TogglePreferenceController
import com.android.settingslib.widget.MainSwitchPreference import com.android.settingslib.widget.MainSwitchPreference
import com.android.settingslib.widget.OnMainSwitchChangeListener
abstract class AppLockTogglePreferenceController( abstract class AppLockTogglePreferenceController(
context: Context, context: Context,
key: String, key: String,
) : TogglePreferenceController(context, key), ) : TogglePreferenceController(context, key),
OnMainSwitchChangeListener { OnCheckedChangeListener {
override fun displayPreference(screen: PreferenceScreen) { override fun displayPreference(screen: PreferenceScreen) {
super.displayPreference(screen) super.displayPreference(screen)
@@ -41,9 +41,9 @@ abstract class AppLockTogglePreferenceController(
} }
} }
override fun onSwitchChanged(switchView: Switch, isChecked: Boolean) { override fun onCheckedChanged(buttonView: CompoundButton, isChecked: Boolean) {
setChecked(isChecked) setChecked(isChecked)
} }
override fun getSliceHighlightMenuRes() = R.string.menu_key_security override fun getSliceHighlightMenuRes() = R.string.menu_key_security
} }