From 99f0bd4aa6480f76fb7740ada8101bff84c1feb3 Mon Sep 17 00:00:00 2001 From: "Philip P. Moltmann" Date: Wed, 25 Nov 2015 16:13:01 -0800 Subject: [PATCH] Change onResume -> onStart in the print settings to update even paused activities. Change-Id: Ie28de2cd3ba02c3f19d11c61b3dbbce5d33ddb5a --- .../settings/print/PrintJobSettingsFragment.java | 8 ++++---- .../settings/print/PrintServiceSettingsFragment.java | 11 ++++++++--- .../android/settings/print/PrintSettingsFragment.java | 8 ++++---- 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/src/com/android/settings/print/PrintJobSettingsFragment.java b/src/com/android/settings/print/PrintJobSettingsFragment.java index 9988cb0b736..d299aa478fd 100644 --- a/src/com/android/settings/print/PrintJobSettingsFragment.java +++ b/src/com/android/settings/print/PrintJobSettingsFragment.java @@ -99,16 +99,16 @@ public class PrintJobSettingsFragment extends SettingsPreferenceFragment { } @Override - public void onResume() { - super.onResume(); + public void onStart() { + super.onStart(); mPrintManager.addPrintJobStateChangeListener( mPrintJobStateChangeListener); updateUi(); } @Override - public void onPause() { - super.onPause(); + public void onStop() { + super.onStop(); mPrintManager.removePrintJobStateChangeListener( mPrintJobStateChangeListener); } diff --git a/src/com/android/settings/print/PrintServiceSettingsFragment.java b/src/com/android/settings/print/PrintServiceSettingsFragment.java index d027f988d79..dd41323c5a9 100644 --- a/src/com/android/settings/print/PrintServiceSettingsFragment.java +++ b/src/com/android/settings/print/PrintServiceSettingsFragment.java @@ -147,8 +147,8 @@ public class PrintServiceSettingsFragment extends SettingsPreferenceFragment } @Override - public void onResume() { - super.onResume(); + public void onStart() { + super.onStart(); mSettingsContentObserver.register(getContentResolver()); updateEmptyView(); updateUiForServiceState(); @@ -156,13 +156,18 @@ public class PrintServiceSettingsFragment extends SettingsPreferenceFragment @Override public void onPause() { - mSettingsContentObserver.unregister(getContentResolver()); if (mSearchView != null) { mSearchView.setOnQueryTextListener(null); } super.onPause(); } + @Override + public void onStop() { + mSettingsContentObserver.unregister(getContentResolver()); + super.onStop(); + } + @Override public void onViewCreated(View view, Bundle savedInstanceState) { super.onViewCreated(view, savedInstanceState); diff --git a/src/com/android/settings/print/PrintSettingsFragment.java b/src/com/android/settings/print/PrintSettingsFragment.java index 4cfd21be92c..c2d3ac2273f 100644 --- a/src/com/android/settings/print/PrintSettingsFragment.java +++ b/src/com/android/settings/print/PrintSettingsFragment.java @@ -150,8 +150,8 @@ public class PrintSettingsFragment extends SettingsPreferenceFragment } @Override - public void onResume() { - super.onResume(); + public void onStart() { + super.onStart(); mSettingsPackageMonitor.register(getActivity(), getActivity().getMainLooper(), false); mSettingsContentObserver.register(getContentResolver()); updateServicesPreferences(); @@ -160,10 +160,10 @@ public class PrintSettingsFragment extends SettingsPreferenceFragment } @Override - public void onPause() { + public void onStop() { mSettingsPackageMonitor.unregister(); mSettingsContentObserver.unregister(getContentResolver()); - super.onPause(); + super.onStop(); } @Override