From 6d387e4a5f7abadf49b787e456ea06532a24875d Mon Sep 17 00:00:00 2001 From: tmfang Date: Wed, 19 Dec 2018 18:12:38 +0800 Subject: [PATCH] Fix test case fail The implementation in PreferenceGroup is changed, contentEquals doesn't accept null value. We filter null key case in InstrumentedPreferenceFragment. Test: robotest Change-Id: I575d96361edf9bf0b20f7ad4c61d8b3813bf31d9 Fixes: 121232342 --- .../settings/core/InstrumentedPreferenceFragment.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/com/android/settings/core/InstrumentedPreferenceFragment.java b/src/com/android/settings/core/InstrumentedPreferenceFragment.java index cafef00cf6f..f5f245fad66 100644 --- a/src/com/android/settings/core/InstrumentedPreferenceFragment.java +++ b/src/com/android/settings/core/InstrumentedPreferenceFragment.java @@ -22,6 +22,7 @@ import android.text.TextUtils; import android.util.Log; import androidx.annotation.XmlRes; +import androidx.preference.Preference; import androidx.preference.PreferenceScreen; import com.android.settings.overlay.FeatureFactory; @@ -78,6 +79,14 @@ public abstract class InstrumentedPreferenceFragment extends ObservablePreferenc updateActivityTitleWithScreenTitle(getPreferenceScreen()); } + @Override + public T findPreference(CharSequence key) { + if (key == null) { + return null; + } + return super.findPreference(key); + } + protected final Context getPrefContext() { return getPreferenceManager().getContext(); }