From e4fe56e16101343a47c9a0d6e881d07d52ab70f8 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Fri, 7 Sep 2018 13:27:08 -0400 Subject: [PATCH 1/2] Fix settings crash on noti listener screen Test: manual Bug: 114417814 Change-Id: I053a62201d3e9a1066d16d4a494a0c13bebccaf7 --- src/com/android/settings/utils/ManagedServiceSettings.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/android/settings/utils/ManagedServiceSettings.java b/src/com/android/settings/utils/ManagedServiceSettings.java index 6ee5e8e3ac0..d6deba60fb6 100644 --- a/src/com/android/settings/utils/ManagedServiceSettings.java +++ b/src/com/android/settings/utils/ManagedServiceSettings.java @@ -117,7 +117,7 @@ public abstract class ManagedServiceSettings extends EmptyTextSettings { CharSequence title = null; try { title = mPm.getApplicationInfoAsUser( - service.packageName, 0, getCurrentUser(managedProfileId)).loadLabel(mPm); + service.packageName, 0, UserHandle.myUserId()).loadLabel(mPm); } catch (PackageManager.NameNotFoundException e) { // unlikely, as we are iterating over live services. Log.e(TAG, "can't find package name", e); From cbacfc5753e8a9dfba22b273ddf0762ac8bfac52 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Fri, 7 Sep 2018 14:14:47 -0400 Subject: [PATCH 2/2] Fix settings crash if launched with null args Test: manual Change-Id: I81990d63606074fc670cc39471c91ee61a73f1fc Fixes: 73666426 --- .../NotificationSettingsBase.java | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/com/android/settings/notification/NotificationSettingsBase.java b/src/com/android/settings/notification/NotificationSettingsBase.java index d06b545869f..ed0b1235ef4 100644 --- a/src/com/android/settings/notification/NotificationSettingsBase.java +++ b/src/com/android/settings/notification/NotificationSettingsBase.java @@ -112,19 +112,22 @@ abstract public class NotificationSettingsBase extends DashboardFragment { mPkgInfo = findPackageInfo(mPkg, mUid); - mUserId = UserHandle.getUserId(mUid); - mSuspendedAppsAdmin = RestrictedLockUtilsInternal.checkIfApplicationIsSuspended( - mContext, mPkg, mUserId); + if (mPkgInfo != null) { + mUserId = UserHandle.getUserId(mUid); + mSuspendedAppsAdmin = RestrictedLockUtilsInternal.checkIfApplicationIsSuspended( + mContext, mPkg, mUserId); - loadChannel(); - loadAppRow(); - loadChannelGroup(); - collectConfigActivities(); - getSettingsLifecycle().addObserver(use(HeaderPreferenceController.class)); + loadChannel(); + loadAppRow(); + loadChannelGroup(); + collectConfigActivities(); - for (NotificationPreferenceController controller : mControllers) { - controller.onResume(mAppRow, mChannel, mChannelGroup, mSuspendedAppsAdmin); + getSettingsLifecycle().addObserver(use(HeaderPreferenceController.class)); + + for (NotificationPreferenceController controller : mControllers) { + controller.onResume(mAppRow, mChannel, mChannelGroup, mSuspendedAppsAdmin); + } } }