From 28367dae4d64e1a59846365a880ca3574e26b352 Mon Sep 17 00:00:00 2001 From: Bonian Chen Date: Thu, 23 Feb 2023 04:53:05 +0000 Subject: [PATCH 1/3] [Settings] Customizable resource for hiding 3G preferred network type Add a customiazble resource for specifying the carriers that avoiding from showing 3G option within the preferred network type. Bug: 261615630 Bug: 247995343 Bug: 268564499 Bug: 265147144 Bug: 267433657 Bug: 240176276 Bug: 266724047 Bug: 265147263 Bug: 242017692 Bug: 220998105 Bug: 209835551 Bug: 237837196 Bug: 239318933 Bug: 247996564 Test: local Merged-In: I8092372372cb334b5ac1956b869d194b9fcd0523 Merged-In: I5c12ad23a240fbe70630855e5f98b5be83912674 Change-Id: I8092372372cb334b5ac1956b869d194b9fcd0523 --- res/values/arrays.xml | 5 +++++ ...nabledNetworkModePreferenceController.java | 19 +++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/res/values/arrays.xml b/res/values/arrays.xml index b920c1b8069..9bc29560c9a 100644 --- a/res/values/arrays.xml +++ b/res/values/arrays.xml @@ -1654,4 +1654,9 @@ [CHAR LIMIT=NONE] --> + + + + + diff --git a/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceController.java b/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceController.java index e6bafbb71e5..d1b85282da2 100644 --- a/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceController.java +++ b/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceController.java @@ -22,6 +22,7 @@ import static androidx.lifecycle.Lifecycle.Event.ON_STOP; import android.content.Context; import android.os.PersistableBundle; import android.telephony.CarrierConfigManager; +import android.telephony.SubscriptionInfo; import android.telephony.SubscriptionManager; import android.telephony.TelephonyCallback; import android.telephony.TelephonyManager; @@ -239,6 +240,24 @@ public class EnabledNetworkModePreferenceController extends // TODO: Using the carrier config. mDisplay3gOptions = getResourcesForSubId().getBoolean( R.bool.config_display_network_mode_3g_option); + + int[] carriersWithout3gMenu = getResourcesForSubId().getIntArray( + R.array.network_mode_3g_deprecated_carrier_id); + if ((carriersWithout3gMenu != null) && (carriersWithout3gMenu.length > 0)) { + SubscriptionManager sm = mContext.getSystemService(SubscriptionManager.class); + SubscriptionInfo subInfo = sm.getActiveSubscriptionInfo(mSubId); + if (subInfo != null) { + int carrierId = subInfo.getCarrierId(); + + for (int idx = 0; idx < carriersWithout3gMenu.length; idx++) { + if (carrierId == carriersWithout3gMenu[idx]) { + mDisplay3gOptions = false; + break; + } + } + } + } + mLteEnabled = carrierConfig.getBoolean(CarrierConfigManager.KEY_LTE_ENABLED_BOOL); } Log.d(LOG_TAG, "PreferenceEntriesBuilder: subId" + mSubId From 07ca5b7e4e3abd9e4b95f730cb0f266e53b6ccd7 Mon Sep 17 00:00:00 2001 From: Wenhui Yang Date: Mon, 27 Feb 2023 23:37:27 +0000 Subject: [PATCH 2/3] [DO NOT MERGE] Fix tablet verify pin wording Test: Manual - Reset tablet without removing accounts, observe the texts displayed correctly for tablet. Expanded related for devices. Fixes: 267539281 Fixes: 270516438 Change-Id: If2ad3692b9fb2c8a374d8e988aac76a7254b8cd6 --- res/values/strings.xml | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index ecf378d5bd6..173a7598159 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -4730,11 +4730,25 @@ For added security, enter your work password - Your phone was reset to factory settings. To use this phone, enter your previous pattern. + Your phone was reset to factory settings. To use this phone, enter your previous pattern. + + Your tablet was reset to factory settings. To use this tablet, enter your previous pattern. + + Your device was reset to factory settings. To use this device, enter your previous pattern. + - Your phone was reset to factory settings. To use this phone, enter your previous PIN. + Your phone was reset to factory settings. To use this phone, enter your previous PIN. + + Your tablet was reset to factory settings. To use this tablet, enter your previous PIN. + + Your device was reset to factory settings. To use this device, enter your previous PIN. + - Your phone was reset to factory settings. To use this phone, enter your previous password. + Your phone was reset to factory settings. To use this phone, enter your previous password. + + Your tablet was reset to factory settings. To use this tablet, enter your previous password. + + Your device was reset to factory settings. To use this device, enter your previous password. Verify pattern From 64c23fc5cf6afa5425d4bea2dab4a9efc10ee64a Mon Sep 17 00:00:00 2001 From: Phil Weaver Date: Thu, 2 Mar 2023 23:53:30 +0000 Subject: [PATCH 3/3] Revert "Add discrete contrast UI slider in the setting" This reverts commit fd3911ba29a136cb6310442d825be389d3c8fd37. Reason for revert: Setting will be re-landed in developer settings. Not currently aligned with other accessibility features. Change-Id: If896d87b0bd6d5e74422c1919e60d8717d28a1d0 --- .../preference_contrast_level_slider.xml | 104 --------------- res/values/dimens.xml | 4 - res/values/strings.xml | 6 - res/xml/accessibility_color_and_motion.xml | 5 - .../accessibility/ContrastLevelSeekBar.java | 118 ------------------ .../ContrastLevelSeekBarPreference.java | 73 ----------- .../ContrastLevelSeekBarPreferenceTest.java | 69 ---------- .../ContrastLevelSeekBarTest.java | 106 ---------------- 8 files changed, 485 deletions(-) delete mode 100644 res/layout/preference_contrast_level_slider.xml delete mode 100644 src/com/android/settings/accessibility/ContrastLevelSeekBar.java delete mode 100644 src/com/android/settings/accessibility/ContrastLevelSeekBarPreference.java delete mode 100644 tests/robotests/src/com/android/settings/accessibility/ContrastLevelSeekBarPreferenceTest.java delete mode 100644 tests/robotests/src/com/android/settings/accessibility/ContrastLevelSeekBarTest.java diff --git a/res/layout/preference_contrast_level_slider.xml b/res/layout/preference_contrast_level_slider.xml deleted file mode 100644 index 1766dd7f2ee..00000000000 --- a/res/layout/preference_contrast_level_slider.xml +++ /dev/null @@ -1,104 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/res/values/dimens.xml b/res/values/dimens.xml index 1bd09438e8d..57e47f2ec91 100755 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -220,10 +220,6 @@ 20dp 27dp - - 14dp - 1dp - 16dp diff --git a/res/values/strings.xml b/res/values/strings.xml index 28543148e14..ec6ae58c91f 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -4386,12 +4386,6 @@ Remove animations Reduce movement on the screen - - Contrast Level - - Standard - - High Mono audio diff --git a/res/xml/accessibility_color_and_motion.xml b/res/xml/accessibility_color_and_motion.xml index 72c67f93778..a3135261a9a 100644 --- a/res/xml/accessibility_color_and_motion.xml +++ b/res/xml/accessibility_color_and_motion.xml @@ -64,11 +64,6 @@ android:title="@string/accessibility_toggle_large_pointer_icon_title" settings:controller="com.android.settings.accessibility.LargePointerIconPreferenceController"/> - -